[FYI] -finline-stringops: copy timeout factor from memcmp-1.c test
Checks
Commit Message
Hi, Jeff,
On Dec 18, 2023, Jeff Law <jlaw@ventanamicro.com> wrote:
> These are timing sporadically on the embedded platforms. Given they
> include a test that has a timeout factor, it seems to me you should
> duplicate the timeout factor in the new tests.
> Remember when you include another file, the dg- directives in the
> other file aren't applied.
Thanks for the reminder. Sorry I missed most of them.
I added some -finline-stringops tests that included memcmp-1.c, but
carried over the timeout factor onto only one such test. Jeff Law
kindly pointed that out (thanks!), so here's the fix.
Testing on x86_64-linux-gnu. I'll check this in as obvious once testing
is done.
for gcc/testsuite/ChangeLog
* gcc.dg/torture/inline-mem-cmp-1.c: Copy timeout factor from
mem-cmp-1.c.
* gcc.dg/torture/inline-mem-cpy-1.c: Likewise.
---
gcc/testsuite/gcc.dg/torture/inline-mem-cmp-1.c | 1 +
gcc/testsuite/gcc.dg/torture/inline-mem-cpy-1.c | 1 +
2 files changed, 2 insertions(+)
Comments
On 12/19/23 19:32, Alexandre Oliva wrote:
> Hi, Jeff,
>
> On Dec 18, 2023, Jeff Law <jlaw@ventanamicro.com> wrote:
>
>> These are timing sporadically on the embedded platforms. Given they
>> include a test that has a timeout factor, it seems to me you should
>> duplicate the timeout factor in the new tests.
>
>> Remember when you include another file, the dg- directives in the
>> other file aren't applied.
>
> Thanks for the reminder. Sorry I missed most of them.
>
>
> I added some -finline-stringops tests that included memcmp-1.c, but
> carried over the timeout factor onto only one such test. Jeff Law
> kindly pointed that out (thanks!), so here's the fix.
>
> Testing on x86_64-linux-gnu. I'll check this in as obvious once testing
> is done.
>
>
> for gcc/testsuite/ChangeLog
>
> * gcc.dg/torture/inline-mem-cmp-1.c: Copy timeout factor from
> mem-cmp-1.c.
> * gcc.dg/torture/inline-mem-cpy-1.c: Likewise.
Thanks.
jeff
@@ -1,5 +1,6 @@
/* { dg-do run } */
/* { dg-options "-finline-stringops=memcmp -save-temps -g0 -fno-lto" } */
+/* { dg-timeout-factor 2 } */
#include "../memcmp-1.c"
@@ -1,5 +1,6 @@
/* { dg-do run } */
/* { dg-options "-finline-stringops=memcpy -save-temps -g0 -fno-lto" } */
+/* { dg-timeout-factor 2 } */
#include "../memcmp-1.c"
/* Yeah, this memcmp test exercises plenty of memcpy, more than any of the