| Message ID | 20231218214451.2345691-2-cristian.ciocaltea@collabora.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-4415-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp1551763dyi;
Mon, 18 Dec 2023 13:46:17 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IGqtgpXfFksO2rBEOOkpWOYa/WxK26mCjxJEdR14mtmdE+aCYzqJ+RMW9xla6q2bTAwhO0C
X-Received: by 2002:a17:902:7c8c:b0:1d0:6ffd:f230 with SMTP id
y12-20020a1709027c8c00b001d06ffdf230mr8528538pll.134.1702935976895;
Mon, 18 Dec 2023 13:46:16 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1702935976; cv=none;
d=google.com; s=arc-20160816;
b=b6cjQWPeMbD74MGTGRg/53/VhVu+i1d8bQPGjCa0lksognbFVpupHyXBkSYgCPXXnV
k+NE/hE55C5tf00Pf5V4hFu2YFbxYAZwhr5ExCeb2S0LDfYm8LsCrQ0nGqZUl4p1EJ0V
fXsepQqN4sZUXbvreoZ7q76Pz2U/nXN+4puQD+9kOk5rnfu6DlRW5Rsxlyu0UFpCPgau
zejWxHCvqzQrWvjVXRAwDYPJepTLHk7Z+n1H3CMqJtM2UeAihMTuyNiahUCCPv3kNP5m
wJjTGrTpTd3xSQHGQlgu7+0rbmO/fKRXgJqdJGvoxDps1RSCIyDc70F2gesV1BL0/dTU
aFxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:references:in-reply-to:message-id
:date:subject:cc:to:from:dkim-signature;
bh=N7rX2azjC5/uSPgdggeOA3hvkvekvdN9+FSb/zVYoSk=;
fh=syaDh/WjooBXvAaul+2O0Q827rHRcsPrAm5I86d1V5c=;
b=YvTJEN9JQJVQVvlbnYWb7bY35f7YR1PEQcxMipMoGTLAiCE2TCvhHCpJ6a6ZddDWfD
oQiwM1s03BC4o43YdmRpiRs8wRUz7L9tOc2DDl3khlBzXrmL+AkS0h+C58qejklot61c
i7zwvjV67dhlSibBy3rmIeX4k/+IIOx0xqXQfawXG5jzo52TxlWYNGBKqDq4GakN92br
4dzusq+U365mT3PTH2x4St0UpaTaDl+Od6w/CDG3GjQLf1xfnVc/ej6WdXPB5B+mffVL
gV/0KgZQUCrF197l8HjXoPZOf87YIsZo2I+2UEfAhYx4Ov7p8q/U+NNacxyQAI2cm66K
Cgkw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=QiF1Pkq5;
spf=pass (google.com: domain of
linux-kernel+bounces-4415-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:40f1:3f00::1 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-4415-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=collabora.com
Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org.
[2604:1380:40f1:3f00::1])
by mx.google.com with ESMTPS id
j3-20020a170902c08300b001cfd24c7b73si18221876pld.2.2023.12.18.13.46.16
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 18 Dec 2023 13:46:16 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-4415-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Authentication-Results: mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=QiF1Pkq5;
spf=pass (google.com: domain of
linux-kernel+bounces-4415-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:40f1:3f00::1 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-4415-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=collabora.com
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by sy.mirrors.kernel.org (Postfix) with ESMTPS id EBE49B237DE
for <ouuuleilei@gmail.com>; Mon, 18 Dec 2023 21:46:15 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id 9396C768FC;
Mon, 18 Dec 2023 21:45:00 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com
header.b="QiF1Pkq5"
X-Original-To: linux-kernel@vger.kernel.org
Received: from madrid.collaboradmins.com (madrid.collaboradmins.com
[46.235.227.194])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A0AD74E11;
Mon, 18 Dec 2023 21:44:56 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=quarantine dis=none) header.from=collabora.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=collabora.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
s=mail; t=1702935894;
bh=gbMqiSFoR5LPx4Im1XNHPktHQYnQ4AzMO0qHDjq0wBQ=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=QiF1Pkq59BiNjuwKLlI7G2SvuPu8d4HdABH7OIv9txKZMtcYO/Zi/SHD/0pV9S0+N
xhJeBZ0un9Aw/uqrDtuaX3Lc2PG9rdJ2EBQWi5p9Q9MaFN20yTQbR9Jm4NnJoQZfFp
kurNhVjvnlmQW00/QPItqeRNj+b/YYI9xZ6tAW/oajoAbR8inwEsmR6SzgXCOa1xl2
oFPYUWCs6Nvl9r3+LRVSWpk4rHZjfGanUDjjQwtPjWv9rvd5fDEGiHWVigZQ0Di5+t
fa+Z0NAUDrT0kVeFjmHw9TVEHiq9qQauxcfy7IzWrMwEEC7NtWo06GYjnbR00+Rme7
GPekFWKakAH3Q==
Received: from localhost (cola.collaboradmins.com [195.201.22.229])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits)
server-digest SHA256)
(No client certificate requested)
(Authenticated sender: cristicc)
by madrid.collaboradmins.com (Postfix) with ESMTPSA id 4C57D3781476;
Mon, 18 Dec 2023 21:44:54 +0000 (UTC)
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Samin Guo <samin.guo@starfivetech.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Hal Feng <hal.feng@starfivetech.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: netdev@vger.kernel.org,
devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-clk@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
kernel@collabora.com
Subject: [PATCH v4 1/9] dt-bindings: net: starfive,jh7110-dwmac: Drop
redundant reset description
Date: Mon, 18 Dec 2023 23:44:41 +0200
Message-ID: <20231218214451.2345691-2-cristian.ciocaltea@collabora.com>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20231218214451.2345691-1-cristian.ciocaltea@collabora.com>
References: <20231218214451.2345691-1-cristian.ciocaltea@collabora.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1785657794646916049
X-GMAIL-MSGID: 1785657794646916049
|
| Series |
Enable networking support for StarFive JH7100 SoC
|
|
Commit Message
Cristian Ciocaltea
Dec. 18, 2023, 9:44 p.m. UTC
The reset description items are already provided by the referenced
snps,dwmac.yaml schema, hence replace them with the necessary
{min,max}Items.
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
.../devicetree/bindings/net/starfive,jh7110-dwmac.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Comments
On 18/12/2023 22:44, Cristian Ciocaltea wrote: > The reset description items are already provided by the referenced > snps,dwmac.yaml schema, hence replace them with the necessary > {min,max}Items. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > --- > .../devicetree/bindings/net/starfive,jh7110-dwmac.yaml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > index 5e7cfbbebce6..d90cb82c1424 100644 > --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > @@ -55,9 +55,8 @@ properties: > maxItems: 3 > > resets: > - items: > - - description: MAC Reset signal. > - - description: AHB Reset signal. > + minItems: 2 > + maxItems: 2 Why changing only resets, but not reset-names? Best regards, Krzysztof
On 12/19/23 09:24, Krzysztof Kozlowski wrote: > On 18/12/2023 22:44, Cristian Ciocaltea wrote: >> The reset description items are already provided by the referenced >> snps,dwmac.yaml schema, hence replace them with the necessary >> {min,max}Items. >> >> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> >> --- >> .../devicetree/bindings/net/starfive,jh7110-dwmac.yaml | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> index 5e7cfbbebce6..d90cb82c1424 100644 >> --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> @@ -55,9 +55,8 @@ properties: >> maxItems: 3 >> >> resets: >> - items: >> - - description: MAC Reset signal. >> - - description: AHB Reset signal. >> + minItems: 2 >> + maxItems: 2 > > Why changing only resets, but not reset-names? Already answered in [1], but also discussed in the context of the next patch. Thanks, Cristian [1]: https://lore.kernel.org/lkml/0ff7a905-d8f2-401b-a0ff-47947d12ce05@collabora.com/
On 19/12/2023 13:55, Cristian Ciocaltea wrote: > On 12/19/23 09:24, Krzysztof Kozlowski wrote: >> On 18/12/2023 22:44, Cristian Ciocaltea wrote: >>> The reset description items are already provided by the referenced >>> snps,dwmac.yaml schema, hence replace them with the necessary >>> {min,max}Items. >>> >>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> >>> --- >>> .../devicetree/bindings/net/starfive,jh7110-dwmac.yaml | 5 ++--- >>> 1 file changed, 2 insertions(+), 3 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>> index 5e7cfbbebce6..d90cb82c1424 100644 >>> --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>> @@ -55,9 +55,8 @@ properties: >>> maxItems: 3 >>> >>> resets: >>> - items: >>> - - description: MAC Reset signal. >>> - - description: AHB Reset signal. >>> + minItems: 2 >>> + maxItems: 2 >> >> Why changing only resets, but not reset-names? > > Already answered in [1], but also discussed in the context of the > next patch. > > Thanks, > Cristian > > [1]: https://lore.kernel.org/lkml/0ff7a905-d8f2-401b-a0ff-47947d12ce05@collabora.com/ Neither previous answer nor this is correct. snps,dwmac does not allow ahb entry alone. NAK Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml index 5e7cfbbebce6..d90cb82c1424 100644 --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml @@ -55,9 +55,8 @@ properties: maxItems: 3 resets: - items: - - description: MAC Reset signal. - - description: AHB Reset signal. + minItems: 2 + maxItems: 2 reset-names: items: