Message ID | 20221118133216.17037-2-walker.chen@starfivetech.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp208488wrr; Fri, 18 Nov 2022 06:00:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf4KIL1ASi8tq3TUs23T/PCzbdBFpz/jQH4P7WyZPCff4OIevZVpqZA9e1w51ueOanB9IGXz X-Received: by 2002:a17:907:918d:b0:78d:2eea:28c7 with SMTP id bp13-20020a170907918d00b0078d2eea28c7mr6115825ejb.266.1668780026951; Fri, 18 Nov 2022 06:00:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668780026; cv=none; d=google.com; s=arc-20160816; b=szB4KaGv+k9ZPsbqQgpDWQOVyvFmgTs4BKTUDCswNUn/Cun6v3HQlGCgKCx/pGfVB+ pDRmOXUDMen3JU89N5Q68MHja6urLkS/C5gJzqctamsCVQu4UQYReYzNQOyqpmComWXP 7wNnRwevIP9x8pNAhyzsBmxwPlOl8v18Ya0zXlvy+5rYTnFdYn8vyyb8EUW9o/SdhvaD TWmlbdYWVaxx+YiA5MI3Z6RJMQIl3tfVNUX5hS+2X6TBN9VxouU+DxnuHUglA7onLDit jFPMkx8+sIGKYksERXZzH88+UzdzvA2cqWj0c3OKChNGvRuc6kzBNV2kX3wMvPsqME4k Fevg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=UK3h/4E5vXBNqY/13Fttvb8p9v9Cj+sX6uMrYNAkG0A=; b=JrwtGlFaUW7OOZO8VOoDpXne904rW+ceds8aBHRNfYVu98/p2AcrwiUpkJZvpvpHMv SbDpLoXib8I2fMq2pDUeayM1CTNJIAgFa1+5d0CxTMq8t4cnL9EBw3mtmkaaZxzk/3Bc CYmJlUxvMfPYO1P99h0Lq2+98uBMxwf4iAnpAjAyx2ENIbM6MMXfAHNmUuOiMvhl8zVF 4IR2kgYUNBxz8tEoyVJMa9XGbbdrQuDGOsW4jcIPVu1ZZp//nJ5HMdRN6GFFq0iwhs9k p1Y6nZmIw6o8nozKyaDkL9fEjcukphCdpFURhu2h8WroiLLxxPklojqDrv1wjTrLN5QS vxYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr9-20020a170907720900b007877eb5687csi3022380ejc.249.2022.11.18.06.00.01; Fri, 18 Nov 2022 06:00:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241950AbiKRNne (ORCPT <rfc822;kkmonlee@gmail.com> + 99 others); Fri, 18 Nov 2022 08:43:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241574AbiKRNnc (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 18 Nov 2022 08:43:32 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83972CD5; Fri, 18 Nov 2022 05:43:29 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 421B724DBC2; Fri, 18 Nov 2022 21:32:28 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 18 Nov 2022 21:32:28 +0800 Received: from localhost.localdomain (183.27.96.116) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 18 Nov 2022 21:32:27 +0800 From: Walker Chen <walker.chen@starfivetech.com> To: <linux-riscv@lists.infradead.org>, <linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org> CC: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor.dooley@microchip.com>, "Rafael J . Wysocki" <rafael@kernel.org>, Walker Chen <walker.chen@starfivetech.com>, <linux-kernel@vger.kernel.org> Subject: [PATCH v1 1/4] dt-bindings: power: Add StarFive JH7110 power domain definitions Date: Fri, 18 Nov 2022 21:32:13 +0800 Message-ID: <20221118133216.17037-2-walker.chen@starfivetech.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221118133216.17037-1-walker.chen@starfivetech.com> References: <20221118133216.17037-1-walker.chen@starfivetech.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [183.27.96.116] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749842685870084495?= X-GMAIL-MSGID: =?utf-8?q?1749842685870084495?= |
Series |
JH7110 Power Domain Support
|
|
Commit Message
Walker Chen
Nov. 18, 2022, 1:32 p.m. UTC
Add power domain definitions for the StarFive JH7110 SoC.
Signed-off-by: Walker Chen <walker.chen@starfivetech.com>
---
include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 include/dt-bindings/power/jh7110-power.h
Comments
On 18/11/2022 14:32, Walker Chen wrote: > Add power domain definitions for the StarFive JH7110 SoC. > > Signed-off-by: Walker Chen <walker.chen@starfivetech.com> > --- > include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 include/dt-bindings/power/jh7110-power.h > > diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h > new file mode 100644 > index 000000000000..24160c46fbaf > --- /dev/null > +++ b/include/dt-bindings/power/jh7110-power.h Filename matching compatible or bindings file. > @@ -0,0 +1,18 @@ > +/* SPDX-License-Identifier: (GPL-2.0) */ Dual license for bindings. > +/* > + * Copyright (C) 2022 StarFive Technology Co., Ltd. > + * Author: Walker Chen <walker.chen@starfivetech.com> > + */ > +#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__ > +#define __DT_BINDINGS_POWER_JH7110_POWER_H__ Best regards, Krzysztof
On 2022/11/21 18:12, Krzysztof Kozlowski wrote: > On 18/11/2022 14:32, Walker Chen wrote: >> Add power domain definitions for the StarFive JH7110 SoC. >> >> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >> --- >> include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> create mode 100644 include/dt-bindings/power/jh7110-power.h >> >> diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h >> new file mode 100644 >> index 000000000000..24160c46fbaf >> --- /dev/null >> +++ b/include/dt-bindings/power/jh7110-power.h > > Filename matching compatible or bindings file. So the file name should be changed to "starfive,jh7110-power.h" and the compatible in the driver should also be changed to "starfive,jh7110-power". Is it right ? > >> @@ -0,0 +1,18 @@ >> +/* SPDX-License-Identifier: (GPL-2.0) */ > > Dual license for bindings. Ok, the license will be changed to GPL-2.0 or MIT in the patch v2. > >> +/* >> + * Copyright (C) 2022 StarFive Technology Co., Ltd. >> + * Author: Walker Chen <walker.chen@starfivetech.com> >> + */ >> +#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__ >> +#define __DT_BINDINGS_POWER_JH7110_POWER_H__ > > Best regards, > Krzysztof >
On 22/11/2022 08:46, Walker Chen wrote: > On 2022/11/21 18:12, Krzysztof Kozlowski wrote: >> On 18/11/2022 14:32, Walker Chen wrote: >>> Add power domain definitions for the StarFive JH7110 SoC. >>> >>> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >>> --- >>> include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >>> create mode 100644 include/dt-bindings/power/jh7110-power.h >>> >>> diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h >>> new file mode 100644 >>> index 000000000000..24160c46fbaf >>> --- /dev/null >>> +++ b/include/dt-bindings/power/jh7110-power.h >> >> Filename matching compatible or bindings file. > > So the file name should be changed to "starfive,jh7110-power.h" and the compatible in the driver > should also be changed to "starfive,jh7110-power". Is it right ? I said filename should be changed. I don't remember what was your compatible, but if I did not comment there, in means it looked fine. > >> >>> @@ -0,0 +1,18 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0) */ >> >> Dual license for bindings. > > Ok, the license will be changed to GPL-2.0 or MIT in the patch v2. Any reasons why not using the licenses recommended by checkpatch? Best regards, Krzysztof
On 2022/11/22 16:03, Krzysztof Kozlowski wrote: > On 22/11/2022 08:46, Walker Chen wrote: >> On 2022/11/21 18:12, Krzysztof Kozlowski wrote: >>> On 18/11/2022 14:32, Walker Chen wrote: >>>> Add power domain definitions for the StarFive JH7110 SoC. >>>> >>>> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >>>> --- >>>> include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ >>>> 1 file changed, 18 insertions(+) >>>> create mode 100644 include/dt-bindings/power/jh7110-power.h >>>> >>>> diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h >>>> new file mode 100644 >>>> index 000000000000..24160c46fbaf >>>> --- /dev/null >>>> +++ b/include/dt-bindings/power/jh7110-power.h >>> >>> Filename matching compatible or bindings file. >> >> So the file name should be changed to "starfive,jh7110-power.h" and the compatible in the driver >> should also be changed to "starfive,jh7110-power". Is it right ? > > I said filename should be changed. I don't remember what was your > compatible, but if I did not comment there, in means it looked fine. > >> >>> >>>> @@ -0,0 +1,18 @@ >>>> +/* SPDX-License-Identifier: (GPL-2.0) */ >>> >>> Dual license for bindings. >> >> Ok, the license will be changed to GPL-2.0 or MIT in the patch v2. > > Any reasons why not using the licenses recommended by checkpatch? > Well, it sounds like a better way to decide which license to use by checkpatch. Thanks for your tip. Best Regards, Walker Chen
diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h new file mode 100644 index 000000000000..24160c46fbaf --- /dev/null +++ b/include/dt-bindings/power/jh7110-power.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: (GPL-2.0) */ +/* + * Copyright (C) 2022 StarFive Technology Co., Ltd. + * Author: Walker Chen <walker.chen@starfivetech.com> + */ +#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__ +#define __DT_BINDINGS_POWER_JH7110_POWER_H__ + +#define JH7110_PD_SYSTOP 0 +#define JH7110_PD_CPU 1 +#define JH7110_PD_GPUA 2 +#define JH7110_PD_VDEC 3 +#define JH7110_PD_VOUT 4 +#define JH7110_PD_ISP 5 +#define JH7110_PD_VENC 6 +#define JH7110_PD_GPUB 7 + +#endif