Message ID | 20231208125730.10323-1-johan+linaro@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5432483vqy; Fri, 8 Dec 2023 04:57:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRw1PnSc/S0grQokOo0ChZbEXmCtCj80UJ2BpGaSp6F/3p4MRN+b5rSo1aTYG6YcYQJi0d X-Received: by 2002:a05:6a00:2382:b0:6cb:bc06:b058 with SMTP id f2-20020a056a00238200b006cbbc06b058mr4712711pfc.0.1702040223876; Fri, 08 Dec 2023 04:57:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702040223; cv=none; d=google.com; s=arc-20160816; b=r1lLXEKgQ+ViJ0EbUTjqscx6evgQes0VJlcsYTmX86KQOhHcmbTI6qwsZx0yg1DWSI TYI9bpzDHJz2KYqZyfJ9d5zkM1IcH1YmkPwHHi8GDLlMfy0SXAjdE/0m0r2NgRN8x3SX e4raHtvbzdBnhe7BisjawC3XKfL39crrc7QB/g3m+HZpcPCeZjqNimFT3scCqtBE2FPb ZfgVqtpMh50u+jvv1C7bU+s3e14LJskMsu86wu+PkVXfDKoxmHL+riVq0HPGytBjf3VB R9K9Z2uDqAHZ1hUrjImYCYh1EigjKPIVrzt6/jpI0SFnXLbyyhfRO5/BiUrdWziUa+Mm pxIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=QHVMTc7JbOKWQiyE5WnJ1KZVYPGhcddzOdce2g60rHk=; fh=8WK2MfeiYGTN8gN5k2Q88iqRdqfcoS3bVf7Cn7ZMyGA=; b=tktnDOPOj3UiMpOhS/8KF0tTINEi6PxJgPMS6Z5lEvKKpjseH0+gePUSuWvyVtGF2r ADRT8zlp/K94DNfjyBVcvLeiXgd1ATDd51nzXbuEFdcOQfwiJlLMvB9Cky8aPWFpFoHp /N4Ztq9x8vCl8ud5BPXbtd8Y2YCof9lL/tU3/9P/zaInYhKmQTRpS7OXHePM15WXonnh Ma5eoroQgeOVjdvLgqbZMd90OjxWC4oImZKCe5NwBXq8JZVFPLtKzLubCh/0Wr9kPUef UhO6JIFXWSpFNb40sm3B4I38yXNYMxvZeNpAo3hd3jGYr762tuvJFRev5tC9i8wcKwPU JMDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BGURX3Ck; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id g27-20020a63521b000000b005c6ec7e49b0si1299789pgb.825.2023.12.08.04.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 04:57:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BGURX3Ck; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id BEF458379A63; Fri, 8 Dec 2023 04:57:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232504AbjLHM4v (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Fri, 8 Dec 2023 07:56:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229844AbjLHM4v (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 8 Dec 2023 07:56:51 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93F1410FC for <linux-kernel@vger.kernel.org>; Fri, 8 Dec 2023 04:56:57 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3053AC433C7; Fri, 8 Dec 2023 12:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702040217; bh=OSuX71e1jZxpO9PhB7QCT9A4hWvPxJ7NxD/Rhqsq+SI=; h=From:To:Cc:Subject:Date:From; b=BGURX3CkaHSVViOG1V5VQDRQ5+esvsuA8SRZodR/7mOYi2OmZY0YTIIig2EWe/08v v3E1n4bWGqpOHyGi+5jzU6i0m8N4hrKNGX8/jgWPEa4q29TEe55s8Af8NLKvRDtRl6 IuMR2bB3F4SBgvhR2Blk++JH+Fb3W+lZTx5IJ6yyEGeYqJmsoJqfXVq5eICwi6k4vG pzC1qMsDRT+WibmV/PD/CXvAXQwbGsCpEL6yZCBgZDimbODte05HFFP7mdLr9a2vl7 KwhTMc3b6xr1XVFMZYfcKGYgexXgGXNwj/hoORjPg4L+JNDDXutQVx0SMl+7q5dkFN iW8SpZ/UMaNkA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from <johan+linaro@kernel.org>) id 1rBaQM-0002gi-2N; Fri, 08 Dec 2023 13:57:47 +0100 From: Johan Hovold <johan+linaro@kernel.org> To: Bjorn Andersson <andersson@kernel.org> Cc: Andy Gross <agross@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org> Subject: [PATCH] soc: qcom: pmic_glink: disable UCSI on sc8280xp Date: Fri, 8 Dec 2023 13:57:30 +0100 Message-ID: <20231208125730.10323-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 08 Dec 2023 04:57:01 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784718530054450482 X-GMAIL-MSGID: 1784718530054450482 |
Series |
soc: qcom: pmic_glink: disable UCSI on sc8280xp
|
|
Commit Message
Johan Hovold
Dec. 8, 2023, 12:57 p.m. UTC
Enabling UCSI on sc8280xp and the Lenovo ThinkPad X13s in particular
results in a number of errors and timeouts during boot:
[ 9.012421] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-95)
[ 14.047379] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response
[ 14.050708] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110)
[ 20.192382] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response
[ 20.192542] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110)
Disable UCSI on sc8280xp until this has been resolved.
Fixes: 4db09e7b967b ("soc: qcom: pmic_glink: enable UCSI by default)
Link: https://lore.kernel.org/r/ZXL5jvDHr-MuxMoz@hovoldconsulting.com
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/soc/qcom/pmic_glink.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Fri, 8 Dec 2023 at 14:56, Johan Hovold <johan+linaro@kernel.org> wrote: > > Enabling UCSI on sc8280xp and the Lenovo ThinkPad X13s in particular > results in a number of errors and timeouts during boot: > > [ 9.012421] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-95) > [ 14.047379] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response > [ 14.050708] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110) > [ 20.192382] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response > [ 20.192542] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110) > > Disable UCSI on sc8280xp until this has been resolved. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Johan, if you can capture message traces in pmic_glink_ucsi_locked_write() / pmic_glink_ucsi_read() / pmic_glink_ucsi_callback(), this would help me understand what is causing the issue. > > Fixes: 4db09e7b967b ("soc: qcom: pmic_glink: enable UCSI by default) > Link: https://lore.kernel.org/r/ZXL5jvDHr-MuxMoz@hovoldconsulting.com > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/soc/qcom/pmic_glink.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c > index 71d8901a9389..511aa40842a1 100644 > --- a/drivers/soc/qcom/pmic_glink.c > +++ b/drivers/soc/qcom/pmic_glink.c > @@ -342,6 +342,7 @@ static const unsigned long pmic_glink_sm8450_client_mask = BIT(PMIC_GLINK_CLIENT > > static const struct of_device_id pmic_glink_of_match[] = { > { .compatible = "qcom,sc8180x-pmic-glink", .data = &pmic_glink_sc8180x_client_mask }, > + { .compatible = "qcom,sc8280xp-pmic-glink", .data = &pmic_glink_sc8180x_client_mask }, > { .compatible = "qcom,pmic-glink", .data = &pmic_glink_sm8450_client_mask }, > {} > }; > -- > 2.41.0 >
On Fri, Dec 08, 2023 at 06:34:00PM +0200, Dmitry Baryshkov wrote: > On Fri, 8 Dec 2023 at 14:56, Johan Hovold <johan+linaro@kernel.org> wrote: > > > > Enabling UCSI on sc8280xp and the Lenovo ThinkPad X13s in particular > > results in a number of errors and timeouts during boot: > > > > [ 9.012421] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-95) > > [ 14.047379] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response > > [ 14.050708] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110) > > [ 20.192382] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response > > [ 20.192542] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110) > > > > Disable UCSI on sc8280xp until this has been resolved. > Johan, if you can capture message traces in > pmic_glink_ucsi_locked_write() / pmic_glink_ucsi_read() / > pmic_glink_ucsi_callback(), this would help me understand what is > causing the issue. I don't have time to dig into this at the moment, and its probably easiest for everyone if you just try this on your own X13s. Johan
On Fri, 08 Dec 2023 13:57:30 +0100, Johan Hovold wrote: > Enabling UCSI on sc8280xp and the Lenovo ThinkPad X13s in particular > results in a number of errors and timeouts during boot: > > [ 9.012421] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-95) > [ 14.047379] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response > [ 14.050708] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110) > [ 20.192382] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response > [ 20.192542] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110) > > [...] Applied, thanks! [1/1] soc: qcom: pmic_glink: disable UCSI on sc8280xp commit: 3581cb91543967ee1a57849116e26036f6240e6d Best regards,
diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c index 71d8901a9389..511aa40842a1 100644 --- a/drivers/soc/qcom/pmic_glink.c +++ b/drivers/soc/qcom/pmic_glink.c @@ -342,6 +342,7 @@ static const unsigned long pmic_glink_sm8450_client_mask = BIT(PMIC_GLINK_CLIENT static const struct of_device_id pmic_glink_of_match[] = { { .compatible = "qcom,sc8180x-pmic-glink", .data = &pmic_glink_sc8180x_client_mask }, + { .compatible = "qcom,sc8280xp-pmic-glink", .data = &pmic_glink_sc8180x_client_mask }, { .compatible = "qcom,pmic-glink", .data = &pmic_glink_sm8450_client_mask }, {} };