[v2,9/9] dt-bindings: watchdog: qcom-wdt: Make the interrupt example edge triggered
Message ID | 20231106144335.v2.9.Ie30c1d3f780666f6906fd2fd7c437632c229d987@changeid |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp2971596vqu; Mon, 6 Nov 2023 14:46:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEN3/HstqPgE6cDxldyFHzZZpWAwpisn8BVuwG8tb3U+NYkMF9aC5KnUzk7cYGZDHqJ27LU X-Received: by 2002:a05:6a00:1405:b0:68b:a137:3739 with SMTP id l5-20020a056a00140500b0068ba1373739mr28818334pfu.4.1699310766117; Mon, 06 Nov 2023 14:46:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699310766; cv=none; d=google.com; s=arc-20160816; b=mrWYTp5A/F/I0eXnLRPw96gHm6+rsnzPsTcHqYJ7fuspGhTQTIJsCtDRtAwSmSSCeA tCLlpJzlBUq02w3bLb+K6eAxxrZaNvRI9bcggImOkS7OlW4D2doFAoNZ0Cb997GGt2Qw a15dZzMat2VSanctCPuP65+ji+k0BlTGNl4M97qehYNMz8IuzygpFTR5SBqFGCWI3/t6 2Nha9M9sUhcVlP5jNHtAj0f/0HkbTax9tMSuYpA0QOH5Tb9QcI1/KybNxURKMl634X6O wskEq76NdgTNz5J1Vs945+BVem/e57YDOEASdcdfgd1hvwmg8V1I9k/vY9fe5gmvoAPc ClJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DtIla5EbbYn7ksxcCnIGYzIT7sP4waGo4Xe+LkSJul0=; fh=KYz8GBmOzXIWb3d2X9Am/VbOh+TTlrvs7T5ThCgf2ZY=; b=zwK7riiwmm5TVTWe6amxK4+qCmiqfkjWYcS6VtQJzwhCi4EmcwMG0adgX3k8yNK+0u Sq0Ofi/FPnFSUa8QSX0z4QN3Cf+QyH6z76oATbytuNUPoSqCFb4qddkBlq3rlyxjml1V Oyo7Dib+jOFrt78Vi/Fngw86T6i+k5qm4UVnf17a3H75OJXnnd4a7TC7O+DYSH3CDrlz x9BEUYXm7p0GX7MP5uZZM4sqNqMQeKDO2VhIuHVrJgqJkfwrBg7xao2x/GiT+wWQLG9k WzsHwvuTgFreFd1EcgcqBmAG4TAe8t3lJVatuc1J5aNN+SRS6Ygxl0ERUuQ9SxUQ+Xwn kFZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=I+3E4D4u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id cw13-20020a056a00450d00b006b7d62ed165si9758490pfb.94.2023.11.06.14.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 14:46:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=I+3E4D4u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 16C52806AE70; Mon, 6 Nov 2023 14:45:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233370AbjKFWo5 (ORCPT <rfc822;lhua1029@gmail.com> + 34 others); Mon, 6 Nov 2023 17:44:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233399AbjKFWoo (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 6 Nov 2023 17:44:44 -0500 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FD9010CE for <linux-kernel@vger.kernel.org>; Mon, 6 Nov 2023 14:44:31 -0800 (PST) Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6b709048d8eso4276534b3a.2 for <linux-kernel@vger.kernel.org>; Mon, 06 Nov 2023 14:44:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699310670; x=1699915470; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DtIla5EbbYn7ksxcCnIGYzIT7sP4waGo4Xe+LkSJul0=; b=I+3E4D4uAw4sDrCR+Hzng0lg2b9iQelHjIZlh4r1bIG5QfDfsN8/uy9EZd2WsELD6b ZccTJJWRYG02daFWpEFNspzjY6dCN3PGEledRTmfcRdn2nDXYh4GIZpIGdFsxXaztoC+ azTehmJUtMD3Xt79IUghcdxBqt056Evv31Pv0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699310670; x=1699915470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DtIla5EbbYn7ksxcCnIGYzIT7sP4waGo4Xe+LkSJul0=; b=IrC3gegNnSLUe6m10n6yEbcOfFRdIqPLGllgGE4pdttx8heVgacqcNzxxuhC1opr2z nTa5J9wAfJdqB2dcyX9TCV6wFifwVCeJ8PinMrCyXeQFLCTXHKOvreZQwUU4umC4gCCJ 5sIBcNadi7G9qV6eozUr7if7fjEE6IStry7dupzTm/CUrUapfVxyH5zTFBygu3fYxQtZ bwOFmNZYUuwGVniLyMSIkvAcw1MkkjdwDPzmq4qQmfV6+nTGyO0CRn6QuOk28RHpqnue dDDGZJAok9IXl7p93bn1Qu7e4Otiwyp69mZYdwIv7q4RLbZG9PMv34tHJuxmu7pmJGom BvfQ== X-Gm-Message-State: AOJu0YwimPsw5sQ7tuEaglCcGMlzVMUWMZH3Ng8tlnOZR0cHlqhhyOD+ V6dZ7Y56wlLYjfknSBMZdR+M3A== X-Received: by 2002:a05:6a00:2e29:b0:6bd:71e3:b647 with SMTP id fc41-20020a056a002e2900b006bd71e3b647mr28475394pfb.19.1699310669886; Mon, 06 Nov 2023 14:44:29 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:16a7:2c01:9126:36a4]) by smtp.gmail.com with ESMTPSA id c10-20020a056a00248a00b006b725b2158bsm6043402pfv.41.2023.11.06.14.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 14:44:29 -0800 (PST) From: Douglas Anderson <dianders@chromium.org> To: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net> Cc: swboyd@chromium.org, linux-watchdog@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, linux-arm-msm@vger.kernel.org, Douglas Anderson <dianders@chromium.org>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Andy Gross <agross@kernel.org>, Sai Prakash Ranjan <quic_saipraka@quicinc.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 9/9] dt-bindings: watchdog: qcom-wdt: Make the interrupt example edge triggered Date: Mon, 6 Nov 2023 14:43:36 -0800 Message-ID: <20231106144335.v2.9.Ie30c1d3f780666f6906fd2fd7c437632c229d987@changeid> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> References: <20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 06 Nov 2023 14:45:47 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781856485853548145 X-GMAIL-MSGID: 1781856485853548145 |
Series |
[v2,1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered
|
|
Commit Message
Doug Anderson
Nov. 6, 2023, 10:43 p.m. UTC
As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Update the example in the bindings. Fixes: 7c631cdff391 ("dt-bindings: watchdog: qcom-wdt: allow interrupts") Reviewed-by: Guenter Roeck <linux@roeck-us.net> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> --- (no changes since v1) Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi, On Mon, Nov 6, 2023 at 2:44 PM Douglas Anderson <dianders@chromium.org> wrote: > > As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog > bark interrupt edge triggered"), the Qualcomm watchdog timer's bark > interrupt should be configured as edge triggered. > > Update the example in the bindings. > > Fixes: 7c631cdff391 ("dt-bindings: watchdog: qcom-wdt: allow interrupts") > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > (no changes since v1) > > Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I saw Bjorn landed all of the dts patches from this series but it looks like the bindings patch got left behind. Anyone want to claim it for their tree, or Ack it saying that you'd prefer for it to go through someone else's tree? I assume Krzysztof's Ack means he's not intending for it to go through the DT tree and Bjorn doesn't seem to intend for it to go through the Qualcomm tree. Guenter/Wim: it feels like this could go in the watchdog tree? Thanks! -Doug
Hi Doug, > Hi, > > On Mon, Nov 6, 2023 at 2:44 PM Douglas Anderson <dianders@chromium.org> wrote: > > > > As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog > > bark interrupt edge triggered"), the Qualcomm watchdog timer's bark > > interrupt should be configured as edge triggered. > > > > Update the example in the bindings. > > > > Fixes: 7c631cdff391 ("dt-bindings: watchdog: qcom-wdt: allow interrupts") > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > (no changes since v1) > > > > Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > I saw Bjorn landed all of the dts patches from this series but it > looks like the bindings patch got left behind. Anyone want to claim it > for their tree, or Ack it saying that you'd prefer for it to go > through someone else's tree? I assume Krzysztof's Ack means he's not > intending for it to go through the DT tree and Bjorn doesn't seem to > intend for it to go through the Qualcomm tree. Guenter/Wim: it feels > like this could go in the watchdog tree? I picked it up in the watchdog tree. Kind regards, Wim.
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml index 5046dfa55f13..681d1efbaf2f 100644 --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml @@ -121,7 +121,7 @@ examples: compatible = "qcom,apss-wdt-sm8150", "qcom,kpss-wdt"; reg = <0x17c10000 0x1000>; clocks = <&sleep_clk>; - interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>; timeout-sec = <10>; };