crypto: starfive: Remove unneeded NULL checks
Commit Message
NULL check before kfree_sensitive function is not needed.
Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202311301702.LxswfETY-lkp@intel.com/
---
drivers/crypto/starfive/jh7110-rsa.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
Comments
On Mon, Dec 04, 2023 at 11:02:39AM +0800, Jia Jie Ho wrote:
> NULL check before kfree_sensitive function is not needed.
>
> Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311301702.LxswfETY-lkp@intel.com/
> ---
> drivers/crypto/starfive/jh7110-rsa.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Patch applied. Thanks.
@@ -45,12 +45,9 @@ static inline int starfive_pka_wait_done(struct starfive_cryp_ctx *ctx)
static void starfive_rsa_free_key(struct starfive_rsa_key *key)
{
- if (key->d)
- kfree_sensitive(key->d);
- if (key->e)
- kfree_sensitive(key->e);
- if (key->n)
- kfree_sensitive(key->n);
+ kfree_sensitive(key->d);
+ kfree_sensitive(key->e);
+ kfree_sensitive(key->n);
memset(key, 0, sizeof(*key));
}