Message ID | 20231201230257.238513-1-jaegeuk@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1466352vqy; Fri, 1 Dec 2023 15:03:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8BmWg6q9ndUPlqapnjEHKwUtJmCWgWcA4TeSUbwjE3yocCwybqY5QDoUTFhZF4P56v/xr X-Received: by 2002:a05:6a21:338a:b0:18f:97c:614a with SMTP id yy10-20020a056a21338a00b0018f097c614amr286824pzb.71.1701471806277; Fri, 01 Dec 2023 15:03:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701471806; cv=none; d=google.com; s=arc-20160816; b=O9lhgzmhliAb3LY5MtnBUlb2SR83TGGI4SDIrR6G9ZeBz3A+ScQsoNUno7UESozXTN WqFVPCAJ1o4GkfexyPGrjtmPSU20wmTjaJKEHOddSm012x6fX1HMV5qSwnD8VIkZNB/h M9v5VhurgIT5JRXrtsdyn2y64h5VdE26SudbIf1UbFy/zDeYE41Y46GaL3tEWEbfv/tQ TNkqdePhM23pvte81GddjeM+8BZI2GzuSGL+4hfGDWMrVI011tcX41BR7/tWnYcgnCjt vlc+7OkzU1sztFGLG6cUwaTs1+8DfVAjm8TyK7CV0AODSJt6yJAFWfQKuh+gzargLWFq 452A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1nOqAWj20No7G8mrJyYk9Mxl2k+nJ8MA37MHTSjZwxk=; fh=rqHW7NazYv3wAmgqDKAbZUXWTmf0VaM5epB9R4zfTUE=; b=bQtwDwQLsuHzdUhI6QwLKlO72PtiueKSGSNOhxl5Ogr8lspMUXkTZ7WN2LQmTVChOI Ne9JxRSNm9Mgdp4PTqc6/cbbSAR4r1BWuQKStDOzqg5S6Py9qVvUPyDJYFyO3Ecide/B BvK3AxtxdpUXndI0pRGsGO+o2S3LZ4tcLIY99G9Z4WH5sX7HR6GwCrwhFnYl87gh8dcG btPdyF9/DoLikwtY4+VVUHeWpn1sbKM7O7zgbOqtCyPoDk+4xqaI4TaUpp+mHfplxSrV lth5e+8CrF/AY5Unhdso9xOWNZ28VPfcdceCBRzp+QdEsfmG0Pv5Swq4AdS24M1cLsvb V0lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c2HCOXrn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id y188-20020a6364c5000000b005ab6142f1besi3977300pgb.169.2023.12.01.15.03.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 15:03:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c2HCOXrn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 29A5B80D31C5; Fri, 1 Dec 2023 15:03:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbjLAXCx (ORCPT <rfc822;pwkd43@gmail.com> + 99 others); Fri, 1 Dec 2023 18:02:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjLAXCw (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 1 Dec 2023 18:02:52 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CFBA103 for <linux-kernel@vger.kernel.org>; Fri, 1 Dec 2023 15:02:59 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93566C433C8; Fri, 1 Dec 2023 23:02:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701471778; bh=62w1oB1pHopShKh9tMtaRg6KHPHhkdny8MubdbV91fQ=; h=From:To:Cc:Subject:Date:From; b=c2HCOXrnwzG/PgSp+pZZQxjdPmCpwKk49Hqhbo/Ro12tzYvu/nAGK4SXLEUorI70u EiN9jVDo+4/2wJ7rrCB1fCsletjR+fW18IqsR+Sq+JlEF82jXTj+jCSiLQ1NcgoC25 HhXUARvjWEglu0kJZIsOY4ZVJGAa/k+6xp8Xwo1QB3aRagRBuy14GgtD8nkhbd/SHn 3QHNk/2AnuZAWzlnocjletodpcc3MpV+GcQKLwh/lkU4nZGKXfnzAXBc+b0oM0w+Sl 8HDJHqePbA88m+S6IYBuGXoGTxbd2G7XAZ9v4y7XX07kbTinTdOqB487uU0DwbbOnZ BjE8UUeYynNlg== From: Jaegeuk Kim <jaegeuk@kernel.org> To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim <jaegeuk@kernel.org> Subject: [PATCH] f2fs: allow checkpoint=disable for zoned block device Date: Fri, 1 Dec 2023 15:02:56 -0800 Message-ID: <20231201230257.238513-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 01 Dec 2023 15:03:01 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784122500668770499 X-GMAIL-MSGID: 1784122500668770499 |
Series |
f2fs: allow checkpoint=disable for zoned block device
|
|
Commit Message
Jaegeuk Kim
Dec. 1, 2023, 11:02 p.m. UTC
Let's allow checkpoint=disable back for zoned block device. It's very risky
as the feature relies on fsck or runtime recovery which matches the write
pointers again if the device rebooted while disabling the checkpoint.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/super.c | 5 -----
1 file changed, 5 deletions(-)
Comments
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Fri, 1 Dec 2023 15:02:56 -0800 you wrote: > Let's allow checkpoint=disable back for zoned block device. It's very risky > as the feature relies on fsck or runtime recovery which matches the write > pointers again if the device rebooted while disabling the checkpoint. > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > --- > fs/f2fs/super.c | 5 ----- > 1 file changed, 5 deletions(-) Here is the summary with links: - [f2fs-dev] f2fs: allow checkpoint=disable for zoned block device https://git.kernel.org/jaegeuk/f2fs/c/29215a7d43c7 You are awesome, thank you!
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 033af907c3b1..617340e9ea7f 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -1422,11 +1422,6 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount) } } - if (test_opt(sbi, DISABLE_CHECKPOINT) && f2fs_lfs_mode(sbi)) { - f2fs_err(sbi, "LFS is not compatible with checkpoint=disable"); - return -EINVAL; - } - if (test_opt(sbi, ATGC) && f2fs_lfs_mode(sbi)) { f2fs_err(sbi, "LFS is not compatible with ATGC"); return -EINVAL;