Message ID | 20231207165251.2855783-1-robh@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp4916704vqy; Thu, 7 Dec 2023 08:53:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNVViBPiUYzEEFkLFOwTwTrcsBpoHbqxHP1yuvspKf9yTBRzvk0Man0zwIQE4Tz+EDpzZR X-Received: by 2002:a17:90a:f192:b0:286:8f94:baf9 with SMTP id bv18-20020a17090af19200b002868f94baf9mr2068424pjb.22.1701967985896; Thu, 07 Dec 2023 08:53:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701967985; cv=none; d=google.com; s=arc-20160816; b=fRo2bbFAAhmo5t22qATDF5UnZxhY0wpjkcr0KiBW3Ga2mL8vbUdS9FZdQM34VMuxKl DdRb3DH6fJ84P3SwU2zTKi+8MimlRPgdBceTs+WE/c12G4RkT/UAN1wnT/ndFU3GjT8S 3847rpM8FyJHbKOCpRdsrRWhyW7LK7VAw0DolOKsIZxJEL7R8JSTio2gZLpWskG+vzKL YpGEaRpMliBYftZeF9rdbmjf1nk6FS/o/Zz8LUeHbQ8wjBu68GInwtk/JYWdN4rE+MAx Oqyox8QuW4zfvTn3gKeIeLYnSoFr7P21UuZQx2yr4agni94ClWxFLnDe6FkXomSzI7rX /8/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=jBWpeuUGETy3rsau1CIanjaFB3XHnIk3Ug7FoMVzpS8=; fh=oOOYoe7K5Ks0xN8pmr+WHphqElSIPtagQpxRcZs3xV8=; b=FZLY/6tVUbFBp1ESMdSihmGunhRVQj1QJS3vni9LsL4BMIaI6OmjbJZ6u7XvYC52Ws DmXOMRG25sq0Fh1Hdh+NEToTRA/bnGxaWE7wKV2pzONRXme6vAybMNa9Fp3U7MPaQ5Ff b9msYZ9Fstcawip9g7Zm90E3MQqHcOC8sJ1/uI3fTPZF4s3I3e10fwwkHVkBV1W/rVqf 8z5EuyV6C+fjBk8lbdSYMfxV4Hv2zcHVtOpuTC3GNKPBgCPbUdHRZbIrV8NL82IX6+HX xKohwQsWuZ5ph8frHXTMo6F8/k3SvnEaiaCT4P2CQrroCf60NgmwiHPXr1XgkvGnr5md Vc6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id ot4-20020a17090b3b4400b00285c4fd2ff0si113690pjb.116.2023.12.07.08.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 08:53:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 930C780C3A0E; Thu, 7 Dec 2023 08:53:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1441933AbjLGQwx (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Thu, 7 Dec 2023 11:52:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232813AbjLGQww (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 7 Dec 2023 11:52:52 -0500 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 659DA10F3; Thu, 7 Dec 2023 08:52:59 -0800 (PST) Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3b9e07690ccso427073b6e.3; Thu, 07 Dec 2023 08:52:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701967978; x=1702572778; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jBWpeuUGETy3rsau1CIanjaFB3XHnIk3Ug7FoMVzpS8=; b=DroBu+9/y90GBDbk0rBjvxvi8/2ymAU6h2NIyk0nagPhEtVKUBO1z+w6p2NTRm2UIR 3AxvIhWb2sKYMR+iMOWSYqvYDPFAgeDhL0XlWJN0BvlResQY/gDGVey6mqJR3JjK/AKr tm2Ml9C+gRJ1YFwg4ut4lBgUTf0GzAuL102wDOySF8iVrLivgAQwHt8+ugYg3waG5MfS wbmONqWQv/Ue2pwt8pt5Nnqa6fDtcgVZ0EycYSI5ljFy0ALif5LtFV1OSVz7rC9aqR2o 6DC9fdDMMstgW+AgbS1R/TnQWNMIOz9wJSkrJbrE9mI6/8EQqsQKf/GC8s20b9o/fxZK bxFw== X-Gm-Message-State: AOJu0YzNnpOKAStU47lksKKbV/iIgJQZ32+ne3nmcfXK/OEi4chX5ZvZ KAewGxa/I8H/iMvcE44Itw== X-Received: by 2002:a05:6808:191b:b0:3b8:b063:5d6d with SMTP id bf27-20020a056808191b00b003b8b0635d6dmr3494663oib.84.1701967978577; Thu, 07 Dec 2023 08:52:58 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id e4-20020a056808148400b003b2daf09267sm14906oiw.48.2023.12.07.08.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 08:52:58 -0800 (PST) Received: (nullmailer pid 2855942 invoked by uid 1000); Thu, 07 Dec 2023 16:52:57 -0000 From: Rob Herring <robh@kernel.org> To: Marek Vasut <marek.vasut+renesas@gmail.com>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>, Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= <kw@linux.com>, Bjorn Helgaas <bhelgaas@google.com> Cc: linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pci: rcar-gen4: Replace of_device.h with explicit of.h include Date: Thu, 7 Dec 2023 10:52:50 -0600 Message-ID: <20231207165251.2855783-1-robh@kernel.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 07 Dec 2023 08:53:02 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784642782906665635 X-GMAIL-MSGID: 1784642782906665635 |
Series |
pci: rcar-gen4: Replace of_device.h with explicit of.h include
|
|
Commit Message
Rob Herring
Dec. 7, 2023, 4:52 p.m. UTC
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it was merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/pci/controller/dwc/pcie-rcar-gen4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hello, > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it was merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. Applied to controller/rcar, thank you! [1/1] PCI: rcar-gen4: Replace of_device.h with explicit of.h include https://git.kernel.org/pci/pci/c/263714f5fcf8 Krzysztof
Hello, > From: Krzysztof Wilczyński, Sent: Thursday, December 14, 2023 10:33 AM > > Hello, > > > The DT of_device.h and of_platform.h date back to the separate > > of_platform_bus_type before it was merged into the regular platform bus. > > As part of that merge prepping Arm DT support 13 years ago, they > > "temporarily" include each other. They also include platform_device.h > > and of.h. As a result, there's a pretty much random mix of those include > > files used throughout the tree. In order to detangle these headers and > > replace the implicit includes with struct declarations, users need to > > explicitly include the correct includes. > > Applied to controller/rcar, thank you! > > [1/1] PCI: rcar-gen4: Replace of_device.h with explicit of.h include > > https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?id=263714f5fcf8 Thank you! I completely overlooked this patch. Maybe it's too late, but I also reviewed this patch, so Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> It's up to you whether my tag is added to the commit or not :) Best regards, Yoshihiro Shimoda > Krzysztof
Hello, > > > The DT of_device.h and of_platform.h date back to the separate > > > of_platform_bus_type before it was merged into the regular platform bus. > > > As part of that merge prepping Arm DT support 13 years ago, they > > > "temporarily" include each other. They also include platform_device.h > > > and of.h. As a result, there's a pretty much random mix of those include > > > files used throughout the tree. In order to detangle these headers and > > > replace the implicit includes with struct declarations, users need to > > > explicitly include the correct includes. > > > > Applied to controller/rcar, thank you! > > > > [1/1] PCI: rcar-gen4: Replace of_device.h with explicit of.h include > > > > https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?id=263714f5fcf8 > > Thank you! I completely overlooked this patch. Maybe it's too late, but I also reviewed this patch, so > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > It's up to you whether my tag is added to the commit or not :) No worries. Never too late for a good review. :) As such, I added your Reviewed-by, so it should be there, per: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/rcar&id=ec215237480478ca5523ea12f58803d9b7a8a0ea Krzysztof
diff --git a/drivers/pci/controller/dwc/pcie-rcar-gen4.c b/drivers/pci/controller/dwc/pcie-rcar-gen4.c index 3bc45e513b3d..2ca5b7983d62 100644 --- a/drivers/pci/controller/dwc/pcie-rcar-gen4.c +++ b/drivers/pci/controller/dwc/pcie-rcar-gen4.c @@ -8,7 +8,7 @@ #include <linux/interrupt.h> #include <linux/io.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/pci.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h>