[10/10] dt-bindings: pinctrl: qcom: drop common properties and allow wakeup-parent
Commit Message
Drop common properties already defined in referenced common Qualcomm SoC
TLMM bindings and use "unevaluatedProperties: false". This makes the
binding smaller and easier to review. Additionally this allows now
"wakeup-parent" property coming from common TLMM bindings.
In few places move the "required:" block to bottom, to match convention.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 8 +-------
.../bindings/pinctrl/qcom,mdm9615-pinctrl.yaml | 18 ++++++------------
.../bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 8 +-------
.../bindings/pinctrl/qcom,msm8953-pinctrl.yaml | 7 +------
.../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 8 +-------
.../bindings/pinctrl/qcom,sdx65-tlmm.yaml | 8 +-------
6 files changed, 11 insertions(+), 46 deletions(-)
Comments
On Fri, 08 Dec 2023 22:55:34 +0100, Krzysztof Kozlowski wrote:
> Drop common properties already defined in referenced common Qualcomm SoC
> TLMM bindings and use "unevaluatedProperties: false". This makes the
> binding smaller and easier to review. Additionally this allows now
> "wakeup-parent" property coming from common TLMM bindings.
>
> In few places move the "required:" block to bottom, to match convention.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 8 +-------
> .../bindings/pinctrl/qcom,mdm9615-pinctrl.yaml | 18 ++++++------------
> .../bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 8 +-------
> .../bindings/pinctrl/qcom,msm8953-pinctrl.yaml | 7 +------
> .../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 8 +-------
> .../bindings/pinctrl/qcom,sdx65-tlmm.yaml | 8 +-------
> 6 files changed, 11 insertions(+), 46 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
@@ -22,12 +22,6 @@ properties:
interrupts:
maxItems: 1
- interrupt-controller: true
- "#interrupt-cells": true
- gpio-controller: true
- "#gpio-cells": true
- gpio-ranges: true
-
patternProperties:
"-state$":
oneOf:
@@ -100,7 +94,7 @@ required:
- compatible
- reg
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
@@ -23,18 +23,6 @@ properties:
interrupts:
maxItems: 1
- interrupt-controller: true
- '#interrupt-cells': true
- gpio-controller: true
- '#gpio-cells': true
- gpio-ranges: true
-
-required:
- - compatible
- - reg
-
-additionalProperties: false
-
patternProperties:
"-state$":
oneOf:
@@ -74,6 +62,12 @@ $defs:
required:
- pins
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
examples:
- |
#include <dt-bindings/interrupt-controller/arm-gic.h>
@@ -23,12 +23,6 @@ properties:
interrupts:
maxItems: 1
- interrupt-controller: true
- "#interrupt-cells": true
- gpio-controller: true
- "#gpio-cells": true
- gpio-ranges: true
-
gpio-reserved-ranges:
maxItems: 1
@@ -82,7 +76,7 @@ required:
- compatible
- reg
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
@@ -22,12 +22,7 @@ properties:
interrupts:
maxItems: 1
- interrupt-controller: true
- "#interrupt-cells": true
- gpio-controller: true
gpio-reserved-ranges: true
- "#gpio-cells": true
- gpio-ranges: true
patternProperties:
"-state$":
@@ -117,7 +112,7 @@ required:
- compatible
- reg
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
@@ -23,12 +23,6 @@ properties:
interrupts:
maxItems: 1
- interrupt-controller: true
- "#interrupt-cells": true
- gpio-controller: true
- "#gpio-cells": true
- gpio-ranges: true
-
gpio-reserved-ranges:
maxItems: 1
@@ -102,7 +96,7 @@ required:
- compatible
- reg
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
@@ -22,12 +22,6 @@ properties:
interrupts:
maxItems: 1
- interrupt-controller: true
- "#interrupt-cells": true
- gpio-controller: true
- "#gpio-cells": true
- gpio-ranges: true
-
gpio-reserved-ranges:
maxItems: 1
@@ -122,7 +116,7 @@ required:
- compatible
- reg
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |