[committed,v2] aarch64: Add missing driver-aarch64 dependencies

Message ID c2ebaca6-7bae-7130-a160-33c4e7152670@e124511.cambridge.arm.com
State Accepted
Headers
Series [committed,v2] aarch64: Add missing driver-aarch64 dependencies |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Andrew Carlotti Dec. 13, 2023, 2:47 p.m. UTC
  On Sat, Dec 09, 2023 at 06:42:17PM +0000, Richard Sandiford wrote:
> Andrew Carlotti <andrew.carlotti@arm.com> writes:
> The .def files are included in TM_H by:
> 
> TM_H += $(srcdir)/config/aarch64/aarch64-fusion-pairs.def \
> 	$(srcdir)/config/aarch64/aarch64-tuning-flags.def \
> 	$(srcdir)/config/aarch64/aarch64-option-extensions.def \
> 	$(srcdir)/config/aarch64/aarch64-cores.def \
> 	$(srcdir)/config/aarch64/aarch64-isa-modes.def \
> 	$(srcdir)/config/aarch64/aarch64-arches.def

They are included now, but only because you added them last week.

I've removed them in v2 of the patch, committed as below:

---

gcc/ChangeLog:

	* config/aarch64/x-aarch64: Add missing dependencies.
  

Comments

Richard Sandiford Dec. 13, 2023, 6:03 p.m. UTC | #1
Andrew Carlotti <andrew.carlotti@arm.com> writes:
> On Sat, Dec 09, 2023 at 06:42:17PM +0000, Richard Sandiford wrote:
>> Andrew Carlotti <andrew.carlotti@arm.com> writes:
>> The .def files are included in TM_H by:
>> 
>> TM_H += $(srcdir)/config/aarch64/aarch64-fusion-pairs.def \
>> 	$(srcdir)/config/aarch64/aarch64-tuning-flags.def \
>> 	$(srcdir)/config/aarch64/aarch64-option-extensions.def \
>> 	$(srcdir)/config/aarch64/aarch64-cores.def \
>> 	$(srcdir)/config/aarch64/aarch64-isa-modes.def \
>> 	$(srcdir)/config/aarch64/aarch64-arches.def
>
> They are included now, but only because you added them last week.

Ah, right.  I'd already forgotten that I'd only done that recently, sorry...

> I've removed them in v2 of the patch, committed as below:

Thanks.

> ---
>
> gcc/ChangeLog:
>
> 	* config/aarch64/x-aarch64: Add missing dependencies.
>
>
> diff --git a/gcc/config/aarch64/x-aarch64 b/gcc/config/aarch64/x-aarch64
> index 3cf701a0a01ab00eaaafdfad14bd90ebbb1d498f..ee828c9af53a11885c2bcef8f112c0ebaf161c59 100644
> --- a/gcc/config/aarch64/x-aarch64
> +++ b/gcc/config/aarch64/x-aarch64
> @@ -1,3 +1,5 @@
>  driver-aarch64.o: $(srcdir)/config/aarch64/driver-aarch64.cc \
> -  $(CONFIG_H) $(SYSTEM_H)
> +  $(CONFIG_H) $(SYSTEM_H) $(TM_H) $(CORETYPES_H) \
> +  $(srcdir)/config/aarch64/aarch64-protos.h \
> +  $(srcdir)/config/aarch64/aarch64-feature-deps.h
>  	$(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) $<
  

Patch

diff --git a/gcc/config/aarch64/x-aarch64 b/gcc/config/aarch64/x-aarch64
index 3cf701a0a01ab00eaaafdfad14bd90ebbb1d498f..ee828c9af53a11885c2bcef8f112c0ebaf161c59 100644
--- a/gcc/config/aarch64/x-aarch64
+++ b/gcc/config/aarch64/x-aarch64
@@ -1,3 +1,5 @@ 
 driver-aarch64.o: $(srcdir)/config/aarch64/driver-aarch64.cc \
-  $(CONFIG_H) $(SYSTEM_H)
+  $(CONFIG_H) $(SYSTEM_H) $(TM_H) $(CORETYPES_H) \
+  $(srcdir)/config/aarch64/aarch64-protos.h \
+  $(srcdir)/config/aarch64/aarch64-feature-deps.h
 	$(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) $<