[v1] thermal: trip: Drop redundant __thermal_zone_get_trip() header

Message ID 2709306.mvXUDI8C0e@kreacher
State New
Headers
Series [v1] thermal: trip: Drop redundant __thermal_zone_get_trip() header |

Commit Message

Rafael J. Wysocki Dec. 4, 2023, 7:36 p.m. UTC
  From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

The __thermal_zone_get_trip() header in drivers/thermal/thermal_core.h
is redundant, because there is one already in thermal.h, so drop it.

No functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/thermal/thermal_core.h |    2 --
 1 file changed, 2 deletions(-)
  

Comments

Rafael J. Wysocki Dec. 12, 2023, 6:58 p.m. UTC | #1
On Mon, Dec 4, 2023 at 8:36 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The __thermal_zone_get_trip() header in drivers/thermal/thermal_core.h
> is redundant, because there is one already in thermal.h, so drop it.
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

From the lack of comments I gather that this change is fine with
everyone, so I'm going to queue it up for 6.8.

Thanks!

> ---
>  drivers/thermal/thermal_core.h |    2 --
>  1 file changed, 2 deletions(-)
>
> Index: linux-pm/drivers/thermal/thermal_core.h
> ===================================================================
> --- linux-pm.orig/drivers/thermal/thermal_core.h
> +++ linux-pm/drivers/thermal/thermal_core.h
> @@ -120,8 +120,6 @@ void __thermal_zone_device_update(struct
>         for (__trip = __tz->trips; __trip - __tz->trips < __tz->num_trips; __trip++)
>
>  void __thermal_zone_set_trips(struct thermal_zone_device *tz);
> -int __thermal_zone_get_trip(struct thermal_zone_device *tz, int trip_id,
> -                           struct thermal_trip *trip);
>  int thermal_zone_trip_id(struct thermal_zone_device *tz,
>                          const struct thermal_trip *trip);
>  void thermal_zone_trip_updated(struct thermal_zone_device *tz,
>
>
>
>
  
Daniel Lezcano Dec. 13, 2023, 10:52 a.m. UTC | #2
On 04/12/2023 20:36, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> The __thermal_zone_get_trip() header in drivers/thermal/thermal_core.h
> is redundant, because there is one already in thermal.h, so drop it.
> 
> No functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
  

Patch

Index: linux-pm/drivers/thermal/thermal_core.h
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_core.h
+++ linux-pm/drivers/thermal/thermal_core.h
@@ -120,8 +120,6 @@  void __thermal_zone_device_update(struct
 	for (__trip = __tz->trips; __trip - __tz->trips < __tz->num_trips; __trip++)
 
 void __thermal_zone_set_trips(struct thermal_zone_device *tz);
-int __thermal_zone_get_trip(struct thermal_zone_device *tz, int trip_id,
-			    struct thermal_trip *trip);
 int thermal_zone_trip_id(struct thermal_zone_device *tz,
 			 const struct thermal_trip *trip);
 void thermal_zone_trip_updated(struct thermal_zone_device *tz,