diff mbox series

sched/headers: Remove duplicated struct rq declare

Message ID 202312072018+0800-wangjinchao@xfusion.com
State New
Headers
Series sched/headers: Remove duplicated struct rq declare |

Commit Message

Wang Jinchao Dec. 7, 2023, 12:19 p.m. UTC 
  `struct rq` has been declared at the top of the file,
so remove the second declaration.

Signed-off-by: WangJinchao <wangjinchao@xfusion.com>
---
 kernel/sched/sched.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Tim Chen Dec. 12, 2023, 10:26 p.m. UTC | #1 
On Thu, 2023-12-07 at 20:19 +0800, WangJinchao wrote:
> `struct rq` has been declared at the top of the file,
> so remove the second declaration.
> 
> Signed-off-by: WangJinchao <wangjinchao@xfusion.com>
> ---
>  kernel/sched/sched.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 2e5a95486a42..349c90554bd8 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -931,7 +931,6 @@ struct uclamp_rq {
>  DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
>  #endif /* CONFIG_UCLAMP_TASK */
>  
> -struct rq;
>  struct balance_callback {
>  	struct balance_callback *next;
>  	void (*func)(struct rq *rq);

Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>

Tim
Vincent Guittot Dec. 18, 2023, 1:51 p.m. UTC | #2 
On Thu, 7 Dec 2023 at 13:20, WangJinchao <wangjinchao@xfusion.com> wrote:
>
> `struct rq` has been declared at the top of the file,
> so remove the second declaration.
>
> Signed-off-by: WangJinchao <wangjinchao@xfusion.com>

Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

> ---
>  kernel/sched/sched.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 2e5a95486a42..349c90554bd8 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -931,7 +931,6 @@ struct uclamp_rq {
>  DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
>  #endif /* CONFIG_UCLAMP_TASK */
>
> -struct rq;
>  struct balance_callback {
>         struct balance_callback *next;
>         void (*func)(struct rq *rq);
> --
> 2.40.0
>
diff mbox series

Patch

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 2e5a95486a42..349c90554bd8 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -931,7 +931,6 @@  struct uclamp_rq {
 DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
 #endif /* CONFIG_UCLAMP_TASK */
 
-struct rq;
 struct balance_callback {
 	struct balance_callback *next;
 	void (*func)(struct rq *rq);