diff mbox series

arm64: dts: qcom: sm8650: drop unneeded assigned-clocks from WSA macro

Message ID 20231212133143.100575-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series arm64: dts: qcom: sm8650: drop unneeded assigned-clocks from WSA macro |

Commit Message

Krzysztof Kozlowski Dec. 12, 2023, 1:31 p.m. UTC 
  Review of v1 patch resulting in commit 58872a54e4a8 ("arm64: dts: qcom:
sm8650: add ADSP audio codec macros") pointed to remove unneeded
assigned-clock-rates from macro codecs.  One assignment was left in WSA
macro codec, so drop it now as it is redundant: these clocks have fixed
19.2 MHz frequency.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8650.dtsi | 3 ---
 1 file changed, 3 deletions(-)

Comments

Neil Armstrong Dec. 12, 2023, 1:43 p.m. UTC | #1 
On 12/12/2023 14:31, Krzysztof Kozlowski wrote:
> Review of v1 patch resulting in commit 58872a54e4a8 ("arm64: dts: qcom:
> sm8650: add ADSP audio codec macros") pointed to remove unneeded
> assigned-clock-rates from macro codecs.  One assignment was left in WSA
> macro codec, so drop it now as it is redundant: these clocks have fixed
> 19.2 MHz frequency.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   arch/arm64/boot/dts/qcom/sm8650.dtsi | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index 425e1e50d945..3d55d08649ca 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -2773,9 +2773,6 @@ lpass_wsamacro: codec@6b00000 {
>   				      "dcodec",
>   				      "fsgen";
>   
> -			assigned-clocks = <&q6prmcc LPASS_CLK_ID_WSA_CORE_TX_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> -			assigned-clock-rates = <19200000>;
> -
>   			#clock-cells = <0>;
>   			clock-output-names = "mclk";
>   			#sound-dai-cells = <1>;

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Konrad Dybcio Dec. 12, 2023, 2:41 p.m. UTC | #2 
On 12/12/23 14:31, Krzysztof Kozlowski wrote:
> Review of v1 patch resulting in commit 58872a54e4a8 ("arm64: dts: qcom:
> sm8650: add ADSP audio codec macros") pointed to remove unneeded
> assigned-clock-rates from macro codecs.  One assignment was left in WSA
> macro codec, so drop it now as it is redundant: these clocks have fixed
> 19.2 MHz frequency.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Thanks, could you also check if they're fixed on older platforms?

Konrad
Krzysztof Kozlowski Dec. 12, 2023, 7:05 p.m. UTC | #3 
On 12/12/2023 15:41, Konrad Dybcio wrote:
> 
> 
> On 12/12/23 14:31, Krzysztof Kozlowski wrote:
>> Review of v1 patch resulting in commit 58872a54e4a8 ("arm64: dts: qcom:
>> sm8650: add ADSP audio codec macros") pointed to remove unneeded
>> assigned-clock-rates from macro codecs.  One assignment was left in WSA
>> macro codec, so drop it now as it is redundant: these clocks have fixed
>> 19.2 MHz frequency.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> Thanks, could you also check if they're fixed on older platforms?
> 

Ack. To my understand they should not be needed in none of Audioreach
platforms (sc8280xp, sm8[45]50), but I can test only sm8550.

Best regards,
Krzysztof
Bjorn Andersson Dec. 17, 2023, 5:21 p.m. UTC | #4 
On Tue, 12 Dec 2023 14:31:43 +0100, Krzysztof Kozlowski wrote:
> Review of v1 patch resulting in commit 58872a54e4a8 ("arm64: dts: qcom:
> sm8650: add ADSP audio codec macros") pointed to remove unneeded
> assigned-clock-rates from macro codecs.  One assignment was left in WSA
> macro codec, so drop it now as it is redundant: these clocks have fixed
> 19.2 MHz frequency.
> 
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sm8650: drop unneeded assigned-clocks from WSA macro
      commit: 55855d20208a5048ab44ccaf2d5aedd8f9f70e86

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
index 425e1e50d945..3d55d08649ca 100644
--- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
@@ -2773,9 +2773,6 @@  lpass_wsamacro: codec@6b00000 {
 				      "dcodec",
 				      "fsgen";
 
-			assigned-clocks = <&q6prmcc LPASS_CLK_ID_WSA_CORE_TX_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
-			assigned-clock-rates = <19200000>;
-
 			#clock-cells = <0>;
 			clock-output-names = "mclk";
 			#sound-dai-cells = <1>;