diff mbox series

[358/606] media: i2c/ov6650: Convert to i2c's .probe_new()

Message ID 20221118224540.619276-359-uwe@kleine-koenig.org
State New
Headers
Series i2c: Complete conversion to i2c_probe_new |

Commit Message

Uwe Kleine-König Nov. 18, 2022, 10:41 p.m. UTC 
  From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/media/i2c/ov6650.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Janusz Krzysztofik Nov. 19, 2022, 7 a.m. UTC | #1 
Dnia piątek, 18 listopada 2022 23:41:32 CET Uwe Kleine-König pisze:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

LGTM

Acked-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>


> ---
>  drivers/media/i2c/ov6650.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/ov6650.c b/drivers/media/i2c/ov6650.c
> index 18f041e985b7..4c0ea2ae671b 100644
> --- a/drivers/media/i2c/ov6650.c
> +++ b/drivers/media/i2c/ov6650.c
> @@ -1025,8 +1025,7 @@ static const struct v4l2_subdev_internal_ops ov6650_internal_ops = {
>  /*
>   * i2c_driver function
>   */
> -static int ov6650_probe(struct i2c_client *client,
> -                     const struct i2c_device_id *did)
> +static int ov6650_probe(struct i2c_client *client)
>  {
>       struct ov6650 *priv;
>       int ret;
> @@ -1114,7 +1113,7 @@ static struct i2c_driver ov6650_i2c_driver = {
>       .driver = {
>               .name = "ov6650",
>       },
> -     .probe    = ov6650_probe,
> +     .probe_new = ov6650_probe,
>       .remove   = ov6650_remove,
>       .id_table = ov6650_id,
>  };
>
Laurent Pinchart Nov. 19, 2022, 5:45 p.m. UTC | #2 
On Fri, Nov 18, 2022 at 11:41:32PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/i2c/ov6650.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov6650.c b/drivers/media/i2c/ov6650.c
> index 18f041e985b7..4c0ea2ae671b 100644
> --- a/drivers/media/i2c/ov6650.c
> +++ b/drivers/media/i2c/ov6650.c
> @@ -1025,8 +1025,7 @@ static const struct v4l2_subdev_internal_ops ov6650_internal_ops = {
>  /*
>   * i2c_driver function
>   */
> -static int ov6650_probe(struct i2c_client *client,
> -			const struct i2c_device_id *did)
> +static int ov6650_probe(struct i2c_client *client)
>  {
>  	struct ov6650 *priv;
>  	int ret;
> @@ -1114,7 +1113,7 @@ static struct i2c_driver ov6650_i2c_driver = {
>  	.driver = {
>  		.name = "ov6650",
>  	},
> -	.probe    = ov6650_probe,
> +	.probe_new = ov6650_probe,
>  	.remove   = ov6650_remove,
>  	.id_table = ov6650_id,
>  };
> -- 
> 2.38.1
>
diff mbox series

Patch

diff --git a/drivers/media/i2c/ov6650.c b/drivers/media/i2c/ov6650.c
index 18f041e985b7..4c0ea2ae671b 100644
--- a/drivers/media/i2c/ov6650.c
+++ b/drivers/media/i2c/ov6650.c
@@ -1025,8 +1025,7 @@  static const struct v4l2_subdev_internal_ops ov6650_internal_ops = {
 /*
  * i2c_driver function
  */
-static int ov6650_probe(struct i2c_client *client,
-			const struct i2c_device_id *did)
+static int ov6650_probe(struct i2c_client *client)
 {
 	struct ov6650 *priv;
 	int ret;
@@ -1114,7 +1113,7 @@  static struct i2c_driver ov6650_i2c_driver = {
 	.driver = {
 		.name = "ov6650",
 	},
-	.probe    = ov6650_probe,
+	.probe_new = ov6650_probe,
 	.remove   = ov6650_remove,
 	.id_table = ov6650_id,
 };