Message ID | 20231210133915.42112-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp6520485vqy; Sun, 10 Dec 2023 05:39:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFtgOe+EA3rGJ5fCRgftDedrXe8MidpDfvWUUzBtBJ1GJ+0uGRX24AycN239kn3BNuJH31Z X-Received: by 2002:a17:903:6c3:b0:1d0:700b:3f6b with SMTP id kj3-20020a17090306c300b001d0700b3f6bmr3613414plb.37.1702215574701; Sun, 10 Dec 2023 05:39:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702215574; cv=none; d=google.com; s=arc-20160816; b=EiejyuXwHJr3l80MrKqSRW25HkXlDqkGBxROstuIXbAwwmqHYhXdx80lWSidiUgpA5 wT0GK5bKLPSPX0K/aTJGMcrjjrosye2z4EmvQx7Tk3KLYYgE7vj1GkRV8lENuYY7wqBc 3L5+7eCoYq7cKQXb6XEqotkce3SuTvSg3w/AMdufUzrqcmaj2zuV9xy6U3VZ8uVOntN1 TzOV1zS5CWHuZcWi+gx9lYYem/dLjUnxiFQoJMV9C+si5TfIyydFii9QU58zFv2c1XVP K8itbMPFcKBgvWAWSy306XlIkSlzKx66YPnBa+Sv427ACp1bjMHqMJJWk2U+jxNkm0fk 0WHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=SxGHOiWgHxymjdsJtkFtmgKrK8IqfIoFz7FXA4eYB1c=; fh=bQCwuAegX3sJIwwEDp07rcR5xegbU6X7hzVSodSFvD0=; b=c99eaCv2M6UnPXrxgeKc9E/EpG1z6Y4MzQUEBkmv6ony89q3whnwXvHVbTKupylNQ8 oOsi6emPg0PHgIAgOEj2d/xGQJFitBNi5Ec0BNF1jh5mKiKws3ibecxhO+u48psFS26/ 06GKSrG0PlHigdT0SpRsPdqCORZDXYKQkbaJ1efUqSEAB3JAsOVqCffS5OomIAhkp+N7 QH6DmW39R1XeHzKOM/qLRkyyR2cn6eWmJ5CT2QGbYbYOexFO/dpHq6G1Q2QSmnLiybqJ bkF+2BLfmseZRZkCNku2GBAS4i++pVzIMyHh5c0GCrPN/QaCkBjPxhcAWMYjtv6niL6Z npDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tfyizqw0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id o62-20020a634141000000b005c18d508531si4486944pga.212.2023.12.10.05.39.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Dec 2023 05:39:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tfyizqw0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 344CD8078676; Sun, 10 Dec 2023 05:39:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231755AbjLJNjQ (ORCPT <rfc822;rua109.linux@gmail.com> + 99 others); Sun, 10 Dec 2023 08:39:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231778AbjLJNjN (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 10 Dec 2023 08:39:13 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6C28E3 for <linux-kernel@vger.kernel.org>; Sun, 10 Dec 2023 05:39:19 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-55114c073b8so385399a12.1 for <linux-kernel@vger.kernel.org>; Sun, 10 Dec 2023 05:39:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702215558; x=1702820358; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=SxGHOiWgHxymjdsJtkFtmgKrK8IqfIoFz7FXA4eYB1c=; b=tfyizqw0F2/z2HfPu2743RC9QHe0G2gPYITGl+HQiF6fKUFod+hw7uMuUNdHfH+/b4 WfCKFLg0/mxOOTQPUrJCIB0+wlfH6cM3hlCShwlwFGkKrw12WxcBWpZq8BHc1fwlsbVj tYfHE5A/I1z8EDINkMMgtZX5HLESdmEbAwzsryhPLtysLrDt1cRp6XlzE/OYjEUTnQgE KLg7rnKH+1NULcQGEQwIEN6zv9vQKWCWlY8tjhKReltvTh46rDEheyGJONCWA/Cot+1h DuHQF1kjd2PoZSoeyW3IRNOnl+btpQZgNWy3PfAJ30ovL60y7IXmtpQW68Xgq4dGyt0r pPgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702215558; x=1702820358; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SxGHOiWgHxymjdsJtkFtmgKrK8IqfIoFz7FXA4eYB1c=; b=u1ZZNbozyOmHxH2P/ZMVWUBVMav9e+io+Sy9oYlNwgBZoELy1rZg/oBEMnk7mIMLa9 qZN/2g8D5s53POPrfe1B2VaEtVM8ajm2n7iqBJrzpBsOHMQnQ+ELVNngSmuPfR4KhUwI 8rnm2U10japPjREXD69spGDsrsgGdeADvq5HSJHwZ54r/2s6tS5ow3uXAvZJZrDNr3GJ mTsII34uCQKziOXkVvbszFGJfgvuzaec9J+HPwSo7UkjBDN+QZ9Fl/LFOC0OgOfUlGyI 3cr2IHtwY+cnXJYdP8nDtGDZpzYLFli3A/tq13M2F5joaG+/C5EoQthdM6P6sJNl0oWI n9zg== X-Gm-Message-State: AOJu0YwmY3EtxTPdLe1VkWXXZeGY//0/J7T8tjiBWDOXB5TYg+cK2aYb q/bwAClAjhICceh5thHSC0iacvFA//hIudZgvco= X-Received: by 2002:a17:907:a0c6:b0:a1a:57fd:3590 with SMTP id hw6-20020a170907a0c600b00a1a57fd3590mr1008153ejc.13.1702215558224; Sun, 10 Dec 2023 05:39:18 -0800 (PST) Received: from krzk-bin.. ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id sl9-20020a170906618900b00a1dee0289b4sm3404214ejc.169.2023.12.10.05.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Dec 2023 05:39:17 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Tomasz Figa <tomasz.figa@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Alim Akhtar <alim.akhtar@samsung.com>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, Jaewon Kim <jaewon02.kim@samsung.com>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles Date: Sun, 10 Dec 2023 14:39:15 +0100 Message-Id: <20231210133915.42112-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 10 Dec 2023 05:39:32 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784902398765030153 X-GMAIL-MSGID: 1784902398765030153 |
Series |
dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles
|
|
Commit Message
Krzysztof Kozlowski
Dec. 10, 2023, 1:39 p.m. UTC
ExynosAutov920 SoC wake-up pin controller has different register layout
than Exynos7, thus it should not be marked as compatible. Neither DTS
nor Linux driver was merged yet, so the change does not impact ABI.
Cc: Jaewon Kim <jaewon02.kim@samsung.com>
Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Fix for my for-next branch.
---
.../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On 23. 12. 10. 22:39, Krzysztof Kozlowski wrote: > ExynosAutov920 SoC wake-up pin controller has different register layout > than Exynos7, thus it should not be marked as compatible. Neither DTS > nor Linux driver was merged yet, so the change does not impact ABI. > > Cc: Jaewon Kim <jaewon02.kim@samsung.com> > Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > It is reasonable. I will also fix this in v4 patch. Reviewed-by:Jaewon Kim <jaewon02.kim@samsung.com> Thanks, Jaewon Kim
On 11/12/2023 03:18, Jaewon Kim wrote: > > On 23. 12. 10. 22:39, Krzysztof Kozlowski wrote: >> ExynosAutov920 SoC wake-up pin controller has different register layout >> than Exynos7, thus it should not be marked as compatible. Neither DTS >> nor Linux driver was merged yet, so the change does not impact ABI. >> >> Cc: Jaewon Kim <jaewon02.kim@samsung.com> >> Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers") >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> > > It is reasonable. > > I will also fix this in v4 patch. > > > Reviewed-by:Jaewon Kim <jaewon02.kim@samsung.com> This is based on your patchset, because autov920 is not compatible there with the others. Best regards, Krzysztof
On 11/12/2023 03:18, Jaewon Kim wrote: > > On 23. 12. 10. 22:39, Krzysztof Kozlowski wrote: >> ExynosAutov920 SoC wake-up pin controller has different register layout >> than Exynos7, thus it should not be marked as compatible. Neither DTS >> nor Linux driver was merged yet, so the change does not impact ABI. >> >> Cc: Jaewon Kim <jaewon02.kim@samsung.com> >> Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers") >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> > > It is reasonable. > > I will also fix this in v4 patch. > > > Reviewed-by:Jaewon Kim <jaewon02.kim@samsung.com> Please send correct tags so I won't need to manually fix them. Otherwise they get ignored by b4. Best regards, Krzysztof
On Sun, 10 Dec 2023 14:39:15 +0100, Krzysztof Kozlowski wrote: > ExynosAutov920 SoC wake-up pin controller has different register layout > than Exynos7, thus it should not be marked as compatible. Neither DTS > nor Linux driver was merged yet, so the change does not impact ABI. > > Applied, thanks! [1/1] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles https://git.kernel.org/pinctrl/samsung/c/e1564d6f93496bcea3a6b2110eb54cc08f2aca72 Best regards,
On 23. 12. 11. 16:34, Krzysztof Kozlowski wrote: > On 11/12/2023 03:18, Jaewon Kim wrote: >> On 23. 12. 10. 22:39, Krzysztof Kozlowski wrote: >>> ExynosAutov920 SoC wake-up pin controller has different register layout >>> than Exynos7, thus it should not be marked as compatible. Neither DTS >>> nor Linux driver was merged yet, so the change does not impact ABI. >>> >>> Cc: Jaewon Kim <jaewon02.kim@samsung.com> >>> Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers") >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> >> It is reasonable. >> >> I will also fix this in v4 patch. >> >> >> Reviewed-by:Jaewon Kim <jaewon02.kim@samsung.com> > Please send correct tags so I won't need to manually fix them. Otherwise > they get ignored by b4. Thanks Krzysztof I miss space. I will check it again next time. > > Best regards, > Krzysztof > > > Thanks Jaewon Kim
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Sunday, December 10, 2023 7:09 PM > To: Tomasz Figa <tomasz.figa@gmail.com>; Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org>; Sylwester Nawrocki > <s.nawrocki@samsung.com>; Alim Akhtar <alim.akhtar@samsung.com>; > Linus Walleij <linus.walleij@linaro.org>; Rob Herring <robh+dt@kernel.org>; > Conor Dooley <conor+dt@kernel.org>; Jaewon Kim > <jaewon02.kim@samsung.com>; linux-arm-kernel@lists.infradead.org; > linux-samsung-soc@vger.kernel.org; linux-gpio@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920 > wake-up compatibles > > ExynosAutov920 SoC wake-up pin controller has different register layout > than Exynos7, thus it should not be marked as compatible. Neither DTS nor > Linux driver was merged yet, so the change does not impact ABI. > > Cc: Jaewon Kim <jaewon02.kim@samsung.com> > Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for > newer wake-up controllers") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > . . . -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml index 2bafa867aea2..f64da7f58faa 100644 --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml @@ -36,6 +36,7 @@ properties: - samsung,s5pv210-wakeup-eint - samsung,exynos4210-wakeup-eint - samsung,exynos7-wakeup-eint + - samsung,exynosautov920-wakeup-eint - items: - enum: - samsung,exynos5433-wakeup-eint @@ -45,7 +46,6 @@ properties: - items: - enum: - samsung,exynosautov9-wakeup-eint - - samsung,exynosautov920-wakeup-eint - const: samsung,exynos850-wakeup-eint - const: samsung,exynos7-wakeup-eint @@ -112,6 +112,7 @@ allOf: contains: enum: - samsung,exynos850-wakeup-eint + - samsung,exynosautov920-wakeup-eint then: properties: interrupts: false