Message ID | 20231208091355.1417292-3-sherry.sun@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5335015vqy; Fri, 8 Dec 2023 01:14:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IHtPfzUlbtXQeXXscpF6nQy1AGYI4VpiziiH/PTny32zxiPogHBRp96H7eSHKzjJ/l+av+w X-Received: by 2002:a05:6358:640b:b0:170:50f4:447a with SMTP id f11-20020a056358640b00b0017050f4447amr4605629rwh.48.1702026885440; Fri, 08 Dec 2023 01:14:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702026885; cv=pass; d=google.com; s=arc-20160816; b=KOkeNvmWcgrNJq0riHKOGy5z+ME/bwzjc3epDp3vIPQdVO1Hv02J+UnzC7fc9pn9Gw YsHFEjo2gceYy2boH4PWQUZvYbsQ0JHMMAZLFbAEex9HzyyvuH3gskP5LgalECzz+XYN 8oPT92WmEN0jMAIXV/FSmPnyZQ6WK8F5tXTjQP9oEq9ZVC2yGdzK5BneFtmXRxYuqP3i OJnqxU0bNfhsIFEAtWfKwHPZGLJ3MRKDpHYWYJadodMF0JO92TbBriuU3w4qYg82yGG8 xQ9xWr92UULzAJClMN074lGBY7nuprK8SP/9341lBbGplYLzoYmlaSgSf6CUMDjigygw tn6Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PvhYMbdHsfjbcSdTf0vVjjCWEz5ru10GC5wL8RXiYE4=; fh=l1iWo58bMGw3cZiqltecNTFFfZhXvAIg92WGskXbVMI=; b=SysxIipAQhWSusoTi8UxHbKq26hvt9ZMjpdXnmEYOMClFYvgYoRdZq8d8eI6rXNJUN 9DzKNBaR+QCS8NkaftYtuCtLoDtIXOz1iDf+kncIOiBeKk0rnP0XnLsSxJbjBZTQGxyh w9bmcbbttJUKC3fq3miCy6vxhBAOwv1gDJEIdY9cY7bOJ9QSsjK7wzCzFcEEwfnPVIhq ZYpSbYlNuZhIgbCOsIdp+PhF1LDRt4sUjrkuyGJPXFYiJptNBSl19KIZTmvC7LacwcLA kYSuj0dZVEtt29QI7dnyPMLHJwmvkKzAwqM/h0ZAoa6s22fQloNAm7OWSTLIrsSqGmcB dlwg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=q5PFFkIf; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id fi29-20020a056a00399d00b006bf531dd685si1266433pfb.64.2023.12.08.01.14.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 01:14:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=q5PFFkIf; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 310AA8080D67; Fri, 8 Dec 2023 01:14:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235827AbjLHJO3 (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Fri, 8 Dec 2023 04:14:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231863AbjLHJOX (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 8 Dec 2023 04:14:23 -0500 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2087.outbound.protection.outlook.com [40.107.8.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C18F6172E; Fri, 8 Dec 2023 01:14:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NjmVfdl93EzKm2/X2YVcm0gwWTchtrcdrAxB/pBUzzENJJCUqdPBZhGZPfu94FvH3rHhEVz1L+BD8VDqdyajq5xHBR0kAItdyswTelqK02homOL7iE7hBylkJQjlyLRKg2cz0uVVf05gijJ3C5+X17Xc1OYBDsYDRBye+zu0NtcPKHTV3aQmAVCv+patDkHczpN3IzxzR5BRZQ4vF90Hrm0nED5wnDU63rAcuZnI9s7gBT1nc3ti0wqVCox3Xei5Ar/b6LCmvb+C1YrsxRKe6Bo+X2r1UgVlFMmMQgBmxJvdcRKmZ+qwKrEJ7NE+OhxBdmrlYoC26uErVqzrK5rMvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PvhYMbdHsfjbcSdTf0vVjjCWEz5ru10GC5wL8RXiYE4=; b=D9HYthtlPTep/jLUGJClaGtg9G5tLrDAeXdANTf8YPXC27u6NnK4LXB8/m6TR2/jkOaCwr6dVS3MM/k8U9a18ybtPyXJdSk5j7KxSBjdite3pDs2amKP8J19dHnxEEJt13q2rztf+ydBOcNmFUkgXmtm6LDhfa1SRVNEwqjp+nsf4daDV/3YU8GQetbYQw44XLkR6KqvGY67wgjGRJkp786vi1gHmF398Z+QMdBsDtpgpgAdoFDnlVcwhGOBBodOx2p7NerLSUOVytEmKQdJH+cBQMAD48GtZ7P34g6g+Cd+GMuXL1llibb5Rfoox8cTK9EoUa3GbVrLKTL1YfwSfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PvhYMbdHsfjbcSdTf0vVjjCWEz5ru10GC5wL8RXiYE4=; b=q5PFFkIfbJb030mDDYDSgtCT0hlbKzGTCE8W196KlGZ2TiuAURkklp73uGChML/NDVnTAO8AdBN7NeCVLXpqwwj7fOsUCMSjN9AN+JnDuAe6Qv+i32puzBYcTGGvlx+umK1nnKCAViE4lpRgagS6yYAF2eDvlwQ/bGuilBtcZmg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) by DU2PR04MB8646.eurprd04.prod.outlook.com (2603:10a6:10:2dd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.27; Fri, 8 Dec 2023 09:14:26 +0000 Received: from AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::3627:208e:4d62:1e2a]) by AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::3627:208e:4d62:1e2a%6]) with mapi id 15.20.7068.028; Fri, 8 Dec 2023 09:14:26 +0000 From: Sherry Sun <sherry.sun@nxp.com> To: hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com Cc: linux-imx@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] dt-bindings: imx6q-pcie: Add host-wake-gpio property Date: Fri, 8 Dec 2023 17:13:53 +0800 Message-Id: <20231208091355.1417292-3-sherry.sun@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231208091355.1417292-1-sherry.sun@nxp.com> References: <20231208091355.1417292-1-sherry.sun@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI2PR06CA0006.apcprd06.prod.outlook.com (2603:1096:4:186::19) To AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8404:EE_|DU2PR04MB8646:EE_ X-MS-Office365-Filtering-Correlation-Id: af42ab9a-ce2e-42f4-6df0-08dbf7ce131f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: khFxdF1IaUxcVz+1nnpC5f7QvLyWXGvTTG/PNQZeM2HTmglDxEzo5xGwZAOIGTnUSJg4S7KfbPAExCqo1BRe63G9EVrB7B20X/Yec1FLJjbGH/tz2o09JeVAyFNUhNEWVGuiPfBYy5lj4qHPRmE2zwPNQrAK7F1G5XGbzyelXQ0pTN+O3yPaUZiQV+JNOZNmbwQ9GavorAQWKKYf3MeWVNNmB3LqHy2pZanqejYqHuACWnh1i5orWfzm4HJvbG13m9wJpkvLWUAlVibj75C1GfAREG19OpQ9GL8HSAKDJT2G9S92/RFa2heo63lrJJPak87CnmV7G7lcp/nXCLjDk6rJfyo9Wq4vAJOQ3+nWcv+8jJxRN6wPDVlmr6krqdDx/1YU2e6nMLdLMWPqSAyq5iIZgNNEHfiTaafeQ74zO3FWNIg7XeRmJBA5RYZ5E/Wg+cT4yKocOA4d2WoZSRQYuV35M5KxksXdeqKFu8DrM/W+g8rLRZYqpVaCgJTkPcmKqxkngpnFxfbtpXB7SnC/ipbwpSgFa2DYZ5myQPObU4orXyJd8jvcLVcxksobrie5QR5fMJdfDGCU2b7/9wCv+gPw9hXamc6RZ/Ru1QtoiVwibkWhmrqbRU5ySMmEKInMJmze7e7SV8Nz2tQrqucjqXn+Ot9kvZHrSLMT+0qxmsI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8404.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(366004)(396003)(376002)(346002)(136003)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(38350700005)(921008)(41300700001)(36756003)(5660300002)(4744005)(7416002)(44832011)(86362001)(2906002)(478600001)(6512007)(6506007)(52116002)(6486002)(6666004)(26005)(1076003)(38100700002)(2616005)(8936002)(4326008)(8676002)(66556008)(66476007)(66946007)(316002)(32563001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: iN/g8kFpxQZ8QXlXJHua7YxkLVCEPRdIr7nx8xXQm+UYHI4IDPTp5m3Wr3IPgTbI0LPj5inUxbPXFFFPC53cxo31rnqgG1ApJFq6ReP5KPhIFEjngRO/Un+ZBxSNlnsEjfAWdcAZVcpMaYjjmejBuR41V6RH9GJg68coSEH+u+KugfqV3KPkTVMFb7RYUoelPRChQ0BcQUJBLJaDsbH5Rq1ytjn49hf5IXEuIGhINHubi4KNYhvdngPNwYX2iUNPbT06rccyQXhVc+heXsII3XBAbdX7PVVAeZ62lprwfnK0LtzS/UjuT/kkzcCZqu8JYY+eRWbmKbpY0Bp/8gD/dcuRy8FDusN1QZC7ESblcfBSzwGrlfOoRjc1FZV0vfrpLAtoQlDiC6LUKXIOsQb/VUTCcG1CrZDqW7pmTqmx29/Vcj2ydMAYUz1m0y4de99y0e2jB5H6DpXJrL9EGC82oR+0VvevBoxBgGHQqqARsQU/8nQWrMJIfnH66xNjNhhDgMi6CWPlkNaGTsfCMGFB9EXvvlNmhDMWpr3ji8M8imKcH0Fi2KKqvLLQr725TA7N/+dQQRm24eM9yjyHKACHoQubSh46tnkQUNlNtk+CUeEtQ1Twb5qxVIUDKxYti8Nx47Sz2dtLjJDV8Nyf5/VzDqla1osgy1KMBPsasLxJQxn2RUyYJz1jPtfKaJ82gHVimI+qMztI8mUPOVIUxZ1BPRYZRay1cGAiisrnCUYln2RKbyuEHv8I6JpjTgwOD6suZz/2emfH9WXCXM4va872h5nJGjJQca5Os2dBiOe+vAMz3IyyAUyRYNTHK4cZxXu8WvK37alDYtpVjkcp/Q/iqTlRLBlNpAIQaYvIiWKGZFX0LT8JPWvPjXD4E4Rrrw0mAGWdzXSSyZVIX1HhdhBsigQWKudq1ku6dDPO3ytBBcQgheCIFGE0DBdqC3+al18khqmaM5vReSK70k3ZN35XQOh05lZOJvJozB6ZFdbkrDTfOUWHDaNPzP5AMMRdlVgFfE9hBKfAjkzmmaBT7sVKQ+NPIchjJHOYtI+pTJw39TCzK+yn/svrKm4ZwklDxS6+X6fz13H8TbaXdISPuG5YWTL+z7cKw5deTFOG1VUEn4SwRNMlfVyVO6zQiOUJURGYwO2+TasJ2L0JmkwTehYWkyPP9pvE+ct64u5wWxQguLkrN/u0/klZy9tMXbN5n9tH2rS963EPXf7pbABZCqd/RXg/ZHx7lRLfRsSEkyD+JW0UDBZrJOiWoesgJd2FyyFsngQsPlWUIk5O6unBoLJ59QSF0Sex3yIkjuWxLfmbiekVyYS6ZpfM4QealGsh3XqNQsKONDbiplQqbkKjiM8MqfxShWpeW3plQ3trs4b4MCk8o4C5KO4j2zWVcQSoKWKGC3xDuT9ZxVk1jYpV/qX4JnHZmcRMc7thdkXjzAnFeuI43PiZt6SlVEFFHDJgjWI3i0FezwPzVYCVvfMDLAcwEfaQKU488dnU6M0guiYRv5l4l4BP3JQtaCwoNMBQiYfoVl79qrknneQBZsivId4+FYEctjWQeMiDSgSHBNkgn+Y8v6+b47r0TguVzGSjKn+q X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: af42ab9a-ce2e-42f4-6df0-08dbf7ce131f X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 09:14:26.2137 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 68A/KkcauGMc36BJgbOhoOwJZJrRtliBSE7DsMhVDERo2jjZAX6iYmmEeCUnl3/O2t3Y9eWKfi0NyT6/wEsiPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8646 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 08 Dec 2023 01:14:43 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784704543581001731 X-GMAIL-MSGID: 1784704543581001731 |
Series |
PCI: imx6: Add pci host wakeup support
|
|
Commit Message
Sherry Sun
Dec. 8, 2023, 9:13 a.m. UTC
Add host-wake-gpio property that can be used to wakeup the host processor. Signed-off-by: Sherry Sun <sherry.sun@nxp.com> Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com> --- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 4 ++++ 1 file changed, 4 insertions(+)
Comments
Hi Sherry, Am Freitag, dem 08.12.2023 um 17:13 +0800 schrieb Sherry Sun: > Add host-wake-gpio property that can be used to wakeup the host > processor. > > Signed-off-by: Sherry Sun <sherry.sun@nxp.com> > Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com> > --- > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > index 81bbb8728f0f..944f0f961809 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > @@ -72,6 +72,10 @@ properties: > L=operation state) (optional required). > type: boolean > > + host-wake-gpio: There is only one wake signal in PCIe and it has a defined direction, so there is no point in specifying that it is a host wakeup. Also GPIO handles without a traling 's' are deprecated. So this should be wake-gpios > + description: Should specify the GPIO for controlling the PCI bus device > + wake signal, used to wakeup the host processor. Default to active-low. The description is wrong. For the RC complex case (which is the binding you are modifying here) the controller does not control the wake signal, but instead uses it as a input. The description should reflect that. The default is also quite useless, as your implementation does not allow to change it. Please translate the GPIO active flags from the DT to the proper IRQ flags and drop this default here. The DT should simply carry the proper polarity. Regards, Lucas > + > required: > - compatible > - reg
On Fri, Dec 08, 2023 at 11:00:19AM +0100, Lucas Stach wrote: > Hi Sherry, > > Am Freitag, dem 08.12.2023 um 17:13 +0800 schrieb Sherry Sun: > > Add host-wake-gpio property that can be used to wakeup the host > > processor. > > > > Signed-off-by: Sherry Sun <sherry.sun@nxp.com> > > Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com> > > --- > > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > index 81bbb8728f0f..944f0f961809 100644 > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > @@ -72,6 +72,10 @@ properties: > > L=operation state) (optional required). > > type: boolean > > > > + host-wake-gpio: > > There is only one wake signal in PCIe and it has a defined direction, > so there is no point in specifying that it is a host wakeup. Also GPIO > handles without a traling 's' are deprecated. So this should be > > wake-gpios Any standard PCI slot signals need to be documented in common PCI schema. And they should start going into root port nodes rather than the host bridge node because it's the root ports that correspond to slots rather than the host bridge. We've just taken shortcuts because many host bridges only have 1 root port. Note that I'm in the middle of splitting pci-bus.yaml into host bridge, PCI-PCI bridge (and RP), and common device schemas. Rob
On Fri, Dec 08, 2023 at 02:55:45PM -0600, Rob Herring wrote: > ... > And they should start going into root port nodes rather than the > host bridge node because it's the root ports that correspond to slots > rather than the host bridge. We've just taken shortcuts because many > host bridges only have 1 root port. > > Note that I'm in the middle of splitting pci-bus.yaml into host bridge, > PCI-PCI bridge (and RP), and common device schemas. Hooray! Thanks for working on that; the conflation of host bridge and Root Port is a real annoyance. Bjorn
> -----Original Message----- > From: Lucas Stach <l.stach@pengutronix.de> > Sent: 2023年12月8日 18:00 > To: Sherry Sun <sherry.sun@nxp.com>; Hongxing Zhu > <hongxing.zhu@nxp.com>; lpieralisi@kernel.org; kw@linux.com; > robh@kernel.org; bhelgaas@google.com; krzysztof.kozlowski+dt@linaro.org; > conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > kernel@pengutronix.de; festevam@gmail.com > Cc: dl-linux-imx <linux-imx@nxp.com>; linux-pci@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH 2/4] dt-bindings: imx6q-pcie: Add host-wake-gpio > property > > Hi Sherry, > > Am Freitag, dem 08.12.2023 um 17:13 +0800 schrieb Sherry Sun: > > Add host-wake-gpio property that can be used to wakeup the host > > processor. > > > > Signed-off-by: Sherry Sun <sherry.sun@nxp.com> > > Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com> > > --- > > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > index 81bbb8728f0f..944f0f961809 100644 > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > @@ -72,6 +72,10 @@ properties: > > L=operation state) (optional required). > > type: boolean > > > > + host-wake-gpio: > > There is only one wake signal in PCIe and it has a defined direction, so there > is no point in specifying that it is a host wakeup. Also GPIO handles without a > traling 's' are deprecated. So this should be > > wake-gpios Hi Lucas, thanks for the comment, will change it in V2. > > > + description: Should specify the GPIO for controlling the PCI bus device > > + wake signal, used to wakeup the host processor. Default to active-low. > > The description is wrong. For the RC complex case (which is the binding you > are modifying here) the controller does not control the wake signal, but > instead uses it as a input. The description should reflect that. > > The default is also quite useless, as your implementation does not allow to > change it. Please translate the GPIO active flags from the DT to the proper > IRQ flags and drop this default here. The DT should simply carry the proper > polarity. > Will improve the description in V2, thanks. Best Regards Sherry
> -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: 2023年12月9日 4:56 > To: Lucas Stach <l.stach@pengutronix.de> > Cc: Sherry Sun <sherry.sun@nxp.com>; Hongxing Zhu > <hongxing.zhu@nxp.com>; lpieralisi@kernel.org; kw@linux.com; > bhelgaas@google.com; krzysztof.kozlowski+dt@linaro.org; > conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux- > imx@nxp.com>; linux-pci@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH 2/4] dt-bindings: imx6q-pcie: Add host-wake-gpio > property > > On Fri, Dec 08, 2023 at 11:00:19AM +0100, Lucas Stach wrote: > > Hi Sherry, > > > > Am Freitag, dem 08.12.2023 um 17:13 +0800 schrieb Sherry Sun: > > > Add host-wake-gpio property that can be used to wakeup the host > > > processor. > > > > > > Signed-off-by: Sherry Sun <sherry.sun@nxp.com> > > > Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com> > > > --- > > > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > index 81bbb8728f0f..944f0f961809 100644 > > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > @@ -72,6 +72,10 @@ properties: > > > L=operation state) (optional required). > > > type: boolean > > > > > > + host-wake-gpio: > > > > There is only one wake signal in PCIe and it has a defined direction, > > so there is no point in specifying that it is a host wakeup. Also GPIO > > handles without a traling 's' are deprecated. So this should be > > > > wake-gpios > > Any standard PCI slot signals need to be documented in common PCI schema. > And they should start going into root port nodes rather than the host bridge > node because it's the root ports that correspond to slots rather than the host > bridge. We've just taken shortcuts because many host bridges only have 1 > root port. > > Note that I'm in the middle of splitting pci-bus.yaml into host bridge, PCI-PCI > bridge (and RP), and common device schemas. > Hi Rob, thanks for your comment, I am new to PCIe, can you please provide more details on which common PCI schema the WAKE# property should be added in (maybe snps,dw-pcie.yaml or something else)? Best Regards Sherry
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index 81bbb8728f0f..944f0f961809 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml @@ -72,6 +72,10 @@ properties: L=operation state) (optional required). type: boolean + host-wake-gpio: + description: Should specify the GPIO for controlling the PCI bus device + wake signal, used to wakeup the host processor. Default to active-low. + required: - compatible - reg