diff mbox series

[v2] libcpp: Avoid remapping filenames within directives

Message ID 20221102104713.643862-1-richard.purdie@linuxfoundation.org
State Accepted
Headers
Series [v2] libcpp: Avoid remapping filenames within directives |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Richard Purdie Nov. 2, 2022, 10:47 a.m. UTC 
  Code such as:

 #include __FILE__

can interact poorly with the *-prefix-map options when cross compiling. In
general you're after to remap filenames for use in target context but the
local paths should be used to find include files at compile time. Ingoring
filename remapping for directives allows avoiding such failures.

Fix this to improve such usage and then document this against file-prefix-map
(referenced by the other *-prefix-map options) to make the behaviour clear
and defined.

libcpp/ChangeLog:

    * macro.cc (_cpp_builtin_macro_text): Don't remap filenames within directives

gcc/ChangeLog:

    * doc/invoke.texi: Document prefix-maps don't affect directives

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 gcc/doc/invoke.texi | 3 ++-
 libcpp/macro.cc     | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Jeff Law Nov. 18, 2022, 8:14 p.m. UTC | #1 
On 11/2/22 04:47, Richard Purdie via Gcc-patches wrote:
> Code such as:
>
>   #include __FILE__
>
> can interact poorly with the *-prefix-map options when cross compiling. In
> general you're after to remap filenames for use in target context but the
> local paths should be used to find include files at compile time. Ingoring
> filename remapping for directives allows avoiding such failures.
>
> Fix this to improve such usage and then document this against file-prefix-map
> (referenced by the other *-prefix-map options) to make the behaviour clear
> and defined.
>
> libcpp/ChangeLog:
>
>      * macro.cc (_cpp_builtin_macro_text): Don't remap filenames within directives
>
> gcc/ChangeLog:
>
>      * doc/invoke.texi: Document prefix-maps don't affect directives

THanks.  Installed.  Sorry about the wait.

jeff
diff mbox series

Patch

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index c6323a53ad2..9d5dd3e20b7 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -2213,7 +2213,8 @@  any references to them in the result of the compilation as if the
 files resided in directory @file{@var{new}} instead.  Specifying this
 option is equivalent to specifying all the individual
 @option{-f*-prefix-map} options.  This can be used to make reproducible
-builds that are location independent.  See also
+builds that are location independent.  Directories referenced by
+directives are not affected by these options. See also
 @option{-fmacro-prefix-map}, @option{-fdebug-prefix-map} and
 @option{-fprofile-prefix-map}.
 
diff --git a/libcpp/macro.cc b/libcpp/macro.cc
index 8ebf360c03c..7d5a0d0fd2e 100644
--- a/libcpp/macro.cc
+++ b/libcpp/macro.cc
@@ -563,7 +563,7 @@  _cpp_builtin_macro_text (cpp_reader *pfile, cpp_hashnode *node,
 	    if (!name)
 	      abort ();
 	  }
-	if (pfile->cb.remap_filename)
+	if (pfile->cb.remap_filename && !pfile->state.in_directive)
 	  name = pfile->cb.remap_filename (name);
 	len = strlen (name);
 	buf = _cpp_unaligned_alloc (pfile, len * 2 + 3);