Message ID | 20231207074022.14116-1-stanley_chang@realtek.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp4613072vqy; Wed, 6 Dec 2023 23:41:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IGl3aShbCZvmG31/c2imMtBoO7+LIJ+tDoOr7rL3qfmyMrnNrggNmCHBk6+lccsAJ+pDXBB X-Received: by 2002:a05:6808:1150:b0:3b8:b063:893f with SMTP id u16-20020a056808115000b003b8b063893fmr2245832oiu.77.1701934908227; Wed, 06 Dec 2023 23:41:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701934908; cv=none; d=google.com; s=arc-20160816; b=OxiYnWW6SrmvmUtGd2dmm9hSd4wNdiSRLAU/EO0L+olrA6APQoKwMn5+qjGKDSOaKf ZyEpOSck1goVGFhaflyI5KL3qVdJ5LFpDi1eHUY4X2v1+cajeVzQeB9wCX3pZg4INucq 85Qc11C/CU2PQMYbi1VmiFm+WZm4plnIoduDhRKbJOoqnCmwJYoJN/6s2vulpw/PHjCE 6+plYGd/CFvJguUzJ3BfVCp7OTufxPCMCDvgEZxkyciDRbwvq6jG7bkdUbe+y4aH5hlj ORMC6sBEvqa+JbIZShTLeJsJV5LuxSz68puYZaQtxFNq9X5nDjOU3BqjizpZgyIhAzPz NquQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=INGSaGbddqxMsRjAsGT+95ooVtRCP/qfUJTNkThEnEc=; fh=TnBftcBBYXJV91/imYvc9j9VPtUHPAYYr+v4GBy2m2I=; b=NEk3diCiJEl8zvvWAmFPQB6A4GZlhayHAkU35rHFsRSlxdJxzVQIqhufJafl1BRPqI ZIChOvd+RpN4CeW9elL1F/CvG+hg64ATnocHO4JOrVl3mx0J68gLMyh/4kDg5/expMYs tETDvAOxLAP+t2aYAZhxR8KzAFfm0XaFrm1iPuRsLGPw9qofD+vMbksy78uq0qqwP/yg N/H08y7GH0jl7YR0BL4xfKoMC/vaNVd0GLwdTumvO7AYz8/oEKoD1HcbMIOlQiuMdmij lV0k0bjZHZV9Lrc9kIYIwMYrOKpY1EQ/UpcLmhR5C9e/q8JPm0SM7N7csG++yhhRZgRP 0img== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id cb8-20020a056a02070800b0057755b2f032si758875pgb.542.2023.12.06.23.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 23:41:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 9CBCA80DF980; Wed, 6 Dec 2023 23:41:45 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377921AbjLGHl3 (ORCPT <rfc822;pusanteemu@gmail.com> + 99 others); Thu, 7 Dec 2023 02:41:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbjLGHl2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 7 Dec 2023 02:41:28 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F144137; Wed, 6 Dec 2023 23:41:34 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3B77eMLW1005290, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3B77eMLW1005290 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Dec 2023 15:40:22 +0800 Received: from RTEXDAG01.realtek.com.tw (172.21.6.100) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Thu, 7 Dec 2023 15:40:23 +0800 Received: from RTEXH36506.realtek.com.tw (172.21.6.27) by RTEXDAG01.realtek.com.tw (172.21.6.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Thu, 7 Dec 2023 15:40:22 +0800 Received: from localhost.localdomain (172.21.252.101) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server id 15.1.2507.17 via Frontend Transport; Thu, 7 Dec 2023 15:40:22 +0800 From: Stanley Chang <stanley_chang@realtek.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> CC: Stanley Chang <stanley_chang@realtek.com>, Vinod Koul <vkoul@kernel.org>, Johan Hovold <johan@kernel.org>, Kishon Vijay Abraham I <kishon@kernel.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Jinjie Ruan <ruanjinjie@huawei.com>, Rob Herring <robh@kernel.org>, Alan Stern <stern@rowland.harvard.edu>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Flavio Suligoi <f.suligoi@asem.it>, =?utf-8?q?Ricardo_Ca=C3=B1uelo?= <ricardo.canuelo@collabora.com>, <linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>, <linux-usb@vger.kernel.org> Subject: [PATCH v3 RESEND 1/4] phy: core: add notify_connect and notify_disconnect callback Date: Thu, 7 Dec 2023 15:38:04 +0800 Message-ID: <20231207074022.14116-1-stanley_chang@realtek.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-KSE-ServerInfo: RTEXDAG01.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 06 Dec 2023 23:41:45 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784608098123725065 X-GMAIL-MSGID: 1784608098123725065 |
Series |
[v3,RESEND,1/4] phy: core: add notify_connect and notify_disconnect callback
|
|
Commit Message
Stanley Chang[昌育德]
Dec. 7, 2023, 7:38 a.m. UTC
In Realtek SoC, the parameter of usb phy is designed to can dynamic
tuning base on port status. Therefore, add a notify callback of phy
driver when usb connection/disconnection change.
Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
---
RESEND:
Because there is no extcon device provided in the USB framework to
notify connect and disconnect.
Therefore, I added the notification connection/disconnection based
on the generic phy. So I no use the EXTCON framework for notifying
connect/disconnect.
v2 to v3:
No change
v1 to v2:
No change
---
drivers/phy/phy-core.c | 47 +++++++++++++++++++++++++++++++++++++++++
include/linux/phy/phy.h | 18 ++++++++++++++++
2 files changed, 65 insertions(+)
Comments
On 12/7/23 10:38 AM, Stanley Chang wrote: > In Realtek SoC, the parameter of usb phy is designed to can dynamic > tuning base on port status. Therefore, add a notify callback of phy To be able to do dynamic tuning based in the port status, maybe? > driver when usb connection/disconnection change. > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com> [...] > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > index 96a0b1e111f3..a84ad4896b7f 100644 > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -489,6 +489,53 @@ int phy_calibrate(struct phy *phy) > } > EXPORT_SYMBOL_GPL(phy_calibrate); > > +/** > + * phy_notify_connect() - phy connect notify Notification? > + * @phy: the phy returned by phy_get() > + * @port: the port index for connect > + * > + * If phy need the get connection status, the callback can be used. If the PHY needs to get the connection status, maybe? > + * Returns: %0 if successful, a negative error code otherwise > + */ > +int phy_notify_connect(struct phy *phy, int port) > +{ > + int ret; > + > + if (!phy || !phy->ops->connect) > + return 0; > + > + mutex_lock(&phy->mutex); > + ret = phy->ops->connect(phy, port); > + mutex_unlock(&phy->mutex); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(phy_notify_connect); > + > +/** > + * phy_notify_disconnect() - phy disconnect notify Notification? > + * @phy: the phy returned by phy_get() > + * @port: the port index for disconnect > + * > + * If phy need the get disconnection status, the callback can be used. If the PHY needs to get the connection status, maybe? [...] > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index f6d607ef0e80..cf98cb29ddaa 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h [...] MBR, Sergey
Hi Sergei, > > > On 12/7/23 10:38 AM, Stanley Chang wrote: > > > In Realtek SoC, the parameter of usb phy is designed to can dynamic > > tuning base on port status. Therefore, add a notify callback of phy > > To be able to do dynamic tuning based in the port status, maybe? Okay, I will revise. > > driver when usb connection/disconnection change. > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com> > [...] > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index > > 96a0b1e111f3..a84ad4896b7f 100644 > > --- a/drivers/phy/phy-core.c > > +++ b/drivers/phy/phy-core.c > > @@ -489,6 +489,53 @@ int phy_calibrate(struct phy *phy) } > > EXPORT_SYMBOL_GPL(phy_calibrate); > > > > +/** > > + * phy_notify_connect() - phy connect notify > > Notification? Okay, I will revise. > > + * @phy: the phy returned by phy_get() > > + * @port: the port index for connect > > + * > > + * If phy need the get connection status, the callback can be used. > > If the PHY needs to get the connection status, maybe? > > > + * Returns: %0 if successful, a negative error code otherwise */ int > > +phy_notify_connect(struct phy *phy, int port) { > > + int ret; > > + > > + if (!phy || !phy->ops->connect) > > + return 0; > > + > > + mutex_lock(&phy->mutex); > > + ret = phy->ops->connect(phy, port); > > + mutex_unlock(&phy->mutex); > > + > > + return ret; > > +} > > +EXPORT_SYMBOL_GPL(phy_notify_connect); > > + > > +/** > > + * phy_notify_disconnect() - phy disconnect notify > > Notification? Okay, I will revise. > > + * @phy: the phy returned by phy_get() > > + * @port: the port index for disconnect > > + * > > + * If phy need the get disconnection status, the callback can be used. > > If the PHY needs to get the connection status, maybe? Okay, I will revise. Thanks, Stanley
On Thu, Dec 07, 2023 at 03:38:04PM +0800, Stanley Chang wrote: > In Realtek SoC, the parameter of usb phy is designed to can dynamic > tuning base on port status. Therefore, add a notify callback of phy > driver when usb connection/disconnection change. > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com> > --- > RESEND: > Because there is no extcon device provided in the USB framework to > notify connect and disconnect. > Therefore, I added the notification connection/disconnection based > on the generic phy. So I no use the EXTCON framework for notifying > connect/disconnect. > v2 to v3: > No change > v1 to v2: > No change > --- > drivers/phy/phy-core.c | 47 +++++++++++++++++++++++++++++++++++++++++ > include/linux/phy/phy.h | 18 ++++++++++++++++ > 2 files changed, 65 insertions(+) > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > index 96a0b1e111f3..a84ad4896b7f 100644 > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -489,6 +489,53 @@ int phy_calibrate(struct phy *phy) > } > EXPORT_SYMBOL_GPL(phy_calibrate); > > +/** > + * phy_notify_connect() - phy connect notify > + * @phy: the phy returned by phy_get() > + * @port: the port index for connect > + * > + * If phy need the get connection status, the callback can be used. > + * Returns: %0 if successful, a negative error code otherwise > + */ > +int phy_notify_connect(struct phy *phy, int port) > +{ > + int ret; > + > + if (!phy || !phy->ops->connect) > + return 0; How can phy be null? And it is not successful if connect is not valid, so why not return an error there? > + > + mutex_lock(&phy->mutex); > + ret = phy->ops->connect(phy, port); > + mutex_unlock(&phy->mutex); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(phy_notify_connect); > + > +/** > + * phy_notify_disconnect() - phy disconnect notify > + * @phy: the phy returned by phy_get() > + * @port: the port index for disconnect > + * > + * If phy need the get disconnection status, the callback can be used. > + * > + * Returns: %0 if successful, a negative error code otherwise > + */ > +int phy_notify_disconnect(struct phy *phy, int port) > +{ > + int ret; > + > + if (!phy || !phy->ops->disconnect) > + return 0; Same as above. > + > + mutex_lock(&phy->mutex); > + ret = phy->ops->disconnect(phy, port); > + mutex_unlock(&phy->mutex); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(phy_notify_disconnect); > + > /** > * phy_configure() - Changes the phy parameters > * @phy: the phy returned by phy_get() > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index f6d607ef0e80..cf98cb29ddaa 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -122,6 +122,8 @@ struct phy_ops { > union phy_configure_opts *opts); > int (*reset)(struct phy *phy); > int (*calibrate)(struct phy *phy); > + int (*connect)(struct phy *phy, int port); > + int (*disconnect)(struct phy *phy, int port); You forgot to document these and would have a warning from the documentation build if this was applied :( > void (*release)(struct phy *phy); > struct module *owner; > }; > @@ -243,6 +245,8 @@ static inline enum phy_mode phy_get_mode(struct phy *phy) > } > int phy_reset(struct phy *phy); > int phy_calibrate(struct phy *phy); > +int phy_notify_connect(struct phy *phy, int port); > +int phy_notify_disconnect(struct phy *phy, int port); > static inline int phy_get_bus_width(struct phy *phy) > { > return phy->attrs.bus_width; > @@ -396,6 +400,20 @@ static inline int phy_calibrate(struct phy *phy) > return -ENOSYS; > } > > +static inline int phy_notify_connect(struct phy *phy, int index) > +{ > + if (!phy) > + return 0; Why check this? > + return -ENOSYS; > +} > + > +static inline int phy_notify_disconnect(struct phy *phy, int index) > +{ > + if (!phy) > + return 0; Again, why check this? thanks, greg k-h
Hi Greg, > > On Thu, Dec 07, 2023 at 03:38:04PM +0800, Stanley Chang wrote: > > In Realtek SoC, the parameter of usb phy is designed to can dynamic > > tuning base on port status. Therefore, add a notify callback of phy > > driver when usb connection/disconnection change. > > > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com> > > --- > > RESEND: > > Because there is no extcon device provided in the USB framework to > > notify connect and disconnect. > > Therefore, I added the notification connection/disconnection based > > on the generic phy. So I no use the EXTCON framework for notifying > > connect/disconnect. > > v2 to v3: > > No change > > v1 to v2: > > No change > > --- > > drivers/phy/phy-core.c | 47 > > +++++++++++++++++++++++++++++++++++++++++ > > include/linux/phy/phy.h | 18 ++++++++++++++++ > > 2 files changed, 65 insertions(+) > > > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index > > 96a0b1e111f3..a84ad4896b7f 100644 > > --- a/drivers/phy/phy-core.c > > +++ b/drivers/phy/phy-core.c > > @@ -489,6 +489,53 @@ int phy_calibrate(struct phy *phy) } > > EXPORT_SYMBOL_GPL(phy_calibrate); > > > > +/** > > + * phy_notify_connect() - phy connect notify > > + * @phy: the phy returned by phy_get() > > + * @port: the port index for connect > > + * > > + * If phy need the get connection status, the callback can be used. > > + * Returns: %0 if successful, a negative error code otherwise */ int > > +phy_notify_connect(struct phy *phy, int port) { > > + int ret; > > + > > + if (!phy || !phy->ops->connect) > > + return 0; > > How can phy be null? > > And it is not successful if connect is not valid, so why not return an error there? This is possible. If a caller no use the generic phy or no define the connect callback. And if no define connect callback, it will do nothing. So no any error. > > + > > + mutex_lock(&phy->mutex); > > + ret = phy->ops->connect(phy, port); > > + mutex_unlock(&phy->mutex); > > + > > + return ret; > > +} > > +EXPORT_SYMBOL_GPL(phy_notify_connect); > > + > > +/** > > + * phy_notify_disconnect() - phy disconnect notify > > + * @phy: the phy returned by phy_get() > > + * @port: the port index for disconnect > > + * > > + * If phy need the get disconnection status, the callback can be used. > > + * > > + * Returns: %0 if successful, a negative error code otherwise */ int > > +phy_notify_disconnect(struct phy *phy, int port) { > > + int ret; > > + > > + if (!phy || !phy->ops->disconnect) > > + return 0; > > Same as above. Same as connect callback. > > + > > + mutex_lock(&phy->mutex); > > + ret = phy->ops->disconnect(phy, port); > > + mutex_unlock(&phy->mutex); > > + > > + return ret; > > +} > > +EXPORT_SYMBOL_GPL(phy_notify_disconnect); > > + > > /** > > * phy_configure() - Changes the phy parameters > > * @phy: the phy returned by phy_get() diff --git > > a/include/linux/phy/phy.h b/include/linux/phy/phy.h index > > f6d607ef0e80..cf98cb29ddaa 100644 > > --- a/include/linux/phy/phy.h > > +++ b/include/linux/phy/phy.h > > @@ -122,6 +122,8 @@ struct phy_ops { > > union phy_configure_opts *opts); > > int (*reset)(struct phy *phy); > > int (*calibrate)(struct phy *phy); > > + int (*connect)(struct phy *phy, int port); > > + int (*disconnect)(struct phy *phy, int port); > > You forgot to document these and would have a warning from the > documentation build if this was applied :( > I will add a description. > > void (*release)(struct phy *phy); > > struct module *owner; > > }; > > @@ -243,6 +245,8 @@ static inline enum phy_mode phy_get_mode(struct > > phy *phy) } int phy_reset(struct phy *phy); int > > phy_calibrate(struct phy *phy); > > +int phy_notify_connect(struct phy *phy, int port); int > > +phy_notify_disconnect(struct phy *phy, int port); > > static inline int phy_get_bus_width(struct phy *phy) { > > return phy->attrs.bus_width; > > @@ -396,6 +400,20 @@ static inline int phy_calibrate(struct phy *phy) > > return -ENOSYS; > > } > > > > +static inline int phy_notify_connect(struct phy *phy, int index) { > > + if (!phy) > > + return 0; > > Why check this? It is normal for phy to be null. But if phy is not empty, -ENOSYS should be returned to indicate the error "Operation not supported". Other callbacks also follow this rule. > > + return -ENOSYS; > > +} > > + > > +static inline int phy_notify_disconnect(struct phy *phy, int index) { > > + if (!phy) > > + return 0; > > Again, why check this? As above. Thanks, Stanley
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index 96a0b1e111f3..a84ad4896b7f 100644 --- a/drivers/phy/phy-core.c +++ b/drivers/phy/phy-core.c @@ -489,6 +489,53 @@ int phy_calibrate(struct phy *phy) } EXPORT_SYMBOL_GPL(phy_calibrate); +/** + * phy_notify_connect() - phy connect notify + * @phy: the phy returned by phy_get() + * @port: the port index for connect + * + * If phy need the get connection status, the callback can be used. + * Returns: %0 if successful, a negative error code otherwise + */ +int phy_notify_connect(struct phy *phy, int port) +{ + int ret; + + if (!phy || !phy->ops->connect) + return 0; + + mutex_lock(&phy->mutex); + ret = phy->ops->connect(phy, port); + mutex_unlock(&phy->mutex); + + return ret; +} +EXPORT_SYMBOL_GPL(phy_notify_connect); + +/** + * phy_notify_disconnect() - phy disconnect notify + * @phy: the phy returned by phy_get() + * @port: the port index for disconnect + * + * If phy need the get disconnection status, the callback can be used. + * + * Returns: %0 if successful, a negative error code otherwise + */ +int phy_notify_disconnect(struct phy *phy, int port) +{ + int ret; + + if (!phy || !phy->ops->disconnect) + return 0; + + mutex_lock(&phy->mutex); + ret = phy->ops->disconnect(phy, port); + mutex_unlock(&phy->mutex); + + return ret; +} +EXPORT_SYMBOL_GPL(phy_notify_disconnect); + /** * phy_configure() - Changes the phy parameters * @phy: the phy returned by phy_get() diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h index f6d607ef0e80..cf98cb29ddaa 100644 --- a/include/linux/phy/phy.h +++ b/include/linux/phy/phy.h @@ -122,6 +122,8 @@ struct phy_ops { union phy_configure_opts *opts); int (*reset)(struct phy *phy); int (*calibrate)(struct phy *phy); + int (*connect)(struct phy *phy, int port); + int (*disconnect)(struct phy *phy, int port); void (*release)(struct phy *phy); struct module *owner; }; @@ -243,6 +245,8 @@ static inline enum phy_mode phy_get_mode(struct phy *phy) } int phy_reset(struct phy *phy); int phy_calibrate(struct phy *phy); +int phy_notify_connect(struct phy *phy, int port); +int phy_notify_disconnect(struct phy *phy, int port); static inline int phy_get_bus_width(struct phy *phy) { return phy->attrs.bus_width; @@ -396,6 +400,20 @@ static inline int phy_calibrate(struct phy *phy) return -ENOSYS; } +static inline int phy_notify_connect(struct phy *phy, int index) +{ + if (!phy) + return 0; + return -ENOSYS; +} + +static inline int phy_notify_disconnect(struct phy *phy, int index) +{ + if (!phy) + return 0; + return -ENOSYS; +} + static inline int phy_configure(struct phy *phy, union phy_configure_opts *opts) {