Message ID | 20231205092229.19135-3-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3307136vqy; Tue, 5 Dec 2023 01:22:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeWDIdJ8ER+Mi9sMlued7Wgh58cy4UlmNpKbTsV5mGhl9QSpMa3wOm1p1NVzIHXsgDFY0H X-Received: by 2002:a05:6a21:6818:b0:18f:97c:826d with SMTP id wr24-20020a056a21681800b0018f097c826dmr3578711pzb.119.1701768175272; Tue, 05 Dec 2023 01:22:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701768175; cv=none; d=google.com; s=arc-20160816; b=uaqCUNAVq9pYfYTg1AhgD2fKuDMIeANLWmLSqK8V8KpUmzcuoZjaSm9y+IFW7GI55P nEmj8PU3ZKmlxZWiJOE51P1qCY6tsqQc4hTKK17lKxRYSyL8VD95b/tPSzbW5qA/UNO9 zpWFMqFlQToHL/bxBjvb2l1uUz3StRzLKNNZQb3L33jCllT8h1zzDAH42i3FwWrlSVLW 6JL7YWklA132xvNX503R0uLXcbvOdFhPuYFIzErhwBaW26A0BHqVuBDtbmEtNsumGIap iCgzlWiOn8zrWeUxvYgm7dk8RAa4ubaye2Vpo24lmi69kG89CC0ffpgR9+y8AeSPu9Re 7IkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XqatM4kM7wKwmicGW+gEqjAkzatGSFvjDGMOBx55ZZQ=; fh=AilG5DwEGuLqGl78/1nxyk0W4Li6L5QGIzTBumtkZas=; b=itBHzZZtlION+FdfVgMIm3FMXGdI4iHeNbigm59LfRREn2iDap95moAw1T6n962DKK 0JJa4jr5tadJW9+35z66mBKcqbZNQFidexmUSwu+mzkK+Pc9MKbMVcrtYFPMu8US4/9C a+Vs221m+yfAa3bSx6+Dk/2WJ1sKtZhUuB9Z38Do0g9XaCr0Cl+/UxyEIltOSp+Tl2lK s+fyl3giifUtveeDsRBrjovUc5Tfjw1vqVM+4alv9s/asL+IiDKn8jSgJCLOp8Xvn80a uMmvJc2TydwUOQzfYXeIuDiLDPtc6R5zYe8b+y/e0jU4GiOheTswWyOSbhr/uqShVWIV ws4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g0HxNWHl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id r28-20020a635d1c000000b005bdbd1b52d4si9015406pgb.270.2023.12.05.01.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 01:22:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g0HxNWHl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 01235801C88D; Tue, 5 Dec 2023 01:22:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235027AbjLEJWl (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Tue, 5 Dec 2023 04:22:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229710AbjLEJWf (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 5 Dec 2023 04:22:35 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1018C189 for <linux-kernel@vger.kernel.org>; Tue, 5 Dec 2023 01:22:42 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3332ad5b3e3so3798539f8f.2 for <linux-kernel@vger.kernel.org>; Tue, 05 Dec 2023 01:22:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701768160; x=1702372960; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XqatM4kM7wKwmicGW+gEqjAkzatGSFvjDGMOBx55ZZQ=; b=g0HxNWHllGCPgVSvlHjmBBOVKuOhGsi3mnEC2ux9hWSPzA1cGSifernzpJz46lrinF YCAEPXnhEDFpJnfuLlXD/ErOCVViixO2Hya/f2NbReLz+L5nDoo0jywHTMdhSjFi9EV5 /ZLGrlW7c8i1YoG3mwQGayfp+0hiOrzzNNrEkoWWj3nerZBbZHWBdpw3oCCHdqbEh2ew XBL5B4ayRSzS1tP3Iz/D9dD/S2fZMOHLA9jTG71Z5y8gFtkzt1b4ytR7/d4DsST7vZ06 uQF/vERrbsP3BroOUr+1h9vjg7QT+iCdauZunoecXciLbQk2uuw1Xa6Lj4fNyd+QiqYy GxHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701768160; x=1702372960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XqatM4kM7wKwmicGW+gEqjAkzatGSFvjDGMOBx55ZZQ=; b=Qlq/BOiH9aeeNQid8Rb2fiLHki8xVuedl4LXnjFVvZrewhV+o3u/1HpuWDiRAyjHQo 4u5M0xeMbPZLVFYODDHYz9PEAwRtytgZU51w96HySVhZMFqbkOGeQsHcGMHEXnRwHTvv 28OSodpMbOh9PPFZ+dMVAV4NBxFHnTLOMsmJv4HBnMg+8Gtkvb6s1zgXVB6PV1kDwPCO 2G2Kkk3DQ5FN2bKxs+zU6/GgY2dpC+xBkPaJ6NEQ/zXAHVt73sv+j2bzRaFhsFFPHk8m yqveXVyrGLgsIwMlhau8FYrrFGa34nxy8yZt/19Xv9lIJafv2azcSQfVcZQaNIQ0FXYv uXdg== X-Gm-Message-State: AOJu0YxK1AJDagxj/LsbAEPvqwzt4wpiL882MG3sdJ1aAtehTMvLIA4O ZmUSjppTmMDxobHALpDgmd/hEQ== X-Received: by 2002:a05:600c:4508:b0:40b:47f0:66b5 with SMTP id t8-20020a05600c450800b0040b47f066b5mr294797wmo.26.1701768160649; Tue, 05 Dec 2023 01:22:40 -0800 (PST) Received: from krzk-bin.. ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id g10-20020a05600c4eca00b0040596352951sm21692287wmq.5.2023.12.05.01.22.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 01:22:40 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com>, Thierry Reding <thierry.reding@gmail.com>, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>, Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net>, linux-fsd@tesla.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 2/6] dt-bindings: pwm: samsung: add specific compatible for Tesla FSD Date: Tue, 5 Dec 2023 10:22:25 +0100 Message-Id: <20231205092229.19135-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231205092229.19135-1-krzysztof.kozlowski@linaro.org> References: <20231205092229.19135-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 05 Dec 2023 01:22:51 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784433266084366874 X-GMAIL-MSGID: 1784433266084366874 |
Series |
dt-bindings: samsung: continued - add specific compatibles for Tesla FSD Hi,
|
|
Commit Message
Krzysztof Kozlowski
Dec. 5, 2023, 9:22 a.m. UTC
Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the
others it reuses several devices from older designs. Historically we
kept the old (block's) compatible only. This works fine and there is no
bug here, however guidelines expressed in
Documentation/devicetree/bindings/writing-bindings.rst state that:
1. Compatibles should be specific.
2. We should add new compatibles in case of bugs or features.
Add Tesla FSD compatible specific to be used with an existing fallback.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
I propose to take the patch through Samsung SoC (me). See cover letter
for explanation.
---
Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 +
1 file changed, 1 insertion(+)
Comments
Hello, On Tue, Dec 05, 2023 at 10:22:25AM +0100, Krzysztof Kozlowski wrote: > Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the > others it reuses several devices from older designs. Historically we > kept the old (block's) compatible only. This works fine and there is no > bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add Tesla FSD compatible specific to be used with an existing fallback. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
On Tue, Dec 05, 2023 at 10:22:25AM +0100, Krzysztof Kozlowski wrote: > Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the > others it reuses several devices from older designs. Historically we > kept the old (block's) compatible only. This works fine and there is no > bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add Tesla FSD compatible specific to be used with an existing fallback. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 + > 1 file changed, 1 insertion(+) You point to the guidelines that say we should have specific compatible strings, but then the string that you add seems very generic. Now, I'm obviously not an expert on Tesla hardware, but just FSD seems to be quite generic according to the internet. It seems like the chip derived from Samsung used to be known as AP3/HW3, but there's now also AP4/HW4, so I wonder if those differ in some way and if these shouldn't include some sort of version/generation number. Thierry
On 06/12/2023 17:16, Thierry Reding wrote: > On Tue, Dec 05, 2023 at 10:22:25AM +0100, Krzysztof Kozlowski wrote: >> Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the >> others it reuses several devices from older designs. Historically we >> kept the old (block's) compatible only. This works fine and there is no >> bug here, however guidelines expressed in >> Documentation/devicetree/bindings/writing-bindings.rst state that: >> 1. Compatibles should be specific. >> 2. We should add new compatibles in case of bugs or features. >> >> Add Tesla FSD compatible specific to be used with an existing fallback. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> --- >> >> I propose to take the patch through Samsung SoC (me). See cover letter >> for explanation. >> --- >> Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 + >> 1 file changed, 1 insertion(+) > > You point to the guidelines that say we should have specific compatible> strings, but then the string that you add seems very generic. Now, I'm > obviously not an expert on Tesla hardware, but just FSD seems to be > quite generic according to the internet. It seems like the chip derived > from Samsung used to be known as AP3/HW3, but there's now also AP4/HW4, > so I wonder if those differ in some way and if these shouldn't include > some sort of version/generation number. That's the compatible chosen that time for entire platform, as a consensus, for all SoC components. Thus the PWM compatible is as specific as it can get. Best regards, Krzysztof
On Tue, 05 Dec 2023 10:22:25 +0100, Krzysztof Kozlowski wrote: > Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the > others it reuses several devices from older designs. Historically we > kept the old (block's) compatible only. This works fine and there is no > bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add Tesla FSD compatible specific to be used with an existing fallback. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml index 16de6434693b..17a2b927af33 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml @@ -33,6 +33,7 @@ properties: - samsung,exynos7-pwm - samsung,exynosautov9-pwm - samsung,exynosautov920-pwm + - tesla,fsd-pwm - const: samsung,exynos4210-pwm reg: