Message ID | 20231206134446.69048-1-namcao@linutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp4112919vqy; Wed, 6 Dec 2023 05:45:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IEURrXqfv+jKQqI0JEZ/+qvACikJOIsX5x4ifREdrTmwicW69YzjivE6g6s1pTxqQyvHEyP X-Received: by 2002:a05:6a20:26a8:b0:18b:d3db:7048 with SMTP id h40-20020a056a2026a800b0018bd3db7048mr817325pze.23.1701870359454; Wed, 06 Dec 2023 05:45:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701870359; cv=none; d=google.com; s=arc-20160816; b=Vyrlj81iW/+AurO5cMDBGcyyzkBEr8kWnD07iq7yEYK0IBsyvWUB3niKGnzGpfiAwJ ddYilkQnAzZILeSxKjGV7if+/OXaTTMJJYltcIc0ZcG+pcVz6Z/d1Y9hw1GwdVShfw2E O+lcM7RHKyovyWXyGQpMFvghbOK96COMgmxPCN9e03CIPmPEsTQpfHZTmaIDSJHKx+d6 dwZPGBegBNJEaS6qyvKHt9eM0QV1pvs+ZTS/w59rufHdQ20hQBSznb0cPvAKXsSwDfez 2owd9eVpSIGj/HnO2m6MH/xcXTiTlZWj/zVaUNyiVxXoH4sytzwIRRAV3K6pRgf2wXfe LaKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:dkim-signature:dkim-signature:from; bh=Hdgp/KXnKqI/YU7obBU7rXwS3m3tuver7rmEtNCRuvs=; fh=1IKp81/Uvl9vUeFxTVLSiabzC4OE9m73g8+CMu1UOiY=; b=onabVF29y+3/OWWlQ/gc8vADinrP+LCCjRyZiSyCA1x4CwVlYc8nChyiHfintIJpp2 HWxYUVLyqEztCwY4lNj2XcnX90cu0q5/XK/mehPQ7DgsMF6mlSi8IHP9iz/q3LCsckAD FpgSwHtxvuI0ww981LPMrvTpKfJiMnUoYX8GgSeVajDQRJJMf1LVIjld/F4XdI+LDGr6 4gxRnPlW/ysBYnRpyy4rRyuL1Z9DTOABlCvgzmA7kkZ+BcYcHGiblkc/w3xuZ4bBcXUs eZ/E1LH4zwNHbVbAgs5moh2yzTZtJiA5jhzPOXBhwyqo5dTWe+DskFqcULOIEv9McV1k vZLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=VmtRfWqV; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=VCYvcMfl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id f6-20020a056a0022c600b006ce500e3702si5526816pfj.343.2023.12.06.05.45.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 05:45:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=VmtRfWqV; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=VCYvcMfl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 69EAF8040925; Wed, 6 Dec 2023 05:45:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378499AbjLFNox (ORCPT <rfc822;pusanteemu@gmail.com> + 99 others); Wed, 6 Dec 2023 08:44:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378494AbjLFNow (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 6 Dec 2023 08:44:52 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4BC2122; Wed, 6 Dec 2023 05:44:58 -0800 (PST) From: Nam Cao <namcao@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1701870296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Hdgp/KXnKqI/YU7obBU7rXwS3m3tuver7rmEtNCRuvs=; b=VmtRfWqV3hQHWw9VM0X/u40G3JBc+TnoL06+8asysJtoMjehNdcAyCYdDP51wOaAb56uYb 0m998H7iqXzrk57rQrmntYM1KufCXzDaEm18Ixj2nnLThkLIuCCh4s2wKUX1GjDHlK2omr +lFUOHFf6qGrpdGvZYbxAM4tRsEIHQ9e0zwYreDKbBTgvQ9w41LA15NKHlpe+5z3pdf+tM 3TnQdxUk8VxUqR8RKY70iIpQvLkkq3rMsPcUvguZ+v+AFBTP0CsrdxaXaqC9Suh/SruWb6 I9zWmvTPWLKAH3Lg/o0rjDnOZ+evJKaLMPCjwPC2+HxAKz1xnZLnv09+zsss4w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1701870296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Hdgp/KXnKqI/YU7obBU7rXwS3m3tuver7rmEtNCRuvs=; b=VCYvcMflnN1n0brWx4OSl6nN71wZwkggRM0NknHhe57yunSjqHavDTLKwRqHbmQ9w8gS35 AOqdkU359WyNczAA== To: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, daniel@zonque.org Cc: Nam Cao <namcao@linutronix.de> Subject: [PATCH] Revert "spi: cadence: Add SPI transfer delays" Date: Wed, 6 Dec 2023 14:44:46 +0100 Message-Id: <20231206134446.69048-1-namcao@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 06 Dec 2023 05:45:06 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784540413887365163 X-GMAIL-MSGID: 1784540413887365163 |
Series |
Revert "spi: cadence: Add SPI transfer delays"
|
|
Commit Message
Nam Cao
Dec. 6, 2023, 1:44 p.m. UTC
This reverts commit 855a40cd8cccfbf5597adfa77f55cdc8c44b6e42.
SPI transfer delay is already handled in SPI core. There is no need to
do it again.
Signed-off-by: Nam Cao <namcao@linutronix.de>
---
drivers/spi/spi-cadence.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Wed, Dec 06, 2023 at 02:44:46PM +0100, Nam Cao wrote:
> This reverts commit 855a40cd8cccfbf5597adfa77f55cdc8c44b6e42.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
On Wed, 6 Dec 2023 13:55:30 +0000 Mark Brown <broonie@kernel.org> wrote: > On Wed, Dec 06, 2023 at 02:44:46PM +0100, Nam Cao wrote: > > This reverts commit 855a40cd8cccfbf5597adfa77f55cdc8c44b6e42. > > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. > > Please include human readable descriptions of things like commits and > issues being discussed in e-mail in your mails, this makes them much > easier for humans to read especially when they have no internet access. > I do frequently catch up on my mail on flights or while otherwise > travelling so this is even more pressing for me than just being about > making things a bit easier to read. Okay, will send a v2 shortly. Sorry for the inconvenience. Best regards, Nam
diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 12c940ba074a..bd96d8b546cd 100644 --- a/drivers/spi/spi-cadence.c +++ b/drivers/spi/spi-cadence.c @@ -451,7 +451,6 @@ static int cdns_transfer_one(struct spi_controller *ctlr, udelay(10); cdns_spi_process_fifo(xspi, xspi->tx_fifo_depth, 0); - spi_transfer_delay_exec(transfer); cdns_spi_write(xspi, CDNS_SPI_IER, CDNS_SPI_IXR_DEFAULT); return transfer->len;