Message ID | 20231205184741.3092376-3-mmayer@broadcom.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3635529vqy; Tue, 5 Dec 2023 10:48:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IGFw0ia9rnqkWee4KA97WReP5WGX81/RwMYEzvekoUHX4OXFcAuY31gzHwuwXsvapeAlsXC X-Received: by 2002:a17:90a:e654:b0:286:6cc1:864e with SMTP id ep20-20020a17090ae65400b002866cc1864emr1323479pjb.51.1701802111474; Tue, 05 Dec 2023 10:48:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701802111; cv=none; d=google.com; s=arc-20160816; b=YgQ+7UxF1G55pFKa9QkIhJLCbI4ZK/aKQhr7MItLrBhgHn929teSD7f+6QLiOEI65d aKlzJ/Qzoex+zjTN6dy45S6bP/kWCHD3lGbHrULqrghzcsJEPu9n7ot/nAtrxGhnSbvM w0i7MJbj47nzFXniKdQlkvvAg03AKqjDNYteWS2nvRG9Pl2Tm7QDhwRNxbXMdTVz2vfV TCAKSNxXObSlkePJP6BELQOIF1UlNP5fgIQodxjAXtBfLHElAk+q+V60OI8bY25TJTps gINbWDQ5HE52YATBTV2pqnqrQxFXaLKspONU2ZalxPx49Au8IwBI6dVVsIKLDO9DTblL tNtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NMuwtjnej1x8HFalp3Q3/OE/xfiviC9gRjxwKKTrR6w=; fh=JtBfHkLwU5057B0nnGl+wIE10FqpQSpetKyOLDjQ+JQ=; b=rIg93yy8+HG7ymLYnYP25m44IHjHQ/cZbIm5KBUQcDe9vgNk5ve/U7JtVyMUeFzXR7 05ljwvkeyvKsTtZoAcuSfT/fHB07KJ65hqdfhBUP+Tj19aIr+aAgqkU1Jn0lPgHxG5qG iGlmbK1hY27Z6yuTn0xqip2jV7J2sX8Tm5xKo6Wo+ZDr7CRtYfpDYHuChqexhDBbkIJe jV2LPGmDYkBv9qTIN6wyu7YwUKQcEWwHNTUnCBHATQnG0K2xe61Jm1fbnbLKkJ+y9H73 9Lak4Ybb+mcpXTJy5P9fsWAUwbfSFnjplEOY89dsLUzpz6NsyLsq6Tb27eLc/RCT56K/ jXzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=gpEQpc62; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id jj3-20020a170903048300b001d0b693adf9si2785947plb.39.2023.12.05.10.48.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 10:48:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=gpEQpc62; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 2AFBA80309DA; Tue, 5 Dec 2023 10:48:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232254AbjLESsU (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Tue, 5 Dec 2023 13:48:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232202AbjLESsR (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 5 Dec 2023 13:48:17 -0500 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CED6AD42 for <linux-kernel@vger.kernel.org>; Tue, 5 Dec 2023 10:48:21 -0800 (PST) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6ce6f4d3dafso166663b3a.0 for <linux-kernel@vger.kernel.org>; Tue, 05 Dec 2023 10:48:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1701802101; x=1702406901; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NMuwtjnej1x8HFalp3Q3/OE/xfiviC9gRjxwKKTrR6w=; b=gpEQpc62O1bItJgwaYS33n3QRx0bg7SaxQZ+UbpjC8QwzanI0+gn9nayYjx+p3VEoQ IOVL8qx7o7ZF9TzF+j1URzR9MJsJemhepUEQv3HX9DxZVfv4p/Dz14OMvIJQPzqmJ44h QClHW7S4s88WtIOGPEeT8fAwTPMDdNWD4o/Sw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701802101; x=1702406901; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NMuwtjnej1x8HFalp3Q3/OE/xfiviC9gRjxwKKTrR6w=; b=A2bRA4FX6MfA9wjhv3Yy2W0UH5syAQoo4TclehP3mpYxMGLNXpHXrwgj760v0jxfYB h7QAw6X8coMIU06mpKHL/oR2NysWdAogH9qMhPB6SvvSNxHgsFt5INlEWFbX9aTH0YOg tBAc5etcViwnI9uOjsw5vjBetu4Gqi1gMluNPxwOcg7cvxQCzBOblfzlQMJ81uq4fo6O mcVqinZ2JBI3R6XVQ3OGuJReRCcTSYnmvQDya4sNVUT30Bzya+6LKaGBc9cMgER/VxFO Qiq+oBiRtSGH4gCfvf9fgh/zfr5TfFP66AYYtKBPA2BNmR01a3hyRiCkzsYvIIpapkxH df4Q== X-Gm-Message-State: AOJu0Yx31D755pfRZgNvPvzXK/P6NYvY0HXqRjXT+A5DxFyQhNTVycIq fqPuoQVYqR/nTY65uQ30LEo5gw== X-Received: by 2002:aa7:88c6:0:b0:6ce:4c49:58e4 with SMTP id k6-20020aa788c6000000b006ce4c4958e4mr8321583pff.0.1701802101086; Tue, 05 Dec 2023 10:48:21 -0800 (PST) Received: from lbrmn-mmayer.ric.broadcom.net ([192.19.161.248]) by smtp.gmail.com with ESMTPSA id k14-20020aa788ce000000b006ce5b404f5csm3213329pff.134.2023.12.05.10.48.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 10:48:20 -0800 (PST) Received: by lbrmn-mmayer.ric.broadcom.net (Postfix, from userid 1000) id 5BF12D04; Tue, 5 Dec 2023 10:48:19 -0800 (PST) From: Markus Mayer <mmayer@broadcom.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Florian Fainelli <florian.fainelli@broadcom.com>, Rob Herring <robh+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org> Cc: Markus Mayer <mmayer@broadcom.com>, Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>, Device Tree Mailing List <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: [PATCH 2/4] memory: brcmstb_dpfe: introduce version-specific compatible strings Date: Tue, 5 Dec 2023 10:47:35 -0800 Message-ID: <20231205184741.3092376-3-mmayer@broadcom.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231205184741.3092376-1-mmayer@broadcom.com> References: <20231205184741.3092376-1-mmayer@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 10:48:30 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784468850680726067 X-GMAIL-MSGID: 1784468850680726067 |
Series |
memory: brcmstb_dpfe: support DPFE API v4
|
|
Commit Message
Markus Mayer
Dec. 5, 2023, 6:47 p.m. UTC
Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3
to the Broadcom DPFE driver.
Signed-off-by: Markus Mayer <mmayer@broadcom.com>
---
drivers/memory/brcmstb_dpfe.c | 6 ++++++
1 file changed, 6 insertions(+)
Comments
On 12/5/23 10:47, Markus Mayer wrote: > Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3 > to the Broadcom DPFE driver. > > Signed-off-by: Markus Mayer <mmayer@broadcom.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
On 05/12/2023 19:47, Markus Mayer wrote: > Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3 > to the Broadcom DPFE driver. No, why? > > Signed-off-by: Markus Mayer <mmayer@broadcom.com> > --- > drivers/memory/brcmstb_dpfe.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c > index a7ab3d377206..66876b409e59 100644 > --- a/drivers/memory/brcmstb_dpfe.c > +++ b/drivers/memory/brcmstb_dpfe.c > @@ -924,6 +924,12 @@ static const struct of_device_id brcmstb_dpfe_of_match[] = { > { .compatible = "brcm,bcm7271-dpfe-cpu", .data = &dpfe_api_old_v2 }, > { .compatible = "brcm,bcm7278-dpfe-cpu", .data = &dpfe_api_old_v2 }, > { .compatible = "brcm,bcm7211-dpfe-cpu", .data = &dpfe_api_new_v2 }, > + > + /* Match specific DCPU versions */ > + { .compatible = "brcm,dpfe-cpu-v1", .data = &dpfe_api_old_v2 }, > + { .compatible = "brcm,dpfe-cpu-v2", .data = &dpfe_api_new_v2 }, > + { .compatible = "brcm,dpfe-cpu-v3", .data = &dpfe_api_v3 }, Pointless change. Best regards, Krzysztof
On 12/6/2023 3:09 AM, Krzysztof Kozlowski wrote: > On 05/12/2023 19:47, Markus Mayer wrote: >> Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3 >> to the Broadcom DPFE driver. > > No, why? > >> >> Signed-off-by: Markus Mayer <mmayer@broadcom.com> >> --- >> drivers/memory/brcmstb_dpfe.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c >> index a7ab3d377206..66876b409e59 100644 >> --- a/drivers/memory/brcmstb_dpfe.c >> +++ b/drivers/memory/brcmstb_dpfe.c >> @@ -924,6 +924,12 @@ static const struct of_device_id brcmstb_dpfe_of_match[] = { >> { .compatible = "brcm,bcm7271-dpfe-cpu", .data = &dpfe_api_old_v2 }, >> { .compatible = "brcm,bcm7278-dpfe-cpu", .data = &dpfe_api_old_v2 }, >> { .compatible = "brcm,bcm7211-dpfe-cpu", .data = &dpfe_api_new_v2 }, >> + >> + /* Match specific DCPU versions */ >> + { .compatible = "brcm,dpfe-cpu-v1", .data = &dpfe_api_old_v2 }, >> + { .compatible = "brcm,dpfe-cpu-v2", .data = &dpfe_api_new_v2 }, >> + { .compatible = "brcm,dpfe-cpu-v3", .data = &dpfe_api_v3 }, > > Pointless change. Is it possible to ask you as a maintainer to stop having those knee jerk reactions and try to understand things a bit better, or simply request a better explanation from the submitter?
On 06/12/2023 17:19, Florian Fainelli wrote: > > > On 12/6/2023 3:09 AM, Krzysztof Kozlowski wrote: >> On 05/12/2023 19:47, Markus Mayer wrote: >>> Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3 >>> to the Broadcom DPFE driver. >> >> No, why? >> >>> >>> Signed-off-by: Markus Mayer <mmayer@broadcom.com> >>> --- >>> drivers/memory/brcmstb_dpfe.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c >>> index a7ab3d377206..66876b409e59 100644 >>> --- a/drivers/memory/brcmstb_dpfe.c >>> +++ b/drivers/memory/brcmstb_dpfe.c >>> @@ -924,6 +924,12 @@ static const struct of_device_id brcmstb_dpfe_of_match[] = { >>> { .compatible = "brcm,bcm7271-dpfe-cpu", .data = &dpfe_api_old_v2 }, >>> { .compatible = "brcm,bcm7278-dpfe-cpu", .data = &dpfe_api_old_v2 }, >>> { .compatible = "brcm,bcm7211-dpfe-cpu", .data = &dpfe_api_new_v2 }, >>> + >>> + /* Match specific DCPU versions */ >>> + { .compatible = "brcm,dpfe-cpu-v1", .data = &dpfe_api_old_v2 }, >>> + { .compatible = "brcm,dpfe-cpu-v2", .data = &dpfe_api_new_v2 }, >>> + { .compatible = "brcm,dpfe-cpu-v3", .data = &dpfe_api_v3 }, >> >> Pointless change. > > Is it possible to ask you as a maintainer to stop having those knee jerk > reactions and try to understand things a bit better, or simply request a > better explanation from the submitter? I asked: "Why?". None of the commits explain the rationale behind the change. None of them say why such change is needed. They all repeat what the patch is doing, which is pretty easy to see from the diff. The commit must answer the trickiest question: why are we doing this? Best regards, Krzysztof
diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c index a7ab3d377206..66876b409e59 100644 --- a/drivers/memory/brcmstb_dpfe.c +++ b/drivers/memory/brcmstb_dpfe.c @@ -924,6 +924,12 @@ static const struct of_device_id brcmstb_dpfe_of_match[] = { { .compatible = "brcm,bcm7271-dpfe-cpu", .data = &dpfe_api_old_v2 }, { .compatible = "brcm,bcm7278-dpfe-cpu", .data = &dpfe_api_old_v2 }, { .compatible = "brcm,bcm7211-dpfe-cpu", .data = &dpfe_api_new_v2 }, + + /* Match specific DCPU versions */ + { .compatible = "brcm,dpfe-cpu-v1", .data = &dpfe_api_old_v2 }, + { .compatible = "brcm,dpfe-cpu-v2", .data = &dpfe_api_new_v2 }, + { .compatible = "brcm,dpfe-cpu-v3", .data = &dpfe_api_v3 }, + /* API v3 is the default going forward */ { .compatible = "brcm,dpfe-cpu", .data = &dpfe_api_v3 }, {}