Message ID | 20231205084835.15871-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3292529vqy; Tue, 5 Dec 2023 00:48:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IEj5qxXpoB9cR+d2EdYJnbGlGrHVUzmy5aRk3f8vn3QV+2+1COiTCoMaJAMg12GsY8pl7hI X-Received: by 2002:a05:6a00:1491:b0:6ce:6baf:d7d5 with SMTP id v17-20020a056a00149100b006ce6bafd7d5mr929323pfu.4.1701766133661; Tue, 05 Dec 2023 00:48:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701766133; cv=none; d=google.com; s=arc-20160816; b=DUlusnf5RNosNCHi5Q4pNBRonDnDLocmTduJczAVVj2EUlKqTvosRoJCGVIu2BrD5b 4S1w5d/P58kRW2qgyWcvmTsagegMPDGBEsvtzT0Tfq+/FMc7nPl50w47hJWTjO2HnSFy DfPThlewyoA3bwOTFN/7FNi3s7VDfqaKKtMjWblPW5KsWUG2n7Df5Il3aBxn2zlfRIun Muk0GvJJgqXcNJnkfGIFU4/S3gc1E251PteG7RsxXKNgaWRCPEPro0c58YZiFHryvL04 KWQfiXK9Vy9QnwTYR25zlboBGHoh2R1s4Dw127p0xsxea2HbiUPwHJCQ5q/lrYjB4iEr 2Lng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=GBBOhYI+d0VUyAPFbgIHeqblC7WS3xrkGn9mj7w3QOg=; fh=9T6Y9Y4Rksf7V1gcetQjSF3/a7qaUtnhDYamYKbQyfo=; b=xB2WH1XB4faTycya09yUzJnn+62+NnvM9cDhY4UzJ4z6L7WYBtYGTec1PQ5+CiyJm6 KDneVotEEfYuqMAwhPoQY82V38umf83hhLNFFoz23P5f7T/POXRbqBBIK31f+Cc1ssDU 97xP2kPXYyAVBx+1WkZCHM+qJqv5ZsLJTwfdbX/lGPTEpAJH7QBDjdChUdk1MO76NmDP tUuh7w8TAIZD2HOM+zzM0ISNWjvllF+NacKnksrAU2Y24J07dAZMAQFewdpBHaQfq/NH aScU9tyQcZ0l/cRBjBagOPHdeYZbx2IwxSrkW6FjoQC3s6E1hl2ZopJrgMMF7ou+Q1Er F8OQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=U9l3dYf1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id m13-20020a634c4d000000b005b96d038729si9032323pgl.728.2023.12.05.00.48.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 00:48:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=U9l3dYf1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7BB8080B8E5C; Tue, 5 Dec 2023 00:48:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346386AbjLEIsl (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Tue, 5 Dec 2023 03:48:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235003AbjLEIsh (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 5 Dec 2023 03:48:37 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCDBF1B9 for <linux-kernel@vger.kernel.org>; Tue, 5 Dec 2023 00:48:40 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3333b46f26aso2621754f8f.1 for <linux-kernel@vger.kernel.org>; Tue, 05 Dec 2023 00:48:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701766119; x=1702370919; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GBBOhYI+d0VUyAPFbgIHeqblC7WS3xrkGn9mj7w3QOg=; b=U9l3dYf1oUkyYmhOTn4MwC/K+DNjGt62rYE2zROPX1TWFayRR9bEPsD8mW2alPsucI O1o+Ff6NWudOER5S2A4P0C3gx5ylDNuUdOrWjI1UuSsKZp9uC4H8C8AamHP5tqar9iqL mWdRcV4jNfTLBMZEhinV9kfrwG40qK7gQbtqlBrXRRdIfGG63ZKKPjvUX0yCtN3ma4Ka wZYHWHUgwTK9qlgIWfLGQpdjuzyN4FrRkNOlLRSJxV0xs42onYBgRY8wPB/w9tjxVJBg Xu7r0lGY0LqxVy6v3VR5TcKOskM34tl57zeNSyx8XvXSQHGRhGHvyb07Xzth3CnD8cvs NG7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701766119; x=1702370919; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GBBOhYI+d0VUyAPFbgIHeqblC7WS3xrkGn9mj7w3QOg=; b=rrdz7Ag0h9kfzEeU/pj145kWLNn3YBtStBka7eMCTIvlK9siJiTSBiAd/DiX/2lkrp t7HYtYUUK8lzt6D0W412ldmjMckuXVhr/dNrzkft2LyG9HDwma7YiLege2jDk5cgMZU9 HXfybUhiKNZ+t0mE70e1lorUFG9ZyXisza2chdpr4KmmK8nnjbrCbZGcAKhH505dVsG9 YHuJ4aBPq9mqgTjt9MtQD+ps3CDtxRwmiesJkLNGXlaK3j3saxkr4xyV1p1E5ekXOOr2 Ac990Ws153ElLDH7gjX8qEaZLEGTE8hutxLmwTqkQLOeROOsrS/4EYB+S7abIRfmqjah OL0g== X-Gm-Message-State: AOJu0YzLdCbj/w6NIBn5+rydbaGHIafsE40h5PE9y/nUucRNk4Y3vwSt 3FUZOR8mutjY8ybe8fbWP4Icww== X-Received: by 2002:a5d:5406:0:b0:333:3af7:a4ef with SMTP id g6-20020a5d5406000000b003333af7a4efmr2188899wrv.8.1701766119013; Tue, 05 Dec 2023 00:48:39 -0800 (PST) Received: from krzk-bin.. ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id x18-20020adfffd2000000b00332fd9b2b52sm8323097wrs.104.2023.12.05.00.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 00:48:38 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Sakari Ailus <sakari.ailus@linux.intel.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Maxime Ripard <mripard@kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH] media: dt-bindings: ov8856: add missing second link frequency in example Date: Tue, 5 Dec 2023 09:48:35 +0100 Message-Id: <20231205084835.15871-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 00:48:52 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784431125267307808 X-GMAIL-MSGID: 1784431125267307808 |
Series |
media: dt-bindings: ov8856: add missing second link frequency in example
|
|
Commit Message
Krzysztof Kozlowski
Dec. 5, 2023, 8:48 a.m. UTC
Bindings and Linux driver require two link frequencies, so correct the
example:
ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short
Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Krzysztof, Thanks for the patch. On Tue, Dec 05, 2023 at 09:48:35AM +0100, Krzysztof Kozlowski wrote: > Bindings and Linux driver require two link frequencies, so correct the > example: > > ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short > > Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > index 57f5e48fd8e0..bd1a55d767e7 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > @@ -126,7 +126,7 @@ examples: > wcam_out: endpoint { > remote-endpoint = <&mipi_in_wcam>; > data-lanes = <1 2 3 4>; > - link-frequencies = /bits/ 64 <360000000>; > + link-frequencies = /bits/ 64 <360000000 180000000>; There indeed seems to be a problem with the example as far as the bindings are concerned but the primary issue seems to be in the bindings. Both of these frequencies have significance from driver point of view only while the device itself supports a (wider) range. How about removing maxItems and items from the bindings instead? > }; > }; > };
On Tue, Dec 05, 2023 at 11:01:41AM +0000, Sakari Ailus wrote: > Hi Krzysztof, > > Thanks for the patch. > > On Tue, Dec 05, 2023 at 09:48:35AM +0100, Krzysztof Kozlowski wrote: > > Bindings and Linux driver require two link frequencies, so correct the > > example: > > > > ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short > > > > Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas") > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > > index 57f5e48fd8e0..bd1a55d767e7 100644 > > --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml > > @@ -126,7 +126,7 @@ examples: > > wcam_out: endpoint { > > remote-endpoint = <&mipi_in_wcam>; > > data-lanes = <1 2 3 4>; > > - link-frequencies = /bits/ 64 <360000000>; > > + link-frequencies = /bits/ 64 <360000000 180000000>; > > There indeed seems to be a problem with the example as far as the bindings > are concerned but the primary issue seems to be in the bindings. Both of > these frequencies have significance from driver point of view only while > the device itself supports a (wider) range. > > How about removing maxItems and items from the bindings instead? There's also a similar issue with lanes: 1, 2 and 4 are supported.
On 05/12/2023 12:01, Sakari Ailus wrote: > Hi Krzysztof, > > Thanks for the patch. > > On Tue, Dec 05, 2023 at 09:48:35AM +0100, Krzysztof Kozlowski wrote: >> Bindings and Linux driver require two link frequencies, so correct the >> example: >> >> ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short >> >> Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas") >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml >> index 57f5e48fd8e0..bd1a55d767e7 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml >> +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml >> @@ -126,7 +126,7 @@ examples: >> wcam_out: endpoint { >> remote-endpoint = <&mipi_in_wcam>; >> data-lanes = <1 2 3 4>; >> - link-frequencies = /bits/ 64 <360000000>; >> + link-frequencies = /bits/ 64 <360000000 180000000>; > > There indeed seems to be a problem with the example as far as the bindings > are concerned but the primary issue seems to be in the bindings. Both of > these frequencies have significance from driver point of view only while > the device itself supports a (wider) range. > > How about removing maxItems and items from the bindings instead? Yeah, it makes sense. Best regards, Krzysztof
On 05/12/2023 12:43, Sakari Ailus wrote: > On Tue, Dec 05, 2023 at 11:01:41AM +0000, Sakari Ailus wrote: >> Hi Krzysztof, >> >> Thanks for the patch. >> >> On Tue, Dec 05, 2023 at 09:48:35AM +0100, Krzysztof Kozlowski wrote: >>> Bindings and Linux driver require two link frequencies, so correct the >>> example: >>> >>> ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short >>> >>> Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas") >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml >>> index 57f5e48fd8e0..bd1a55d767e7 100644 >>> --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml >>> +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml >>> @@ -126,7 +126,7 @@ examples: >>> wcam_out: endpoint { >>> remote-endpoint = <&mipi_in_wcam>; >>> data-lanes = <1 2 3 4>; >>> - link-frequencies = /bits/ 64 <360000000>; >>> + link-frequencies = /bits/ 64 <360000000 180000000>; >> >> There indeed seems to be a problem with the example as far as the bindings >> are concerned but the primary issue seems to be in the bindings. Both of >> these frequencies have significance from driver point of view only while >> the device itself supports a (wider) range. >> >> How about removing maxItems and items from the bindings instead? > > There's also a similar issue with lanes: 1, 2 and 4 are supported. ack Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml index 57f5e48fd8e0..bd1a55d767e7 100644 --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml @@ -126,7 +126,7 @@ examples: wcam_out: endpoint { remote-endpoint = <&mipi_in_wcam>; data-lanes = <1 2 3 4>; - link-frequencies = /bits/ 64 <360000000>; + link-frequencies = /bits/ 64 <360000000 180000000>; }; }; };