arm64: dts: ti: k3-am62a7-sk: Add interrupt support for IO Expander

Message ID 20231108191652.1118155-1-a-bhatia1@ti.com
State New
Headers
Series arm64: dts: ti: k3-am62a7-sk: Add interrupt support for IO Expander |

Commit Message

Aradhya Bhatia Nov. 8, 2023, 7:16 p.m. UTC
  The Hot Plug Detect (HPD) signal for the HDMI display travels from the
on-board HDMI connector, through the IO Expander 1, and finally to the
main_gpio1 line #23, of the SoC.

Add interrupt information for the IO Expander 1 (exp1).
Also add pinmux info of main gpio 1, line #23.

Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
---

Notes:

  - HDMI display on AM62A7 is not in the mainline yet. All the patches,
    including this one, required to enable HDMI display and HPD on
    AM62A7 SK-EVM, can be found on my github fork in the branch
    "next_am62a-v3"[0].

[0]: https://github.com/aradhya07/linux-ab/tree/next_am62a-v3

 arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)


base-commit: 2220f68f4504aa1ccce0fac721ccdb301e9da32f
  

Comments

Jai Luthra Nov. 27, 2023, 4:01 p.m. UTC | #1
Hi Aradhya,

On Nov 09, 2023 at 00:46:52 +0530, Aradhya Bhatia wrote:
> The Hot Plug Detect (HPD) signal for the HDMI display travels from the
> on-board HDMI connector, through the IO Expander 1, and finally to the
> main_gpio1 line #23, of the SoC.
> 
> Add interrupt information for the IO Expander 1 (exp1).
> Also add pinmux info of main gpio 1, line #23.
> 
> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>

Reviewed-by: Jai Luthra <j-luthra@ti.com>

> ---
> 
> Notes:
> 
>   - HDMI display on AM62A7 is not in the mainline yet. All the patches,
>     including this one, required to enable HDMI display and HPD on
>     AM62A7 SK-EVM, can be found on my github fork in the branch
>     "next_am62a-v3"[0].
> 
> [0]: https://github.com/aradhya07/linux-ab/tree/next_am62a-v3
> 
>  arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index 8f64ac2c7568..560dad02ef62 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -274,6 +274,12 @@ AM62AX_IOPAD(0x08c, PIN_OUTPUT, 2) /* (K19) GPMC0_WEn.MCASP1_AXR0 */
>  			AM62AX_IOPAD(0x084, PIN_INPUT, 2) /* (L18) GPMC0_ADVn_ALE.MCASP1_AXR2 */
>  		>;
>  	};
> +
> +	main_gpio1_ioexp_intr_pins_default: main-gpio1-ioexp-intr-default-pins {
> +		pinctrl-single,pins = <
> +			AM62AX_IOPAD(0x01d4, PIN_INPUT, 7) /* (C15) UART0_RTSn.GPIO1_23 */
> +		>;
> +	};
>  };
>  
>  &mcu_pmx0 {
> @@ -407,6 +413,12 @@ exp1: gpio@22 {
>  		reg = <0x22>;
>  		gpio-controller;
>  		#gpio-cells = <2>;
> +		interrupt-parent = <&main_gpio1>;
> +		interrupts = <23 IRQ_TYPE_EDGE_FALLING>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&main_gpio1_ioexp_intr_pins_default>;
>  
>  		gpio-line-names = "GPIO_CPSW2_RST", "GPIO_CPSW1_RST",
>  				   "BT_EN_SOC", "MMC1_SD_EN",
> 
> base-commit: 2220f68f4504aa1ccce0fac721ccdb301e9da32f
> -- 
> 2.42.0
>
  
Nishanth Menon Dec. 4, 2023, 9:12 p.m. UTC | #2
Hi Aradhya Bhatia,

On Thu, 09 Nov 2023 00:46:52 +0530, Aradhya Bhatia wrote:
> The Hot Plug Detect (HPD) signal for the HDMI display travels from the
> on-board HDMI connector, through the IO Expander 1, and finally to the
> main_gpio1 line #23, of the SoC.
> 
> Add interrupt information for the IO Expander 1 (exp1).
> Also add pinmux info of main gpio 1, line #23.
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/1] arm64: dts: ti: k3-am62a7-sk: Add interrupt support for IO Expander
      commit: e57ba268254bda25a3ddca8b7971d6ad8277e2d8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
  

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
index 8f64ac2c7568..560dad02ef62 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
@@ -274,6 +274,12 @@  AM62AX_IOPAD(0x08c, PIN_OUTPUT, 2) /* (K19) GPMC0_WEn.MCASP1_AXR0 */
 			AM62AX_IOPAD(0x084, PIN_INPUT, 2) /* (L18) GPMC0_ADVn_ALE.MCASP1_AXR2 */
 		>;
 	};
+
+	main_gpio1_ioexp_intr_pins_default: main-gpio1-ioexp-intr-default-pins {
+		pinctrl-single,pins = <
+			AM62AX_IOPAD(0x01d4, PIN_INPUT, 7) /* (C15) UART0_RTSn.GPIO1_23 */
+		>;
+	};
 };
 
 &mcu_pmx0 {
@@ -407,6 +413,12 @@  exp1: gpio@22 {
 		reg = <0x22>;
 		gpio-controller;
 		#gpio-cells = <2>;
+		interrupt-parent = <&main_gpio1>;
+		interrupts = <23 IRQ_TYPE_EDGE_FALLING>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&main_gpio1_ioexp_intr_pins_default>;
 
 		gpio-line-names = "GPIO_CPSW2_RST", "GPIO_CPSW1_RST",
 				   "BT_EN_SOC", "MMC1_SD_EN",