Message ID | 20231129161459.1002323-13-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a5a7:0:b0:403:3b70:6f57 with SMTP id d7csp449967vqn; Wed, 29 Nov 2023 08:16:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IF7GnzxAl+lvMe2TlmmxFHXzgxaN8Tjej9BbBvCKTsEK0FC38fdW/CTYCktgchNs38S/JDS X-Received: by 2002:a05:6a20:9e4c:b0:187:d93f:b0fa with SMTP id mt12-20020a056a209e4c00b00187d93fb0famr22413228pzb.27.1701274615212; Wed, 29 Nov 2023 08:16:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701274615; cv=none; d=google.com; s=arc-20160816; b=h0nqB/NTXlH04HwerygRder8RO8ISDxulg7EwEg/6ZyvBnFnGoJNx6BrNpV7SI+t1Z vRRmDJ3HuxvOYOi/GuNPQuIyXP3Vb+taNlrccUgxmn1I8oQogLx/dWHyR7efex4JcUQi VHIEZs2dk6lL6pqa4CdUvO/lvhr4ErAovITZg5Z70iFUtDzgnBM7+/xcK8raffQY1kc1 3QP2HMe4AsjjhpMRxCG6OrFXx0JqdG+gMFTR89hugWN2Zh44B7jVJt4D+62T3uKIsLsS oVP4nuX/nCzofas/QIVJYl/XR47JQUzr2kTwWPGL7URrVpiIiTL9ltPqk9uK+1rUbPYz fsmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=anTtiC2OivjXTLiFNi+8mAML1Z7aJiqLP2gBQpQzTLw=; fh=p5qGgOuQ1qdHRKXQ3E7ZkEX+heMqfz4xi8z6J8C0/aQ=; b=FOmMuLzK+sQeIlcMShgwOoLFPKehQiSZirVfesgoJ00f3XIGAKh8SMEcWfqL4iVOYN qdChxB5P8+HCNjDyxTEtcXFAcpeMQwtSIgNWmnVgJlXoY512DJ9mdWrpnw248GChpOMV GPiLcPAe5OMGwwnvZSX4avd1Fd/EKl/K1kPb9BjMFOb2XKpOgaD/81N3zmTInprCI/a+ gDoRYX6l48uyzLtiohk29F4fBYsWlA6oJGigYSSjWxfRGCaIxPgQmu6R+Ftr36TjTCni lrGzXsWyW1KCL1QxL4O7P/+BILAZmh3kvnDJZX195NqVlevyNqprsqkaafV4l6NlB9ob WuXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Su7DFqOq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id x12-20020a634a0c000000b0059b64b153f6si129265pga.845.2023.11.29.08.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 08:16:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Su7DFqOq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 74124808A349; Wed, 29 Nov 2023 08:16:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231709AbjK2QP5 (ORCPT <rfc822;toshivichauhan@gmail.com> + 99 others); Wed, 29 Nov 2023 11:15:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230120AbjK2QPV (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 29 Nov 2023 11:15:21 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE21010D9; Wed, 29 Nov 2023 08:15:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701274527; x=1732810527; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3nCf9Nawx9DZLMwtP7gm5hKJWHmWiIVjJbmiWUav9q4=; b=Su7DFqOqtkI7w82/V7cHpPlodXPQiuHokueBkgOETHA8i4GxPumuVBPV p2kRFmVOhpI/d14WKZfyaaRFw20O6LOgFJgOCWhbX+j3TuUis3banaj8P BMy+loAKtD91qwZBNen1J7pU7a/i8BSkiXa9gLeuJCO/soSNkcYXCgj5x c3fb7ZuzrUHv74xvY3omkThK1PDi1CgadT6bu+slDYojzsImjriFA1apM fJkXqjplWvQknEdNLZW4xGi6nPo6qA1l+3OaTbFa4WRlVf+yQ18AP1EQD LI5c0e7evMmWENx365PYStLI5oQTOl2C5Xu6Z8c95xA3Fgw3F2B6+kIKJ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="373372764" X-IronPort-AV: E=Sophos;i="6.04,235,1695711600"; d="scan'208";a="373372764" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2023 08:15:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="892498890" X-IronPort-AV: E=Sophos;i="6.04,235,1695711600"; d="scan'208";a="892498890" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga004.jf.intel.com with ESMTP; 29 Nov 2023 08:15:12 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id DC476B01; Wed, 29 Nov 2023 18:15:01 +0200 (EET) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bartosz.golaszewski@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, =?utf-8?q?Jonathan_Neusch?= =?utf-8?q?=C3=A4fer?= <j.neuschaefer@gmx.net>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, =?utf-8?q?Uwe_Kleine-?= =?utf-8?q?K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, Geert Uytterhoeven <geert+renesas@glider.be>, Biju Das <biju.das.jz@bp.renesas.com>, Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>, Jianlong Huang <jianlong.huang@starfivetech.com>, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org, linux-mips@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org Cc: Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Dong Aisheng <aisheng.dong@nxp.com>, Fabio Estevam <festevam@gmail.com>, Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Sascha Hauer <s.hauer@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, Sean Wang <sean.wang@kernel.org>, Paul Cercueil <paul@crapouillou.net>, Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>, Bjorn Andersson <andersson@kernel.org>, Andy Gross <agross@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Emil Renner Berthing <kernel@esmil.dk>, Hal Feng <hal.feng@starfivetech.com> Subject: [PATCH v4 12/23] pinctrl: mediatek: Make use of PINCTRL_GROUP_DESC() Date: Wed, 29 Nov 2023 18:06:35 +0200 Message-ID: <20231129161459.1002323-13-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231129161459.1002323-1-andriy.shevchenko@linux.intel.com> References: <20231129161459.1002323-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 29 Nov 2023 08:16:47 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783915730860217333 X-GMAIL-MSGID: 1783915730860217333 |
Series |
pinctrl: Convert struct group_desc to use struct pingroup
|
|
Commit Message
Andy Shevchenko
Nov. 29, 2023, 4:06 p.m. UTC
Make use of PINCTRL_GROUP_DESC() instead of open coding it.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/mediatek/pinctrl-moore.h | 7 +------
drivers/pinctrl/mediatek/pinctrl-paris.h | 7 +------
2 files changed, 2 insertions(+), 12 deletions(-)
Comments
On 29.11.2023 17:06, Andy Shevchenko wrote: > Make use of PINCTRL_GROUP_DESC() instead of open coding it. > > Signed-off-by: Andy Shevchenko<andriy.shevchenko@linux.intel.com> This patch landed in linux-next as commit 1949e4630c3b ("pinctrl: mediatek: Make use of PINCTRL_GROUP_DESC()"). Unfortunately it causes a build break of ARM64 arch with standard defconfig. > --- > drivers/pinctrl/mediatek/pinctrl-moore.h | 7 +------ > drivers/pinctrl/mediatek/pinctrl-paris.h | 7 +------ > 2 files changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-moore.h b/drivers/pinctrl/mediatek/pinctrl-moore.h > index e1b4b82b9d3d..22ef1ffbcdcb 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-moore.h > +++ b/drivers/pinctrl/mediatek/pinctrl-moore.h > @@ -38,12 +38,7 @@ > } > > #define PINCTRL_PIN_GROUP(name, id) \ > - { \ > - name, \ > - id##_pins, \ > - ARRAY_SIZE(id##_pins), \ > - id##_funcs, \ > - } > + PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), id##_funcs) > int mtk_moore_pinctrl_probe(struct platform_device *pdev, > const struct mtk_pin_soc *soc); > diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.h b/drivers/pinctrl/mediatek/pinctrl-paris.h > index 8762ac599329..f208a904c4a8 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-paris.h > +++ b/drivers/pinctrl/mediatek/pinctrl-paris.h > @@ -50,12 +50,7 @@ > } > > #define PINCTRL_PIN_GROUP(name, id) \ > - { \ > - name, \ > - id##_pins, \ > - ARRAY_SIZE(id##_pins), \ > - id##_funcs, \ > - } > + PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), id##_funcs) > > int mtk_paris_pinctrl_probe(struct platform_device *pdev); PINCTRL_GROUP_DESC() macro from drivers/pinctrl/core.h contains a cast to (struct group_desc), what breaks users of the above macros. Best regards
On 04/12/2023 12:40, Marek Szyprowski wrote: > On 29.11.2023 17:06, Andy Shevchenko wrote: >> Make use of PINCTRL_GROUP_DESC() instead of open coding it. >> >> Signed-off-by: Andy Shevchenko<andriy.shevchenko@linux.intel.com> > > This patch landed in linux-next as commit 1949e4630c3b ("pinctrl: > mediatek: Make use of PINCTRL_GROUP_DESC()"). Unfortunately it causes a > build break of ARM64 arch with standard defconfig. Not only arm64, but also arm32. Defconfigs, so something completely standard. This wasn't compiled which is quite surprising because cross building defconfigs is trivial, not even mentioning testing your trees with LKP. :( https://lore.kernel.org/all/ed981149-5d96-43a9-9534-c1e52443a983@linaro.org/ Best regards, Krzysztof
On Mon, Dec 04, 2023 at 12:40:38PM +0100, Marek Szyprowski wrote: > On 29.11.2023 17:06, Andy Shevchenko wrote: > > Make use of PINCTRL_GROUP_DESC() instead of open coding it. > PINCTRL_GROUP_DESC() macro from drivers/pinctrl/core.h contains a cast > to (struct group_desc), what breaks users of the above macros. There is no cast (*). Thanks for report, I will check. But this was v4 of the series and LKP actually sent a positive feedback. Besides that I have tested this locally with modules enabled. *) It's a compound literal, _not_ a cast. Taking above into consideration I'm wondering what compilers are in use?
On 04/12/2023 14:10, Andy Shevchenko wrote: > On Mon, Dec 04, 2023 at 12:40:38PM +0100, Marek Szyprowski wrote: >> On 29.11.2023 17:06, Andy Shevchenko wrote: >>> Make use of PINCTRL_GROUP_DESC() instead of open coding it. > >> PINCTRL_GROUP_DESC() macro from drivers/pinctrl/core.h contains a cast >> to (struct group_desc), what breaks users of the above macros. > > There is no cast (*). > Thanks for report, I will check. > > But this was v4 of the series and LKP actually sent a positive feedback. > Besides that I have tested this locally with modules enabled. > > *) It's a compound literal, _not_ a cast. > Taking above into consideration I'm wondering what compilers > are in use? In my case: standard provided by Ubuntu 22.04, so: gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04) Best regards, Krzysztof
Hi Andy, On Mon, Dec 4, 2023 at 2:10 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Mon, Dec 04, 2023 at 12:40:38PM +0100, Marek Szyprowski wrote: > > On 29.11.2023 17:06, Andy Shevchenko wrote: > > > Make use of PINCTRL_GROUP_DESC() instead of open coding it. > > > PINCTRL_GROUP_DESC() macro from drivers/pinctrl/core.h contains a cast > > to (struct group_desc), what breaks users of the above macros. > > There is no cast (*). > Thanks for report, I will check. > > But this was v4 of the series and LKP actually sent a positive feedback. > Besides that I have tested this locally with modules enabled. > > *) It's a compound literal, _not_ a cast. > Taking above into consideration I'm wondering what compilers > are in use? kisskb reported the following m68k failures to me: linux-next/m68k-allmodconfig/m68k-gcc8 linux-next/m68k-allmodconfig/m68k-gcc11 linux-next/m68k-allmodconfig/m68k-gcc12 However, according to [1], linux-next/m68k-allmodconfig/m68k-gcc13 did succeed, so I guess you are using gcc13? [1] http://kisskb.ellerman.id.au/kisskb/head/629a3b49f3f957e975253c54846090b8d5ed2e9b/ Gr{oetje,eeting}s, Geert
On 04/12/2023 14:18, Krzysztof Kozlowski wrote: > On 04/12/2023 14:10, Andy Shevchenko wrote: >> On Mon, Dec 04, 2023 at 12:40:38PM +0100, Marek Szyprowski wrote: >>> On 29.11.2023 17:06, Andy Shevchenko wrote: >>>> Make use of PINCTRL_GROUP_DESC() instead of open coding it. >> >>> PINCTRL_GROUP_DESC() macro from drivers/pinctrl/core.h contains a cast >>> to (struct group_desc), what breaks users of the above macros. >> >> There is no cast (*). >> Thanks for report, I will check. >> >> But this was v4 of the series and LKP actually sent a positive feedback. >> Besides that I have tested this locally with modules enabled. >> >> *) It's a compound literal, _not_ a cast. >> Taking above into consideration I'm wondering what compilers >> are in use? > > In my case: standard provided by Ubuntu 22.04, so: gcc version 11.4.0 > (Ubuntu 11.4.0-1ubuntu1~22.04) This was from my local machine. The ones used on the server are mentioned in one of the steps: https://krzk.eu/#/builders/5/builds/2532/steps/5/logs/property_changes Best regards, Krzysztof
On Mon, Dec 04, 2023 at 02:19:10PM +0100, Geert Uytterhoeven wrote: > Hi Andy, > > On Mon, Dec 4, 2023 at 2:10 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Dec 04, 2023 at 12:40:38PM +0100, Marek Szyprowski wrote: > > > On 29.11.2023 17:06, Andy Shevchenko wrote: > > > > Make use of PINCTRL_GROUP_DESC() instead of open coding it. > > > > > PINCTRL_GROUP_DESC() macro from drivers/pinctrl/core.h contains a cast > > > to (struct group_desc), what breaks users of the above macros. > > > > There is no cast (*). > > Thanks for report, I will check. > > > > But this was v4 of the series and LKP actually sent a positive feedback. > > Besides that I have tested this locally with modules enabled. > > > > *) It's a compound literal, _not_ a cast. > > Taking above into consideration I'm wondering what compilers > > are in use? > > kisskb reported the following m68k failures to me: > linux-next/m68k-allmodconfig/m68k-gcc8 > linux-next/m68k-allmodconfig/m68k-gcc11 > linux-next/m68k-allmodconfig/m68k-gcc12 > > However, according to [1], linux-next/m68k-allmodconfig/m68k-gcc13 > did succeed, so I guess you are using gcc13? Yes, I compiled with these: $ gcc --version gcc (Debian 13.2.0-5) 13.2.0 Copyright (C) 2023 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ clang --version Debian clang version 16.0.6 (16) Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin
Hi Andy, On Mon, Dec 4, 2023 at 2:32 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Mon, Dec 04, 2023 at 02:19:10PM +0100, Geert Uytterhoeven wrote: > > On Mon, Dec 4, 2023 at 2:10 PM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > On Mon, Dec 04, 2023 at 12:40:38PM +0100, Marek Szyprowski wrote: > > > > On 29.11.2023 17:06, Andy Shevchenko wrote: > > > > > Make use of PINCTRL_GROUP_DESC() instead of open coding it. > > > > > > > PINCTRL_GROUP_DESC() macro from drivers/pinctrl/core.h contains a cast > > > > to (struct group_desc), what breaks users of the above macros. > > > > > > There is no cast (*). > > > Thanks for report, I will check. > > > > > > But this was v4 of the series and LKP actually sent a positive feedback. > > > Besides that I have tested this locally with modules enabled. > > > > > > *) It's a compound literal, _not_ a cast. > > > Taking above into consideration I'm wondering what compilers > > > are in use? > > > > kisskb reported the following m68k failures to me: > > linux-next/m68k-allmodconfig/m68k-gcc8 > > linux-next/m68k-allmodconfig/m68k-gcc11 > > linux-next/m68k-allmodconfig/m68k-gcc12 > > > > However, according to [1], linux-next/m68k-allmodconfig/m68k-gcc13 > > did succeed, so I guess you are using gcc13? > > Yes, I compiled with these: > > $ gcc --version > gcc (Debian 13.2.0-5) 13.2.0 Time to install and try an older version ;-) Gr{oetje,eeting}s, Geert
On Mon, Dec 04, 2023 at 02:39:37PM +0100, Geert Uytterhoeven wrote: > On Mon, Dec 4, 2023 at 2:32 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Dec 04, 2023 at 02:19:10PM +0100, Geert Uytterhoeven wrote: > > > On Mon, Dec 4, 2023 at 2:10 PM Andy Shevchenko > > > <andriy.shevchenko@linux.intel.com> wrote: > > > > On Mon, Dec 04, 2023 at 12:40:38PM +0100, Marek Szyprowski wrote: > > > > > On 29.11.2023 17:06, Andy Shevchenko wrote: > > > > > > Make use of PINCTRL_GROUP_DESC() instead of open coding it. > > > > > > > > > PINCTRL_GROUP_DESC() macro from drivers/pinctrl/core.h contains a cast > > > > > to (struct group_desc), what breaks users of the above macros. > > > > > > > > There is no cast (*). > > > > Thanks for report, I will check. > > > > > > > > But this was v4 of the series and LKP actually sent a positive feedback. > > > > Besides that I have tested this locally with modules enabled. > > > > > > > > *) It's a compound literal, _not_ a cast. > > > > Taking above into consideration I'm wondering what compilers > > > > are in use? > > > > > > kisskb reported the following m68k failures to me: > > > linux-next/m68k-allmodconfig/m68k-gcc8 > > > linux-next/m68k-allmodconfig/m68k-gcc11 > > > linux-next/m68k-allmodconfig/m68k-gcc12 > > > > > > However, according to [1], linux-next/m68k-allmodconfig/m68k-gcc13 > > > did succeed, so I guess you are using gcc13? > > > > Yes, I compiled with these: > > > > $ gcc --version > > gcc (Debian 13.2.0-5) 13.2.0 > > Time to install and try an older version ;-) Yeah, compound literals seems the often-to-break topic (as per GCC bugzilla). Tried with GCC 8 for ARM64 and indeed it doesn't build it well.
diff --git a/drivers/pinctrl/mediatek/pinctrl-moore.h b/drivers/pinctrl/mediatek/pinctrl-moore.h index e1b4b82b9d3d..22ef1ffbcdcb 100644 --- a/drivers/pinctrl/mediatek/pinctrl-moore.h +++ b/drivers/pinctrl/mediatek/pinctrl-moore.h @@ -38,12 +38,7 @@ } #define PINCTRL_PIN_GROUP(name, id) \ - { \ - name, \ - id##_pins, \ - ARRAY_SIZE(id##_pins), \ - id##_funcs, \ - } + PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), id##_funcs) int mtk_moore_pinctrl_probe(struct platform_device *pdev, const struct mtk_pin_soc *soc); diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.h b/drivers/pinctrl/mediatek/pinctrl-paris.h index 8762ac599329..f208a904c4a8 100644 --- a/drivers/pinctrl/mediatek/pinctrl-paris.h +++ b/drivers/pinctrl/mediatek/pinctrl-paris.h @@ -50,12 +50,7 @@ } #define PINCTRL_PIN_GROUP(name, id) \ - { \ - name, \ - id##_pins, \ - ARRAY_SIZE(id##_pins), \ - id##_funcs, \ - } + PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), id##_funcs) int mtk_paris_pinctrl_probe(struct platform_device *pdev);