diff mbox series

dt-bindings: iio/adc: ti,palmas-gpadc: Drop incomplete example

Message ID 20231128214803.3975542-1-robh@kernel.org
State New
Headers
Series dt-bindings: iio/adc: ti,palmas-gpadc: Drop incomplete example |

Commit Message

Rob Herring Nov. 28, 2023, 9:48 p.m. UTC 
  The example for the TI Palmas ADC is incomplete as the binding is the
full PMIC, not just the sub-functions. It is preferred for MFD examples
to be complete in the top-level MFD device binding rather than piecemeal
in each sub-function binding.

This also fixes an undocumented (by schema) compatible warning for
'"ti,twl6035-pmic", "ti,palmas-pmic"'.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/iio/adc/ti,palmas-gpadc.yaml         | 15 ---------------
 1 file changed, 15 deletions(-)

Comments

Krzysztof Kozlowski Nov. 29, 2023, 8:30 a.m. UTC | #1 
On 28/11/2023 22:48, Rob Herring wrote:
> The example for the TI Palmas ADC is incomplete as the binding is the
> full PMIC, not just the sub-functions. It is preferred for MFD examples
> to be complete in the top-level MFD device binding rather than piecemeal
> in each sub-function binding.
> 
> This also fixes an undocumented (by schema) compatible warning for
> '"ti,twl6035-pmic", "ti,palmas-pmic"'.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Jonathan Cameron Dec. 4, 2023, 1:23 p.m. UTC | #2 
On Wed, 29 Nov 2023 09:30:23 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 28/11/2023 22:48, Rob Herring wrote:
> > The example for the TI Palmas ADC is incomplete as the binding is the
> > full PMIC, not just the sub-functions. It is preferred for MFD examples
> > to be complete in the top-level MFD device binding rather than piecemeal
> > in each sub-function binding.
> > 
> > This also fixes an undocumented (by schema) compatible warning for
> > '"ti,twl6035-pmic", "ti,palmas-pmic"'.
> > 
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---  
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 

Applied to the togreg branch of iio.git and pushed out as testing
for all the normal reasons.

Thanks,

Jonathan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
index 720c16a108d4..f94057d8f605 100644
--- a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
@@ -67,19 +67,4 @@  required:
   - compatible
   - "#io-channel-cells"
 
-examples:
-  - |
-    #include <dt-bindings/clock/mt8183-clk.h>
-    pmic {
-        compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
-        adc {
-            compatible = "ti,palmas-gpadc";
-            interrupts = <18 0>,
-                         <16 0>,
-                         <17 0>;
-            #io-channel-cells = <1>;
-            ti,channel0-current-microamp = <5>;
-            ti,channel3-current-microamp = <10>;
-        };
-    };
 ...