Message ID | 20231204-msm8916-blsp-dma-remote-v1-1-3e49c8838c8d@gerhold.net |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2666131vqy; Mon, 4 Dec 2023 02:22:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IHT9K7JtlqpgbhqxyW85dX6V9UgliDxVHfYJtZlnH9GvxkmOZ9qwlENRzONIdYgmYNhsiT5 X-Received: by 2002:a05:6a20:230e:b0:18f:97c:978a with SMTP id n14-20020a056a20230e00b0018f097c978amr3625880pzc.114.1701685335404; Mon, 04 Dec 2023 02:22:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1701685335; cv=pass; d=google.com; s=arc-20160816; b=XZAkj4f18IbAFAQ5JyXLvhY3eFLNLib/f9ejAfD7l8Ly0R15h2nARaAFz0mIK5QZPE W8FOFgqhfB+HvLOC1y+mo6lNPyWV/zMiXVCzArKX453zdCa/Szxqmo3Gyu9uA90MNSnM hiDF9hDEFHvqRurzzOYRJh1KrJsrrSEsy3gLYIbhtD+OQsbOdAvqxbBvn1Mbolv1hzzp jMC+3MQtE2+6LqPdnGKzBg2l4I3gE95MIXakhFQcXSJNyK2VLtikCEuSPiDTT12Ay5wC lZmLNQFbtK/+2WI1ijqkV1yunAkfoiMiyPXdOGBIQ/11yr5nV/D58WJN5BwtSY+700Fa COQQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature:dkim-signature; bh=uj1QzN6J5pFbgGdmuZdH8PeMQa0Jc71qDrizP07VFLg=; fh=WU4onb5zTy7IBgVB9TEyVX5gCt4JbOwFC/RThck7mG4=; b=tCkFEPfisB3Ya9AZBl92JknHbXSBhsOU4a0wvsfXMvFq72WdxSZtXTHFY6CCw9EMPz 8BV7CPDetOwqTWOGYy9Ct7/CnUAu8ockVuTzcn+EOxrHBZfcXrZLxLO4NIxcc9xu9EKh eMPES+dV+c2hva9VKhV5get2z7vvis9ItJOTSfdnakr7gGh+PnxJkgW2lzHEEW7uV6DJ ePRO6qZ0vGFok4eANSLjTONxXWGKoACqWNRvzK1wfCuMlVX6asvZ0b9xD4kJHj2303/c eHzoyXEaJtMECSLFK5hb0Z9abklYif+Ca9lSAVL/8G4osM/+zc7ljsOzpHpSzYXmhnR9 1doQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gerhold.net header.s=strato-dkim-0002 header.b="UJPPDA/8"; dkim=neutral (no key) header.i=@gerhold.net header.s=strato-dkim-0003 header.b="/b8+AmJ2"; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id q145-20020a632a97000000b005a9b0fe6afbsi7757661pgq.144.2023.12.04.02.22.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 02:22:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@gerhold.net header.s=strato-dkim-0002 header.b="UJPPDA/8"; dkim=neutral (no key) header.i=@gerhold.net header.s=strato-dkim-0003 header.b="/b8+AmJ2"; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id C985B805FB88; Mon, 4 Dec 2023 02:22:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343919AbjLDKVq (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Mon, 4 Dec 2023 05:21:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234819AbjLDKV3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 4 Dec 2023 05:21:29 -0500 Received: from mo4-p02-ob.smtp.rzone.de (mo4-p02-ob.smtp.rzone.de [81.169.146.169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45C8BF3; Mon, 4 Dec 2023 02:21:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701685291; cv=none; d=strato.com; s=strato-dkim-0002; b=AyvJ6jYRFtDQIWlWMGeO2vijKT0bbAVc5Zi2Myf/0/vysRh6Hd9Lly8u9WwDjfYWxd 1sHGZCESVQuyHhyJlkHA+bCEku2QjMO8tPvCl+0ERzNsC0MF8WFSqocuD0/W5FPYopbr mrWxoJ+pwXN9jA+ZgghCK3Er7KY3Me02a5s4NsWpyDOT//1Qf7m33ekDXKbUvsZ5jWR5 o4JDGcTfviH8agYvhcHce6iLO9hwT+gThVZuR6zxhFIdM40Ec5ZRbCBL93szmMK3vw86 uvNaG7SrEHcoZ/C2bLXaLGX3xBJ8qnTBJSotzu2Rq9Y7OzI6mn06Mcr8QMwdxiSJSKjP VZSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1701685291; s=strato-dkim-0002; d=strato.com; h=Cc:To:In-Reply-To:References:Message-Id:Subject:Date:From:Cc:Date: From:Subject:Sender; bh=uj1QzN6J5pFbgGdmuZdH8PeMQa0Jc71qDrizP07VFLg=; b=SBG1zuzr8U4YRptKR7yoWIxW2jK3TSjTFsAkdcYcsZQ5oh0Pk358XD6g6ORivKMAIS Z61S0et38J/PD7LagsSACq+mg2XO5qbal8pVZOn5wQ90VVhIG/4NZNSfBaR5Ypqt6PDy 52Lt9QSEkAq15Ixu7//beHADX+1LQgoNqPChj81V3578Xczg8qLrY5weLqGcXO1/+iOI j72ULt0TSgcKGZl2svA5kbHyQoQDti+QJSqENjtCDCsesBO1cm+8aUjWUVdaK/r1S5/K 4GsPBOaQ4KejJqcY16RW9cougFftGrv6qmnNJB2gRDiIEhW+NbaTgy9F1Zj0jz3WVhie bh4g== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1701685291; s=strato-dkim-0002; d=gerhold.net; h=Cc:To:In-Reply-To:References:Message-Id:Subject:Date:From:Cc:Date: From:Subject:Sender; bh=uj1QzN6J5pFbgGdmuZdH8PeMQa0Jc71qDrizP07VFLg=; b=UJPPDA/8j3b6Dt23C41dFpc9rQkNkpaKSC27i0nL3ZCJ1jVWoj1ZE/Vp5rdeMtK0KI DL5hPdwpxjGalBpXUVo6W7v3idhXb5LoMssIhKN1e2FcS+Xd2aBflGpzIjXKwB6/O6+I z1H87xD5O2RlOmhfJ4Zc5sf2Z1pkuiVnPd4cSnXPA70fw5lweV6e8BTlbptQ/oU1L8xy mRzrlW0JC4+jppR8Ip7oqhe78W+fV5klEuP951jkbxaoqBi4e06Xo1DgckMbwpHW9zw8 LASiYMBJ83HHNXvEahdK9zgwm1seLXetZTT9600wvj3V00NNAPj0IjWbgNKWGOJ0GQ3q 2oig== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1701685291; s=strato-dkim-0003; d=gerhold.net; h=Cc:To:In-Reply-To:References:Message-Id:Subject:Date:From:Cc:Date: From:Subject:Sender; bh=uj1QzN6J5pFbgGdmuZdH8PeMQa0Jc71qDrizP07VFLg=; b=/b8+AmJ2mdBGRGmg/8TZ0kT/6Wx9lOMWDBmN2wCDzW4z7VDEDN6PY+lTyciWn5mPnT ukQSOLBTE8C/g0D477Dw== X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQjVd4CteZ/7jYgS+mLFY+H0JAn8u4l+/zY=" Received: from [192.168.244.3] by smtp.strato.de (RZmta 49.9.7 DYNA|AUTH) with ESMTPSA id R5487bzB4ALVA1x (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 4 Dec 2023 11:21:31 +0100 (CET) From: Stephan Gerhold <stephan@gerhold.net> Date: Mon, 04 Dec 2023 11:21:20 +0100 Subject: [PATCH 1/2] arm64: dts: qcom: msm8916: Make blsp_dma controlled-remotely MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231204-msm8916-blsp-dma-remote-v1-1-3e49c8838c8d@gerhold.net> References: <20231204-msm8916-blsp-dma-remote-v1-0-3e49c8838c8d@gerhold.net> In-Reply-To: <20231204-msm8916-blsp-dma-remote-v1-0-3e49c8838c8d@gerhold.net> To: Bjorn Andersson <andersson@kernel.org> Cc: Andy Gross <agross@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Bryan O'Donoghue <bryan.odonoghue@linaro.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stephan Gerhold <stephan@gerhold.net>, stable@vger.kernel.org X-Mailer: b4 0.12.4 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 04 Dec 2023 02:22:13 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784346402212750235 X-GMAIL-MSGID: 1784346402212750235 |
Series |
arm64: dts: qcom: msm8916/39: Make blsp_dma controlled-remotely
|
|
Commit Message
Stephan Gerhold
Dec. 4, 2023, 10:21 a.m. UTC
The blsp_dma controller is shared between the different subsystems,
which is why it is already initialized by the firmware. We should not
reinitialize it from Linux to avoid potential other users of the DMA
engine to misbehave.
In mainline this can be described using the "qcom,controlled-remotely"
property. In the downstream/vendor kernel from Qualcomm there is an
opposite "qcom,managed-locally" property. This property is *not* set
for the qcom,sps-dma@7884000 [1] so adding "qcom,controlled-remotely"
upstream matches the behavior of the downstream/vendor kernel.
Adding this seems to fix some weird issues with UART where both
input/output becomes garbled with certain obscure firmware versions on
some devices.
[1]: https://git.codelinaro.org/clo/la/kernel/msm-3.10/-/blob/LA.BR.1.2.9.1-02310-8x16.0/arch/arm/boot/dts/qcom/msm8916.dtsi#L1466-1472
Cc: <stable@vger.kernel.org> # 6.5
Fixes: a0e5fb103150 ("arm64: dts: qcom: Add msm8916 BLSP device nodes")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
This should only be backported to v6.5+ since it depends on commit
8975dd41a9db ("dmaengine: qcom: bam_dma: allow omitting
num-{channels,ees}") which landed in v6.5.
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 +
1 file changed, 1 insertion(+)
Comments
On 04/12/2023 11:21, Stephan Gerhold wrote: > The blsp_dma controller is shared between the different subsystems, > which is why it is already initialized by the firmware. We should not > reinitialize it from Linux to avoid potential other users of the DMA > engine to misbehave. > > In mainline this can be described using the "qcom,controlled-remotely" > property. In the downstream/vendor kernel from Qualcomm there is an > opposite "qcom,managed-locally" property. This property is *not* set > for the qcom,sps-dma@7884000 [1] so adding "qcom,controlled-remotely" > upstream matches the behavior of the downstream/vendor kernel. > > Adding this seems to fix some weird issues with UART where both > input/output becomes garbled with certain obscure firmware versions on > some devices. > > [1]: https://git.codelinaro.org/clo/la/kernel/msm-3.10/-/blob/LA.BR.1.2.9.1-02310-8x16.0/arch/arm/boot/dts/qcom/msm8916.dtsi#L1466-1472 > > Cc: <stable@vger.kernel.org> # 6.5 > Fixes: a0e5fb103150 ("arm64: dts: qcom: Add msm8916 BLSP device nodes") > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > --- > This should only be backported to v6.5+ since it depends on commit > 8975dd41a9db ("dmaengine: qcom: bam_dma: allow omitting > num-{channels,ees}") which landed in v6.5. > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index e8a14dd7e7c2..7f8327b0dbdb 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -2155,6 +2155,7 @@ blsp_dma: dma-controller@7884000 { > clock-names = "bam_clk"; > #dma-cells = <1>; > qcom,ee = <0>; > + qcom,controlled-remotely; > }; > > blsp_uart1: serial@78af000 { > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index e8a14dd7e7c2..7f8327b0dbdb 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -2155,6 +2155,7 @@ blsp_dma: dma-controller@7884000 { clock-names = "bam_clk"; #dma-cells = <1>; qcom,ee = <0>; + qcom,controlled-remotely; }; blsp_uart1: serial@78af000 {