Message ID | 20231202211554.2319770-1-christoph.muellner@vrull.eu |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1958630vqy; Sat, 2 Dec 2023 13:16:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IH8PJabz5fuMLOmxSs0plW5YJGFOAHmAvptrXWIboCcRkQm6cCZ4gwf4bXECtEmMfbSK8Ur X-Received: by 2002:a05:620a:4882:b0:77e:fba4:3a2f with SMTP id ea2-20020a05620a488200b0077efba43a2fmr2549289qkb.133.1701551789703; Sat, 02 Dec 2023 13:16:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1701551789; cv=pass; d=google.com; s=arc-20160816; b=1I80Bxy2wS+OP88ftO9GeDKtDwJ7y+zkSGoeHTsHY83soZ3va1YG08fBP6AGCW2s42 06/IhL0JBj6F/oMtoWr8IAFoK/v/hjVrj9Omrd+jnAjfmUgnRBn6L0PhLsrQtdVDNYDR 1TS2vEdyWPQ2R2qBRJHOfdFx+3QpogFeiJpqi0PTLwY9ZlcUBtqNWykjY4CvrBZQMKec xGiblKRK248GVzgMYo+zwcucEAe9cVzaofq+7iA3lsdskqRI94IyaHlpShZ7ZZT4umZE jU+/ZkUDAedBxZMEz8Sh/AJd9CFRpkEAkwwKEr2Ob6aIfSPatkxWVWiE63JCxmeBTv/l 5lPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=/WWe5gc6rkNGzTBjsubk1NlNLe1eyqiPesW4T3RIb6U=; fh=SOte8hLOvFJ3lpu7w3ocz2TE+sBbg8do/Qj4UBHSXP0=; b=yvwkproNRjwdaSeo4DfrjRAL4C8i65CoOl778qnIeMFHPaWI1KGT+xBnvD7zobuC4u 79BTcM2IQeoGBKxnoPMJUEIgeUuhtpZLjfSzsPzcnYdoO290g1n+SgTE+53hsplDYqCU 6TDUuxSjmcuhHkc4hx0EUy/b51CSWayx7s3xX/tnzA+jtRhR1t+iwlfWw/P5zvEislBX VBMPsR7xfAZocUrYzi7/ZO3o+QeG+/27XggkpI0Q7qucxjntkgnsC6j+ZxpTZwQk5vYq HoEwYEyO6N7BAfSdWoeSBZA9hjq0z787Fk3WYnvCJ05xt/VMDc5A4Ak4teyii7cV1bu8 gYSw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vrull.eu header.s=google header.b="Us8mVX/Y"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=vrull.eu Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id h7-20020a05620a400700b0077dbdba7e72si6489631qko.377.2023.12.02.13.16.29 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 13:16:29 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@vrull.eu header.s=google header.b="Us8mVX/Y"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=vrull.eu Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 75E0A385AC21 for <ouuuleilei@gmail.com>; Sat, 2 Dec 2023 21:16:29 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id 098DD3858D33 for <gcc-patches@gcc.gnu.org>; Sat, 2 Dec 2023 21:16:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 098DD3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 098DD3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701551766; cv=none; b=AizDrCOFHizwt4Jrg1JxpslBKrQMv757U8qsew4jRkyxYpUF8DnMpcz1wY6ieyNWLxJTSnqrvUbb+VwvtN2lWwHBbA+dUClxs+SyMRq65m939zqjA1ZnFubKoFQk4Itk1RWiKcktWsMsY2dTpvhTg+OAAxJRlAvUm2IPscGpjS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701551766; c=relaxed/simple; bh=z8mrTFIJtYHP5I3PWNYpztzAArpSTdCNEdPb/SRwba0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=db7ndoSl4fXPKQuO1ZJwUGb7dVgB7XCNzUlforqPRib/Vaq5uKX3aNzT+UMoXzykRB/ErRlhT7vD5plkIh8AMpI9IxJN+ghEH4/6bLLHwDqBBCZGTOxcOowsZJznhjTe5EtIDDQwU/GXr6ek+x6+nxlq7rIPdN/Gund/H/E+qWo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-50abbb23122so4572391e87.3 for <gcc-patches@gcc.gnu.org>; Sat, 02 Dec 2023 13:16:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1701551760; x=1702156560; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/WWe5gc6rkNGzTBjsubk1NlNLe1eyqiPesW4T3RIb6U=; b=Us8mVX/YkZflWGBQpgjln4Jk7EQtmOW36ky2EDU6khxhZyaNLmHLZddFoO66WU5XJF G4pC/r6uQwxNWEysH5erVcWYXlBmR43OGxtGWsPNWceI2AoGbdm2LidVFp/oE5ItF2XJ bTA1ncB9u4BP6DTG/fbc5JUN/gpFkqJd6opbrHiyYc1YJDQoUtO4NpfTkz2jF5W39AsJ A9h3tqxcpaNdYAdIYYrtaDx64dGaq4MCHQCDZqaw7aIyuxrAqlzZTm2lYZVARWI93OBz CUFAq9HcxBfq9jz7gAE29BiTf3IkELbt//2pkOVvzRFczYLKdhrj01GtMd/hGCRovAUS XVkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701551760; x=1702156560; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/WWe5gc6rkNGzTBjsubk1NlNLe1eyqiPesW4T3RIb6U=; b=SZgwqIOQeLBLHPVrvSKdoEw/x1IappYvWXU53pHoEa64G/4svQiGONyleGwRbQXg6p Tur5BKZWuBcHBSAgX8wmzNI9gilivzNbNGjIzM3/z6xqaq+inmfnJ406ScbJqmd6Xq7V 70IDy/fxw/IRmcI3zaD+a1VqlLWdFlN651MapAHVmE1MjjGvPnR4nJW21DYwSN1f1eZ6 O3oKHk6gzsPEpI1kphCC0LUncUiVfQBRQDBT7iaa+0pKaxEXO/Fhs19AlhwUUD6szi3x urcMv2nTYWX7zz4/QDPSJ+StHuCEr3ZhEGVf3quART9dJ8tERfY8gN68CGsw91TZHz7U 5z4Q== X-Gm-Message-State: AOJu0Yw+Z71Wau/6yaIVP1oR0pMOVIlN7sIKVznpUfgVhXgMqlAydBoH Wn8r2IcuQpHQ2a50CmteCEcQ9ZOx7iTvZtjDZKNO9w== X-Received: by 2002:a19:c514:0:b0:50b:f15d:1eac with SMTP id w20-20020a19c514000000b0050bf15d1eacmr80878lfe.4.1701551758801; Sat, 02 Dec 2023 13:15:58 -0800 (PST) Received: from beast.fritz.box (62-178-148-172.cable.dynamic.surfer.at. [62.178.148.172]) by smtp.gmail.com with ESMTPSA id cf5-20020a0564020b8500b0054c4db03b9dsm2164469edb.30.2023.12.02.13.15.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 13:15:57 -0800 (PST) From: =?utf-8?q?Christoph_M=C3=BCllner?= <christoph.muellner@vrull.eu> To: gcc-patches@gcc.gnu.org, Kito Cheng <kito.cheng@sifive.com>, Jim Wilson <jim.wilson.gcc@gmail.com>, Palmer Dabbelt <palmer@dabbelt.com>, Andrew Waterman <andrew@sifive.com>, Philipp Tomsich <philipp.tomsich@vrull.eu>, Jeff Law <jeffreyalaw@gmail.com>, Jeremy Bennett <jeremy.bennett@embecosm.com> Cc: =?utf-8?q?Christoph_M=C3=BCllner?= <christoph.muellner@vrull.eu> Subject: [PATCH] RISC-V: Document optimization parameter riscv-strcmp-inline-limit Date: Sat, 2 Dec 2023 22:15:54 +0100 Message-ID: <20231202211554.2319770-1-christoph.muellner@vrull.eu> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_MANYTO, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784206369673790238 X-GMAIL-MSGID: 1784206369673790238 |
Series |
RISC-V: Document optimization parameter riscv-strcmp-inline-limit
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Christoph Müllner
Dec. 2, 2023, 9:15 p.m. UTC
This patch documents the optimization parameter
riscv-strcmp-inline-limit, which can be used to tweak the behaviour
of -minline-strcmp and -minline-strncmp.
gcc/ChangeLog:
PR target/112650
* doc/invoke.texi: Document riscv-strcmp-inline-limit.
Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
---
gcc/doc/invoke.texi | 8 ++++++++
1 file changed, 8 insertions(+)
Comments
LGTM On Sun, Dec 3, 2023 at 5:16 AM Christoph Müllner < christoph.muellner@vrull.eu> wrote: > This patch documents the optimization parameter > riscv-strcmp-inline-limit, which can be used to tweak the behaviour > of -minline-strcmp and -minline-strncmp. > > gcc/ChangeLog: > > PR target/112650 > * doc/invoke.texi: Document riscv-strcmp-inline-limit. > > Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu> > --- > gcc/doc/invoke.texi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > index 2fab4c5d71f..ba2d843b484 100644 > --- a/gcc/doc/invoke.texi > +++ b/gcc/doc/invoke.texi > @@ -29846,6 +29846,10 @@ Inlining will only be done if the strings are > properly aligned > and instructions for accelerated processing are available. > The default is to not inline strcmp calls. > > +The @option{--param riscv-strcmp-inline-limit=@{n}} parameter controls > +the maximum number of bytes compared by the inlined code. > +The default value is 64. > + > @opindex minline-strncmp > @item -minline-strncmp > @itemx -mno-inline-strncmp > @@ -29854,6 +29858,10 @@ Inlining will only be done if the strings are > properly aligned > and instructions for accelerated processing are available. > The default is to not inline strncmp calls. > > +The @option{--param riscv-strcmp-inline-limit=@{n}} parameter controls > +the maximum number of bytes compared by the inlined code. > +The default value is 64. > + > @opindex mshorten-memrefs > @item -mshorten-memrefs > @itemx -mno-shorten-memrefs > -- > 2.41.0 > >
Wait, I got this on my machine? ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/doc/invoke.texi:29774: misplaced } ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/doc/invoke.texi:29786: misplaced } On Mon, Dec 4, 2023 at 10:43 AM Kito Cheng <kito.cheng@gmail.com> wrote: > > LGTM > > On Sun, Dec 3, 2023 at 5:16 AM Christoph Müllner <christoph.muellner@vrull.eu> wrote: >> >> This patch documents the optimization parameter >> riscv-strcmp-inline-limit, which can be used to tweak the behaviour >> of -minline-strcmp and -minline-strncmp. >> >> gcc/ChangeLog: >> >> PR target/112650 >> * doc/invoke.texi: Document riscv-strcmp-inline-limit. >> >> Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu> >> --- >> gcc/doc/invoke.texi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi >> index 2fab4c5d71f..ba2d843b484 100644 >> --- a/gcc/doc/invoke.texi >> +++ b/gcc/doc/invoke.texi >> @@ -29846,6 +29846,10 @@ Inlining will only be done if the strings are properly aligned >> and instructions for accelerated processing are available. >> The default is to not inline strcmp calls. >> >> +The @option{--param riscv-strcmp-inline-limit=@{n}} parameter controls >> +the maximum number of bytes compared by the inlined code. >> +The default value is 64. >> + >> @opindex minline-strncmp >> @item -minline-strncmp >> @itemx -mno-inline-strncmp >> @@ -29854,6 +29858,10 @@ Inlining will only be done if the strings are properly aligned >> and instructions for accelerated processing are available. >> The default is to not inline strncmp calls. >> >> +The @option{--param riscv-strcmp-inline-limit=@{n}} parameter controls >> +the maximum number of bytes compared by the inlined code. >> +The default value is 64. >> + >> @opindex mshorten-memrefs >> @item -mshorten-memrefs >> @itemx -mno-shorten-memrefs >> -- >> 2.41.0 >>
On Mon, Dec 4, 2023 at 4:46 AM Kito Cheng <kito.cheng@gmail.com> wrote: > > Wait, I got this on my machine? > > ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/doc/invoke.texi:29774: misplaced } > ../../../../riscv-gnu-toolchain-trunk/gcc/gcc/doc/invoke.texi:29786: misplaced } @{n} should be @var{n}. I was too optimistic and sent the patch before the build finished (or in this case failed). Sorry for that. I have sent a v2 that builds fine: https://gcc.gnu.org/pipermail/gcc-patches/2023-December/639142.html > > > On Mon, Dec 4, 2023 at 10:43 AM Kito Cheng <kito.cheng@gmail.com> wrote: > > > > LGTM > > > > On Sun, Dec 3, 2023 at 5:16 AM Christoph Müllner <christoph.muellner@vrull.eu> wrote: > >> > >> This patch documents the optimization parameter > >> riscv-strcmp-inline-limit, which can be used to tweak the behaviour > >> of -minline-strcmp and -minline-strncmp. > >> > >> gcc/ChangeLog: > >> > >> PR target/112650 > >> * doc/invoke.texi: Document riscv-strcmp-inline-limit. > >> > >> Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu> > >> --- > >> gcc/doc/invoke.texi | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > >> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > >> index 2fab4c5d71f..ba2d843b484 100644 > >> --- a/gcc/doc/invoke.texi > >> +++ b/gcc/doc/invoke.texi > >> @@ -29846,6 +29846,10 @@ Inlining will only be done if the strings are properly aligned > >> and instructions for accelerated processing are available. > >> The default is to not inline strcmp calls. > >> > >> +The @option{--param riscv-strcmp-inline-limit=@{n}} parameter controls > >> +the maximum number of bytes compared by the inlined code. > >> +The default value is 64. > >> + > >> @opindex minline-strncmp > >> @item -minline-strncmp > >> @itemx -mno-inline-strncmp > >> @@ -29854,6 +29858,10 @@ Inlining will only be done if the strings are properly aligned > >> and instructions for accelerated processing are available. > >> The default is to not inline strncmp calls. > >> > >> +The @option{--param riscv-strcmp-inline-limit=@{n}} parameter controls > >> +the maximum number of bytes compared by the inlined code. > >> +The default value is 64. > >> + > >> @opindex mshorten-memrefs > >> @item -mshorten-memrefs > >> @itemx -mno-shorten-memrefs > >> -- > >> 2.41.0 > >>
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 2fab4c5d71f..ba2d843b484 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -29846,6 +29846,10 @@ Inlining will only be done if the strings are properly aligned and instructions for accelerated processing are available. The default is to not inline strcmp calls. +The @option{--param riscv-strcmp-inline-limit=@{n}} parameter controls +the maximum number of bytes compared by the inlined code. +The default value is 64. + @opindex minline-strncmp @item -minline-strncmp @itemx -mno-inline-strncmp @@ -29854,6 +29858,10 @@ Inlining will only be done if the strings are properly aligned and instructions for accelerated processing are available. The default is to not inline strncmp calls. +The @option{--param riscv-strcmp-inline-limit=@{n}} parameter controls +the maximum number of bytes compared by the inlined code. +The default value is 64. + @opindex mshorten-memrefs @item -mshorten-memrefs @itemx -mno-shorten-memrefs