diff mbox series

testsuite: Tweak some further tests for modern C changes

Message ID ZWnDFz+FcrkpsHzE@tucnak
State Unresolved
Headers
Series testsuite: Tweak some further tests for modern C changes |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Jakub Jelinek Dec. 1, 2023, 11:27 a.m. UTC 
  Hi!

On IRC Richi mentioned some FAILs in gcc.target/x86_64 and in pr83126.c.

The following patch fixes the former ones (they need recent binutils to
be enabled), for pr83126.c because I didn't have graphite configured I've
just verified that the test compiles (didn't without the patch) and that
the gimple dump is identical with one from yesterday's gcc (as it was a
tree-parloops.cc ICE, I guess identical gimple is all we care about
and no need to verify it further).

Ok for trunk?

2023-12-01  Jakub Jelinek  <jakub@redhat.com>

	* gcc.target/x86_64/abi/avx512fp16/m512h/test_passing_m512.c
	(fun_check_passing_m512_8_values, fun_check_passing_m512h_8_values):
	Add missing void return type.
	* gcc.target/x86_64/abi/avx512fp16/m256h/test_passing_m256.c
	(fun_check_passing_m256_8_values, fun_check_passing_m256h_8_values):
	Likewise.
	* gcc.dg/graphite/pr83126.c (ew): Add missing casts to __INTPTR_TYPE__
	and then to int *.


	Jakub

Comments

Richard Biener Dec. 1, 2023, 11:24 a.m. UTC | #1 
On Fri, 1 Dec 2023, Jakub Jelinek wrote:

> Hi!
> 
> On IRC Richi mentioned some FAILs in gcc.target/x86_64 and in pr83126.c.
> 
> The following patch fixes the former ones (they need recent binutils to
> be enabled), for pr83126.c because I didn't have graphite configured I've
> just verified that the test compiles (didn't without the patch) and that
> the gimple dump is identical with one from yesterday's gcc (as it was a
> tree-parloops.cc ICE, I guess identical gimple is all we care about
> and no need to verify it further).
> 
> Ok for trunk?

OK.

Richard.

> 2023-12-01  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* gcc.target/x86_64/abi/avx512fp16/m512h/test_passing_m512.c
> 	(fun_check_passing_m512_8_values, fun_check_passing_m512h_8_values):
> 	Add missing void return type.
> 	* gcc.target/x86_64/abi/avx512fp16/m256h/test_passing_m256.c
> 	(fun_check_passing_m256_8_values, fun_check_passing_m256h_8_values):
> 	Likewise.
> 	* gcc.dg/graphite/pr83126.c (ew): Add missing casts to __INTPTR_TYPE__
> 	and then to int *.
> 
> --- gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m512h/test_passing_m512.c.jj	2021-12-30 15:12:43.747143127 +0100
> +++ gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m512h/test_passing_m512.c	2023-12-01 11:56:10.708574470 +0100
> @@ -25,6 +25,7 @@ int failed = 0;
>    assert (memcmp (&X1, &X2, sizeof (T)) == 0); \
>  } while (0)
>  
> +void
>  fun_check_passing_m512_8_values (__m512 i0 ATTRIBUTE_UNUSED,
>  				 __m512 i1 ATTRIBUTE_UNUSED,
>  				 __m512 i2 ATTRIBUTE_UNUSED,
> @@ -45,6 +46,7 @@ fun_check_passing_m512_8_values (__m512
>    compare (values.i7, i7, __m512);
>  }
>  
> +void
>  fun_check_passing_m512h_8_values (__m512h i0 ATTRIBUTE_UNUSED,
>  				  __m512h i1 ATTRIBUTE_UNUSED,
>  				  __m512h i2 ATTRIBUTE_UNUSED,
> --- gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m256h/test_passing_m256.c.jj	2021-12-30 15:12:43.746143141 +0100
> +++ gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m256h/test_passing_m256.c	2023-12-01 11:55:56.770772491 +0100
> @@ -25,6 +25,7 @@ int failed = 0;
>    assert (memcmp (&X1, &X2, sizeof (T)) == 0); \
>  } while (0)
>  
> +void
>  fun_check_passing_m256_8_values (__m256 i0 ATTRIBUTE_UNUSED,
>  				 __m256 i1 ATTRIBUTE_UNUSED,
>  				 __m256 i2 ATTRIBUTE_UNUSED,
> @@ -45,6 +46,7 @@ fun_check_passing_m256_8_values (__m256
>    compare (values.i7, i7, __m256);
>  }
>  
> +void
>  fun_check_passing_m256h_8_values (__m256h i0 ATTRIBUTE_UNUSED,
>  				  __m256h i1 ATTRIBUTE_UNUSED,
>  				  __m256h i2 ATTRIBUTE_UNUSED,
> --- gcc/testsuite/gcc.dg/graphite/pr83126.c.jj	2020-01-12 11:54:37.438397944 +0100
> +++ gcc/testsuite/gcc.dg/graphite/pr83126.c	2023-12-01 12:20:42.045695863 +0100
> @@ -12,7 +12,7 @@ ew (unsigned short int c9, int stuff)
>        int *fd = &stuff;
>  
>        *fd = c9;
> -      fd = *fd;
> +      fd = (int *) (__INTPTR_TYPE__) *fd;
>        if (*fd != 0)
>  	for (*by = 0; *by < 2; ++*by)
>  	  c9 *= e1;
> 
> 	Jakub
> 
>
Florian Weimer Dec. 1, 2023, 11:37 a.m. UTC | #2 
* Jakub Jelinek:

> Hi!
>
> On IRC Richi mentioned some FAILs in gcc.target/x86_64 and in pr83126.c.
>
> The following patch fixes the former ones (they need recent binutils to
> be enabled), for pr83126.c because I didn't have graphite configured I've
> just verified that the test compiles (didn't without the patch) and that
> the gimple dump is identical with one from yesterday's gcc (as it was a
> tree-parloops.cc ICE, I guess identical gimple is all we care about
> and no need to verify it further).
>
> Ok for trunk?
>
> 2023-12-01  Jakub Jelinek  <jakub@redhat.com>
>
> 	* gcc.target/x86_64/abi/avx512fp16/m512h/test_passing_m512.c
> 	(fun_check_passing_m512_8_values, fun_check_passing_m512h_8_values):
> 	Add missing void return type.
> 	* gcc.target/x86_64/abi/avx512fp16/m256h/test_passing_m256.c
> 	(fun_check_passing_m256_8_values, fun_check_passing_m256h_8_values):
> 	Likewise.
> 	* gcc.dg/graphite/pr83126.c (ew): Add missing casts to __INTPTR_TYPE__
> 	and then to int *.

Looks fine.  Sorry, I totally forgot to upgrade binutils and install
isl.

Thanks,
Florian
diff mbox series

Patch

--- gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m512h/test_passing_m512.c.jj	2021-12-30 15:12:43.747143127 +0100
+++ gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m512h/test_passing_m512.c	2023-12-01 11:56:10.708574470 +0100
@@ -25,6 +25,7 @@  int failed = 0;
   assert (memcmp (&X1, &X2, sizeof (T)) == 0); \
 } while (0)
 
+void
 fun_check_passing_m512_8_values (__m512 i0 ATTRIBUTE_UNUSED,
 				 __m512 i1 ATTRIBUTE_UNUSED,
 				 __m512 i2 ATTRIBUTE_UNUSED,
@@ -45,6 +46,7 @@  fun_check_passing_m512_8_values (__m512
   compare (values.i7, i7, __m512);
 }
 
+void
 fun_check_passing_m512h_8_values (__m512h i0 ATTRIBUTE_UNUSED,
 				  __m512h i1 ATTRIBUTE_UNUSED,
 				  __m512h i2 ATTRIBUTE_UNUSED,
--- gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m256h/test_passing_m256.c.jj	2021-12-30 15:12:43.746143141 +0100
+++ gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m256h/test_passing_m256.c	2023-12-01 11:55:56.770772491 +0100
@@ -25,6 +25,7 @@  int failed = 0;
   assert (memcmp (&X1, &X2, sizeof (T)) == 0); \
 } while (0)
 
+void
 fun_check_passing_m256_8_values (__m256 i0 ATTRIBUTE_UNUSED,
 				 __m256 i1 ATTRIBUTE_UNUSED,
 				 __m256 i2 ATTRIBUTE_UNUSED,
@@ -45,6 +46,7 @@  fun_check_passing_m256_8_values (__m256
   compare (values.i7, i7, __m256);
 }
 
+void
 fun_check_passing_m256h_8_values (__m256h i0 ATTRIBUTE_UNUSED,
 				  __m256h i1 ATTRIBUTE_UNUSED,
 				  __m256h i2 ATTRIBUTE_UNUSED,
--- gcc/testsuite/gcc.dg/graphite/pr83126.c.jj	2020-01-12 11:54:37.438397944 +0100
+++ gcc/testsuite/gcc.dg/graphite/pr83126.c	2023-12-01 12:20:42.045695863 +0100
@@ -12,7 +12,7 @@  ew (unsigned short int c9, int stuff)
       int *fd = &stuff;
 
       *fd = c9;
-      fd = *fd;
+      fd = (int *) (__INTPTR_TYPE__) *fd;
       if (*fd != 0)
 	for (*by = 0; *by < 2; ++*by)
 	  c9 *= e1;