Message ID | 20231129-j7200-tisci-s2r-v1-1-c1d5964ed574@bootlin.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a5a7:0:b0:403:3b70:6f57 with SMTP id d7csp418729vqn; Wed, 29 Nov 2023 07:31:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGT+VHTiFY2U7tufyXuePEYl+LtZ71X2UGErYhyIhPR0je3J9en5DiM4p51an4XSFI/2xJy X-Received: by 2002:a05:6870:1681:b0:1fa:1f0c:cf with SMTP id j1-20020a056870168100b001fa1f0c00cfmr18755802oae.6.1701271905607; Wed, 29 Nov 2023 07:31:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701271905; cv=none; d=google.com; s=arc-20160816; b=otGaf7YhTfTMdxUy+20Tr9ym39M4PPSW+UlAFevuVjMNnOqbc/Sa1JZoOvRMYQCtTR jaoMaKW/b/mB1HW4UV2POz+MI9IcXw1pFRQQbkDxccDOsDSHAmJrRnPb5vnfFOw0iU3n Jah4IKRtPNSW9GMRmo2d25eqcmkz60dH60mrY5d2n98EdfPlRr3rp53U3rRM4yA63LYF Y2rvjpNQsGVBSlZ4m6PDKdW6cVF3cxv6xv9AWUYZY9gDy4JNn/ZSwW06SKshXshwmlIc RUDQ/rJucUyWB7WFo9i1eeloNMPehYp6Xta1CN3WXSuyuAZxzIcLh2PHrh8jS9xb2xhs VBuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=QI1TyzlXaMDB+nhKVeoMHOxLQU8QDlDCw/eJpwfHUjI=; fh=qiuiZXOuSBoCezToil2F5RBR95PkXWcuBaEpicqga+E=; b=lcSiNpzyFNK9h/AShqBsjPFEQXQxf3gPB27ajgQ3aDvGSm4dMY/J3uZutF7cGia5or p6sYAQBfJy++rvlomWTdUMT4EtiyvbrXrORBX8jJN7A+1MsgNPzyxpNBCqcusmOpkg0j Ko13sm6k1hjypCBf3SLd6W1zhZ3mXYseNafaFWnyyX2LFGhH5FpyorMLn3Y+MnTdMu8o CNXuuLDjU2/RSscAzzEUYQOVysfbqJ5ZlyC/hqnIplLIvMF+2FtXvQOu+27p2+Ihoa5L 4haMeMzJRD2pT5ImwKvZRJNLbejBf+//+6z6M0KisudONKa1tXrjDT9iDECuwRvjsfc0 iLjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=B+04Pvk3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id oy19-20020a056871781300b001fa150be386si4277336oac.285.2023.11.29.07.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 07:31:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=B+04Pvk3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 2F5D681CCDAA; Wed, 29 Nov 2023 07:31:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234890AbjK2PbV (ORCPT <rfc822;toshivichauhan@gmail.com> + 99 others); Wed, 29 Nov 2023 10:31:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231206AbjK2PbT (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 29 Nov 2023 10:31:19 -0500 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A99B1D48; Wed, 29 Nov 2023 07:31:25 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id C7635E0004; Wed, 29 Nov 2023 15:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701271884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QI1TyzlXaMDB+nhKVeoMHOxLQU8QDlDCw/eJpwfHUjI=; b=B+04Pvk3bWmTvMKPRwosQPKO0bPMfT8nIYKro4x6w5StmHTn4ntp35qumfbEmEr1iZUFvY h5vd2lx1Zu/KXq7I1HA6Svd1D8ClwkQzAwQqywyRs6HtxmBhOuq9HzTD+NKrs44JpoWvuw VHRg8plyHlX+LFUItkfkhsHzfg4vpwM8PfCvcrdrTsXreunjIm8cyH+AnsJW1ZwL0MK0KB r0EjUi5bX7UQ1s8CqLH9z99bs2+qnDt7eLd45H3/eLWPQ18er8GjsSPAiysHVatAko5t7V 3TbKN29vILU+zZ12cMiF7FB7eNV+Q1gav41vgI+AS112rPbwCGOV6ckr5sfFiQ== From: Thomas Richard <thomas.richard@bootlin.com> Date: Wed, 29 Nov 2023 16:31:17 +0100 Subject: [PATCH 1/5] dt-bindings: arm: keystone: add ti,j7200-sci compatible MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231129-j7200-tisci-s2r-v1-1-c1d5964ed574@bootlin.com> References: <20231129-j7200-tisci-s2r-v1-0-c1d5964ed574@bootlin.com> In-Reply-To: <20231129-j7200-tisci-s2r-v1-0-c1d5964ed574@bootlin.com> To: Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Vignesh Raghavendra <vigneshr@ti.com> Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, u-kumar1@ti.com, Thomas Richard <thomas.richard@bootlin.com> X-Mailer: b4 0.12.0 X-GND-Sasl: thomas.richard@bootlin.com X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 29 Nov 2023 07:31:37 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783912889758351237 X-GMAIL-MSGID: 1783912889758351237 |
Series |
Add suspend/resume support in ti_sci driver for j7200
|
|
Commit Message
Thomas Richard
Nov. 29, 2023, 3:31 p.m. UTC
On j7200, during suspend to ram the soc is powered-off.
At resume requested irqs shall be restored which is a different behavior
from other platforms.
Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
---
Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 2 ++
1 file changed, 2 insertions(+)
Comments
On Wed, Nov 29, 2023 at 04:31:17PM +0100, Thomas Richard wrote: > On j7200, during suspend to ram the soc is powered-off. > At resume requested irqs shall be restored which is a different behavior > from other platforms. > > Signed-off-by: Thomas Richard <thomas.richard@bootlin.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
On Wed, Nov 29, 2023 at 03:34:20PM +0000, Conor Dooley wrote: > On Wed, Nov 29, 2023 at 04:31:17PM +0100, Thomas Richard wrote: > > On j7200, during suspend to ram the soc is powered-off. > > At resume requested irqs shall be restored which is a different behavior > > from other platforms. > > > > Signed-off-by: Thomas Richard <thomas.richard@bootlin.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> Un-Acked. Your dts patch contradicts this one. Is the programming model compatible with the existing devices? To be compatible, the existing device only need to support a compatible subset of behaviours. If so, this patch is wrong. If not, then the dts one is. Thanks, Conor.
On 11/29/23 9:31 AM, Thomas Richard wrote: > On j7200, during suspend to ram the soc is powered-off. > At resume requested irqs shall be restored which is a different behavior > from other platforms. Why is J7200 different? All K3 can/will support off mode suspend to RAM. The only difference is you are adding support for it to this one SoC first. You are describing a software behavior, not hardware. Using a compatible to describe if a SW feature is enabled is not a correct use of DT. Andrew > > Signed-off-by: Thomas Richard <thomas.richard@bootlin.com> > --- > Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml > index c24ad0968f3e..53d9c58dcd70 100644 > --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml > +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml > @@ -40,6 +40,8 @@ properties: > - description: System controller on TI AM654 SoC > items: > - const: ti,am654-sci > + - description: System controller on TI J7200 SOC > + - const: ti,j7200-sci > > reg-names: > description: | >
On Wed, Nov 29, 2023 at 03:38:04PM +0000, Conor Dooley wrote: > On Wed, Nov 29, 2023 at 03:34:20PM +0000, Conor Dooley wrote: > > On Wed, Nov 29, 2023 at 04:31:17PM +0100, Thomas Richard wrote: > > > On j7200, during suspend to ram the soc is powered-off. > > > At resume requested irqs shall be restored which is a different behavior > > > from other platforms. > > > > > > Signed-off-by: Thomas Richard <thomas.richard@bootlin.com> > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Un-Acked. Your dts patch contradicts this one. > > Is the programming model compatible with the existing devices? To be > compatible, the existing device only need to support a compatible subset > of behaviours. > If so, this patch is wrong. If not, then the dts one is. Given Andrew's response, it looks like the dts patch is the correct one of the two, and this patch should document the k2g as a fallback for the jh7200. Cheers, Conor.
On 16:31-20231129, Thomas Richard wrote: > On j7200, during suspend to ram the soc is powered-off. > At resume requested irqs shall be restored which is a different behavior > from other platforms. > > Signed-off-by: Thomas Richard <thomas.richard@bootlin.com> > --- > Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml > index c24ad0968f3e..53d9c58dcd70 100644 > --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml > +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml > @@ -40,6 +40,8 @@ properties: > - description: System controller on TI AM654 SoC > items: > - const: ti,am654-sci > + - description: System controller on TI J7200 SOC > + - const: ti,j7200-sci > > reg-names: > description: | > > -- > 2.39.2 > Sorry, but I don't see why this is any different for all K3 devices. they all follow the same pattern of usage. Also, constraints you are speaking off is also present even for am654-sci. just handle this in the driver.
diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml index c24ad0968f3e..53d9c58dcd70 100644 --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml @@ -40,6 +40,8 @@ properties: - description: System controller on TI AM654 SoC items: - const: ti,am654-sci + - description: System controller on TI J7200 SOC + - const: ti,j7200-sci reg-names: description: |