diff mbox series

[v1,1/3] arm64: dts: qcom: msm8996: Fix 'in-ports' is a required property

Message ID 20231129143815.7892-2-quic_jinlmao@quicinc.com
State New
Headers
Series arm64: dts: qcom: Fix the warnings from coresight bindings |

Commit Message

Mao Jinlong Nov. 29, 2023, 2:38 p.m. UTC 
  The inport of funnel@3023000 connects to a source which is not supported
in current linux kernel. Remove the device tree node of funnel@3023000
to fix the warning. It will be added once the driver support to the
source is added to linux kernel.

Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 26 --------------------------
 1 file changed, 26 deletions(-)

Comments

Krzysztof Kozlowski Nov. 30, 2023, 8:55 a.m. UTC | #1 
On 29/11/2023 15:38, Mao Jinlong wrote:
> The inport of funnel@3023000 connects to a source which is not supported
> in current linux kernel. Remove the device tree node of funnel@3023000
> to fix the warning. It will be added once the driver support to the
> source is added to linux kernel.

Thanks for the changes, but that's not correct reason to remove DTS
code. What kernel supports or not, should be irrelevant for the DTS. DTS
for example is used in other projects - did you check if they have the
same issues? Anyway, DTS describes the hardware, so how current kernel
support defines what is and what is not in the hardware?


Best regards,
Krzysztof
Mao Jinlong Nov. 30, 2023, 11:15 a.m. UTC | #2 
On 11/30/2023 4:55 PM, Krzysztof Kozlowski wrote:
> On 29/11/2023 15:38, Mao Jinlong wrote:
>> The inport of funnel@3023000 connects to a source which is not supported
>> in current linux kernel. Remove the device tree node of funnel@3023000
>> to fix the warning. It will be added once the driver support to the
>> source is added to linux kernel.
> 
> Thanks for the changes, but that's not correct reason to remove DTS
> code. What kernel supports or not, should be irrelevant for the DTS. DTS
> for example is used in other projects - did you check if they have the
> same issues? Anyway, DTS describes the hardware, so how current kernel
> support defines what is and what is not in the hardware?
> 
> 
> Best regards,
> Krzysztof

Hi Krzysztof,

The funnel dt node must have in-ports node. It is to describe the input
connection of funnel HW. But there is no dt_binding doc to describe the
DT node of the HW connected to funnel@3023000. So remove the funnel to 
solve the warning as of now. The funnel will be added back once driver 
and dt_binding are added for the HW.

Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml

Thanks
Jinlong Mao
>
Krzysztof Kozlowski Nov. 30, 2023, 12:06 p.m. UTC | #3 
On 30/11/2023 12:15, Jinlong Mao wrote:
> 
> 
> On 11/30/2023 4:55 PM, Krzysztof Kozlowski wrote:
>> On 29/11/2023 15:38, Mao Jinlong wrote:
>>> The inport of funnel@3023000 connects to a source which is not supported
>>> in current linux kernel. Remove the device tree node of funnel@3023000
>>> to fix the warning. It will be added once the driver support to the
>>> source is added to linux kernel.
>>
>> Thanks for the changes, but that's not correct reason to remove DTS
>> code. What kernel supports or not, should be irrelevant for the DTS. DTS
>> for example is used in other projects - did you check if they have the
>> same issues? Anyway, DTS describes the hardware, so how current kernel
>> support defines what is and what is not in the hardware?
>>
>>
>> Best regards,
>> Krzysztof
> 
> Hi Krzysztof,
> 
> The funnel dt node must have in-ports node. It is to describe the input
> connection of funnel HW. But there is no dt_binding doc to describe the
> DT node of the HW connected to funnel@3023000. So remove the funnel to 
> solve the warning as of now. The funnel will be added back once driver 
> and dt_binding are added for the HW.
> 
> Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml

Why we cannot add now the binding for the connected hardware? It's not
really related to the driver.

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 30, 2023, 1:35 p.m. UTC | #4 
On 30/11/2023 14:12, Jinlong Mao wrote:
> 
> 
> On 11/30/2023 8:06 PM, Krzysztof Kozlowski wrote:
>> On 30/11/2023 12:15, Jinlong Mao wrote:
>>>
>>>
>>> On 11/30/2023 4:55 PM, Krzysztof Kozlowski wrote:
>>>> On 29/11/2023 15:38, Mao Jinlong wrote:
>>>>> The inport of funnel@3023000 connects to a source which is not supported
>>>>> in current linux kernel. Remove the device tree node of funnel@3023000
>>>>> to fix the warning. It will be added once the driver support to the
>>>>> source is added to linux kernel.
>>>>
>>>> Thanks for the changes, but that's not correct reason to remove DTS
>>>> code. What kernel supports or not, should be irrelevant for the DTS. DTS
>>>> for example is used in other projects - did you check if they have the
>>>> same issues? Anyway, DTS describes the hardware, so how current kernel
>>>> support defines what is and what is not in the hardware?
>>>>
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>> Hi Krzysztof,
>>>
>>> The funnel dt node must have in-ports node. It is to describe the input
>>> connection of funnel HW. But there is no dt_binding doc to describe the
>>> DT node of the HW connected to funnel@3023000. So remove the funnel to
>>> solve the warning as of now. The funnel will be added back once driver
>>> and dt_binding are added for the HW.
>>>
>>> Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
>>
>> Why we cannot add now the binding for the connected hardware? It's not
>> really related to the driver.
>>
>> Best regards,
>> Krzysztof
> 
> Do you mean yaml file can be added before the driver code is merged ?

Yes, the binding. YAML is only the language. We don't write YAMLs, we
write bindings.

Best regards,
Krzysztof
Mao Jinlong Nov. 30, 2023, 1:37 p.m. UTC | #5 
On 11/30/2023 9:35 PM, Krzysztof Kozlowski wrote:
> On 30/11/2023 14:12, Jinlong Mao wrote:
>>
>>
>> On 11/30/2023 8:06 PM, Krzysztof Kozlowski wrote:
>>> On 30/11/2023 12:15, Jinlong Mao wrote:
>>>>
>>>>
>>>> On 11/30/2023 4:55 PM, Krzysztof Kozlowski wrote:
>>>>> On 29/11/2023 15:38, Mao Jinlong wrote:
>>>>>> The inport of funnel@3023000 connects to a source which is not supported
>>>>>> in current linux kernel. Remove the device tree node of funnel@3023000
>>>>>> to fix the warning. It will be added once the driver support to the
>>>>>> source is added to linux kernel.
>>>>>
>>>>> Thanks for the changes, but that's not correct reason to remove DTS
>>>>> code. What kernel supports or not, should be irrelevant for the DTS. DTS
>>>>> for example is used in other projects - did you check if they have the
>>>>> same issues? Anyway, DTS describes the hardware, so how current kernel
>>>>> support defines what is and what is not in the hardware?
>>>>>
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>
>>>> Hi Krzysztof,
>>>>
>>>> The funnel dt node must have in-ports node. It is to describe the input
>>>> connection of funnel HW. But there is no dt_binding doc to describe the
>>>> DT node of the HW connected to funnel@3023000. So remove the funnel to
>>>> solve the warning as of now. The funnel will be added back once driver
>>>> and dt_binding are added for the HW.
>>>>
>>>> Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
>>>
>>> Why we cannot add now the binding for the connected hardware? It's not
>>> really related to the driver.
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Do you mean yaml file can be added before the driver code is merged ?
> 
> Yes, the binding. YAML is only the language. We don't write YAMLs, we
> write bindings.
> 
> Best regards,
> Krzysztof

ok, Thanks. I will prepare the binding file.

Thanks
Jinlong Mao

>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 6ba9da9e6a8b..e42c22b26adc 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -2637,24 +2637,6 @@  funnel1_out: endpoint {
 			};
 		};
 
-		funnel@3023000 {
-			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
-			reg = <0x3023000 0x1000>;
-
-			clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
-			clock-names = "apb_pclk", "atclk";
-
-
-			out-ports {
-				port {
-					funnel2_out: endpoint {
-						remote-endpoint =
-						  <&merge_funnel_in2>;
-					};
-				};
-			};
-		};
-
 		funnel@3025000 {
 			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
 			reg = <0x3025000 0x1000>;
@@ -2681,14 +2663,6 @@  merge_funnel_in1: endpoint {
 						  <&funnel1_out>;
 					};
 				};
-
-				port@2 {
-					reg = <2>;
-					merge_funnel_in2: endpoint {
-						remote-endpoint =
-						  <&funnel2_out>;
-					};
-				};
 			};
 
 			out-ports {