Message ID | 20231128174404.393393-1-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp4104214vqx; Tue, 28 Nov 2023 09:44:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTPsKoY7rXHMGyV+XMF9wRQcMSemBNdLJAzhCKSIKsrlrEOEn7Jruj7rLYzStlpKDidLnf X-Received: by 2002:a17:902:ef95:b0:1cc:4e78:d10f with SMTP id iz21-20020a170902ef9500b001cc4e78d10fmr15092581plb.8.1701193466073; Tue, 28 Nov 2023 09:44:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701193466; cv=none; d=google.com; s=arc-20160816; b=CqCBQZb7z135y2FLyoJIZeDGM0MGH8TPEbvbvXqZOOEo8LGaQ7t6qF7slP0L0qs24s zJO10C/XnRR29yHlm8UES2DMuwFUdKyKDip5vJxlGnQweBTL5sYLkKqI6m6Io4E8B3Sp pjGJWdhf9SHFTKbNVI/gYDuxPJLfClsHopOOWinPibUN1ArDpzSNqL9DvtWnN7VzVH2m onHtBcufSVBZ4ynTh1WjZaq6fJWTdQr8px42mVmUYH17VJROqV16PF73YG/fI/RX71wz MKae4Fkh19hxP5Klr9qgYxUOkycucIC2H/xVbZSygEsXnV098yo33FXQoG7Rt1CaK/v1 R4lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vJ8DipaddxE/iUlV0E4x3n80rbSgqs0twWV7DamyTf8=; fh=lLmjOcAa57V749lDBv8Du+g8rNUqj2Mi6M/+JzObZD8=; b=LEw/faqc5iR3lKOCIwCNjCzmt59Dub5KCPSjGJHvc4em3tjr+3erl/vA8nGSAja3T6 lVyNO1CLJgycCzv2B3dgplJKDYUzRZVNlL3yY1bWvqNtkyzQjmUTEKtpJnpsDEVXd2Xk 5b/B5eMOaASEr/OdOBdsi2l2LsjZKIjvsY/psbhXk7QxXT9d0Q4fCF/s5hcvyJY++2N3 /+KJvQg8eIvyAarzcDpuZrBIwCP+kBoGv4cXm9vq+Y/vQQ+yw54hynrhKZQeaOmDyF0o 7djSvX/1fdzhWklbZi0ErhbCBzbQX5h93lXrhYMD6CZsl837eDqCYqV637B8XAnlTT+Z NoiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HxabNe95; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id w7-20020a170902e88700b001cfb87c51f2si4959760plg.194.2023.11.28.09.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 09:44:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HxabNe95; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 3FBBB804C20F; Tue, 28 Nov 2023 09:44:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344957AbjK1RoL (ORCPT <rfc822;toshivichauhan@gmail.com> + 99 others); Tue, 28 Nov 2023 12:44:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233170AbjK1RoK (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 28 Nov 2023 12:44:10 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC367B4 for <linux-kernel@vger.kernel.org>; Tue, 28 Nov 2023 09:44:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701193457; x=1732729457; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=T7lCwvuWnBL9JGTIol0SSSdAIV5XfI5MplTNjSiz61M=; b=HxabNe95v7ltz9jD7FgSJkisBhyj2lzfVv00NKWoUomuvpdePAlKJv1F /C6bk3v9YUEQvkfUBwjUr6BlE1zzvxgRr+RxYs+HL/aG6Ps4DH220p5M8 srlpomaR26R5RQ9JTR7Sczk41dDd70K+0Gtwnn5ueFaUIty7HRD7xSMsx 3fK1qOGPnrBzmL/6swuE2m90oNsiG0C3zMLjyypVEU41PQ750EDo9GJFC 2Xi7VqWflXOxROPRZ7SgBewVDMvoXeF0vJ4D0u02vSz2CtG+XvadNRbSG nr69HHBEeaE7LUbf3TAD1HRb07DNGEjRvkzMWcpGroGNxYTBASAvAL08N g==; X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="11681884" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="11681884" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 09:44:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="1100184548" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="1100184548" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 28 Nov 2023 09:44:07 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 20D7523E; Tue, 28 Nov 2023 19:44:06 +0200 (EET) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Damian Muszynski <damian.muszynski@intel.com>, linux-kernel@vger.kernel.org Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>, Andrew Morton <akpm@linux-foundation.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH v1 1/1] units: Add missing header Date: Tue, 28 Nov 2023 19:44:03 +0200 Message-ID: <20231128174404.393393-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 28 Nov 2023 09:44:20 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783830639986584157 X-GMAIL-MSGID: 1783830639986584157 |
Series |
[v1,1/1] units: Add missing header
|
|
Commit Message
Andy Shevchenko
Nov. 28, 2023, 5:44 p.m. UTC
BITS_PER_BYTE is defined in bits.h.
Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/units.h | 1 +
1 file changed, 1 insertion(+)
Comments
On 11/28/23 09:44, Andy Shevchenko wrote: > BITS_PER_BYTE is defined in bits.h. > > Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > include/linux/units.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/units.h b/include/linux/units.h > index ff1bd6b5f5b3..45110daaf8d3 100644 > --- a/include/linux/units.h > +++ b/include/linux/units.h > @@ -2,6 +2,7 @@ > #ifndef _LINUX_UNITS_H > #define _LINUX_UNITS_H > > +#include <linux/bits.h> > #include <linux/math.h> > > /* Metric prefixes in accordance with Système international (d'unités) */
On Tue, 28 Nov 2023 19:44:03 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > BITS_PER_BYTE is defined in bits.h. > > Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT") This is post-6.6, so the fix should go into this -rc whatever happens, but... It would be rather nice to know the effects of this change please. Did some build break? > --- a/include/linux/units.h > +++ b/include/linux/units.h > @@ -2,6 +2,7 @@ > #ifndef _LINUX_UNITS_H > #define _LINUX_UNITS_H > > +#include <linux/bits.h> > #include <linux/math.h> > > /* Metric prefixes in accordance with Système international (d'unités) */ > -- > 2.43.0.rc1.1.gbec44491f096
On Tue, Nov 28, 2023 at 06:09:57PM -0800, Andrew Morton wrote: > On Tue, 28 Nov 2023 19:44:03 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > > BITS_PER_BYTE is defined in bits.h. > > > > Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT") > > This is post-6.6, so the fix should go into this -rc whatever happens, but... > > It would be rather nice to know the effects of this change please. Did > some build break? Not of my knowledge. Fixes tag here to make sure people won't forget that headers are special and we need a bit stricter rules on how we add a new stuff (which will require another header) or remove an old one (which may give a stale inclusion).
diff --git a/include/linux/units.h b/include/linux/units.h index ff1bd6b5f5b3..45110daaf8d3 100644 --- a/include/linux/units.h +++ b/include/linux/units.h @@ -2,6 +2,7 @@ #ifndef _LINUX_UNITS_H #define _LINUX_UNITS_H +#include <linux/bits.h> #include <linux/math.h> /* Metric prefixes in accordance with Système international (d'unités) */