Message ID | 20231113164632.2439400-1-florian.fainelli@broadcom.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp1336605vqg; Mon, 13 Nov 2023 08:57:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHMOwLQPujWniOG+KkebFOO4WCILZ1ujd4NZoQUyoJGKpctQ6bT7ZVaUXDEKzgpBx+9yiq0 X-Received: by 2002:a05:6a20:840a:b0:186:8dc1:f4a with SMTP id c10-20020a056a20840a00b001868dc10f4amr3958664pzd.0.1699894657548; Mon, 13 Nov 2023 08:57:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699894657; cv=none; d=google.com; s=arc-20160816; b=eeADUW/cyeQS4EwQmtkSNUY09K3ktMnqOrpmOty3gL8WihtJ2Mey7FTTnAUGg77cd0 /dV9wVAuFfMdYynroJUAnVJtliKDEcqrr2gua8a4JhSyW68ZV0y8tdq7XlhcT6vchPAB ZXyRhffCy5KSHWxNECJp79wmQlijIStfRI3Q+KDSIH1GoiMwT5teY7feP7iClJk+tCb2 xT8Am8dCvCJb6QGVTG9n3wayYVrlR57Lqf+dDtXYCldNUvu2R/ZbVAxPa1a2QZ5ujX64 4K2vYvNKiTU1QDAT1NrjFXqVnKXSaWidYNBRCA6yIZNroze2e74MD4UgfpvNNC2u71PO F+Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=FpNN/IoKKN8YtNSHtgri0PaqLpqneBhAMhvhjwNnysc=; fh=iXgIw0lXFex2KAooB1raJU08W+w6BNI3NiqZFHGT0ck=; b=u5z4J/RLyLumLencWBfZ/XubLXKWsGGHazeJg6cE3as8KcvqCmYDAEkOTjhumf434m aiPKHQaAfma2TtRsGAPI8EMQzFh5z3dvYSxEPYc8KxzPtFEzvXDfmE4Ef1nZXAB+cNES HeAK5BpK8pEuXsw8PB/iNOcgvRtkwp3OBRAdmbF/PUTPceRSJQw6FL5OkG4Yj8AsTWZs /ZET7t8g9jLZreB+n7kIFqk/lLs1N8kiLuHBOuNB+dU1ASflRc7KjA9pijiSeG9U/46D Pm1aoFgfcwC3APr7snlZ/yc1elHfGxyGKy286kuxZ5bq4S2yPfmqaF8nrOLJCV1jD/Am CyOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b=tKfbEOR6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id q20-20020a056a00085400b006b864485166si6424676pfk.146.2023.11.13.08.57.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 08:57:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=dkimrelay header.b=tKfbEOR6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 95994805F640; Mon, 13 Nov 2023 08:57:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230139AbjKMQ5e (ORCPT <rfc822;lhua1029@gmail.com> + 30 others); Mon, 13 Nov 2023 11:57:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbjKMQ5d (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 13 Nov 2023 11:57:33 -0500 X-Greylist: delayed 600 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 13 Nov 2023 08:57:31 PST Received: from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com [192.19.144.205]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B600D53; Mon, 13 Nov 2023 08:57:31 -0800 (PST) Received: from mail-lvn-it-01.lvn.broadcom.net (mail-lvn-it-01.lvn.broadcom.net [10.36.132.253]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id C1557C0000E8; Mon, 13 Nov 2023 08:47:30 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com C1557C0000E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1699894050; bh=6/JLDQZPDBH2aFK3yzNfKgCy/0JwglECNuOR5JcF6tQ=; h=From:To:Cc:Subject:Date:From; b=tKfbEOR6o4g2ykzQO/Bj2MIgOKxlaBb7cMcJKlocj+up4z2qfRjaDtVbFfETCrBgF R8R59/u2oIR8iJzSPQ0GFA2HtpTN/voYh3+1MC+YW6xpZaF/mnyafk6njFNQwom6CD NpDSDbzsPoiUfMO6mCAXT2lFSFBTeraHMTpFLK/k= Received: from fainelli-desktop.igp.broadcom.net (fainelli-desktop.dhcp.broadcom.net [10.67.48.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail-lvn-it-01.lvn.broadcom.net (Postfix) with ESMTPSA id 666BE18041CAC4; Mon, 13 Nov 2023 08:47:29 -0800 (PST) From: Florian Fainelli <florian.fainelli@broadcom.com> To: linux-kernel@vger.kernel.org Cc: Florian Fainelli <florian.fainelli@broadcom.com>, Thierry Reding <thierry.reding@gmail.com>, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, linux-pwm@vger.kernel.org (open list:PWM SUBSYSTEM), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE) Subject: [PATCH] pwm: bcm2835: Fix NPD in suspend/resume Date: Mon, 13 Nov 2023 08:46:32 -0800 Message-Id: <20231113164632.2439400-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 13 Nov 2023 08:57:36 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782468739928343064 X-GMAIL-MSGID: 1782468739928343064 |
Series |
pwm: bcm2835: Fix NPD in suspend/resume
|
|
Commit Message
Florian Fainelli
Nov. 13, 2023, 4:46 p.m. UTC
When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was
sent out on October 11th,, there was still a call to
platform_set_drvdata() which would ensure that the driver private data
structure could be used in bcm2835_pwm_{suspend,resume}.
A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835:
Simplify using devm functions") removed that call which would now cause
a NPD in bcm2835_pwm_{suspend,resume} as a consequence.
Fixes: 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume")
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
drivers/pwm/pwm-bcm2835.c | 2 ++
1 file changed, 2 insertions(+)
Comments
Hello, On Mon, Nov 13, 2023 at 08:46:32AM -0800, Florian Fainelli wrote: > When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was > sent out on October 11th,, there was still a call to > platform_set_drvdata() which would ensure that the driver private data > structure could be used in bcm2835_pwm_{suspend,resume}. > > A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835: > Simplify using devm functions") removed that call which would now cause > a NPD in bcm2835_pwm_{suspend,resume} as a consequence. > > Fixes: 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> oops, indeed. Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
On Mon, 13 Nov 2023 08:46:32 -0800, Florian Fainelli wrote: > When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was > sent out on October 11th,, there was still a call to > platform_set_drvdata() which would ensure that the driver private data > structure could be used in bcm2835_pwm_{suspend,resume}. > > A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835: > Simplify using devm functions") removed that call which would now cause > a NPD in bcm2835_pwm_{suspend,resume} as a consequence. > > [...] Applied, thanks! [1/1] pwm: bcm2835: Fix NPD in suspend/resume commit: fba7e9f839d7fcb0888094697da45c5668226455 Best regards,
On Tue, Nov 28, 2023 at 06:49:22PM +0100, Thierry Reding wrote: > > On Mon, 13 Nov 2023 08:46:32 -0800, Florian Fainelli wrote: > > When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was > > sent out on October 11th,, there was still a call to > > platform_set_drvdata() which would ensure that the driver private data > > structure could be used in bcm2835_pwm_{suspend,resume}. > > > > A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835: > > Simplify using devm functions") removed that call which would now cause > > a NPD in bcm2835_pwm_{suspend,resume} as a consequence. > > > > [...] > > Applied, thanks! > > [1/1] pwm: bcm2835: Fix NPD in suspend/resume > commit: fba7e9f839d7fcb0888094697da45c5668226455 This one should IMHO go into v6.7. Do you intend to send it to Linus during the current cycle? Best regards Uwe
Hello Thierry, On Tue, Nov 28, 2023 at 09:55:48PM +0100, Uwe Kleine-König wrote: > On Tue, Nov 28, 2023 at 06:49:22PM +0100, Thierry Reding wrote: > > > > On Mon, 13 Nov 2023 08:46:32 -0800, Florian Fainelli wrote: > > > When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was > > > sent out on October 11th,, there was still a call to > > > platform_set_drvdata() which would ensure that the driver private data > > > structure could be used in bcm2835_pwm_{suspend,resume}. > > > > > > A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835: > > > Simplify using devm functions") removed that call which would now cause > > > a NPD in bcm2835_pwm_{suspend,resume} as a consequence. > > > > > > [...] > > > > Applied, thanks! > > > > [1/1] pwm: bcm2835: Fix NPD in suspend/resume > > commit: fba7e9f839d7fcb0888094697da45c5668226455 > > This one should IMHO go into v6.7. Do you intend to send it to Linus > during the current cycle? We know since > 2 weeks now that the pwm-bcm2835 driver is broken in v6.7-rc1 and there is a fix since day 0. If you continue to be silent about this (here and at https://lore.kernel.org/linux-pwm/20231121112029.gyv3gqirlycysyr4@pengutronix.de) I intend to send a PR to Linus with this fix on Friday next week. Best regards Uwe
diff --git a/drivers/pwm/pwm-bcm2835.c b/drivers/pwm/pwm-bcm2835.c index 9777babd5b95..ab30667f4f95 100644 --- a/drivers/pwm/pwm-bcm2835.c +++ b/drivers/pwm/pwm-bcm2835.c @@ -155,6 +155,8 @@ static int bcm2835_pwm_probe(struct platform_device *pdev) pc->chip.ops = &bcm2835_pwm_ops; pc->chip.npwm = 2; + platform_set_drvdata(pdev, pc); + ret = devm_pwmchip_add(&pdev->dev, &pc->chip); if (ret < 0) return dev_err_probe(&pdev->dev, ret,