diff mbox series

[1/3] dt-bindings: net: phy: dp83867: add LED mode property

Message ID 20221118001548.635752-2-tharvey@gateworks.com
State New
Headers
Series add dt configuration for dp83867 led modes |

Commit Message

Tim Harvey Nov. 18, 2022, 12:15 a.m. UTC 
  Add description for new property ti,led-modes in binding file.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 .../devicetree/bindings/net/ti,dp83867.yaml      |  6 ++++++
 include/dt-bindings/net/ti-dp83867.h             | 16 ++++++++++++++++
 2 files changed, 22 insertions(+)

Comments

Rob Herring Nov. 18, 2022, 3:56 a.m. UTC | #1 
On Thu, 17 Nov 2022 16:15:46 -0800, Tim Harvey wrote:
> Add description for new property ti,led-modes in binding file.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  .../devicetree/bindings/net/ti,dp83867.yaml      |  6 ++++++
>  include/dt-bindings/net/ti-dp83867.h             | 16 ++++++++++++++++
>  2 files changed, 22 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/net/ti,dp83867.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/net/schemas/types.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221118001548.635752-2-tharvey@gateworks.com

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
index b8c0e4b5b494..8b84c34d389f 100644
--- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml
+++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
@@ -118,6 +118,12 @@  properties:
       Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h for applicable
       values.
 
+  ti,led-modes:
+    description: |
+      List of LED modes - see dt-bindings/net/ti-dp83867.h for applicable
+      values.
+    $ref: schemas/types.yaml#/definitions/uint32-array
+
 required:
   - reg
 
diff --git a/include/dt-bindings/net/ti-dp83867.h b/include/dt-bindings/net/ti-dp83867.h
index 6fc4b445d3a1..ea3e17b27427 100644
--- a/include/dt-bindings/net/ti-dp83867.h
+++ b/include/dt-bindings/net/ti-dp83867.h
@@ -50,4 +50,20 @@ 
 #define DP83867_CLK_O_SEL_REF_CLK		0xC
 /* Special flag to indicate clock should be off */
 #define DP83867_CLK_O_SEL_OFF			0xFFFFFFFF
+
+/* LED_CFG - LED configuration selection */
+#define DP83867_LED_SEL_LINK			0
+#define DP83867_LED_SEL_ACT			1
+#define DP83867_LED_SEL_ACT_TX			2
+#define DP83867_LED_SEL_ACT_RX			3
+#define DP83867_LED_SEL_COL			4
+#define DP83867_LED_SEL_LINK_1000BT		5
+#define DP83867_LED_SEL_LINK_100BT		6
+#define DP83867_LED_SEL_LINK_10BT		7
+#define DP83867_LED_SEL_LINK_10_100BT		8
+#define DP83867_LED_SEL_LINK_100_1000BT		9
+#define DP83867_LED_SEL_FULL_DUPLEX		10
+#define DP83867_LED_SEL_LINK_ACT		11
+#define DP83867_LED_SEL_ERR_TX_RX		13
+#define DP83867_LED_SEL_ERR_RX			14
 #endif