| Message ID | 20231127013602.253835-7-jeeheng.sia@starfivetech.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2788897vqx;
Sun, 26 Nov 2023 17:37:20 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IHJQJMpxM3iwEzM7K3vy+jxZV+Uxxl0Wt3WOSoFwOA4CmF31ACTlnvLffMuAIj+/sheAwSZ
X-Received: by 2002:a05:6808:218c:b0:3b6:cbb6:36b8 with SMTP id
be12-20020a056808218c00b003b6cbb636b8mr16000274oib.34.1701049039887;
Sun, 26 Nov 2023 17:37:19 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1701049039; cv=none;
d=google.com; s=arc-20160816;
b=zD8RPqWS7fyPHChv+bo4PYzSgKk4c03Kya15QQvT0OahrFXmbK827cS+qhdUaSqmxY
sjLBmJ7pW4wKC3xyOYKEJMqZyED0GgYM5U+OdaJXBy/e1HC/Gjp4Yi2RGBQ1Pup+UaHy
TvIlLJv+nnyv8qE9/Riak5vwi3T4d+DTgbIgmyHb9Ma7jxz47HXsK82g6ZWqmmrRAmFF
DQGXPlJErnBMOVJA4nx75SXwBofGu5dj+cNXxmu1RyCcRGerCN2jz8NmQfXN1FykoF6w
UifotpESNusdQ7bymOiMYivESqpHK4BsQvm3Zp2bvLRCz32pZ9kbI9UkzVXBo0sojYx6
XUEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=xZk8V+37wO0f8D8RwA8dDB/rY4tmPJndIyajaNBCRc0=;
fh=NwY0g3O8p+TEjJRhPyjQLQ8C7jChqXBBckF6d4Husj0=;
b=G6fAYp2tepBCdmvy9iZoRgFmBPTVqqLH4xMrCwtPF1ml8ZPgbJlPIZlIxTjx9RE5Iu
i+IGrbMejA+I+GKFsD/8E41UjNw9xs7/5D/zQDGJ7O9dvsLjEzkEL/Afla21Jrsw7uUs
ovYf/Q3QkJXI7SvumxbucJvrHPeViDs6yLJDn4DUVOEuZnf3eGHBXxYWA+xxLfjs2m2t
mTjUOoqMfp06MyhGxSFSzga3K95FGHI1VR512CH0EBwEtprn+z5NEHmIh9MzIX0pPwrE
qU3M9vf2hAinzoLf7FqM7/bFxSYOABAprGQb9VhchLpbxRSEtYxewTeHHdoAj9GfSjcj
3lvw==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:3 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3])
by mx.google.com with ESMTPS id
f12-20020a631f0c000000b005b21d089aabsi8831618pgf.519.2023.11.26.17.37.19
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 26 Nov 2023 17:37:19 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:3 as permitted sender)
client-ip=2620:137:e000::3:3;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:3 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by lipwig.vger.email (Postfix) with ESMTP id 00BBF806B127;
Sun, 26 Nov 2023 17:37:17 -0800 (PST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231982AbjK0Bgt convert rfc822-to-8bit (ORCPT
<rfc822;kernel.ruili@gmail.com> + 99 others);
Sun, 26 Nov 2023 20:36:49 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51114 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231607AbjK0Bgk (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sun, 26 Nov 2023 20:36:40 -0500
Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com
[61.152.239.71])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CABF610C3
for <linux-kernel@vger.kernel.org>;
Sun, 26 Nov 2023 17:36:39 -0800 (PST)
Received: from EXMBX165.cuchost.com (unknown [175.102.18.54])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(Client CN "EXMBX165", Issuer "EXMBX165" (not verified))
by fd01.gateway.ufhost.com (Postfix) with ESMTP id 338E27FFB;
Mon, 27 Nov 2023 09:36:38 +0800 (CST)
Received: from EXMBX066.cuchost.com (172.16.7.66) by EXMBX165.cuchost.com
(172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 27 Nov
2023 09:36:37 +0800
Received: from jsia-virtual-machine.localdomain (202.188.176.82) by
EXMBX066.cuchost.com (172.16.6.66) with Microsoft SMTP Server (TLS) id
15.0.1497.42; Mon, 27 Nov 2023 09:36:34 +0800
From: Sia Jee Heng <jeeheng.sia@starfivetech.com>
To: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <conor@kernel.org>, <kernel@esmil.dk>,
<robh+dt@kernel.org>, <emil.renner.berthing@canonical.com>
CC: <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<jeeheng.sia@starfivetech.com>, <leyfoon.tan@starfivetech.com>
Subject: [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for
StarFive
Date: Mon, 27 Nov 2023 09:36:01 +0800
Message-ID: <20231127013602.253835-7-jeeheng.sia@starfivetech.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20231127013602.253835-1-jeeheng.sia@starfivetech.com>
References: <20231127013602.253835-1-jeeheng.sia@starfivetech.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [202.188.176.82]
X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX066.cuchost.com
(172.16.6.66)
X-YovoleRuleAgent: yovoleflag
Content-Transfer-Encoding: 8BIT
X-Spam-Status: No,
score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]);
Sun, 26 Nov 2023 17:37:17 -0800 (PST)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1783679197616621383
X-GMAIL-MSGID: 1783679197616621383
|
| Series |
Initial device tree support for StarFive JH8100 SoC
|
|
Commit Message
JeeHeng Sia
Nov. 27, 2023, 1:36 a.m. UTC
This patch adds the new compatible string for StarFive JH8100 SoC Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com> Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> --- drivers/tty/serial/xilinx_uartps.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On 27/11/2023 02:36, Sia Jee Heng wrote: > This patch adds the new compatible string for StarFive JH8100 SoC > > Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com> > Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > --- > drivers/tty/serial/xilinx_uartps.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c > index 66a45a634158..170901c143c2 100644 > --- a/drivers/tty/serial/xilinx_uartps.c > +++ b/drivers/tty/serial/xilinx_uartps.c > @@ -1210,7 +1210,7 @@ OF_EARLYCON_DECLARE(cdns, "xlnx,xuartps", cdns_early_console_setup); > OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p8", cdns_early_console_setup); > OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p12", cdns_early_console_setup); > OF_EARLYCON_DECLARE(cdns, "xlnx,zynqmp-uart", cdns_early_console_setup); > - > +OF_EARLYCON_DECLARE(cdns, "starfive,jh8100-uart", cdns_early_console_setup); > > /* Static pointer to console port */ > static struct uart_port *console_port; > @@ -1448,6 +1448,7 @@ static const struct of_device_id cdns_uart_of_match[] = { > { .compatible = "cdns,uart-r1p8", }, > { .compatible = "cdns,uart-r1p12", .data = &zynqmp_uart_def }, > { .compatible = "xlnx,zynqmp-uart", .data = &zynqmp_uart_def }, > + { .compatible = "starfive,jh8100-uart", }, Why you do not express compatibility in your bindings? Skip this driver change. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Monday, November 27, 2023 4:49 PM > To: JeeHeng Sia <jeeheng.sia@starfivetech.com>; paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; > conor@kernel.org; kernel@esmil.dk; robh+dt@kernel.org; emil.renner.berthing@canonical.com > Cc: linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Leyfoon Tan <leyfoon.tan@starfivetech.com> > Subject: Re: [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for StarFive > > On 27/11/2023 02:36, Sia Jee Heng wrote: > > This patch adds the new compatible string for StarFive JH8100 SoC > > > > Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com> > > Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > > --- > > drivers/tty/serial/xilinx_uartps.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c > > index 66a45a634158..170901c143c2 100644 > > --- a/drivers/tty/serial/xilinx_uartps.c > > +++ b/drivers/tty/serial/xilinx_uartps.c > > @@ -1210,7 +1210,7 @@ OF_EARLYCON_DECLARE(cdns, "xlnx,xuartps", cdns_early_console_setup); > > OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p8", cdns_early_console_setup); > > OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p12", cdns_early_console_setup); > > OF_EARLYCON_DECLARE(cdns, "xlnx,zynqmp-uart", cdns_early_console_setup); > > - > > +OF_EARLYCON_DECLARE(cdns, "starfive,jh8100-uart", cdns_early_console_setup); > > > > /* Static pointer to console port */ > > static struct uart_port *console_port; > > @@ -1448,6 +1448,7 @@ static const struct of_device_id cdns_uart_of_match[] = { > > { .compatible = "cdns,uart-r1p8", }, > > { .compatible = "cdns,uart-r1p12", .data = &zynqmp_uart_def }, > > { .compatible = "xlnx,zynqmp-uart", .data = &zynqmp_uart_def }, > > + { .compatible = "starfive,jh8100-uart", }, > > Why you do not express compatibility in your bindings? Skip this driver > change. The compatibility string was added to the binding in the 5th patch. We need to add this compatibility string to the driver, as the other compatibilities were used for other SoCs. > > Best regards, > Krzysztof
On 28/11/2023 06:25, JeeHeng Sia wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzk@kernel.org> >> Sent: Monday, November 27, 2023 4:49 PM >> To: JeeHeng Sia <jeeheng.sia@starfivetech.com>; paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; >> conor@kernel.org; kernel@esmil.dk; robh+dt@kernel.org; emil.renner.berthing@canonical.com >> Cc: linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Leyfoon Tan <leyfoon.tan@starfivetech.com> >> Subject: Re: [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for StarFive >> >> On 27/11/2023 02:36, Sia Jee Heng wrote: >>> This patch adds the new compatible string for StarFive JH8100 SoC >>> >>> Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com> >>> Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> >>> --- >>> drivers/tty/serial/xilinx_uartps.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c >>> index 66a45a634158..170901c143c2 100644 >>> --- a/drivers/tty/serial/xilinx_uartps.c >>> +++ b/drivers/tty/serial/xilinx_uartps.c >>> @@ -1210,7 +1210,7 @@ OF_EARLYCON_DECLARE(cdns, "xlnx,xuartps", cdns_early_console_setup); >>> OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p8", cdns_early_console_setup); >>> OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p12", cdns_early_console_setup); >>> OF_EARLYCON_DECLARE(cdns, "xlnx,zynqmp-uart", cdns_early_console_setup); >>> - >>> +OF_EARLYCON_DECLARE(cdns, "starfive,jh8100-uart", cdns_early_console_setup); >>> >>> /* Static pointer to console port */ >>> static struct uart_port *console_port; >>> @@ -1448,6 +1448,7 @@ static const struct of_device_id cdns_uart_of_match[] = { >>> { .compatible = "cdns,uart-r1p8", }, >>> { .compatible = "cdns,uart-r1p12", .data = &zynqmp_uart_def }, >>> { .compatible = "xlnx,zynqmp-uart", .data = &zynqmp_uart_def }, >>> + { .compatible = "starfive,jh8100-uart", }, >> >> Why you do not express compatibility in your bindings? Skip this driver >> change. > The compatibility string was added to the binding in the 5th patch. We need to add this compatibility string to the driver, as the other compatibilities were used for other SoCs. You did not add "compatibility string" but compatible. I am asking why you are not expressing in your bindings the compatibility between this and other devices. And no, you do not need driver change for compatible devices, so again: skip this driver change. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Tuesday, November 28, 2023 3:21 PM > To: JeeHeng Sia <jeeheng.sia@starfivetech.com>; paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; > conor@kernel.org; kernel@esmil.dk; robh+dt@kernel.org; emil.renner.berthing@canonical.com > Cc: linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Leyfoon Tan <leyfoon.tan@starfivetech.com> > Subject: Re: [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for StarFive > > On 28/11/2023 06:25, JeeHeng Sia wrote: > > > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzk@kernel.org> > >> Sent: Monday, November 27, 2023 4:49 PM > >> To: JeeHeng Sia <jeeheng.sia@starfivetech.com>; paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; > >> conor@kernel.org; kernel@esmil.dk; robh+dt@kernel.org; emil.renner.berthing@canonical.com > >> Cc: linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Leyfoon Tan <leyfoon.tan@starfivetech.com> > >> Subject: Re: [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for StarFive > >> > >> On 27/11/2023 02:36, Sia Jee Heng wrote: > >>> This patch adds the new compatible string for StarFive JH8100 SoC > >>> > >>> Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com> > >>> Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > >>> --- > >>> drivers/tty/serial/xilinx_uartps.c | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c > >>> index 66a45a634158..170901c143c2 100644 > >>> --- a/drivers/tty/serial/xilinx_uartps.c > >>> +++ b/drivers/tty/serial/xilinx_uartps.c > >>> @@ -1210,7 +1210,7 @@ OF_EARLYCON_DECLARE(cdns, "xlnx,xuartps", cdns_early_console_setup); > >>> OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p8", cdns_early_console_setup); > >>> OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p12", cdns_early_console_setup); > >>> OF_EARLYCON_DECLARE(cdns, "xlnx,zynqmp-uart", cdns_early_console_setup); > >>> - > >>> +OF_EARLYCON_DECLARE(cdns, "starfive,jh8100-uart", cdns_early_console_setup); > >>> > >>> /* Static pointer to console port */ > >>> static struct uart_port *console_port; > >>> @@ -1448,6 +1448,7 @@ static const struct of_device_id cdns_uart_of_match[] = { > >>> { .compatible = "cdns,uart-r1p8", }, > >>> { .compatible = "cdns,uart-r1p12", .data = &zynqmp_uart_def }, > >>> { .compatible = "xlnx,zynqmp-uart", .data = &zynqmp_uart_def }, > >>> + { .compatible = "starfive,jh8100-uart", }, > >> > >> Why you do not express compatibility in your bindings? Skip this driver > >> change. > > The compatibility string was added to the binding in the 5th patch. We need to add this compatibility string to the driver, as the > other compatibilities were used for other SoCs. > > You did not add "compatibility string" but compatible. I am asking why > you are not expressing in your bindings the compatibility between this > and other devices. > > And no, you do not need driver change for compatible devices, so again: > skip this driver change. Alright, I will skip this driver change. Thanks. > > > Best regards, > Krzysztof
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 66a45a634158..170901c143c2 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1210,7 +1210,7 @@ OF_EARLYCON_DECLARE(cdns, "xlnx,xuartps", cdns_early_console_setup); OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p8", cdns_early_console_setup); OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p12", cdns_early_console_setup); OF_EARLYCON_DECLARE(cdns, "xlnx,zynqmp-uart", cdns_early_console_setup); - +OF_EARLYCON_DECLARE(cdns, "starfive,jh8100-uart", cdns_early_console_setup); /* Static pointer to console port */ static struct uart_port *console_port; @@ -1448,6 +1448,7 @@ static const struct of_device_id cdns_uart_of_match[] = { { .compatible = "cdns,uart-r1p8", }, { .compatible = "cdns,uart-r1p12", .data = &zynqmp_uart_def }, { .compatible = "xlnx,zynqmp-uart", .data = &zynqmp_uart_def }, + { .compatible = "starfive,jh8100-uart", }, {} }; MODULE_DEVICE_TABLE(of, cdns_uart_of_match);