Message ID | 20231126191840.110564-4-andreas@kemnade.info |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2644280vqx; Sun, 26 Nov 2023 11:19:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQvbhngSyjERuL3ky7ouRWwSL/jRwasHJOZP8fo33VF7FwU8fkHHBTaOuq/BKjHYdlS1JZ X-Received: by 2002:a05:6e02:20ec:b0:35b:2e43:ac30 with SMTP id q12-20020a056e0220ec00b0035b2e43ac30mr13171445ilv.24.1701026357707; Sun, 26 Nov 2023 11:19:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701026357; cv=none; d=google.com; s=arc-20160816; b=KwNGKXfGwZn3FjUtqZNRSbDeDZLByUHOmhqV2a2Nio3FKwbxiLwY41whwQBNMOzpCm 61Ffs9BWgw32IQZwiAcjIdy7jJ60ZkENVJwlwdxG52oqkVyD3zdFpo6xSmLW80MiBRmp AqnNGWcjmk/E/iQgE89r/UVcQ1bZi9+hGC2vnBZ6nMV4p3DjKo5M8RYGl51sXdjY1/TR 1Lrm7JeCpD/W3WXFJo9oTsSqDduJy1qrV1+3ayiiDxzT0RSKifnfP5Kg5XEAcwjm7wLl rYZyKsXsYPyWznQZfeW9sBaj0t41eEvp5sIhvaoNAoq+MI6QnI0p8ChhelzwBBKBW9T1 kEXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=SsOnvlXonurlA564IEOQWemzj0C6BzUJ79azZ6H6G8Y=; fh=LG9dKayB47Aw5OhgE4A33oFKes3+TtS9nbezIo8wrtw=; b=pPMmyzKSdF4HIsmJC+WdlIoMfjd2wKDB1P91KAfUxQDuELCbVYZuQJkf/hUhjDfDBq tVMK56QHMyJ7HnzMUI0+BeGSa4xK0FPKWib/2l9AfgIB3udh3tRfMYi1lH/Ks8i3PEEc HiAiHG9P4aLmGKwJkMEmcv+Y2vORUsXNZDYbRnaR/fzsRiXyKugcmU60/fhQkcDoyR2+ +kkOdexNbFRvvpCFgCXK1gbUzichATcaDrKtBS81TqDqv44BO0AwIr026CoqLiXMXMps aP0YlyUpOvAemBYTs+8TPPZf2+HNJn8chrHseUmhjrYtWqVaezsEdVzJO/JAkc8j9+Zv GfzA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id s1-20020a056a0008c100b006cb6338dd60si8504523pfu.19.2023.11.26.11.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 11:19:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 45A8C806141D; Sun, 26 Nov 2023 11:19:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230488AbjKZTSz (ORCPT <rfc822;kernel.ruili@gmail.com> + 99 others); Sun, 26 Nov 2023 14:18:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjKZTSt (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 26 Nov 2023 14:18:49 -0500 Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a02:c205:3004:2154::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34246FD for <linux-kernel@vger.kernel.org>; Sun, 26 Nov 2023 11:18:53 -0800 (PST) Received: from p200301077700a9001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:107:7700:a900:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <andreas@kemnade.info>) id 1r7KeT-006khU-JE; Sun, 26 Nov 2023 20:18:45 +0100 Received: from andi by aktux with local (Exim 4.96) (envelope-from <andreas@kemnade.info>) id 1r7KeT-000Slq-15; Sun, 26 Nov 2023 20:18:45 +0100 From: Andreas Kemnade <andreas@kemnade.info> To: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, johan@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, andreas@kemnade.info, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, tomi.valkeinen@ideasonboard.com, Tony Lindgren <tony@atomide.com>, =?utf-8?q?P=C3=A9ter_Ujfalusi?= <peter.ujfalusi@gmail.com>, robh@kernel.org Subject: [RFC PATCH 3/3] drivers: misc: ti-st: begin to deorbit Date: Sun, 26 Nov 2023 20:18:40 +0100 Message-Id: <20231126191840.110564-4-andreas@kemnade.info> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231126191840.110564-1-andreas@kemnade.info> References: <20231126191840.110564-1-andreas@kemnade.info> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 26 Nov 2023 11:19:15 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783655413798005018 X-GMAIL-MSGID: 1783655413798005018 |
Series |
bluetooth/gnss: GNSS support for TiWi chips
|
|
Commit Message
Andreas Kemnade
Nov. 26, 2023, 7:18 p.m. UTC
The TI-ST driver seems not to be used anymore. For bluetooth needs
there is hci_ll.c which has device tree support and can work without
this one. Also firmware download support is there, so it is also not needed
here. GPS can also reuse parts of the framework in hci_ll
Contrary from this driver, device tree support has been removed.
So start deorbiting it by marking it as broken.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
drivers/misc/ti-st/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Sun, Nov 26, 2023 at 08:18:40PM +0100, Andreas Kemnade wrote: > The TI-ST driver seems not to be used anymore. For bluetooth needs > there is hci_ll.c which has device tree support and can work without > this one. Also firmware download support is there, so it is also not needed > here. GPS can also reuse parts of the framework in hci_ll > > Contrary from this driver, device tree support has been removed. > > So start deorbiting it by marking it as broken. > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > --- > drivers/misc/ti-st/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig > index 1503a6496f632..6bf9cc845745c 100644 > --- a/drivers/misc/ti-st/Kconfig > +++ b/drivers/misc/ti-st/Kconfig > @@ -7,7 +7,7 @@ menu "Texas Instruments shared transport line discipline" > config TI_ST > tristate "Shared transport core driver" > depends on NET && TTY > - depends on GPIOLIB || COMPILE_TEST > + depends on GPIOLIB || COMPILE_TEST || BROKEN Why not just delete it? Why have it stick around any longer? thanks, greg k-h
* Greg KH <gregkh@linuxfoundation.org> [231127 08:25]: > On Sun, Nov 26, 2023 at 08:18:40PM +0100, Andreas Kemnade wrote: > > The TI-ST driver seems not to be used anymore. For bluetooth needs > > there is hci_ll.c which has device tree support and can work without > > this one. Also firmware download support is there, so it is also not needed > > here. GPS can also reuse parts of the framework in hci_ll > > > > Contrary from this driver, device tree support has been removed. > > > > So start deorbiting it by marking it as broken. > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > > --- > > drivers/misc/ti-st/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig > > index 1503a6496f632..6bf9cc845745c 100644 > > --- a/drivers/misc/ti-st/Kconfig > > +++ b/drivers/misc/ti-st/Kconfig > > @@ -7,7 +7,7 @@ menu "Texas Instruments shared transport line discipline" > > config TI_ST > > tristate "Shared transport core driver" > > depends on NET && TTY > > - depends on GPIOLIB || COMPILE_TEST > > + depends on GPIOLIB || COMPILE_TEST || BROKEN > > Why not just delete it? Why have it stick around any longer? Sounds good to me too. Regards, Tony
Hi Greg, On Mon, 27 Nov 2023 08:25:46 +0000 Greg KH <gregkh@linuxfoundation.org> wrote: > On Sun, Nov 26, 2023 at 08:18:40PM +0100, Andreas Kemnade wrote: > > The TI-ST driver seems not to be used anymore. For bluetooth needs > > there is hci_ll.c which has device tree support and can work without > > this one. Also firmware download support is there, so it is also not needed > > here. GPS can also reuse parts of the framework in hci_ll > > > > Contrary from this driver, device tree support has been removed. > > > > So start deorbiting it by marking it as broken. > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > > --- > > drivers/misc/ti-st/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig > > index 1503a6496f632..6bf9cc845745c 100644 > > --- a/drivers/misc/ti-st/Kconfig > > +++ b/drivers/misc/ti-st/Kconfig > > @@ -7,7 +7,7 @@ menu "Texas Instruments shared transport line discipline" > > config TI_ST > > tristate "Shared transport core driver" > > depends on NET && TTY > > - depends on GPIOLIB || COMPILE_TEST > > + depends on GPIOLIB || COMPILE_TEST || BROKEN > > Why not just delete it? Why have it stick around any longer? > Well, I just thought that marking something as broken and then deleting it if no one complains would be the standard procedure. So we can delete it now since there are obviously no users (no board files, no device tree support)? The logical connection between the other patches of this series is given only by the fact that patches 1+2 are for me the proof that we do not need that ti-st driver. I think since there are no in-tree users, having that proof in lkml is enough, so we can probably remove the driver now? I will send a separate remove patch including going with a brush through include/linux/ti_wilink_st.h Regards, Andreas
diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig index 1503a6496f632..6bf9cc845745c 100644 --- a/drivers/misc/ti-st/Kconfig +++ b/drivers/misc/ti-st/Kconfig @@ -7,7 +7,7 @@ menu "Texas Instruments shared transport line discipline" config TI_ST tristate "Shared transport core driver" depends on NET && TTY - depends on GPIOLIB || COMPILE_TEST + depends on GPIOLIB || COMPILE_TEST || BROKEN select FW_LOADER help This enables the shared transport core driver for TI