Message ID | 20231123193355.3400852-13-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp669724vqx; Thu, 23 Nov 2023 11:34:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IEz8hbmy7ls26bKDrtYvnW0xYosp1axplwKzUipYDaJnZEkDM6MkLsH7huy2KqKA0WbWLrj X-Received: by 2002:a05:6a20:869d:b0:189:b414:3e0d with SMTP id k29-20020a056a20869d00b00189b4143e0dmr335703pze.54.1700768087646; Thu, 23 Nov 2023 11:34:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700768087; cv=none; d=google.com; s=arc-20160816; b=mABEecVvThQm+uF6TKKk/wqik4P/e7SCgXuOfaiOlkCf2YDbWYkJoEwboHH5QI1I7s c1qLRG+bOG9pw78Q2qN4eOqVizMyXGX5GkpszycXGZ2zbHsVnhN/AjJvfVa/d/bTqgwH 7pRTwuIyuWIl+lNHmzuFvxd8w+upRgDxzgGPhD2k4R/KwZSgzYvPzNmmXIa37cp1/O8u avWX1viQGBq6CE0UIK34DO/lzszuQUs5ExOowoFpuFwHFSYXFSrsyYH/H83W5zdEPaqV wQoAR/aQ5KYmuHZtiTIWcRBFdFq5DcyIzu/38azOnsx9YGuM3v2JTD2B14QgkEjjmGP+ ADQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=aYptDPmUHUBPIL2BGdHO5tQXLiJSx/pk4xrhZuhmw7M=; fh=o6/j60XBkz0cs1N8PQkcSMZ4tgCM5mUF5G/ULMywbv8=; b=PmGr2uuwYD6tQcX9uuggnQ/i/2WBg+BsbWDMqicGmwSf0X+MnjqGW4DcIQJFCDttz2 nS2yA4rCMz3QyfBrML7tWEBXwJ4SRX64GWFAq8Gia/Iu9qoxumXNFPP3jdlli1vhgPBd tDRcWzLwvCO/kkqPZtrOPwZioWQA0BTaBSYwbW/9pKx1VL9i/7PYMOq2k3kPar561CeV kpqsGaRFyA13xRk8REtSO9Lmk+3H89zqtyeKclWbZrITNi/6nhgFF2F31xeWKy3AVENh yjWMmjju59+PZo+6ggiUXVLEaJafoMedLcqBM6iNsX/kzrUuwzxiCccQKHQivLQWzTUW 1zew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Mu1xLNsT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id x19-20020a170902821300b001cc30cb3f9asi1586345pln.14.2023.11.23.11.34.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 11:34:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Mu1xLNsT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id D5E8482D87A7; Thu, 23 Nov 2023 11:34:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229656AbjKWTe0 (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Thu, 23 Nov 2023 14:34:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229838AbjKWTeS (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 23 Nov 2023 14:34:18 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BC6810D4; Thu, 23 Nov 2023 11:34:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700768057; x=1732304057; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=oWROro8zaz/FXYo/HWfHQvzRYrdVT7osWgNgoAMuX7s=; b=Mu1xLNsTC8F+Lu0qBuq3xpn68jtrHF+8t+G/LieVfHEpD6kIYG7SunMg Vjvf1266B0UxYaf+QYRJvy6a7AqL2RsvLLLawnhCMFTnkb/qb8PZY5Se1 DbDfhFeiGYMBaUQOaOaW59RydCACDlbaKZQtI11DWtE8HlOmrRxWpCedI sqHWapKlyO7knhYBX2v0osKrVE8AqkRKsOP94pHDAm2+gQjWYsN7LS01k xkbJkY6ADQbj5uAfHkcmYpKprWlmIaHRQVCcM1y0t6H2npfrN1LR5vFuc q6o0FMBz6/iyIVvEuAkWlrx/S1A3xL4c6YEUvF8I4QqDuD1E/iWf3G5tD g==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="371671421" X-IronPort-AV: E=Sophos;i="6.04,222,1695711600"; d="scan'208";a="371671421" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2023 11:34:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="771062252" X-IronPort-AV: E=Sophos;i="6.04,222,1695711600"; d="scan'208";a="771062252" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 23 Nov 2023 11:34:09 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3141F6E3; Thu, 23 Nov 2023 21:33:59 +0200 (EET) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bartosz.golaszewski@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, =?utf-8?q?Jonathan_Neusch?= =?utf-8?q?=C3=A4fer?= <j.neuschaefer@gmx.net>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, =?utf-8?q?Uwe_Kleine-?= =?utf-8?q?K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, Geert Uytterhoeven <geert+renesas@glider.be>, Biju Das <biju.das.jz@bp.renesas.com>, Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>, Jianlong Huang <jianlong.huang@starfivetech.com>, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org, linux-mips@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org Cc: Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Dong Aisheng <aisheng.dong@nxp.com>, Fabio Estevam <festevam@gmail.com>, Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Sascha Hauer <s.hauer@pengutronix.de>, NXP Linux Team <linux-imx@nxp.com>, Sean Wang <sean.wang@kernel.org>, Paul Cercueil <paul@crapouillou.net>, Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Emil Renner Berthing <kernel@esmil.dk>, Hal Feng <hal.feng@starfivetech.com> Subject: [PATCH v2 12/21] pinctrl: core: Embed struct pingroup into struct group_desc Date: Thu, 23 Nov 2023 21:31:40 +0200 Message-ID: <20231123193355.3400852-13-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231123193355.3400852-1-andriy.shevchenko@linux.intel.com> References: <20231123193355.3400852-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 23 Nov 2023 11:34:42 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783384598527715154 X-GMAIL-MSGID: 1783384598527715154 |
Series |
pinctrl: Convert struct group_desc to use struct pingroup
|
|
Commit Message
Andy Shevchenko
Nov. 23, 2023, 7:31 p.m. UTC
struct group_desc is a particular version of the struct pingroup
with associated opaque data. Start switching pin control core and
drivers to use it explicitly.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/core.c | 15 ++++++++++++---
drivers/pinctrl/core.h | 5 +++++
2 files changed, 17 insertions(+), 3 deletions(-)
Comments
Hi Andy, kernel test robot noticed the following build errors: [auto build test ERROR on linusw-pinctrl/devel] [also build test ERROR on linusw-pinctrl/for-next next-20231124] [cannot apply to geert-renesas-drivers/renesas-pinctrl pinctrl-samsung/for-next linus/master v6.7-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/pinctrl-qcom-lpass-lpi-Remove-unused-member-in-struct-lpi_pingroup/20231124-043212 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel patch link: https://lore.kernel.org/r/20231123193355.3400852-13-andriy.shevchenko%40linux.intel.com patch subject: [PATCH v2 12/21] pinctrl: core: Embed struct pingroup into struct group_desc config: i386-buildonly-randconfig-006-20231125 (https://download.01.org/0day-ci/archive/20231125/202311250448.uz5Yom3N-lkp@intel.com/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231125/202311250448.uz5Yom3N-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202311250448.uz5Yom3N-lkp@intel.com/ All error/warnings (new ones prefixed by >>): In file included from drivers/pinctrl/pinctrl-ingenic.c:29:0: drivers/pinctrl/core.h:217:21: error: initializer element is not constant (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:200:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("mmc-1bit", jz4730_mmc_1bit, 1), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:21: note: (near initialization for 'jz4730_groups') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:200:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("mmc-1bit", jz4730_mmc_1bit, 1), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:21: error: initializer element is not constant (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:296:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("mmc-1bit", jz4740_mmc_1bit, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:21: note: (near initialization for 'jz4740_groups') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:296:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("mmc-1bit", jz4740_mmc_1bit, 0), ^~~~~~~~~~~~~~~~~ In file included from include/linux/gpio/driver.h:13:0, from drivers/pinctrl/pinctrl-ingenic.c:11: >> include/linux/pinctrl/pinctrl.h:43:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:297:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("mmc-4bit", jz4740_mmc_4bit, 0), ^~~~~~~~~~~~~~~~~ include/linux/pinctrl/pinctrl.h:43:1: note: (near initialization for '(anonymous).grp.name') (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:297:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("mmc-4bit", jz4740_mmc_4bit, 0), ^~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-ingenic.c:29:0: drivers/pinctrl/core.h:217:1: warning: missing braces around initializer [-Wmissing-braces] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:297:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("mmc-4bit", jz4740_mmc_4bit, 0), ^~~~~~~~~~~~~~~~~ >> drivers/pinctrl/core.h:217:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:297:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("mmc-4bit", jz4740_mmc_4bit, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[1].grp.name') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:297:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("mmc-4bit", jz4740_mmc_4bit, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: error: initializer element is not constant (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:297:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("mmc-4bit", jz4740_mmc_4bit, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[1].grp.name') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:297:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("mmc-4bit", jz4740_mmc_4bit, 0), ^~~~~~~~~~~~~~~~~ In file included from include/linux/gpio/driver.h:13:0, from drivers/pinctrl/pinctrl-ingenic.c:11: >> include/linux/pinctrl/pinctrl.h:43:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:298:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-data", jz4740_uart0_data, 1), ^~~~~~~~~~~~~~~~~ include/linux/pinctrl/pinctrl.h:43:1: note: (near initialization for '(anonymous).grp.name') (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:298:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-data", jz4740_uart0_data, 1), ^~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-ingenic.c:29:0: drivers/pinctrl/core.h:217:1: warning: missing braces around initializer [-Wmissing-braces] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:298:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-data", jz4740_uart0_data, 1), ^~~~~~~~~~~~~~~~~ >> drivers/pinctrl/core.h:217:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:298:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-data", jz4740_uart0_data, 1), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[1].grp.pins') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:298:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-data", jz4740_uart0_data, 1), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: error: initializer element is not constant (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:298:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-data", jz4740_uart0_data, 1), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[1].grp.pins') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:298:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-data", jz4740_uart0_data, 1), ^~~~~~~~~~~~~~~~~ In file included from include/linux/gpio/driver.h:13:0, from drivers/pinctrl/pinctrl-ingenic.c:11: >> include/linux/pinctrl/pinctrl.h:43:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:299:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-hwflow", jz4740_uart0_hwflow, 1), ^~~~~~~~~~~~~~~~~ include/linux/pinctrl/pinctrl.h:43:1: note: (near initialization for '(anonymous).grp.name') (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:299:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-hwflow", jz4740_uart0_hwflow, 1), ^~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-ingenic.c:29:0: drivers/pinctrl/core.h:217:1: warning: missing braces around initializer [-Wmissing-braces] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:299:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-hwflow", jz4740_uart0_hwflow, 1), ^~~~~~~~~~~~~~~~~ >> drivers/pinctrl/core.h:217:1: warning: initialization makes integer from pointer without a cast [-Wint-conversion] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:299:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-hwflow", jz4740_uart0_hwflow, 1), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[1].grp.npins') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:299:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-hwflow", jz4740_uart0_hwflow, 1), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: error: initializer element is not constant (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:299:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-hwflow", jz4740_uart0_hwflow, 1), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[1].grp.npins') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:299:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart0-hwflow", jz4740_uart0_hwflow, 1), ^~~~~~~~~~~~~~~~~ In file included from include/linux/gpio/driver.h:13:0, from drivers/pinctrl/pinctrl-ingenic.c:11: >> include/linux/pinctrl/pinctrl.h:43:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:300:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart1-data", jz4740_uart1_data, 2), ^~~~~~~~~~~~~~~~~ include/linux/pinctrl/pinctrl.h:43:1: note: (near initialization for '(anonymous).grp.name') (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:300:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart1-data", jz4740_uart1_data, 2), ^~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-ingenic.c:29:0: drivers/pinctrl/core.h:217:1: warning: missing braces around initializer [-Wmissing-braces] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:300:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart1-data", jz4740_uart1_data, 2), ^~~~~~~~~~~~~~~~~ >> drivers/pinctrl/core.h:217:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:300:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart1-data", jz4740_uart1_data, 2), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[1].name') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:300:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart1-data", jz4740_uart1_data, 2), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: error: initializer element is not constant (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:300:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart1-data", jz4740_uart1_data, 2), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[1].name') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:300:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("uart1-data", jz4740_uart1_data, 2), ^~~~~~~~~~~~~~~~~ In file included from include/linux/gpio/driver.h:13:0, from drivers/pinctrl/pinctrl-ingenic.c:11: >> include/linux/pinctrl/pinctrl.h:43:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:301:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-8bit", jz4740_lcd_8bit, 0), ^~~~~~~~~~~~~~~~~ include/linux/pinctrl/pinctrl.h:43:1: note: (near initialization for '(anonymous).grp.name') (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:301:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-8bit", jz4740_lcd_8bit, 0), ^~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-ingenic.c:29:0: drivers/pinctrl/core.h:217:1: warning: missing braces around initializer [-Wmissing-braces] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:301:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-8bit", jz4740_lcd_8bit, 0), ^~~~~~~~~~~~~~~~~ >> drivers/pinctrl/core.h:217:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:301:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-8bit", jz4740_lcd_8bit, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[1].pins') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:301:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-8bit", jz4740_lcd_8bit, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: error: initializer element is not constant (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:301:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-8bit", jz4740_lcd_8bit, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[1].pins') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:301:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-8bit", jz4740_lcd_8bit, 0), ^~~~~~~~~~~~~~~~~ In file included from include/linux/gpio/driver.h:13:0, from drivers/pinctrl/pinctrl-ingenic.c:11: >> include/linux/pinctrl/pinctrl.h:43:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:302:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-16bit", jz4740_lcd_16bit, 0), ^~~~~~~~~~~~~~~~~ include/linux/pinctrl/pinctrl.h:43:1: note: (near initialization for '(anonymous).grp.name') (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:302:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-16bit", jz4740_lcd_16bit, 0), ^~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-ingenic.c:29:0: drivers/pinctrl/core.h:217:1: warning: missing braces around initializer [-Wmissing-braces] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:302:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-16bit", jz4740_lcd_16bit, 0), ^~~~~~~~~~~~~~~~~ >> drivers/pinctrl/core.h:217:1: warning: initialization makes integer from pointer without a cast [-Wint-conversion] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:302:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-16bit", jz4740_lcd_16bit, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[1].num_pins') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:302:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-16bit", jz4740_lcd_16bit, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: error: initializer element is not constant (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:302:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-16bit", jz4740_lcd_16bit, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[1].num_pins') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:302:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-16bit", jz4740_lcd_16bit, 0), ^~~~~~~~~~~~~~~~~ In file included from include/linux/gpio/driver.h:13:0, from drivers/pinctrl/pinctrl-ingenic.c:11: >> include/linux/pinctrl/pinctrl.h:43:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:303:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-18bit", jz4740_lcd_18bit, 0), ^~~~~~~~~~~~~~~~~ include/linux/pinctrl/pinctrl.h:43:1: note: (near initialization for '(anonymous).grp.name') (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:303:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-18bit", jz4740_lcd_18bit, 0), ^~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-ingenic.c:29:0: drivers/pinctrl/core.h:217:1: warning: missing braces around initializer [-Wmissing-braces] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:303:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-18bit", jz4740_lcd_18bit, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:303:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-18bit", jz4740_lcd_18bit, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: error: initializer element is not constant (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:303:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-18bit", jz4740_lcd_18bit, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[1].data') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:303:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-18bit", jz4740_lcd_18bit, 0), ^~~~~~~~~~~~~~~~~ In file included from include/linux/gpio/driver.h:13:0, from drivers/pinctrl/pinctrl-ingenic.c:11: >> include/linux/pinctrl/pinctrl.h:43:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:304:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-special", jz4740_lcd_special, 0), ^~~~~~~~~~~~~~~~~ include/linux/pinctrl/pinctrl.h:43:1: note: (near initialization for '(anonymous).grp.name') (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:304:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-special", jz4740_lcd_special, 0), ^~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-ingenic.c:29:0: drivers/pinctrl/core.h:217:1: warning: missing braces around initializer [-Wmissing-braces] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:304:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-special", jz4740_lcd_special, 0), ^~~~~~~~~~~~~~~~~ >> drivers/pinctrl/core.h:217:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:304:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-special", jz4740_lcd_special, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[2].grp.name') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:304:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-special", jz4740_lcd_special, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: error: initializer element is not constant (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:304:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-special", jz4740_lcd_special, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[2].grp.name') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:304:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-special", jz4740_lcd_special, 0), ^~~~~~~~~~~~~~~~~ In file included from include/linux/gpio/driver.h:13:0, from drivers/pinctrl/pinctrl-ingenic.c:11: >> include/linux/pinctrl/pinctrl.h:43:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:305:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-generic", jz4740_lcd_generic, 0), ^~~~~~~~~~~~~~~~~ include/linux/pinctrl/pinctrl.h:43:1: note: (near initialization for '(anonymous).grp.name') (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:305:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-generic", jz4740_lcd_generic, 0), ^~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-ingenic.c:29:0: drivers/pinctrl/core.h:217:1: warning: missing braces around initializer [-Wmissing-braces] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:305:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-generic", jz4740_lcd_generic, 0), ^~~~~~~~~~~~~~~~~ >> drivers/pinctrl/core.h:217:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:305:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-generic", jz4740_lcd_generic, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[2].grp.pins') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:305:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-generic", jz4740_lcd_generic, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: error: initializer element is not constant (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:305:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-generic", jz4740_lcd_generic, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[2].grp.pins') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:305:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("lcd-generic", jz4740_lcd_generic, 0), ^~~~~~~~~~~~~~~~~ In file included from include/linux/gpio/driver.h:13:0, from drivers/pinctrl/pinctrl-ingenic.c:11: >> include/linux/pinctrl/pinctrl.h:43:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:306:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs1", jz4740_nand_cs1, 0), ^~~~~~~~~~~~~~~~~ include/linux/pinctrl/pinctrl.h:43:1: note: (near initialization for '(anonymous).grp.name') (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:306:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs1", jz4740_nand_cs1, 0), ^~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-ingenic.c:29:0: drivers/pinctrl/core.h:217:1: warning: missing braces around initializer [-Wmissing-braces] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:306:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs1", jz4740_nand_cs1, 0), ^~~~~~~~~~~~~~~~~ >> drivers/pinctrl/core.h:217:1: warning: initialization makes integer from pointer without a cast [-Wint-conversion] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:306:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs1", jz4740_nand_cs1, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[2].grp.npins') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:306:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs1", jz4740_nand_cs1, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: error: initializer element is not constant (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:306:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs1", jz4740_nand_cs1, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[2].grp.npins') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:306:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs1", jz4740_nand_cs1, 0), ^~~~~~~~~~~~~~~~~ In file included from include/linux/gpio/driver.h:13:0, from drivers/pinctrl/pinctrl-ingenic.c:11: >> include/linux/pinctrl/pinctrl.h:43:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:307:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs2", jz4740_nand_cs2, 0), ^~~~~~~~~~~~~~~~~ include/linux/pinctrl/pinctrl.h:43:1: note: (near initialization for '(anonymous).grp.name') (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:307:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs2", jz4740_nand_cs2, 0), ^~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-ingenic.c:29:0: drivers/pinctrl/core.h:217:1: warning: missing braces around initializer [-Wmissing-braces] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:307:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs2", jz4740_nand_cs2, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:307:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs2", jz4740_nand_cs2, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[2].name') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:307:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs2", jz4740_nand_cs2, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: error: initializer element is not constant (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:307:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs2", jz4740_nand_cs2, 0), ^~~~~~~~~~~~~~~~~ drivers/pinctrl/core.h:217:1: note: (near initialization for 'jz4740_groups[2].name') (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:307:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs2", jz4740_nand_cs2, 0), ^~~~~~~~~~~~~~~~~ In file included from include/linux/gpio/driver.h:13:0, from drivers/pinctrl/pinctrl-ingenic.c:11: include/linux/pinctrl/pinctrl.h:43:1: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:308:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs3", jz4740_nand_cs3, 0), ^~~~~~~~~~~~~~~~~ include/linux/pinctrl/pinctrl.h:43:1: note: (near initialization for '(anonymous).grp.name') (struct pingroup) { \ ^ drivers/pinctrl/core.h:218:9: note: in expansion of macro 'PINCTRL_PINGROUP' .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ ^~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins), (void *)(func)) ^~~~~~~~~~~~~~~~~~ drivers/pinctrl/pinctrl-ingenic.c:308:2: note: in expansion of macro 'INGENIC_PIN_GROUP' INGENIC_PIN_GROUP("nand-cs3", jz4740_nand_cs3, 0), ^~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-ingenic.c:29:0: drivers/pinctrl/core.h:217:1: warning: missing braces around initializer [-Wmissing-braces] (struct group_desc) { \ ^ drivers/pinctrl/pinctrl-ingenic.c:89:2: note: in expansion of macro 'PINCTRL_GROUP_DESC' vim +43 include/linux/pinctrl/pinctrl.h 003cbe04617159 Basavaraj Natikar 2022-06-01 40 003cbe04617159 Basavaraj Natikar 2022-06-01 41 /* Convenience macro to define a single named or anonymous pingroup */ 003cbe04617159 Basavaraj Natikar 2022-06-01 42 #define PINCTRL_PINGROUP(_name, _pins, _npins) \ 003cbe04617159 Basavaraj Natikar 2022-06-01 @43 (struct pingroup) { \ 003cbe04617159 Basavaraj Natikar 2022-06-01 44 .name = _name, \ 003cbe04617159 Basavaraj Natikar 2022-06-01 45 .pins = _pins, \ 003cbe04617159 Basavaraj Natikar 2022-06-01 46 .npins = _npins, \ 003cbe04617159 Basavaraj Natikar 2022-06-01 47 } 003cbe04617159 Basavaraj Natikar 2022-06-01 48
On Sat, Nov 25, 2023 at 07:39:02AM +0800, kernel test robot wrote: > Hi Andy, > > kernel test robot noticed the following build errors: > [also build test ERROR on linusw-pinctrl/for-next next-20231124] Hmm... I have compiled tested on Linux Next it several times, I can't reproduce this neither with GCC nor with LLVM.
On Tue, Nov 28, 2023 at 05:53:21PM +0200, Andy Shevchenko wrote: > On Sat, Nov 25, 2023 at 07:39:02AM +0800, kernel test robot wrote: > > Hi Andy, > > > > kernel test robot noticed the following build errors: > > > [also build test ERROR on linusw-pinctrl/for-next next-20231124] > > Hmm... I have compiled tested on Linux Next it several times, I can't reproduce > this neither with GCC nor with LLVM. Actually it rings a bell that some versions of GCC have a bug (?) that they may not identify initializations like this to be converted to constants as we are using compound literal it should make no difference.
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 3f1fd50fbb10..e08d4b3b0a56 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -559,7 +559,10 @@ const char *pinctrl_generic_get_group_name(struct pinctrl_dev *pctldev, if (!group) return NULL; - return group->name; + if (group->name) + return group->name; + + return group->grp.name; } EXPORT_SYMBOL_GPL(pinctrl_generic_get_group_name); @@ -585,8 +588,14 @@ int pinctrl_generic_get_group_pins(struct pinctrl_dev *pctldev, return -EINVAL; } - *pins = group->pins; - *num_pins = group->num_pins; + if (group->pins) { + *pins = group->pins; + *num_pins = group->num_pins; + return 0; + } + + *pins = group->grp.pins; + *num_pins = group->grp.npins; return 0; } diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h index 276a631fd49c..863b4956a41e 100644 --- a/drivers/pinctrl/core.h +++ b/drivers/pinctrl/core.h @@ -194,14 +194,18 @@ struct pinctrl_maps { #ifdef CONFIG_GENERIC_PINCTRL_GROUPS +#include <linux/pinctrl/pinctrl.h> + /** * struct group_desc - generic pin group descriptor + * @grp: generic data of the pin group (name and pins) * @name: name of the pin group * @pins: array of pins that belong to the group * @num_pins: number of pins in the group * @data: pin controller driver specific data */ struct group_desc { + struct pingroup grp; const char *name; const int *pins; int num_pins; @@ -211,6 +215,7 @@ struct group_desc { /* Convenience macro to define a generic pin group descriptor */ #define PINCTRL_GROUP_DESC(_name, _pins, _num_pins, _data) \ (struct group_desc) { \ + .grp = PINCTRL_PINGROUP(_name, _pins, _num_pins), \ .name = _name, \ .pins = _pins, \ .num_pins = _num_pins, \