Message ID | 20231123-dwmac-rk_phy_wol-v1-1-bf4e718081b9@wolfvision.net |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp400530vqx; Thu, 23 Nov 2023 04:17:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFMsnbvZNY7fotQjq/Sf8Tk5jKiakE+VPWccM9XcMqVwMYAlnmY05Ahpwn8eW2P2G5/1WXg X-Received: by 2002:a17:902:e9c5:b0:1cf:56bf:8dd5 with SMTP id 5-20020a170902e9c500b001cf56bf8dd5mr4903141plk.51.1700741837179; Thu, 23 Nov 2023 04:17:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1700741837; cv=pass; d=google.com; s=arc-20160816; b=j0rGpfXjne9usFPtLpDDFp3W9Gw7TCKPBIP0hpFjxwg5zcrGRKrQ/6Wffq9ZCF9Lz5 XM9GqER+//cAFCfowWDCdc4y6DHZkr5kNDI7fRETBH/I6SVLJ4R0BwW5Zj2jI8ZvIqS9 Ml+dr1q4mvpKXcGzT9YnuNsjlQ1rHy+DceA9QSHhrZGmm6j9JndznJyNq4WvLWz2mGBI kcGrmF6Pt8+O1LmPRFatl71n/9dTyoynKulHlhtrXAxKarvVHZQEyF0FxUvBu+EJzciY dVjnHChlMIofonMWDnkc0iSn18J18f+dwugyLKMQo/VLoRt4DOj6Amfa3EAyE/FtcUMV gVXg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:cc:to:in-reply-to:references :message-id:content-transfer-encoding:subject:date:from :dkim-signature; bh=JT1UHAK8mf2BxFRMKPA7B37sIWgCMnP/9/n44FUcXBk=; fh=I+mp2iE83YRg0vsrSK94X0MYvN9utJiRswALBfniw1g=; b=uG3HileS5vOwS6z4jYak0POdEK3SNhfwMLu0GvpIsa7A6AQpA4mDFplUMyxTk96CfM kEt9Ugy1hyFtgx38kQhKRgOI20YFMSwdE9oUofLVWkjPQ82DKs06jmbchuTwprsMf0wk OdS98VeLBj6dEjMAOuoIbQ65Vlf12pmbgo34wpZzEpFa/qBhsKTswtoYX7M7LCd+7GqV MU/jZWzzsypl6OHgvFAf1xK/xMBpfP2D62VXNnzc7rCDTi0wL6CDBd4BPLQo996NCp71 iIFEegXIYjdHDswOADD7f9zruq0xNGygeSqXP6xVSS0sSqPBD8vvJRxUx1SMMu6Gh6Y+ 9RbQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@wolfvision.net header.s=selector2 header.b=HiXFXGOl; arc=pass (i=1 spf=pass spfdomain=wolfvision.net dkim=pass dkdomain=wolfvision.net dmarc=pass fromdomain=wolfvision.net); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=wolfvision.net Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id w13-20020a170902e88d00b001c3e98a0d79si1059828plg.401.2023.11.23.04.17.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 04:17:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@wolfvision.net header.s=selector2 header.b=HiXFXGOl; arc=pass (i=1 spf=pass spfdomain=wolfvision.net dkim=pass dkdomain=wolfvision.net dmarc=pass fromdomain=wolfvision.net); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=wolfvision.net Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 9BFFA801E1D1; Thu, 23 Nov 2023 04:15:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345245AbjKWMPU (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Thu, 23 Nov 2023 07:15:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345252AbjKWMPR (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 23 Nov 2023 07:15:17 -0500 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2058.outbound.protection.outlook.com [40.107.7.58]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B3BFD56; Thu, 23 Nov 2023 04:15:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+2jiqE8R9ZGKAgRsjUUTHKYQJFAsSgLD5M4qpFGVN4AFWs54gRykB8hS5j5gG8ocm0iNWk/THC2WUowiZEIr9A5jIfB1EeKPIT9mF/OROnqKkvEP0BCFapEw9GvkYgygQhfsmFTdn0fsepudcw3ASqOY19PiKvdLgnavLiPsR2nS3tPUkqBolY41fag3WkOLVh3CJMyqgEtmhjiMTnPtYQ4qGu7lC8of3xwMbR83HuNYvtmciyV7L/jZElcbHryuczhIaCU2ZZiDxbeDZ3z+ZvXyjvrX19rJN7hRnaRQPN0b0EtgCSo9jlFat9ASX5YPgYL9EpZO5o7ahc9OT+Rew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JT1UHAK8mf2BxFRMKPA7B37sIWgCMnP/9/n44FUcXBk=; b=IM6FVpC7/Oo3KQo85jvEcDsRbs/nry7WtoUpYg7RmnqSFwE/WD39e80AILzjknzFJCDvgh6GVENl/IDrZZscq4lyrrAJggaSbfF6wioGAt3xljJUYfEultYbM5xLOAxBsmTGYAhKESILaAePNYh5cYuaX+5H0yRR7pYeFhp53vRDbw68xktUmbqxgEa2i8L0IaBx65+j7U8P5z+mF9dJFNjE3JPJ3Bc4ZpjCEOTSzkTdzO+r6D1hiPq+pPfOJHtPW3MG8+tNgQckyC1YHQTYA84hNX+QDp41RLAT1RLvBIjd8WtzUxAbi0SXK0ii6RkWqZPcf/0OKSAd825Oy9GRbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wolfvision.net; dmarc=pass action=none header.from=wolfvision.net; dkim=pass header.d=wolfvision.net; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wolfvision.net; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JT1UHAK8mf2BxFRMKPA7B37sIWgCMnP/9/n44FUcXBk=; b=HiXFXGOlVIR7w/G7VTO1+rYfIQfMsQKltI8H3C6J8h+EWgAYkU8UgMW16nK6nHjsxgEIT3HSrP0TW3BKN1EBK1ab+0hnbbTnMwX+CQylwxlSIo6KVypF4rjbP9FwW1QrucvbfXqVsGZt1hLir3+cQSJBFPL9wmNt2yqVM3pToHc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wolfvision.net; Received: from VE1PR08MB4974.eurprd08.prod.outlook.com (2603:10a6:803:111::15) by DU0PR08MB8423.eurprd08.prod.outlook.com (2603:10a6:10:405::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.18; Thu, 23 Nov 2023 12:15:16 +0000 Received: from VE1PR08MB4974.eurprd08.prod.outlook.com ([fe80::6b40:1e6f:7c94:71dc]) by VE1PR08MB4974.eurprd08.prod.outlook.com ([fe80::6b40:1e6f:7c94:71dc%4]) with mapi id 15.20.7025.020; Thu, 23 Nov 2023 12:15:16 +0000 From: Javier Carrasco <javier.carrasco@wolfvision.net> Date: Thu, 23 Nov 2023 13:14:13 +0100 Subject: [PATCH RFC WIP 1/2] dt-bindings: net: rockchip-dwmac: add rockchip,phy-wol property Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231123-dwmac-rk_phy_wol-v1-1-bf4e718081b9@wolfvision.net> References: <20231123-dwmac-rk_phy_wol-v1-0-bf4e718081b9@wolfvision.net> In-Reply-To: <20231123-dwmac-rk_phy_wol-v1-0-bf4e718081b9@wolfvision.net> To: "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>, David Wu <david.wu@rock-chips.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Javier Carrasco <javier.carrasco@wolfvision.net> X-Mailer: b4 0.12.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1700741701; l=1046; i=javier.carrasco@wolfvision.net; s=20230509; h=from:subject:message-id; bh=5nCO7JT4rELhAOOidUsUPsNZ2GKEnGwXx3JdX0dzDQQ=; b=UeEC7LCJswlJVl64pR16sDF8op2YugDv1KeanMbaonXr+v5Pq1wNbIKTv5zk8Q9qoUJ2G3Szt s2Q2MpIVOLtCRpLd2dATlMYGcb+SigDPkFkFJNm7VW9piKpMjEcszBg X-Developer-Key: i=javier.carrasco@wolfvision.net; a=ed25519; pk=tIGJV7M+tCizagNijF0eGMBGcOsPD+0cWGfKjl4h6K8= X-ClientProxiedBy: VI1PR06CA0227.eurprd06.prod.outlook.com (2603:10a6:802:2c::48) To VE1PR08MB4974.eurprd08.prod.outlook.com (2603:10a6:803:111::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR08MB4974:EE_|DU0PR08MB8423:EE_ X-MS-Office365-Filtering-Correlation-Id: d2b22efc-0458-4139-1fcb-08dbec1dd2e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +0BUUNwvy1j/IDnejKD9cl8+cKbzQKEgxe17dS5Hn5jU/5QKGtO8qwvirM+1rExlV8vgE8pwwLkeDlhZP00ThrlnuSypn3OckMZPE05a/9Et8r2mWPGz9/Y4Tv2NPmoeGt8eALL7E7TSS4Ef/haEELBFk3UfaN+EM/YcP6BaXwa1FEZboHmNaG/Zpk0drbwr3AOaAVLo8GUX5FPdF84Gj5CbDA2UIw3bJS2i/2BNP4bZ1mPn0WsuB4K6yGs59c1f8G/4TapFgarPwnjbQ8ZVM8MwlKT0lFPiN/1Af0F/tmADCyd82ZLLj+v4OjT2cawE7VjN9BPg9qs1C3oEFvtUEw9ZEWUPq/CTFzS0B/VmdOt7jQHqcM7RWSXTnWxMyUFgi+ssbiD0eVKjSL9aDAHpLvxkr89hWWx2HBMD99JgqNtAHKZUVg7BotW8zJaG5hpmFSebQGlhLKskOUhF9+2a0SaYg3k117sqZumbAmjX0X8wtpOG5hv4utdjtN/1tOcCULYTqIBopmCLI3e5YLMHyiJ027B07YdwNPwHW0nU6YgLCNhUPNPO0mXTpR79QY/b1Z8wdyQd3RZw/S0soJrnoIrJuS+HFo7Aw0srSsX35safGo/SYGQOUoZP0Zt8dCUb88bYwm3AH0MkxcfyXSntCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB4974.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(376002)(346002)(366004)(39850400004)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(921008)(26005)(2906002)(7416002)(4744005)(38100700002)(66556008)(66946007)(2616005)(107886003)(44832011)(5660300002)(41300700001)(8936002)(4326008)(8676002)(6486002)(86362001)(38350700005)(478600001)(66476007)(36756003)(110136005)(316002)(6512007)(6666004)(52116002)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?okIWI9X7XWyqG/fJR6+1Ht2wWa57?= =?utf-8?q?yDBD2wZOPqGP+9Ogft6Mx7bzvPhxwxDGZyVGNK9+r2sJ/ym9jfQJHUb3dPc84tGzV?= =?utf-8?q?SsjSYDDCIgb8P76pXAjf7BoN8mcrmbpulgKaB3wBAHmmyACGBk7pyDUVKDC24oZ3C?= =?utf-8?q?I/XGkDBHQn6qr99tCFgOIm5/qwTc1cL+zhhpxkXE78JcJ2PqPW3K9mzudNRXtveFP?= =?utf-8?q?wnCBpKJMATHzptrZeBa7tIO0dhckZwYiZSeHVJKMfp8xMAyBVMuzGOpqi5qx9G4+x?= =?utf-8?q?zGOdwCTTpamEr+opraTY9pYUAkh+RFKE1h/gtHMe6N8NDgJjrDBXRlsBM7aYnnra9?= =?utf-8?q?bmEliUNqeqn+qky3DJ93Mj9WE7trrJmwMpcZY+ke5LnnSoxxm+5eZOpe3feBHJQ4s?= =?utf-8?q?eRrDnnELnn8Nzgd4hJRgc5EOOYPmYjSLuoPFM7xN7ZuW+zEcN1lkEwol8rJud+HNG?= =?utf-8?q?Kf6CJBI4E3+zrwhCS+YXKer1TlS+i6YDKl1OEer6NicX7tKNMDLkhWtSn2tiOOSq5?= =?utf-8?q?BHeZSRJMO3GKCd1BCPPrLsc+lhFCcvBEhQxeb57B550IUmsl5Z+0tn7sWq5BzjBnH?= =?utf-8?q?tybyGanHFhi2EsrJK3nnsVSHAuQGbeBZysGA9Tv8ZchjNmJkKMUxwgFiQy6Zp2K13?= =?utf-8?q?L38UcGqkDs9AHtSfq/sbxIyMsakpkIOGsgmZW8C0FuqvDwMtWYElXmw5M+5PnjC10?= =?utf-8?q?CKmPFK7q7Chuzw/lczpzWbrus2nyrd4mRqc3OxZ16Y+gxjVSmRxKhM4QAu1fqxVOq?= =?utf-8?q?uGzWLz1AR2CPKBcl98xYQ3frCgjI8WHZoAUT6HrIWCck+wjiWAqTTJkqpXOZmTzI4?= =?utf-8?q?1X0eVmFjk+4qm+TqTduEzHQ4XZQ0SEVhoXIlcNn+d2aJUEku6ti9welKO8Kmc6mDe?= =?utf-8?q?FJIerTvXuwRDY2/xWNhwRseTUl0uBbUirsC0VmKLFuV3yCUXSjBTXAEBuOZr8JJBv?= =?utf-8?q?Ixnl5G0LwkIaaUC/kohWnr1DTg/QEHQGvkHY3woTwIf9eBdJJGx/+YC4tRKg4snkZ?= =?utf-8?q?q7RVWeKdxhdYFvg+mUGGRS/FyltPzFRYyQpDMQnLb0hY4dxBnc/o2af2kzPnVIRNm?= =?utf-8?q?MieTNvuMogZGUT4dIEotZjWZyZrfOVFYJmrjXBqdE0948BWBZXFiWxK2GG4KNKyCD?= =?utf-8?q?yL1yH3VTLrVWDUnIjZh4WlEhu3RT9eUGPjAeQqtwMUOcM9dZ8s77a+FxojV2g3oHj?= =?utf-8?q?62/vjodeodtYDd1soN7FhS5MVh0hAGArSl5xdQIw744itmsWxdT6N5YdAt/PWSTYr?= =?utf-8?q?Mshu5oFUAAFTxTFsvVPRoNl8/8iMK+F7C6dhDE0fsbmghnY6w3Bq8io8ByYKE2W6D?= =?utf-8?q?ndi1AzXwCLFXZkbaC4baGUHh2mJGfuhgGLArximWQGENAOdF0h6A9koxkqjzryAu3?= =?utf-8?q?cLXHAogd76PVl9D3oglvd7ClixSJfVxSenxf5KGu7HEdtPW2e55wWyBOOuO1G0td+?= =?utf-8?q?G28ycffXBTcVy+E7R15wfDRAXjOekf+/t847/VHMz5QIH3sgQ8JnzGTyxhKiX8d1S?= =?utf-8?q?ZqBsj2xaRHH9K5bTOFzrWF87lM2efX5x83fHJtZ/f8+mljdiyjdqyCQ=3D?= X-OriginatorOrg: wolfvision.net X-MS-Exchange-CrossTenant-Network-Message-Id: d2b22efc-0458-4139-1fcb-08dbec1dd2e0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 12:15:04.0333 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ueja0yb86HgygVWt4v+g3oDWA36hJFf81zeQcEDqnTwvR2MwIc25sIVAtwYW7+iomSF/ilT0MISDiOAq9KZjAtAHoSRWNseU96paf2EMlmg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8423 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 23 Nov 2023 04:15:37 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783357072473086266 X-GMAIL-MSGID: 1783357072473086266 |
Series |
net: stmmac: dwmac-rk: add support for PHY wake on LAN
|
|
Commit Message
Javier Carrasco
Nov. 23, 2023, 12:14 p.m. UTC
This property defines if PHY WOL is preferred. If it is not defined, MAC
WOL will be preferred instead.
Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
---
Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++++
1 file changed, 6 insertions(+)
Comments
On Thu, Nov 23, 2023 at 01:14:13PM +0100, Javier Carrasco wrote: > This property defines if PHY WOL is preferred. If it is not defined, MAC > WOL will be preferred instead. > > Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> > --- > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index 70bbc4220e2a..fc4b02a5a375 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -91,6 +91,12 @@ properties: > The phandle of the syscon node for the peripheral general register file. > $ref: /schemas/types.yaml#/definitions/phandle > > + rockchip,phy-wol: > + type: boolean > + description: > + If present, indicates that PHY WOL is preferred. MAC WOL is preferred > + otherwise. Although I suspect this isn't, it sounds like software policy. What attribute of the hardware determines which is preferred?
On 23.11.23 18:20, Conor Dooley wrote: > On Thu, Nov 23, 2023 at 01:14:13PM +0100, Javier Carrasco wrote: >> This property defines if PHY WOL is preferred. If it is not defined, MAC >> WOL will be preferred instead. >> >> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> >> --- >> Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml >> index 70bbc4220e2a..fc4b02a5a375 100644 >> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml >> @@ -91,6 +91,12 @@ properties: >> The phandle of the syscon node for the peripheral general register file. >> $ref: /schemas/types.yaml#/definitions/phandle >> >> + rockchip,phy-wol: >> + type: boolean >> + description: >> + If present, indicates that PHY WOL is preferred. MAC WOL is preferred >> + otherwise. > > Although I suspect this isn't, it sounds like software policy. What > attribute of the hardware determines which is preferred? Maybe the word "preferred" set off a red flag. The description is taken from the mediatek,mac-wol, which is used to set the same flag with inverted logic (I could invert my logic to call mine rockchip,mac-wol and use a description without "preferences"). This property is used to enable the PHY WOL in case the MAC is powered off in suspend mode, so it cannot provide WOL. This is done by a PMIC as defined in the device tree and that should not be something the software could tweak. Best regards, Javier Carrasco
On 23/11/2023 20:36, Javier Carrasco wrote: > On 23.11.23 18:20, Conor Dooley wrote: >> On Thu, Nov 23, 2023 at 01:14:13PM +0100, Javier Carrasco wrote: >>> This property defines if PHY WOL is preferred. If it is not defined, MAC >>> WOL will be preferred instead. >>> >>> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> >>> --- >>> Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml >>> index 70bbc4220e2a..fc4b02a5a375 100644 >>> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml >>> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml >>> @@ -91,6 +91,12 @@ properties: >>> The phandle of the syscon node for the peripheral general register file. >>> $ref: /schemas/types.yaml#/definitions/phandle >>> >>> + rockchip,phy-wol: >>> + type: boolean >>> + description: >>> + If present, indicates that PHY WOL is preferred. MAC WOL is preferred >>> + otherwise. >> >> Although I suspect this isn't, it sounds like software policy. What >> attribute of the hardware determines which is preferred? > > Maybe the word "preferred" set off a red flag. The description is taken > from the mediatek,mac-wol, which is used to set the same flag with > inverted logic (I could invert my logic to call mine rockchip,mac-wol > and use a description without "preferences"). > > This property is used to enable the PHY WOL in case the MAC is powered > off in suspend mode, so it cannot provide WOL. This is done by a PMIC as > defined in the device tree and that should not be something the software > could tweak. I wonder if generic wakeup-source property could not be used. WOL is a bit different because it allows to actually turn on the computer, but otherwise it is also a wake-up. Best regards, Krzysztof
On Thu, Nov 23, 2023 at 05:20:48PM +0000, Conor Dooley wrote: > On Thu, Nov 23, 2023 at 01:14:13PM +0100, Javier Carrasco wrote: > > This property defines if PHY WOL is preferred. If it is not defined, MAC > > WOL will be preferred instead. > > > > Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> > > --- > > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > > index 70bbc4220e2a..fc4b02a5a375 100644 > > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > > @@ -91,6 +91,12 @@ properties: > > The phandle of the syscon node for the peripheral general register file. > > $ref: /schemas/types.yaml#/definitions/phandle > > > > + rockchip,phy-wol: > > + type: boolean > > + description: > > + If present, indicates that PHY WOL is preferred. MAC WOL is preferred > > + otherwise. > > Although I suspect this isn't, it sounds like software policy. What > attribute of the hardware determines which is preferred? I tend to agree, its a software policy. Doing WoL in the PHY should be the preferred solution, because it allows the MAC to be powered off, saving more power. If the PHY does not implement it, then the MAC should be used. It should be possible for the MAC driver to pass the WoL settings to the PHY, and if it returns EOPNOTSUPP, or maybe EINVAL, implement the WoL in the MAC. This might be a behaviour change, depending on the MAC driver. So i could imaging a less risk tolerant developers wanting a knob to enable this. However, if done correctly, using the PHY instead of the MAC should not be visible from the users perspective. Andrew
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml index 70bbc4220e2a..fc4b02a5a375 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml @@ -91,6 +91,12 @@ properties: The phandle of the syscon node for the peripheral general register file. $ref: /schemas/types.yaml#/definitions/phandle + rockchip,phy-wol: + type: boolean + description: + If present, indicates that PHY WOL is preferred. MAC WOL is preferred + otherwise. + tx_delay: description: Delay value for TXD timing. $ref: /schemas/types.yaml#/definitions/uint32