[08/10] drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
Message ID | 20231118180504.1785-9-hkallweit1@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp1305130vqn; Sat, 18 Nov 2023 10:06:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IFyaGtlDIDs5SvIvtfn8mx9jYXEiEzV4vDBfsljIVuW0pZjPcUbom16b/wRTW+8iF5yCTNd X-Received: by 2002:a05:6a00:1822:b0:68f:d1a7:1a3a with SMTP id y34-20020a056a00182200b0068fd1a71a3amr4029548pfa.8.1700330763194; Sat, 18 Nov 2023 10:06:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700330763; cv=none; d=google.com; s=arc-20160816; b=ieVf0abFL7stoxfTb8yy6z2bMo0lnpfbHIPbY8SOKBZafmi5ehLOfESslyxQpxlrJy FX8rdLVryZbYFedV8tFabcRddvw3ONeIKY3xtpwvfgZisnaCpZKsRdb9AZ/bxfplpQXH f8e+Ir7M39sVHtcRMes27wzdQ3xcODWdOvOT8FSrdAjVm86t+1JOcwvXMf7By4rPhsRi cHPTViwIaYE5C0VJNbi6xynGQTdiX3TM8oQf9Ftg8+OYKCSjyxSFpFhXKpzrOIxCDTtV c31MJO6pLiFP0WQOdW/O2njVGCJKPNxGu6TmpxHdqAMH6e9zk8LqJNQy+VJGk0eVFYMv 5dPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VbsbH1CThP42UiUJns2VDtTJbIoXHmLVJdFuam5YX4A=; fh=iwYNcjGNm7J5aBIB6zdxXujcpSkDHPjFUr6Dac0DENk=; b=A02qHPE9nC+a5Su1lGvwdITF/5QD+pTY1g8zh1fVcaZszm4BtkR3j/qMIuKSosjDLF 8lgsm5YUXCGUSYPqQZhtuOM1x++0vpRBimGaihYn9rCBOZ46VjsXMJArN7xWZSfFSOYc 4ZJvUuUVhfoe+odhQXzJsjt4JKE2NbSxRNiddyj3LccBWDgH/qNB59jm744tzGxwCxXK hBS4sxsFhe+bjo+7dPayrIEaX0UHJzvP7jcUGLVlI7hYzMmvgYO5z23Wmvv67WAR+pZV B18iV32GI3mJ8f9CLAqTfPz4AHQ2HtY9Ud33A8FjmW8CsB/m+wRcw629pEn5E7rG9qQu OD7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Dv1atdjH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id n7-20020a632707000000b005be27346472si4784730pgn.582.2023.11.18.10.06.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 10:06:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Dv1atdjH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D2ACA8032000; Sat, 18 Nov 2023 10:06:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230392AbjKRSFn (ORCPT <rfc822;jaysivo@gmail.com> + 29 others); Sat, 18 Nov 2023 13:05:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230470AbjKRSFZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 18 Nov 2023 13:05:25 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B153D58; Sat, 18 Nov 2023 10:05:18 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-9d0b4dfd60dso398915466b.1; Sat, 18 Nov 2023 10:05:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700330717; x=1700935517; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VbsbH1CThP42UiUJns2VDtTJbIoXHmLVJdFuam5YX4A=; b=Dv1atdjHcnH/I2odaOBenqZknAsMnKzuSQWWgeZPa2HfRKHZJKBv9Sl+MgIYr6Y2zU qnt75kcKK3rNa5np1KabUB7otAx/uHdrCDpkfxTNDq2YySVWaLAoA2YD9QzX4ZxnNYAn XVNHJxftBKepdmKI+60sTXxmODw1bw19uK0o61ZK2H0EiPa+ynDxqrGRz23vfxuKyx1f ISlGzp5f2j8gxxbXmg+xxvRVnWkhM3uSm2d01tFJls9GHsyI55WnagtCAyLLIuygy9hH 9Pn2xouodlTVkMQo0XJbA0yvvm/qzYoGxjg7v4tdZj2gwffmmA7RyDAw8a9b+g8ucMOK WkVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700330717; x=1700935517; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VbsbH1CThP42UiUJns2VDtTJbIoXHmLVJdFuam5YX4A=; b=jBrXXt5zX/hyUkTiM5FECe9OmA9I/R14NI2jc0mOG3jWZGQc93wDYNOK1gBqWBxKuy GYIF0VsG85tKxcMupytOVm4WcfHZeM7PpgAQcsGrk7Ur3kmRNrAnq8ipleSauB0E9q26 JK0Fzqm3UGly+7tL64LpYUPeUyYQk3D036e9TtvieHsWSZLiY4BEWoSCe2wAFGDa5rja Z5Vyw+OPUdqwpkWsBbprVr9HNC80TpxCEE4GZO1OsW+QIG/MwRQMgN7ZYynT+MfTXZ2C 04yR6g7bVXByu9UazPaaaZOjb/sgIa8Fw77XkGmjv73QtasT3IpB1GfzCuUIBVQjDLco J+TA== X-Gm-Message-State: AOJu0YxTHejG0lUrJ26vB1CPgidtrfvUJvfOuu9Lorlq3Qrf1rJwcGdM dGhqiO3afGPdk1uvGdN5kQE= X-Received: by 2002:a17:906:d7:b0:9ae:37d9:803e with SMTP id 23-20020a17090600d700b009ae37d9803emr2558599eji.8.1700330716752; Sat, 18 Nov 2023 10:05:16 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c22-77bf-8300-2223-08ff-fe18-0310.c22.pool.telefonica.de. [2a01:c22:77bf:8300:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id m20-20020a1709062b9400b009f2c769b4ebsm2079456ejg.151.2023.11.18.10.05.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 10:05:16 -0800 (PST) From: Heiner Kallweit <hkallweit1@gmail.com> To: Wolfram Sang <wsa@kernel.org>, Sergey Kozlov <serjk@netup.ru> Cc: linux-i2c@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>, Abylay Ospan <aospan@netup.ru>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/10] drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Date: Sat, 18 Nov 2023 19:05:02 +0100 Message-ID: <20231118180504.1785-9-hkallweit1@gmail.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231118180504.1785-1-hkallweit1@gmail.com> References: <20231118180504.1785-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 18 Nov 2023 10:06:01 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782926030328309883 X-GMAIL-MSGID: 1782926030328309883 |
Series |
Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
|
|
Commit Message
Heiner Kallweit
Nov. 18, 2023, 6:05 p.m. UTC
After removal of the legacy eeprom driver the only remaining I2C
client device driver supporting I2C_CLASS_SPD is jc42. Because this
driver also supports I2C_CLASS_HWMON, adapters don't have to
declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
It's one step towards getting rid of I2C_CLASS_SPD mid-term.
Series was created supported by Coccinelle and its splitpatch.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Sat, Nov 18, 2023 at 07:05:02PM +0100, Heiner Kallweit wrote: > After removal of the legacy eeprom driver the only remaining I2C > client device driver supporting I2C_CLASS_SPD is jc42. Because this > driver also supports I2C_CLASS_HWMON, adapters don't have to > declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON. > It's one step towards getting rid of I2C_CLASS_SPD mid-term. > > Series was created supported by Coccinelle and its splitpatch. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> As I want to apply this cleanup early in the cycle, could we have an ack for me to modify this subsystem, please? > > --- > drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c > index bd38ce444..46676f2c8 100644 > --- a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c > +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c > @@ -289,7 +289,7 @@ static const struct i2c_algorithm netup_i2c_algorithm = { > static const struct i2c_adapter netup_i2c_adapter = { > .owner = THIS_MODULE, > .name = NETUP_UNIDVB_NAME, > - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD, > + .class = I2C_CLASS_HWMON, > .algo = &netup_i2c_algorithm, > }; > >
On 23.11.2023 21:55, Wolfram Sang wrote: > On Sat, Nov 18, 2023 at 07:05:02PM +0100, Heiner Kallweit wrote: >> After removal of the legacy eeprom driver the only remaining I2C >> client device driver supporting I2C_CLASS_SPD is jc42. Because this >> driver also supports I2C_CLASS_HWMON, adapters don't have to >> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON. >> It's one step towards getting rid of I2C_CLASS_SPD mid-term. >> >> Series was created supported by Coccinelle and its splitpatch. >> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > As I want to apply this cleanup early in the cycle, could we have an ack > for me to modify this subsystem, please? > Looking at the git history for this driver, there has been no sign of life from the official maintainers for years. Hopefully Mauro can ack this. >> >> --- >> drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c >> index bd38ce444..46676f2c8 100644 >> --- a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c >> +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c >> @@ -289,7 +289,7 @@ static const struct i2c_algorithm netup_i2c_algorithm = { >> static const struct i2c_adapter netup_i2c_adapter = { >> .owner = THIS_MODULE, >> .name = NETUP_UNIDVB_NAME, >> - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD, >> + .class = I2C_CLASS_HWMON, >> .algo = &netup_i2c_algorithm, >> }; >> >>
diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c index bd38ce444..46676f2c8 100644 --- a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c @@ -289,7 +289,7 @@ static const struct i2c_algorithm netup_i2c_algorithm = { static const struct i2c_adapter netup_i2c_adapter = { .owner = THIS_MODULE, .name = NETUP_UNIDVB_NAME, - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD, + .class = I2C_CLASS_HWMON, .algo = &netup_i2c_algorithm, };