Message ID | 20231122022805.511839-1-irogers@google.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2b07:b0:403:3b70:6f57 with SMTP id io7csp1052821vqb; Tue, 21 Nov 2023 18:28:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IF6qKhr679d1vpef3ey7E+PDxAya3+2FtUGXgG4EWt6oQUEnFgvclMNEZHIF2cUgp+BtgC6 X-Received: by 2002:a17:903:41d2:b0:1cc:5648:f15c with SMTP id u18-20020a17090341d200b001cc5648f15cmr1204781ple.48.1700620105905; Tue, 21 Nov 2023 18:28:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700620105; cv=none; d=google.com; s=arc-20160816; b=YDx536P5SJ4AnTnnsIwZkNZQmSDMvpwWVti2uAdToslGQGy0yY4j4LEzbP8utmVhhs QzMdGIJLu+12j2pvfC4Xa3noVKjyk+qSDl4rIM6e1D8fr7OHb+94NEbND4zbj8rtps7a vHBr1vFBikH52ZcFzXois+nPqnn4qfDZXhKcouRqkKyPo07kTsbt/aI27EPT85w3XwB7 cNw01+ORqZoTP806/lpOjr9vH6rfjeth3fRsqBdK40Xcbo+ysamGkUHSVsLqaJ0I0ze0 +bEmbnx6M4LzJ3AnoLf9ObkUyxoE/IEdXhuvQJcj5gaJSky8P8mGG57o5cpuyM1/jETI 9G9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:from:subject:mime-version:message-id:date :dkim-signature; bh=9IER+tn3y73SnSAMuBhvXywbHOoikax61O9o+LNCM00=; fh=rD6SoxS7+6hQSAFXzeSuWSuEyFKtsJh2ujjWRbRIh6w=; b=1EnpTjxdV7DG1KMya75l1hDf5D/WomOWcDO81MKWea6h+ekIvALC6cEMZD7fSqbdkd C7Q+kOfL3XjXu2CibpLQueryi35ZaqGEXrv5Lrc4ATGR4luy2EvARBpBCwXgqgHQbBZX Y+x8LHOqm7FDdMUJXMwiRMw9B5nUhsZJAXLVqQyCm//35usY43gk6dOhBMeZyby/f5aJ vdTdSkd7CqLI4wkyc1XxCzujPK6JF0W6r23ZVc6HNVE4DJNUnF6M4pxWDyeeqsN4sDB8 c2PfJXi+lX2ry6mBo0JgejXJYGaPKRW1r8qovYB8wL+FjRvcWD+B1K0kFmV9izCJt2L9 tVuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=bwb5hwGK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id iw18-20020a170903045200b001cbe9b9f160si11048669plb.5.2023.11.21.18.28.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 18:28:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=bwb5hwGK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 3581380EA4E7; Tue, 21 Nov 2023 18:28:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235037AbjKVC2U (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Tue, 21 Nov 2023 21:28:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235052AbjKVC2S (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 21 Nov 2023 21:28:18 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F1CEE7 for <linux-kernel@vger.kernel.org>; Tue, 21 Nov 2023 18:28:14 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5c87663a873so69616947b3.2 for <linux-kernel@vger.kernel.org>; Tue, 21 Nov 2023 18:28:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700620094; x=1701224894; darn=vger.kernel.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=9IER+tn3y73SnSAMuBhvXywbHOoikax61O9o+LNCM00=; b=bwb5hwGK+G0RyFqP8rWxyp5SQdIk0YoDhCFusnvQVU5bbhUZWqSQt2aNeZlleEwxbY E5NVuJ6uRvaTgrJYsXpuXv9LPOXVXEKbyOxJGAH5UZhnPedBmY8Ui7FinCopZkp0/QT9 ZT0fGrQDamJcqiLg61QUB4bOw/ujQ43KOhvEAmRBtmKlH4ZUe0ASlJULnPFPSasFSKbY J9SwGzs/pYCa4pSDxV8438XBvdsBhmJI8Al8VC5H+68w4x12bIjbj4VxwdoKOhCj2nKX 5bt+0b9r/TrwcTHcmIkY9Drs3x4J4bj7rCJeRGbODdysOmahVAyvPNaQ4dMTGIVwxZP4 Y2iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700620094; x=1701224894; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9IER+tn3y73SnSAMuBhvXywbHOoikax61O9o+LNCM00=; b=YHDOxYYW75BalRM8tspEEQWsdDM3kGtjtqq0gvBufj8VPs0F68Df5AMiAO48bIDd4U GgGq1DSbySLAI/5V6U7fWadEoiVK8QxYyBvfIhlK+C/pQycgwGLAFQ/mIEbuC5ERdK9y 9PdLTPGtJAfX7WrztQbO8s1bqBGLeXvE1ckZsqDd6q4iWqTbrURDL2iSOqoRSgrOGrf3 fc8cgGa2fO64yPyuUhLeSiyz7WoZb7TrOQJQqiXAAA7Is5uXA0zrS+6UYifK1u49dFwl anqSziw1eOxI5Nv3Bqg3N+7bmW/YCCUZwn7XGRVNhV5T4nin3inzqndVkH6FkP3Jd1H/ tsrg== X-Gm-Message-State: AOJu0Yz+aAQXAbs627ODyKUjnR3syqujpLLNYYorTzImmaJEg2nMbnp+ 80XsPH3I9Ygzr03QC56B1D5K5JKh8Fj7 X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:c36:a8cf:912c:9142]) (user=irogers job=sendgmr) by 2002:a81:4851:0:b0:5cb:f2cf:1572 with SMTP id v78-20020a814851000000b005cbf2cf1572mr22851ywa.1.1700620093802; Tue, 21 Nov 2023 18:28:13 -0800 (PST) Date: Tue, 21 Nov 2023 18:28:05 -0800 Message-Id: <20231122022805.511839-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.43.0.rc1.413.gea7ed67945-goog Subject: [PATCH v1] perf MANIFEST: Add gen-sysreg for ARM SPE From: Ian Rogers <irogers@google.com> To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Ian Rogers <irogers@google.com>, Adrian Hunter <adrian.hunter@intel.com>, Oliver Upton <oliver.upton@linux.dev>, Marc Zyngier <maz@kernel.org>, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 21 Nov 2023 18:28:20 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783229428017924952 X-GMAIL-MSGID: 1783229428017924952 |
Series |
[v1] perf MANIFEST: Add gen-sysreg for ARM SPE
|
|
Commit Message
Ian Rogers
Nov. 22, 2023, 2:28 a.m. UTC
The necessary files for generating sysreg-defs.h need adding to the
perf tool MANIFEST that lists the files for packaging the perf tool
source code. Fix for the following:
```
$ make perf-tar-src-pkg
$ tar xvf perf-6.7.0-rc2.tar
$ cd perf-6.7.0-rc2
$ make -C tools/perf
...
PERF_VERSION = 6.7.rc2.gc2d5304e6c64
make[3]: *** No rule to make target 'perf-6.7.0-rc2/arch/arm64/tools/gen-sysreg.awk', needed by 'perf-6.7.0-rc2/tools/arch/arm64/include/generated/asm/sysreg-defs.h'. Stop.
make[2]: *** [Makefile.perf:456: arm64-sysreg-defs] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile.perf:242: sub-make] Error 2
make: *** [Makefile:70: all] Error 2
make: Leaving directory 'perf-6.7.0-rc2/tools/perf'
...
```
Fixes: e2bdd172e665 ("perf build: Generate arm64's sysreg-defs.h and add to include path")
---
Note: the breakage is in Linus' tree and perf-tools, not yet in perf-tools-next.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/MANIFEST | 2 ++
1 file changed, 2 insertions(+)
Comments
Em Tue, Nov 21, 2023 at 06:28:05PM -0800, Ian Rogers escreveu: > The necessary files for generating sysreg-defs.h need adding to the > perf tool MANIFEST that lists the files for packaging the perf tool > source code. Fix for the following: > > ``` > $ make perf-tar-src-pkg > $ tar xvf perf-6.7.0-rc2.tar > $ cd perf-6.7.0-rc2 > $ make -C tools/perf > ... > PERF_VERSION = 6.7.rc2.gc2d5304e6c64 > make[3]: *** No rule to make target 'perf-6.7.0-rc2/arch/arm64/tools/gen-sysreg.awk', needed by 'perf-6.7.0-rc2/tools/arch/arm64/include/generated/asm/sysreg-defs.h'. Stop. > make[2]: *** [Makefile.perf:456: arm64-sysreg-defs] Error 2 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [Makefile.perf:242: sub-make] Error 2 > make: *** [Makefile:70: all] Error 2 > make: Leaving directory 'perf-6.7.0-rc2/tools/perf' > ... > ``` > > Fixes: e2bdd172e665 ("perf build: Generate arm64's sysreg-defs.h and add to include path") Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> Namhyung, I'm testing this together with your headers sync series + what is in perf-tools/tmp.perf-tools, will report results soon. - Arnaldo > --- > Note: the breakage is in Linus' tree and perf-tools, not yet in perf-tools-next. > > Signed-off-by: Ian Rogers <irogers@google.com> > --- > tools/perf/MANIFEST | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST > index 1da7f4b91b4f..dc42de1785ce 100644 > --- a/tools/perf/MANIFEST > +++ b/tools/perf/MANIFEST > @@ -1,3 +1,5 @@ > +arch/arm64/tools/gen-sysreg.awk > +arch/arm64/tools/sysreg > tools/perf > tools/arch > tools/scripts > -- > 2.43.0.rc1.413.gea7ed67945-goog >
Em Wed, Nov 22, 2023 at 09:18:03AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Nov 21, 2023 at 06:28:05PM -0800, Ian Rogers escreveu: > > The necessary files for generating sysreg-defs.h need adding to the > > perf tool MANIFEST that lists the files for packaging the perf tool > > source code. Fix for the following: > > > > ``` > > $ make perf-tar-src-pkg > > $ tar xvf perf-6.7.0-rc2.tar > > $ cd perf-6.7.0-rc2 > > $ make -C tools/perf And I detected this while doing these tests on perf-tools/tmp.perf-tools: [acme@toolbox perf-tools]$ git log --oneline -1 ; time make -C tools/perf build-test 4dbc034e08146c48 (HEAD -> perf-tools) tools/perf: Update tools's copy of mips syscall table make: Entering directory '/home/acme/git/perf-tools/tools/perf' egrep: warning: egrep is obsolescent; using grep -E - tarpkg: ./tests/perf-targz-src-pkg . make[1]: *** [tests/make:348: tarpkg] Error 2 make: *** [Makefile:103: build-test] Error 2 make: Leaving directory '/home/acme/git/perf-tools/tools/perf' real 0m7.498s user 0m12.059s sys 0m5.491s ⬢[acme@toolbox perf-tools]$ > > Fixes: e2bdd172e665 ("perf build: Generate arm64's sysreg-defs.h and add to include path") > > Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > Namhyung, I'm testing this together with your headers sync series + what > is in perf-tools/tmp.perf-tools, will report results soon. > > - Arnaldo > > > --- > > Note: the breakage is in Linus' tree and perf-tools, not yet in perf-tools-next. > > > > Signed-off-by: Ian Rogers <irogers@google.com> > > --- > > tools/perf/MANIFEST | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST > > index 1da7f4b91b4f..dc42de1785ce 100644 > > --- a/tools/perf/MANIFEST > > +++ b/tools/perf/MANIFEST > > @@ -1,3 +1,5 @@ > > +arch/arm64/tools/gen-sysreg.awk > > +arch/arm64/tools/sysreg > > tools/perf > > tools/arch > > tools/scripts > > -- > > 2.43.0.rc1.413.gea7ed67945-goog > > > > -- > > - Arnaldo
Hi Ian, On Tue, Nov 21, 2023 at 06:28:05PM -0800, Ian Rogers wrote: > The necessary files for generating sysreg-defs.h need adding to the > perf tool MANIFEST that lists the files for packaging the perf tool > source code. Fix for the following: > > ``` > $ make perf-tar-src-pkg > $ tar xvf perf-6.7.0-rc2.tar > $ cd perf-6.7.0-rc2 > $ make -C tools/perf > ... > PERF_VERSION = 6.7.rc2.gc2d5304e6c64 > make[3]: *** No rule to make target 'perf-6.7.0-rc2/arch/arm64/tools/gen-sysreg.awk', needed by 'perf-6.7.0-rc2/tools/arch/arm64/include/generated/asm/sysreg-defs.h'. Stop. > make[2]: *** [Makefile.perf:456: arm64-sysreg-defs] Error 2 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [Makefile.perf:242: sub-make] Error 2 > make: *** [Makefile:70: all] Error 2 > make: Leaving directory 'perf-6.7.0-rc2/tools/perf' > ... > ``` > > Fixes: e2bdd172e665 ("perf build: Generate arm64's sysreg-defs.h and add to include path") > --- > Note: the breakage is in Linus' tree and perf-tools, not yet in perf-tools-next. > > Signed-off-by: Ian Rogers <irogers@google.com> I had sent out fixes for both of your comments [*], no preference as to which gets applied. So, FWIW: Reviewed-by: Oliver Upton <oliver.upton@linux.dev> [*] https://lore.kernel.org/linux-perf-users/20231121192956.919380-1-oliver.upton@linux.dev/
Hi Arnaldo, On Wed, Nov 22, 2023 at 4:20 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > Em Wed, Nov 22, 2023 at 09:18:03AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Tue, Nov 21, 2023 at 06:28:05PM -0800, Ian Rogers escreveu: > > > The necessary files for generating sysreg-defs.h need adding to the > > > perf tool MANIFEST that lists the files for packaging the perf tool > > > source code. Fix for the following: > > > > > > ``` > > > $ make perf-tar-src-pkg > > > $ tar xvf perf-6.7.0-rc2.tar > > > $ cd perf-6.7.0-rc2 > > > $ make -C tools/perf > > And I detected this while doing these tests on > perf-tools/tmp.perf-tools: > > [acme@toolbox perf-tools]$ git log --oneline -1 ; time make -C tools/perf build-test > 4dbc034e08146c48 (HEAD -> perf-tools) tools/perf: Update tools's copy of mips syscall table > make: Entering directory '/home/acme/git/perf-tools/tools/perf' > egrep: warning: egrep is obsolescent; using grep -E > - tarpkg: ./tests/perf-targz-src-pkg . > make[1]: *** [tests/make:348: tarpkg] Error 2 > make: *** [Makefile:103: build-test] Error 2 > make: Leaving directory '/home/acme/git/perf-tools/tools/perf' > > real 0m7.498s > user 0m12.059s > sys 0m5.491s > ⬢[acme@toolbox perf-tools]$ > > > > Fixes: e2bdd172e665 ("perf build: Generate arm64's sysreg-defs.h and add to include path") > > > > Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > > > Namhyung, I'm testing this together with your headers sync series + what > > is in perf-tools/tmp.perf-tools, will report results soon. Great, thanks for the testing! Namhyung
Hi Oliver, On Wed, Nov 22, 2023 at 9:05 AM Oliver Upton <oliver.upton@linux.dev> wrote: > > Hi Ian, > > On Tue, Nov 21, 2023 at 06:28:05PM -0800, Ian Rogers wrote: > > The necessary files for generating sysreg-defs.h need adding to the > > perf tool MANIFEST that lists the files for packaging the perf tool > > source code. Fix for the following: > > > > ``` > > $ make perf-tar-src-pkg > > $ tar xvf perf-6.7.0-rc2.tar > > $ cd perf-6.7.0-rc2 > > $ make -C tools/perf > > ... > > PERF_VERSION = 6.7.rc2.gc2d5304e6c64 > > make[3]: *** No rule to make target 'perf-6.7.0-rc2/arch/arm64/tools/gen-sysreg.awk', needed by 'perf-6.7.0-rc2/tools/arch/arm64/include/generated/asm/sysreg-defs.h'. Stop. > > make[2]: *** [Makefile.perf:456: arm64-sysreg-defs] Error 2 > > make[2]: *** Waiting for unfinished jobs.... > > make[1]: *** [Makefile.perf:242: sub-make] Error 2 > > make: *** [Makefile:70: all] Error 2 > > make: Leaving directory 'perf-6.7.0-rc2/tools/perf' > > ... > > ``` > > > > Fixes: e2bdd172e665 ("perf build: Generate arm64's sysreg-defs.h and add to include path") > > --- > > Note: the breakage is in Linus' tree and perf-tools, not yet in perf-tools-next. > > > > Signed-off-by: Ian Rogers <irogers@google.com> > > I had sent out fixes for both of your comments [*], no preference as to > which gets applied. So, FWIW: > > Reviewed-by: Oliver Upton <oliver.upton@linux.dev> Thanks, I think I can pick up your patches as they came before. Namhyung > > [*] https://lore.kernel.org/linux-perf-users/20231121192956.919380-1-oliver.upton@linux.dev/
diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST index 1da7f4b91b4f..dc42de1785ce 100644 --- a/tools/perf/MANIFEST +++ b/tools/perf/MANIFEST @@ -1,3 +1,5 @@ +arch/arm64/tools/gen-sysreg.awk +arch/arm64/tools/sysreg tools/perf tools/arch tools/scripts