Message ID | E1r0JLV-00CTxS-QB@rmk-PC.armlinux.org.uk |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp140304vqo; Tue, 7 Nov 2023 02:31:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0KtqhDm6VL8ZCo8WJAwdjzwPF6dnQshpFn1vKJGlERDX0+5qNgs/bWyH6Hs5mi8FEG0Aj X-Received: by 2002:a17:902:f990:b0:1c6:21b4:30bb with SMTP id ky16-20020a170902f99000b001c621b430bbmr23899985plb.15.1699353074964; Tue, 07 Nov 2023 02:31:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699353074; cv=none; d=google.com; s=arc-20160816; b=lszYju2tHGTYblzgcgF9PJE8tZUwOmlpF57kidZGQzk1MNZxgRospKhygIgqWkOMAc ND4cF1sSUVwVuZP7rRDJaSO1xkrJLOsKc8pH228R74Q7yfFAp4JC0kbe2y0P4PvLXmCH 5HKkV6ypBoJ9W92FFnj0HOfyF1R8GbTjIfSJopXkTpYRKrdalXk+rmxIISyCwV1SuNzO L+sdTXO/ZMxR8y39SCru/knhq5AcSESTsih9y9FF32ybJIfWVW13hmrTUpBMxlgvIt67 0JRh5wgN3qQ1K/9Yy+I+FYjzjQcCYWzJATlG8g3updA89vBmH8NbALfNRZu+T6bT0Ap+ lSdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:sender:message-id:content-transfer-encoding :content-disposition:mime-version:subject:cc:to:from:references :in-reply-to:dkim-signature; bh=AMLeOPj97UWFUJITi7pviQd/DMBECoV/Ju2iA1XroZM=; fh=vGp9XFM4D1RKi7jyAIjKAaHKfpl3Nk8bXN5xkWYvhvI=; b=e2LM2ak4l3l0o8/YYc/mzoMrp+tn6lpe+ASa8YMN/aBavHl0sGdQdHQmXz+3jpUzmP YUfGIRaZubPcmQYXdzJ1R+zkpqzg+Z8lQLgl3xYkrrTtJQnQakxDfCIMw5wrioMm/7zz w2jSmkQ67cGWwJ7YfIYqAVjiaGy1FKA8EuDoEHUIKbtr5xA+SIIQph6sN9DykcyXsq5D tyZCuoDyhZuRe7zNQd5b3Wck/gNUkiwCanaYJxhICIY+OOfjxeoCV/aiwA7nBwmyQLoN 5cFNeYEqiW7cGi9OmgisEj2Dd+cs2chT4qTwJFJ3ejsQAu10O1eacFmN7ETceTPZNuGG Wiaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="iWpNzX/i"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id iw22-20020a170903045600b001c5c344a425si10044003plb.418.2023.11.07.02.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 02:31:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="iWpNzX/i"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 553D18026AFF; Tue, 7 Nov 2023 02:31:08 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234106AbjKGKai (ORCPT <rfc822;lhua1029@gmail.com> + 32 others); Tue, 7 Nov 2023 05:30:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233996AbjKGKaW (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 7 Nov 2023 05:30:22 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55E469B; Tue, 7 Nov 2023 02:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AMLeOPj97UWFUJITi7pviQd/DMBECoV/Ju2iA1XroZM=; b=iWpNzX/iPGoOYZQkZm1FIQXbPq l/1gVppyboPmC6oMcfXlstcdMZwkQemSDC3sAWAcxjAeobj3XzuPCbPhXny1YZMJO2nRHG63r3Mh0 jNvRH7k+2oC8ySGSAk8U2dvBaMevMXVHN0gC+MMpsqaWK0L8ihN0bQUJoxLPTYxrKgZM+Pjlih3fs LcT8t4CZjhVC6MPxRxQ/d17Q4R2MW+G5mBgCs6797LrxnXap9B7GaDDQT/BHu44vMbeZ+KHsAGb5e MKJai+jRkoPwqj8S97N9deRW2n8XWFl+QX4UABVhRevJwiRLKylNLlAEpPAjcV2W5jTxW4wJunXYc Rs7uQr5g==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:54898 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from <rmk@armlinux.org.uk>) id 1r0JLU-0000GD-0Y; Tue, 07 Nov 2023 10:30:08 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from <rmk@rmk-PC.armlinux.org.uk>) id 1r0JLV-00CTxS-QB; Tue, 07 Nov 2023 10:30:09 +0000 In-Reply-To: <ZUoRY33AAHMc5ThW@shell.armlinux.org.uk> References: <ZUoRY33AAHMc5ThW@shell.armlinux.org.uk> From: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> To: linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, linux-csky@vger.kernel.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org Cc: Salil Mehta <salil.mehta@huawei.com>, Jean-Philippe Brucker <jean-philippe@linaro.org>, jianyong.wu@arm.com, justin.he@arm.com, James Morse <james.morse@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org> Subject: [PATCH RFC 10/22] drivers: base: Move cpu_dev_init() after node_dev_init() MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" Message-Id: <E1r0JLV-00CTxS-QB@rmk-PC.armlinux.org.uk> Sender: Russell King <rmk@armlinux.org.uk> Date: Tue, 07 Nov 2023 10:30:09 +0000 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 07 Nov 2023 02:31:08 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781900849940465730 X-GMAIL-MSGID: 1781900849940465730 |
Series |
Initial cleanups for vCPU hotplug
|
|
Commit Message
Russell King (Oracle)
Nov. 7, 2023, 10:30 a.m. UTC
From: James Morse <james.morse@arm.com> NUMA systems require the node descriptions to be ready before CPUs are registered. This is so that the node symlinks can be created in sysfs. Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs are registered by arch code, instead of cpu_dev_init(). Move cpu_dev_init() after node_dev_init() so that NUMA architectures can use GENERIC_CPU_DEVICES. Signed-off-by: James Morse <james.morse@arm.com> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- Note: Jonathan's comment still needs addressing - see https://lore.kernel.org/r/20230914121612.00006ac7@Huawei.com --- drivers/base/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 11/7/23 20:30, Russell King (Oracle) wrote: > From: James Morse <james.morse@arm.com> > > NUMA systems require the node descriptions to be ready before CPUs are > registered. This is so that the node symlinks can be created in sysfs. > > Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs > are registered by arch code, instead of cpu_dev_init(). > > Move cpu_dev_init() after node_dev_init() so that NUMA architectures > can use GENERIC_CPU_DEVICES. > > Signed-off-by: James Morse <james.morse@arm.com> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > --- > Note: Jonathan's comment still needs addressing - see > https://lore.kernel.org/r/20230914121612.00006ac7@Huawei.com > --- > drivers/base/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > With Jonathan's comments addressed: Reviewed-by: Gavin Shan <gshan@redhat.com>
On Mon, Nov 13, 2023 at 10:58:46AM +1000, Gavin Shan wrote: > > > On 11/7/23 20:30, Russell King (Oracle) wrote: > > From: James Morse <james.morse@arm.com> > > > > NUMA systems require the node descriptions to be ready before CPUs are > > registered. This is so that the node symlinks can be created in sysfs. > > > > Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs > > are registered by arch code, instead of cpu_dev_init(). > > > > Move cpu_dev_init() after node_dev_init() so that NUMA architectures > > can use GENERIC_CPU_DEVICES. > > > > Signed-off-by: James Morse <james.morse@arm.com> > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > --- > > Note: Jonathan's comment still needs addressing - see > > https://lore.kernel.org/r/20230914121612.00006ac7@Huawei.com > > --- > > drivers/base/init.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > With Jonathan's comments addressed: That needs James' input, which is why I made the note on the patch.
On Mon, Nov 13, 2023 at 08:00:19AM +0000, Russell King (Oracle) wrote: > On Mon, Nov 13, 2023 at 10:58:46AM +1000, Gavin Shan wrote: > > > > > > On 11/7/23 20:30, Russell King (Oracle) wrote: > > > From: James Morse <james.morse@arm.com> > > > > > > NUMA systems require the node descriptions to be ready before CPUs are > > > registered. This is so that the node symlinks can be created in sysfs. > > > > > > Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs > > > are registered by arch code, instead of cpu_dev_init(). > > > > > > Move cpu_dev_init() after node_dev_init() so that NUMA architectures > > > can use GENERIC_CPU_DEVICES. > > > > > > Signed-off-by: James Morse <james.morse@arm.com> > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > > --- > > > Note: Jonathan's comment still needs addressing - see > > > https://lore.kernel.org/r/20230914121612.00006ac7@Huawei.com > > > --- > > > drivers/base/init.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > With Jonathan's comments addressed: > > That needs James' input, which is why I made the note on the patch. I'm going to be posting the series without RFC soon, and it will be with Jonathan's comment unaddressed - because as I've said several times it needs James' input and we have sadly not yet received that. Short of waiting until James can respond, I don't think there are any other alternatives. I do hope we can get this queued up for v6.8 though.
On Tue, 21 Nov 2023 13:27:08 +0000 "Russell King (Oracle)" <linux@armlinux.org.uk> wrote: > On Mon, Nov 13, 2023 at 08:00:19AM +0000, Russell King (Oracle) wrote: > > On Mon, Nov 13, 2023 at 10:58:46AM +1000, Gavin Shan wrote: > > > > > > > > > On 11/7/23 20:30, Russell King (Oracle) wrote: > > > > From: James Morse <james.morse@arm.com> > > > > > > > > NUMA systems require the node descriptions to be ready before CPUs are > > > > registered. This is so that the node symlinks can be created in sysfs. > > > > > > > > Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs > > > > are registered by arch code, instead of cpu_dev_init(). > > > > > > > > Move cpu_dev_init() after node_dev_init() so that NUMA architectures > > > > can use GENERIC_CPU_DEVICES. > > > > > > > > Signed-off-by: James Morse <james.morse@arm.com> > > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > > > --- > > > > Note: Jonathan's comment still needs addressing - see > > > > https://lore.kernel.org/r/20230914121612.00006ac7@Huawei.com > > > > --- > > > > drivers/base/init.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > With Jonathan's comments addressed: > > > > That needs James' input, which is why I made the note on the patch. > > I'm going to be posting the series without RFC soon, and it will be > with Jonathan's comment unaddressed - because as I've said several > times it needs James' input and we have sadly not yet received that. > > Short of waiting until James can respond, I don't think there are > any other alternatives. In the interests of expediency I'm fine with that. (To be honest I'd forgotten I even made that comment ;) Jonathan > > I do hope we can get this queued up for v6.8 though. >
On Tue, 28 Nov 2023 13:55:36 +0000 Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote: > On Tue, 21 Nov 2023 13:27:08 +0000 > "Russell King (Oracle)" <linux@armlinux.org.uk> wrote: > > > On Mon, Nov 13, 2023 at 08:00:19AM +0000, Russell King (Oracle) wrote: > > > On Mon, Nov 13, 2023 at 10:58:46AM +1000, Gavin Shan wrote: > > > > > > > > > > > > On 11/7/23 20:30, Russell King (Oracle) wrote: > > > > > From: James Morse <james.morse@arm.com> > > > > > > > > > > NUMA systems require the node descriptions to be ready before CPUs are > > > > > registered. This is so that the node symlinks can be created in sysfs. > > > > > > > > > > Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs > > > > > are registered by arch code, instead of cpu_dev_init(). > > > > > > > > > > Move cpu_dev_init() after node_dev_init() so that NUMA architectures > > > > > can use GENERIC_CPU_DEVICES. > > > > > > > > > > Signed-off-by: James Morse <james.morse@arm.com> > > > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > > > > --- > > > > > Note: Jonathan's comment still needs addressing - see > > > > > https://lore.kernel.org/r/20230914121612.00006ac7@Huawei.com > > > > > --- > > > > > drivers/base/init.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > > With Jonathan's comments addressed: > > > > > > That needs James' input, which is why I made the note on the patch. > > > > I'm going to be posting the series without RFC soon, and it will be > > with Jonathan's comment unaddressed - because as I've said several > > times it needs James' input and we have sadly not yet received that. > > > > Short of waiting until James can respond, I don't think there are > > any other alternatives. > > In the interests of expediency I'm fine with that. (To be honest I'd > forgotten I even made that comment ;) > Given what I was looking for was a 'nice to have' extra bit of info in the patch description and I'm fine with the actual change even without that: Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Jonathan > > > > > I do hope we can get this queued up for v6.8 though. *fingers crossed* ! > > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Mon, Nov 13, 2023 at 10:58:46AM +1000, Gavin Shan wrote: > > > On 11/7/23 20:30, Russell King (Oracle) wrote: > > From: James Morse <james.morse@arm.com> > > > > NUMA systems require the node descriptions to be ready before CPUs are > > registered. This is so that the node symlinks can be created in sysfs. > > > > Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs > > are registered by arch code, instead of cpu_dev_init(). > > > > Move cpu_dev_init() after node_dev_init() so that NUMA architectures > > can use GENERIC_CPU_DEVICES. > > > > Signed-off-by: James Morse <james.morse@arm.com> > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > --- > > Note: Jonathan's comment still needs addressing - see > > https://lore.kernel.org/r/20230914121612.00006ac7@Huawei.com > > --- > > drivers/base/init.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > With Jonathan's comments addressed: > > Reviewed-by: Gavin Shan <gshan@redhat.com> Can I assume, given Jonathan's reply later in this sub-thread, that you are happy for me to add your r-b without the referred comment having been addressed - Jonathan says tit was a "nice to have" and he's fine without the requested change. See https://lore.kernel.org/r/20231128150017.000069eb@Huawei.com Thanks.
diff --git a/drivers/base/init.c b/drivers/base/init.c index 397eb9880cec..c4954835128c 100644 --- a/drivers/base/init.c +++ b/drivers/base/init.c @@ -35,8 +35,8 @@ void __init driver_init(void) of_core_init(); platform_bus_init(); auxiliary_bus_init(); - cpu_dev_init(); memory_dev_init(); node_dev_init(); + cpu_dev_init(); container_dev_init(); }