diff mbox series

nvme-keyring: add MODULE_LICENSE()

Message ID 20231023230052.31161-1-rdunlap@infradead.org
State New
Headers
Series nvme-keyring: add MODULE_LICENSE() |

Commit Message

Randy Dunlap Oct. 23, 2023, 11 p.m. UTC 
  When NVME_KEYRING=y (NVME_AUTH is not set), there is a modpost build
error:

ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o

so add a MODULE_LICENSE() to keyring.c (copied from auth.c).

Fixes: 9d77eb527784 ("nvme-keyring: register '.nvme' keyring")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Keith Busch <kbusch@kernel.org>
Cc: Jens Axboe <axboe@fb.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Hannes Reinecke <hare@suse.de>
Cc: linux-nvme@lists.infradead.org
---
 drivers/nvme/common/keyring.c |    2 ++
 1 file changed, 2 insertions(+)

Comments

Hannes Reinecke Oct. 24, 2023, 5:24 a.m. UTC | #1 
On 10/24/23 01:00, Randy Dunlap wrote:
> When NVME_KEYRING=y (NVME_AUTH is not set), there is a modpost build
> error:
> 
> ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o
> 
> so add a MODULE_LICENSE() to keyring.c (copied from auth.c).
> 
> Fixes: 9d77eb527784 ("nvme-keyring: register '.nvme' keyring")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Keith Busch <kbusch@kernel.org>
> Cc: Jens Axboe <axboe@fb.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: linux-nvme@lists.infradead.org
> ---
>   drivers/nvme/common/keyring.c |    2 ++
>   1 file changed, 2 insertions(+)
> 
> diff -- a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c
> --- a/drivers/nvme/common/keyring.c
> +++ b/drivers/nvme/common/keyring.c
> @@ -180,3 +180,5 @@ void nvme_keyring_exit(void)
>   	key_put(nvme_keyring);
>   }
>   EXPORT_SYMBOL_GPL(nvme_keyring_exit);
> +
> +MODULE_LICENSE("GPL v2");

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
Christoph Hellwig Oct. 24, 2023, 6:29 a.m. UTC | #2 
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Sagi Grimberg Nov. 20, 2023, 2:40 p.m. UTC | #3 
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
diff mbox series

Patch

diff -- a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c
--- a/drivers/nvme/common/keyring.c
+++ b/drivers/nvme/common/keyring.c
@@ -180,3 +180,5 @@  void nvme_keyring_exit(void)
 	key_put(nvme_keyring);
 }
 EXPORT_SYMBOL_GPL(nvme_keyring_exit);
+
+MODULE_LICENSE("GPL v2");