diff mbox series

[2/2,RESEND] nvme-auth: set explanation code for failure2 msgs

Message ID 20231011084512.1835614-2-shiftee@posteo.net
State New
Headers
Series [1/2,RESEND] nvme-auth: unlock mutex in one place only |

Commit Message

Mark O'Donovan Oct. 11, 2023, 8:45 a.m. UTC 
  Some error cases were not setting an auth-failure-reason-code-explanation.
This means an AUTH_Failure2 message will be sent with an explanation value
of 0 which is a reserved value.

Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
Reviewed-by: Hannes Reinecke <hare@suse.de>
---
v1->v2: Set failure explanation in a single place if the error handling
code has not already done so.
---
 drivers/nvme/host/auth.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Sagi Grimberg Nov. 20, 2023, 11:01 a.m. UTC | #1 
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
diff mbox series

Patch

diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
index e1a98647c3a2..9556cfc4f5f3 100644
--- a/drivers/nvme/host/auth.c
+++ b/drivers/nvme/host/auth.c
@@ -839,6 +839,8 @@  static void nvme_queue_auth_work(struct work_struct *work)
 	}
 
 fail2:
+	if (chap->status == 0)
+		chap->status = NVME_AUTH_DHCHAP_FAILURE_FAILED;
 	dev_dbg(ctrl->device, "%s: qid %d send failure2, status %x\n",
 		__func__, chap->qid, chap->status);
 	tl = nvme_auth_set_dhchap_failure2_data(ctrl, chap);