gfortran: Rely on dg-do-what-default to avoid running pr85853.f90, pr107254.f90 and vect-alias-check-1.F90 on non-vector targets
| Message ID | 20231102190911.66763-1-patrick@rivosinc.com |
|---|---|
| State | Accepted |
| Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp579851vqu;
Thu, 2 Nov 2023 12:09:49 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IFi7Qw8dBX8O/nZSWiPGL3RIeqm4u9HH0ovsFiAaOsWgY7J2bgk3bQ3wDRNjMICRqJitmWj
X-Received: by 2002:a05:6214:2a8a:b0:672:96e:cac with SMTP id
jr10-20020a0562142a8a00b00672096e0cacmr13301353qvb.25.1698952188971;
Thu, 02 Nov 2023 12:09:48 -0700 (PDT)
ARC-Seal: i=2; a=rsa-sha256; t=1698952188; cv=pass;
d=google.com; s=arc-20160816;
b=DDqmGy6iNn15tjUrgAQQzD+4aSKPWRPuVby2S9bKXwLzT6Z03Ud+EtsJlUiiE1VUoR
DzNRwRGVRhvEgIpOsK7FefYd2BmBKVXywyDHRxj/47UghXnK5DqDdqvrKtDgzqfzGIhn
kEJ3MqyuYva4bJXmWNBMcFbYnEN3H/NOOYRmHR55w8NbzDe8Uexflrbh3hgeVrPbRi7d
8A8z4LXqz4OFwFdIcAsDWY9TnTRluwkG7W3UkfMtN7U7ZJPBLiA2izJ7AQRlGT3dsEcj
uOxUsUSjZGCnygUdiyKpHC38Z4OB9gbWRbPKYSG5S4tFwgyNbJ21VfAWQhMcmkXtflYH
9mzA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=errors-to:list-subscribe:list-help:list-post:list-archive
:list-unsubscribe:list-id:precedence:content-transfer-encoding
:mime-version:message-id:date:subject:cc:to:from:dkim-signature
:arc-filter:dmarc-filter:delivered-to;
bh=Bgeq/wbfhZSNcWzmoRCWkwEADJ0ZCnKsHiotpCQRxEg=;
fh=AMD4FSz6cUc4n6xCKkDOe8Mgn0A5ubP59ONK3itePwA=;
b=ztr+3RCaOYYwriVY65FhBeXOFBtJDrpr4TqB+PQmajXmdP8PfNhVVoSQWMdS5uELf2
31r5A9j+P5vUF28tzDyLfv8SJvlkcSFplke3zofn8IRnFGw87+AtVPXPFz/UCYcrtIQP
3PGIygl20x6b11RBTZICmJ4NaNjfazlzd408RonRlJgkJm2jYfwNhcUcYlDU44ZHaHUR
DMIOZ0ct7736VXHPKDOpR3M3j27vCCBgivwodCr1ACx8lTcj3Kl7CauhihXwQxHE44mT
GDXf9AJjHfp6sRB/stKo7k+AzNvYFUZ8+WQ3ORE5lhpBr96ORHJ4a1I3wC0m6MSdW4Fc
kE8A==
ARC-Authentication-Results: i=2; mx.google.com;
dkim=pass header.i=@rivosinc-com.20230601.gappssmtp.com
header.s=20230601 header.b="wzqphoC/";
arc=pass (i=1);
spf=pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates
2620:52:3:1:0:246e:9693:128c as permitted sender)
smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"
Received: from server2.sourceware.org (server2.sourceware.org.
[2620:52:3:1:0:246e:9693:128c])
by mx.google.com with ESMTPS id
et9-20020a056214176900b00647220c635asi61464qvb.33.2023.11.02.12.09.48
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 02 Nov 2023 12:09:48 -0700 (PDT)
Received-SPF: pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates
2620:52:3:1:0:246e:9693:128c as permitted sender)
client-ip=2620:52:3:1:0:246e:9693:128c;
Authentication-Results: mx.google.com;
dkim=pass header.i=@rivosinc-com.20230601.gappssmtp.com
header.s=20230601 header.b="wzqphoC/";
arc=pass (i=1);
spf=pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates
2620:52:3:1:0:246e:9693:128c as permitted sender)
smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"
Received: from server2.sourceware.org (localhost [IPv6:::1])
by sourceware.org (Postfix) with ESMTP id B0F673858C2B
for <ouuuleilei@gmail.com>; Thu, 2 Nov 2023 19:09:48 +0000 (GMT)
X-Original-To: gcc-patches@gcc.gnu.org
Delivered-To: gcc-patches@gcc.gnu.org
Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com
[IPv6:2607:f8b0:4864:20::62f])
by sourceware.org (Postfix) with ESMTPS id E37343858D37
for <gcc-patches@gcc.gnu.org>; Thu, 2 Nov 2023 19:09:23 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E37343858D37
Authentication-Results: sourceware.org;
dmarc=none (p=none dis=none) header.from=rivosinc.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E37343858D37
Authentication-Results: server2.sourceware.org;
arc=none smtp.remote-ip=2607:f8b0:4864:20::62f
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698952165; cv=none;
b=m66H3qruBb6if4KhRSLjC2n8dluGUo10UO80zMBSnLFkArC/rOV8qA/Ge3Z1O2WeAEixH3WAGREzswq0xZdy3Y6Es9AYUH4L6QgDpJlndQJzjT6L9opwRs2QbUxYllwWVCjB6K8TvJ9DfUM4B44DwiOw/D1gDnj61A67/KhuU2A=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
t=1698952165; c=relaxed/simple;
bh=FO7S0XVMFde2kLp+FlrstHAeyQJCVoPNhVYGXGo8lgE=;
h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;
b=HNt7j/Bh94spEIhCM9qBiqIi9vVN9fkMfd44cnQ7/nbzSvmjmmYgtyU/7QaS6FnexYrjlN7oUxjWtQvmdd0MhTA40/kfI9FH6dQ+fAAXgiG+idapHVZDU1+NVKQVmjbSoF8QOl3lsoHPfFPepS6UnVRPyC/34+IpcqmQwWlBy00=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: by mail-pl1-x62f.google.com with SMTP id
d9443c01a7336-1cc58219376so11498075ad.1
for <gcc-patches@gcc.gnu.org>; Thu, 02 Nov 2023 12:09:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1698952162;
x=1699556962;
darn=gcc.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=Bgeq/wbfhZSNcWzmoRCWkwEADJ0ZCnKsHiotpCQRxEg=;
b=wzqphoC/YfFcEIuc3WPWbdy25HFAcY3O955fyZkts/59QHkUgWwhoqMtG0itBwc8P9
dXZauerY9BaXgomupVwRgfXE/qJy+iy/4VSSIzt2xv0XlQUT36bNMCop/7lf3AAvW44v
HIS+vcI2H8e8Fp+zUS4s7kAsX0dVyT2TRrjXdS9Zf4UbgdrTI3gDr74sP6+zXelxXlrB
CUhtrYkvxH5WPiaauvPf+WoKrRpSRR5aGGbANVdl9sC85Jb29DwQGrV+8XKTRVm+BVfT
CAhkgrkgbWNaGv+6uHLss8ayj+t5q5Qtbe6BC2X6B0pU75v961dy0r0KnMxb2VQ7+VgH
xciA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1698952162; x=1699556962;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=Bgeq/wbfhZSNcWzmoRCWkwEADJ0ZCnKsHiotpCQRxEg=;
b=N09wSYtvSpA5bQV6xwFT2KeJfv7qadCEbOG4Y7a3TcYIV0LUvYX8Sg3Bkvps1UxGRu
8/TAl/Js0GQOg55498GFudOWHGuCdfAn5msq/IDjTkMyEkWa+AdiMpGxCOvFqe4EUFY9
PsNGxUVZ+ZopQ6llJKsXkDmiHllFuNLNmJjmORcpI62ahrPyuLn480vIRP25V0vpicLZ
bHgqtf1ouxL7+pMwDmYICQO79lT5OQutMrc/QX1w3Q2bmIasTC74KXvfnvW82i9TUNiP
aPcNFbqIdCZrMwYaAdEbEUccVcPvkHs7lMpxsJGMPvEHLxBwx+6+iU/q6CvrJXbOuMQH
dA8A==
X-Gm-Message-State: AOJu0YwEryCRVZ1h8bAAXXdnNSj0O+AbJMBfmS61pYo5bOI4l9rU7M/C
LZsKnfwF/DqF9pII9Au4ywd3SnzIdAD0Vby05io=
X-Received: by 2002:a17:902:d50d:b0:1cc:339b:62af with SMTP id
b13-20020a170902d50d00b001cc339b62afmr19677987plg.16.1698952162024;
Thu, 02 Nov 2023 12:09:22 -0700 (PDT)
Received: from patrick-ThinkPad-X1-Carbon-Gen-8.hq.rivosinc.com
([12.44.203.122]) by smtp.gmail.com with ESMTPSA id
be4-20020a170902aa0400b001c736b0037fsm71506plb.231.2023.11.02.12.09.21
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 02 Nov 2023 12:09:21 -0700 (PDT)
From: Patrick O'Neill <patrick@rivosinc.com>
To: gcc-patches@gcc.gnu.org
Cc: Patrick O'Neill <patrick@rivosinc.com>
Subject: [PATCH] gfortran: Rely on dg-do-what-default to avoid running
pr85853.f90, pr107254.f90 and vect-alias-check-1.F90 on non-vector targets
Date: Thu, 2 Nov 2023 12:09:11 -0700
Message-ID: <20231102190911.66763-1-patrick@rivosinc.com>
X-Mailer: git-send-email 2.42.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
<mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
<mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1781480490461777635
X-GMAIL-MSGID: 1781480490461777635
|
| Series |
gfortran: Rely on dg-do-what-default to avoid running pr85853.f90, pr107254.f90 and vect-alias-check-1.F90 on non-vector targets
|
|
Checks
| Context | Check | Description |
|---|---|---|
| snail/gcc-patch-check | success | Github commit url |
Commit Message
Patrick O'Neill
Nov. 2, 2023, 7:09 p.m. UTC
Testcases in gfortran.dg/vect/vect.exp rely on
check_vect_support_and_set_flags to set dg-do-what-default and avoid
running vector tests on non-vector targets. The three testcases in this
patch overwrite the default with dg-do run which causes issues
for non-vector targets.
Removing the dg-do run directive resolves this issue for non-vector
targets (while still running the tests on vector targets).
gcc/testsuite/ChangeLog:
* gfortran.dg/vect/pr107254.f90: Remove dg-do run directive.
* gfortran.dg/vect/pr85853.f90: Ditto.
* gfortran.dg/vect/vect-alias-check-1.F90: Ditto.
Signed-off-by: Patrick O'Neill <patrick@rivosinc.com>
---
Tested using rv64gc & rv64gcv to make sure the testcases compile/run
as expected.
These files haven't been changed in a long time so I'm not sure why (or
if) this hasn't been run into by other people before.
---
gcc/testsuite/gfortran.dg/vect/pr107254.f90 | 2 --
gcc/testsuite/gfortran.dg/vect/pr85853.f90 | 1 -
gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 | 1 -
3 files changed, 4 deletions(-)
Comments
Ping. Testsuite fixup similar to: https://inbox.sourceware.org/gcc-patches/974e9e5e-8f07-46dd-b9b9-db8aa46859b5@gmail.com/T/#t https://inbox.sourceware.org/gcc-patches/7e78cd70-70c9-41b1-8a98-6977a103429e@rivosinc.com/T/#t Patrick On Thu, Nov 2, 2023 at 12:09 PM Patrick O'Neill <patrick@rivosinc.com> wrote: > > Testcases in gfortran.dg/vect/vect.exp rely on > check_vect_support_and_set_flags to set dg-do-what-default and avoid > running vector tests on non-vector targets. The three testcases in this > patch overwrite the default with dg-do run which causes issues > for non-vector targets. > > Removing the dg-do run directive resolves this issue for non-vector > targets (while still running the tests on vector targets). > > gcc/testsuite/ChangeLog: > > * gfortran.dg/vect/pr107254.f90: Remove dg-do run directive. > * gfortran.dg/vect/pr85853.f90: Ditto. > * gfortran.dg/vect/vect-alias-check-1.F90: Ditto. > > Signed-off-by: Patrick O'Neill <patrick@rivosinc.com> > --- > Tested using rv64gc & rv64gcv to make sure the testcases compile/run > as expected. > > These files haven't been changed in a long time so I'm not sure why (or > if) this hasn't been run into by other people before. > --- > gcc/testsuite/gfortran.dg/vect/pr107254.f90 | 2 -- > gcc/testsuite/gfortran.dg/vect/pr85853.f90 | 1 - > gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 | 1 - > 3 files changed, 4 deletions(-) > > diff --git a/gcc/testsuite/gfortran.dg/vect/pr107254.f90 b/gcc/testsuite/gfortran.dg/vect/pr107254.f90 > index 85bcb5f3fa2..adce6bedc30 100644 > --- a/gcc/testsuite/gfortran.dg/vect/pr107254.f90 > +++ b/gcc/testsuite/gfortran.dg/vect/pr107254.f90 > @@ -1,5 +1,3 @@ > -! { dg-do run } > - > subroutine dlartg( f, g, s, r ) > implicit none > double precision :: f, g, r, s > diff --git a/gcc/testsuite/gfortran.dg/vect/pr85853.f90 b/gcc/testsuite/gfortran.dg/vect/pr85853.f90 > index 68f4a004324..4c0e3b81a09 100644 > --- a/gcc/testsuite/gfortran.dg/vect/pr85853.f90 > +++ b/gcc/testsuite/gfortran.dg/vect/pr85853.f90 > @@ -1,5 +1,4 @@ > ! Taken from execute/where_2.f90, but with special flags. > -! { dg-do run } > ! { dg-additional-options "-fno-tree-loop-vectorize" } > > ! Program to test the WHERE constructs > diff --git a/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 b/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 > index 3014ff9f3b6..85ae9b151e3 100644 > --- a/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 > +++ b/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 > @@ -1,4 +1,3 @@ > -! { dg-do run } > ! { dg-additional-options "-fno-inline" } > > #define N 200 > -- > 2.34.1 >
On 11/15/23 17:03, Patrick O'Neill wrote: > Ping. > > Testsuite fixup similar to: > https://inbox.sourceware.org/gcc-patches/974e9e5e-8f07-46dd-b9b9-db8aa46859b5@gmail.com/T/#t > https://inbox.sourceware.org/gcc-patches/7e78cd70-70c9-41b1-8a98-6977a103429e@rivosinc.com/T/#t OK. Jeff
On 11/18/23 20:09, Jeff Law wrote: > > > On 11/15/23 17:03, Patrick O'Neill wrote: >> Ping. >> >> Testsuite fixup similar to: >> https://inbox.sourceware.org/gcc-patches/974e9e5e-8f07-46dd-b9b9-db8aa46859b5@gmail.com/T/#t >> >> https://inbox.sourceware.org/gcc-patches/7e78cd70-70c9-41b1-8a98-6977a103429e@rivosinc.com/T/#t >> > OK. > > > Jeff Committed. Patrick
diff --git a/gcc/testsuite/gfortran.dg/vect/pr107254.f90 b/gcc/testsuite/gfortran.dg/vect/pr107254.f90 index 85bcb5f3fa2..adce6bedc30 100644 --- a/gcc/testsuite/gfortran.dg/vect/pr107254.f90 +++ b/gcc/testsuite/gfortran.dg/vect/pr107254.f90 @@ -1,5 +1,3 @@ -! { dg-do run } - subroutine dlartg( f, g, s, r ) implicit none double precision :: f, g, r, s diff --git a/gcc/testsuite/gfortran.dg/vect/pr85853.f90 b/gcc/testsuite/gfortran.dg/vect/pr85853.f90 index 68f4a004324..4c0e3b81a09 100644 --- a/gcc/testsuite/gfortran.dg/vect/pr85853.f90 +++ b/gcc/testsuite/gfortran.dg/vect/pr85853.f90 @@ -1,5 +1,4 @@ ! Taken from execute/where_2.f90, but with special flags. -! { dg-do run } ! { dg-additional-options "-fno-tree-loop-vectorize" } ! Program to test the WHERE constructs diff --git a/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 b/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 index 3014ff9f3b6..85ae9b151e3 100644 --- a/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 +++ b/gcc/testsuite/gfortran.dg/vect/vect-alias-check-1.F90 @@ -1,4 +1,3 @@ -! { dg-do run } ! { dg-additional-options "-fno-inline" } #define N 200