Message ID | 20231116180743.2763021-2-javierm@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6359:6513:b0:164:83eb:24d7 with SMTP id sk19csp42197rwb; Thu, 16 Nov 2023 10:08:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFudsqQ0L1Sj5CHwOI81n81FthGO20I/nautoPptonKgQTuHZSEGIqD7uJz+/LjWjIn4y9I X-Received: by 2002:a17:902:ced1:b0:1cc:6597:f421 with SMTP id d17-20020a170902ced100b001cc6597f421mr11137136plg.48.1700158091366; Thu, 16 Nov 2023 10:08:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700158091; cv=none; d=google.com; s=arc-20160816; b=Pt72WihY5ggNflTGC03jIsAIxPxUAlvz8zlVZNdYAcIk1O01SYzDI/hlphl81obWeK Uoylv54kGDIC5kd3nsePP12QTvpwhT55ac2wXAvKdTrhL8A9o+Wz7FeynDmhpGj+RMv7 kvOqn7fiWKi2hv30oWucRTJifwhXj9qq+7OmwFd4IFpFPhuUz2BrrvwwmTSA12JPV82b 1MqbvBJRM1vGBeOsM6//GAkW/Nuwi/MKxVt0iGtoKNsxfxJU/pAPTn3hMxrp5KEZ6X1B 3ghdMPAkIvMO3YywxrKPCE9Y3IbOMdaNEIAHShwN67FMi038bLoFsuNdppxCkAS7LO6/ OPTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=W54lS/jbyFmKQJpxN3dQRiCf/ft7R1Q+OyFPgBZkh2k=; fh=ClnT/DlgPYyrvRTTio8EwcEWTwAS3w1eaPYjvGFKkX8=; b=0JpqRfvokN7XkXe/IDg1JyerhPqoc/6kI0QauWSZvbOFFJFrSwHgE9IHDIHHjOKR56 R1sMIDHmNyD/8rlVIEydMWPJhc6aLkGZq/Xd39iOuymatYHv7x3kSzX/WegoeXJgcgV7 yPWUaKFLCrfEuRA4NRKoZdpQOoKW2CIrIl3SzXbUko3u2UYycjU9GWpzy3yOrcP96Nvv Kfa2rRN9ENivvOz3JrdGlU4pgBFm85abIf+ctkphTRNtwEiPB/h+Cf8s91I4Dmr2fiDP Rf+kZbFY/mHCzF8sBGHcXJ902aAlTK7uOqJ4aLczv3h2LtwPhqEr1E9f9Rger96PpQJz UcCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eqhIonDB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id 12-20020a170902ee4c00b001cc76bea4fesi1338209plo.163.2023.11.16.10.08.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 10:08:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eqhIonDB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E888C815D7CE; Thu, 16 Nov 2023 10:08:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345401AbjKPSIF (ORCPT <rfc822;jaysivo@gmail.com> + 30 others); Thu, 16 Nov 2023 13:08:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231307AbjKPSIC (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 16 Nov 2023 13:08:02 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA3D519B for <linux-kernel@vger.kernel.org>; Thu, 16 Nov 2023 10:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700158079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W54lS/jbyFmKQJpxN3dQRiCf/ft7R1Q+OyFPgBZkh2k=; b=eqhIonDBpjIEJ90ik6n6HuCFFP4r/1TIzsOcrIBXYU+DBoECfeHQvs4aKBkP1atpX17y6h 67oMU+8dfWzgVAIZJwSvQwPk0Fo66RgSTI1AmRCbcsuwc2bjXIxy2Ww9yPhASHLuUOxnxo n4DcT7Seg5W/6Hu8DXi4wiDU1yRDL0M= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-113-31z9j3-ePwWdQuw9uwWvfA-1; Thu, 16 Nov 2023 13:07:57 -0500 X-MC-Unique: 31z9j3-ePwWdQuw9uwWvfA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-32db43129c6so544068f8f.1 for <linux-kernel@vger.kernel.org>; Thu, 16 Nov 2023 10:07:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700158076; x=1700762876; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W54lS/jbyFmKQJpxN3dQRiCf/ft7R1Q+OyFPgBZkh2k=; b=WiquvTOARCvosNP4DimOwKaOHc4kzc8uN+GJ37VZ/p0GtthOUjcxDvUMxquABLtSzh K5SFu3mU7+Mmk/TPKai3P43dqi59ABnHzp/RwfTOsFaZoUUcm2eqq4pZ8uAK9/+1K6xv WP0E4Dqur721SSZ/sBPX+Tmil/VClDJmvW3BaK6vnpgCM+1FIZK+ilnmsK99Ic3bywvs Shzj3c0vnsgQaRAviH6KyX9DkQhQZCDvIyv+QcJAKOEjFr9l/2KFk+Li6E85BiOjcP2B hNEsK1/n0ck86RuWB+nG/QTztin8gsIlpJpOw8DAFHTIfcC/38RkNLNCiFkfF7cBKTyw XvSA== X-Gm-Message-State: AOJu0YxRiJ7FBh9CHww1ls5CFGA+oTxSYF8DhtZfZEA8CKAgxQGfyoSF WhmWbEEPPFhdhj6waK9hkFbvmuAGyhsaAtGc2HJemZf01+GcL9cdRj7zpOFayK9/1s6T2lcrKqK DUosLG/9V7DT7i8asjUW9Zjh73fJClso8SUaT7Zn1DWzEWaPhTedHb40egLc6v3o/k0hD1obwQq boOF8L0/I= X-Received: by 2002:a5d:4441:0:b0:32d:a688:8813 with SMTP id x1-20020a5d4441000000b0032da6888813mr11709933wrr.32.1700158076015; Thu, 16 Nov 2023 10:07:56 -0800 (PST) X-Received: by 2002:a5d:4441:0:b0:32d:a688:8813 with SMTP id x1-20020a5d4441000000b0032da6888813mr11709913wrr.32.1700158075741; Thu, 16 Nov 2023 10:07:55 -0800 (PST) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id p6-20020a5d48c6000000b0032db8cccd3asm32812wrs.114.2023.11.16.10.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 10:07:54 -0800 (PST) From: Javier Martinez Canillas <javierm@redhat.com> To: linux-kernel@vger.kernel.org Cc: Sahaj Sarup <sahaj.sarup@linaro.org>, Javier Martinez Canillas <javierm@redhat.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Helge Deller <deller@gmx.de>, Sam Ravnborg <sam@ravnborg.org>, Thomas Zimmermann <tzimmermann@suse.de>, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 2/3] fbdev: ssd1307fb: Change "solomon,page-offset" property default value Date: Thu, 16 Nov 2023 19:07:38 +0100 Message-ID: <20231116180743.2763021-2-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231116180743.2763021-1-javierm@redhat.com> References: <20231116180743.2763021-1-javierm@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 16 Nov 2023 10:08:10 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782744970970235787 X-GMAIL-MSGID: 1782744970970235787 |
Series |
[1/3] dt-bindings: display: ssd1307fb: Change "solomon,page-offset" default value
|
|
Commit Message
Javier Martinez Canillas
Nov. 16, 2023, 6:07 p.m. UTC
This is used to specify the page start address offset of the display RAM.
The value is used as offset when setting the page start address with the
SSD130X_SET_PAGE_RANGE command, and the driver currently sets its value to
1 if the property is not present in the Device Tree.
But the datasheet mentions that the value on reset for the page start is a
0, so it makes more sense to also have 0 as the default value for the page
offset if the property is not present.
In fact, using a default value of 1 leads to the display not working when
the fbdev is attached to the framebuffer console.
Reported-by: Sahaj Sarup <sahaj.sarup@linaro.org>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
drivers/video/fbdev/ssd1307fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, Nov 16, 2023 at 07:07:38PM +0100, Javier Martinez Canillas wrote: > This is used to specify the page start address offset of the display RAM. > > The value is used as offset when setting the page start address with the > SSD130X_SET_PAGE_RANGE command, and the driver currently sets its value to > 1 if the property is not present in the Device Tree. > > But the datasheet mentions that the value on reset for the page start is a > 0, so it makes more sense to also have 0 as the default value for the page > offset if the property is not present. > > In fact, using a default value of 1 leads to the display not working when > the fbdev is attached to the framebuffer console. > > Reported-by: Sahaj Sarup <sahaj.sarup@linaro.org> Closes? Fixes? > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes: Hello Andy, > On Thu, Nov 16, 2023 at 07:07:38PM +0100, Javier Martinez Canillas wrote: >> This is used to specify the page start address offset of the display RAM. >> >> The value is used as offset when setting the page start address with the >> SSD130X_SET_PAGE_RANGE command, and the driver currently sets its value to >> 1 if the property is not present in the Device Tree. >> >> But the datasheet mentions that the value on reset for the page start is a >> 0, so it makes more sense to also have 0 as the default value for the page >> offset if the property is not present. >> >> In fact, using a default value of 1 leads to the display not working when >> the fbdev is attached to the framebuffer console. >> >> Reported-by: Sahaj Sarup <sahaj.sarup@linaro.org> > > Closes? There's no report in a mailing list or bug tracker to reference. > Fixes? > Since the default has been the same since the driver was merged, it doesn't make that much sense for me to reference that commit.
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index 5ae48e36fccb..34f014bf4994 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -637,7 +637,7 @@ static int ssd1307fb_probe(struct i2c_client *client) par->height = 16; if (device_property_read_u32(dev, "solomon,page-offset", &par->page_offset)) - par->page_offset = 1; + par->page_offset = 0; if (device_property_read_u32(dev, "solomon,col-offset", &par->col_offset)) par->col_offset = 0;