[v2,2/4] dt-bindings: clock: Convert keystone-gate.txt to YAML
Commit Message
Convert keystone-gate.txt to ti,keystone,psc-clock.yaml.
Signed-off-by: Andrew Davis <afd@ti.com>
---
Changes for v2:
- Fix dt_binding_check warning
.../bindings/clock/keystone-gate.txt | 29 ---------
.../bindings/clock/ti,keystone,psc-clock.yaml | 59 +++++++++++++++++++
2 files changed, 59 insertions(+), 29 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/clock/keystone-gate.txt
create mode 100644 Documentation/devicetree/bindings/clock/ti,keystone,psc-clock.yaml
Comments
Hi Andrew,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on vkoul-dmaengine/next broonie-spi/for-next clk/clk-next linus/master v6.7-rc1 next-20231116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andrew-Davis/dt-bindings-clock-Convert-keystone-gate-txt-to-YAML/20231115-053346
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20231114212911.429951-2-afd%40ti.com
patch subject: [PATCH v2 2/4] dt-bindings: clock: Convert keystone-gate.txt to YAML
reproduce: (https://download.01.org/0day-ci/archive/20231116/202311161400.qg1QNgEh-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311161400.qg1QNgEh-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> Warning: Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt references a file that doesn't exist: Documentation/devicetree/bindings/clock/keystone-gate.txt
On Tue, 14 Nov 2023 15:29:09 -0600, Andrew Davis wrote:
> Convert keystone-gate.txt to ti,keystone,psc-clock.yaml.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>
> Changes for v2:
> - Fix dt_binding_check warning
>
> .../bindings/clock/keystone-gate.txt | 29 ---------
> .../bindings/clock/ti,keystone,psc-clock.yaml | 59 +++++++++++++++++++
> 2 files changed, 59 insertions(+), 29 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/keystone-gate.txt
> create mode 100644 Documentation/devicetree/bindings/clock/ti,keystone,psc-clock.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
On 11/16/23 12:35 AM, kernel test robot wrote:
> Hi Andrew,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on robh/for-next]
> [also build test WARNING on vkoul-dmaengine/next broonie-spi/for-next clk/clk-next linus/master v6.7-rc1 next-20231116]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Andrew-Davis/dt-bindings-clock-Convert-keystone-gate-txt-to-YAML/20231115-053346
> base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> patch link: https://lore.kernel.org/r/20231114212911.429951-2-afd%40ti.com
> patch subject: [PATCH v2 2/4] dt-bindings: clock: Convert keystone-gate.txt to YAML
> reproduce: (https://download.01.org/0day-ci/archive/20231116/202311161400.qg1QNgEh-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311161400.qg1QNgEh-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>>> Warning: Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt references a file that doesn't exist: Documentation/devicetree/bindings/clock/keystone-gate.txt
>
Planning to convert bindings/remoteproc/ti,keystone-rproc.txt,
will update this link then if that is okay.
Andrew
deleted file mode 100644
@@ -1,29 +0,0 @@
-Status: Unstable - ABI compatibility may be broken in the future
-
-Binding for Keystone gate control driver which uses PSC controller IP.
-
-This binding uses the common clock binding[1].
-
-[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
-
-Required properties:
-- compatible : shall be "ti,keystone,psc-clock".
-- #clock-cells : from common clock binding; shall be set to 0.
-- clocks : parent clock phandle
-- reg : psc control and domain address address space
-- reg-names : psc control and domain registers
-- domain-id : psc domain id needed to check the transition state register
-
-Optional properties:
-- clock-output-names : From common clock binding to override the
- default output clock name
-Example:
- clkusb: clkusb {
- #clock-cells = <0>;
- compatible = "ti,keystone,psc-clock";
- clocks = <&chipclk16>;
- clock-output-names = "usb";
- reg = <0x02350008 0xb00>, <0x02350000 0x400>;
- reg-names = "control", "domain";
- domain-id = <0>;
- };
new file mode 100644
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/ti,keystone,psc-clock.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Keystone gate control driver which uses PSC controller IP
+
+maintainers:
+ - Andrew Davis <afd@ti.com>
+
+properties:
+ compatible:
+ const: ti,keystone,psc-clock
+
+ reg:
+ items:
+ - description: PSC control registers
+ - description: Domain registers
+
+ reg-names:
+ items:
+ - const: control
+ - const: domain
+
+ domain-id:
+ description: PSC domain id needed to check the transition state register
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ clocks:
+ maxItems: 1
+
+ clock-output-names:
+ maxItems: 1
+
+ "#clock-cells":
+ const: 0
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - domain-id
+ - clocks
+ - "#clock-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ clkusb@2350008 {
+ compatible = "ti,keystone,psc-clock";
+ reg = <0x02350008 0xb00>, <0x02350000 0x400>;
+ reg-names = "control", "domain";
+ domain-id = <0>;
+ clocks = <&chipclk16>;
+ clock-output-names = "usb";
+ #clock-cells = <0>;
+ };