diff mbox series

[wireless] wilc1000: fix potential memory leak in wilc_mac_xmit()

Message ID 1668657419-29240-1-git-send-email-zhangchangzhong@huawei.com
State New
Headers
Series [wireless] wilc1000: fix potential memory leak in wilc_mac_xmit() |

Commit Message

Zhang Changzhong Nov. 17, 2022, 3:56 a.m. UTC 
  The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add
dev_kfree_skb() to fix it.

Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
 drivers/net/wireless/microchip/wilc1000/netdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kalle Valo Nov. 17, 2022, 10:09 a.m. UTC | #1 
Zhang Changzhong <zhangchangzhong@huawei.com> writes:

> The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add
> dev_kfree_skb() to fix it.
>
> Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>

Same as in your other patch, have you tested this is on a real device?
diff mbox series

Patch

diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c
index 9b319a4..6f3ae0d 100644
--- a/drivers/net/wireless/microchip/wilc1000/netdev.c
+++ b/drivers/net/wireless/microchip/wilc1000/netdev.c
@@ -730,6 +730,7 @@  netdev_tx_t wilc_mac_xmit(struct sk_buff *skb, struct net_device *ndev)
 
 	if (skb->dev != ndev) {
 		netdev_err(ndev, "Packet not destined to this device\n");
+		dev_kfree_skb(skb);
 		return NETDEV_TX_OK;
 	}