| Message ID | 20231113-j7200-usb-suspend-v1-6-ad1ee714835c@bootlin.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp1238514vqg;
Mon, 13 Nov 2023 06:28:05 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IGMjIS2xuHtNAxj3VitQ1s9d+KlIaVit78ACqlHn88OHIUkWnGRf9IUO04Upi27Qo7ZEjjC
X-Received: by 2002:a05:6a21:78b:b0:180:18f6:ca99 with SMTP id
mg11-20020a056a21078b00b0018018f6ca99mr4594582pzb.56.1699885685233;
Mon, 13 Nov 2023 06:28:05 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1699885685; cv=none;
d=google.com; s=arc-20160816;
b=PDndwIJfHln50iG8bG/eiupQf8S06pQS2fPyk8VNHr4tYdTQDn0uTf3nxJH1vUcRZ8
2n3zyQIdPQhyhA7kUzl7m+gEKNywsuDo9Ea3YPK/0Dh4woEj7KmR6guzkHp1j5yo7tIj
WnGaqxaDrZk5f1KcooYSzKyKNS+V8qCgoUkw+Dh8PcvpKhU92E7rH1ohU5/yy4FhAkY+
QvMXn+6MV9pE1he9rqLy2sVS89O3Oj/I9Bimfk0wUYOop+l1LkKbdn0QFwCjdRGlphwh
WdRN80t8ePL9Ulynwh6S/jKlWhIr/APxDQmWlsaTszA/GlFRGVwAuaZjE3F2Le+/Hn56
kUxg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:cc:to:in-reply-to:references:message-id
:content-transfer-encoding:mime-version:subject:date:from
:dkim-signature;
bh=xSePrEltdrZVOTvOhxdlRrK/qcL9Ks2P2izMU5tje1Y=;
fh=16DCl5XFH1WL+t9Nj2yh7FiMyRP+/MtGOeDFkjBs21w=;
b=UskWEOH7ElyOt9rkwx1Jb5rB2VvsRxmFysQTr6vdR+ZdM1kHUeDr88SmpvBFP8f5NR
Wx2j90Ni15brK28oMb0PpzqfijQuPVZchT+FrJlaXgHh7JefsekD9FID2PDpbXnC9xaB
TucZUKHdaxoaJtBth31dNQs4H/9f1NamFKPzTGNWeCirovTDeFLsG4rXJgL8igIhuBpA
878CWo5CNANXdHc4UhQtGZZZzrABwq0onVDJLfZa/sHqmj8CfFzNBJvND9nEnF3iwSBL
a5J8LpsTcGOWEQnbr++seLs5VjD50zbrKAfxvay6+r3FwPUNLYVzo2impp0XqxTtHTY1
dx2g==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@bootlin.com header.s=gm1 header.b=JKEFIsKB;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:8 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com
Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8])
by mx.google.com with ESMTPS id
u11-20020a170902e80b00b001b8c4021be9si5923678plg.397.2023.11.13.06.28.04
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 13 Nov 2023 06:28:05 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:8 as permitted sender)
client-ip=2620:137:e000::3:8;
Authentication-Results: mx.google.com;
dkim=pass header.i=@bootlin.com header.s=gm1 header.b=JKEFIsKB;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:8 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by fry.vger.email (Postfix) with ESMTP id 1474480A64C7;
Mon, 13 Nov 2023 06:27:56 -0800 (PST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231295AbjKMO1W (ORCPT <rfc822;heyuhang3455@gmail.com>
+ 29 others); Mon, 13 Nov 2023 09:27:22 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50496 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229549AbjKMO1I (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 13 Nov 2023 09:27:08 -0500
Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net
[IPv6:2001:4b98:dc4:8::225])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 498BE10E5;
Mon, 13 Nov 2023 06:27:05 -0800 (PST)
Received: by mail.gandi.net (Postfix) with ESMTPSA id 4C9EF1C001D;
Mon, 13 Nov 2023 14:27:03 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1;
t=1699885623;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=xSePrEltdrZVOTvOhxdlRrK/qcL9Ks2P2izMU5tje1Y=;
b=JKEFIsKBpS7AxZ3+kCpMqv8P5Lm/HTtIKtvBs8c7H0q2fKGbGECmfrHKImDfvuhobhcZ1u
Gev9AUbdxWIBRLqbHb9k+OlVwvxQ+DY57PY32FuoA6asoyuyGrY/3aU1cw9zXPwh40A6Fl
GkGACM+hTd3rwNT/kPle3JVOlWyYr2W7uGhaaJ0LHKZIJRVeUdOzSgyQm4/QJvm8+TYPlJ
6zPY419LPYhfOWk8JRyDs1PWuCrxJXCxFtTxK1QPgkK2j2S5NxvA9kO5dbHI6Fl56yOGMF
IXVctc1Up4doHSAd2pWgQRfsBDo87v3jFFRcn3Zy/HQI2ZibhVwnDVX29lxXVg==
From: =?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>
Date: Mon, 13 Nov 2023 15:27:01 +0100
Subject: [PATCH 6/6] arm64: dts: ti: k3-j7200: use J7200-specific USB
compatible
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Message-Id: <20231113-j7200-usb-suspend-v1-6-ad1ee714835c@bootlin.com>
References: <20231113-j7200-usb-suspend-v1-0-ad1ee714835c@bootlin.com>
In-Reply-To: <20231113-j7200-usb-suspend-v1-0-ad1ee714835c@bootlin.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Roger Quadros <rogerq@kernel.org>,
Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
=?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>
X-Mailer: b4 0.12.3
X-GND-Sasl: theo.lebrun@bootlin.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]);
Mon, 13 Nov 2023 06:27:56 -0800 (PST)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1782459331804504464
X-GMAIL-MSGID: 1782459331804504464
|
| Series |
usb: cdns: fix suspend on J7200 by assuming reset on resume
|
|
Commit Message
Théo Lebrun
Nov. 13, 2023, 2:27 p.m. UTC
On our platform, suspend-to-idle or suspend-to-RAM turn the controller
off thanks to a power-domain. This compatible triggers reset on resume
behavior to reconfigure the hardware.
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
---
arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hello Théo, > On our platform, suspend-to-idle or suspend-to-RAM turn the controller > off thanks to a power-domain. This compatible triggers reset on resume > behavior to reconfigure the hardware. > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > --- > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > index 709081cd1e7f..581905d9199e 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > @@ -788,7 +788,7 @@ pcie1_ep: pcie-ep@2910000 { > }; > > usbss0: cdns-usb@4104000 { > - compatible = "ti,j721e-usb"; > + compatible = "ti,j7200-usb"; What about keeping the old compatible as fallback in the unlikley case we have a new dtb with an old kernel ? Gregory > reg = <0x00 0x4104000 0x00 0x100>; > dma-coherent; > power-domains = <&k3_pds 288 TI_SCI_PD_EXCLUSIVE>; > > -- > 2.41.0 > >
Hello, On Tue Nov 14, 2023 at 11:01 AM CET, Gregory CLEMENT wrote: > > --- > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > > index 709081cd1e7f..581905d9199e 100644 > > --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > > +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > > @@ -788,7 +788,7 @@ pcie1_ep: pcie-ep@2910000 { > > }; > > > > usbss0: cdns-usb@4104000 { > > - compatible = "ti,j721e-usb"; > > + compatible = "ti,j7200-usb"; > > What about keeping the old compatible as fallback in the unlikley case > we have a new dtb with an old kernel ? I see the usecase; that will be done in V2. Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi index 709081cd1e7f..581905d9199e 100644 --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi @@ -788,7 +788,7 @@ pcie1_ep: pcie-ep@2910000 { }; usbss0: cdns-usb@4104000 { - compatible = "ti,j721e-usb"; + compatible = "ti,j7200-usb"; reg = <0x00 0x4104000 0x00 0x100>; dma-coherent; power-domains = <&k3_pds 288 TI_SCI_PD_EXCLUSIVE>;