diff mbox series

[V2,1/2] ASoC: amd: acp: add Kconfig options for acp7.0 based platform driver

Message ID 20231113123345.2196504-1-Syed.SabaKareem@amd.com
State New
Headers
Series [V2,1/2] ASoC: amd: acp: add Kconfig options for acp7.0 based platform driver |

Commit Message

Saba Kareem, Syed Nov. 13, 2023, 12:33 p.m. UTC 
  ACP7.0 based platform legacy drivers can be built by selecting
necessary kernel config option. This patch enables build support
of the same.

Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
---
changes since v1:
     - added missing commit message.

 sound/soc/amd/acp/Kconfig  | 12 ++++++++++++
 sound/soc/amd/acp/Makefile |  2 ++
 2 files changed, 14 insertions(+)

Comments

Mario Limonciello Nov. 13, 2023, 4:19 p.m. UTC | #1 
On 11/13/2023 06:33, Syed Saba Kareem wrote:
> ACP7.0 based platform legacy drivers can be built by selecting
> necessary kernel config option. This patch enables build support
> of the same.
> 
> Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
> ---
> changes since v1:
>       - added missing commit message.
> 
>   sound/soc/amd/acp/Kconfig  | 12 ++++++++++++
>   sound/soc/amd/acp/Makefile |  2 ++
>   2 files changed, 14 insertions(+)
> 
> diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig
> index 5fb322212938..c8ac0027f741 100644
> --- a/sound/soc/amd/acp/Kconfig
> +++ b/sound/soc/amd/acp/Kconfig
> @@ -73,6 +73,18 @@ config SND_AMD_ASOC_ACP63
>   	  Say Y if you want to enable AUDIO on ACP6.3
>   	  If unsure select "N".
>   
> +config SND_AMD_ASOC_ACP70
> +	tristate "AMD ACP ASOC Acp7.0 Support"
> +	depends on X86 && PCI
> +	depends on ACPI
> +	select SND_SOC_AMD_ACP_PCM
> +	select SND_SOC_AMD_ACP_I2S
> +	select SND_SOC_AMD_ACP_PDM

Do you not need:

	select SND_SOC_AMD_ACP_LEGACY_COMMON

Like how ACP63, Rembrandt, and Renoir all select?

> +	help
> +	This option enables Acp7.0 PDM support on AMD platform.
> +	Say Y if you want to enable AUDIO on ACP7.0
> +          If unsure select "N".
> +
>   config SND_SOC_AMD_MACH_COMMON
>   	tristate
>   	depends on X86 && PCI && I2C
> diff --git a/sound/soc/amd/acp/Makefile b/sound/soc/amd/acp/Makefile
> index dd85700f1c5f..ff5f7893b81e 100644
> --- a/sound/soc/amd/acp/Makefile
> +++ b/sound/soc/amd/acp/Makefile
> @@ -15,6 +15,7 @@ snd-acp-pci-objs     := acp-pci.o
>   snd-acp-renoir-objs     := acp-renoir.o
>   snd-acp-rembrandt-objs  := acp-rembrandt.o
>   snd-acp63-objs := acp63.o
> +snd-acp70-objs := acp70.o
>   
>   #machine specific driver
>   snd-acp-mach-objs     := acp-mach-common.o
> @@ -30,6 +31,7 @@ obj-$(CONFIG_SND_SOC_AMD_ACP_PCI) += snd-acp-pci.o
>   obj-$(CONFIG_SND_AMD_ASOC_RENOIR) += snd-acp-renoir.o
>   obj-$(CONFIG_SND_AMD_ASOC_REMBRANDT) += snd-acp-rembrandt.o
>   obj-$(CONFIG_SND_AMD_ASOC_ACP63) += snd-acp63.o
> +obj-$(CONFIG_SND_AMD_ASOC_ACP70) += snd-acp70.o
>   
>   obj-$(CONFIG_SND_SOC_AMD_MACH_COMMON) += snd-acp-mach.o
>   obj-$(CONFIG_SND_SOC_AMD_LEGACY_MACH) += snd-acp-legacy-mach.o
Mark Brown Nov. 14, 2023, 11:39 a.m. UTC | #2 
On Mon, 13 Nov 2023 18:03:42 +0530, Syed Saba Kareem wrote:
> ACP7.0 based platform legacy drivers can be built by selecting
> necessary kernel config option. This patch enables build support
> of the same.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: amd: acp: add Kconfig options for acp7.0 based platform driver
      commit: d3534684ada99ef8c0899eb28c62b4462483ee19
[2/2] ASoC: amd: acp: add pm ops support for renoir platform
      (no commit info)

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
syed saba kareem Nov. 14, 2023, 12:45 p.m. UTC | #3 
On 11/13/23 21:49, Mario Limonciello wrote:
> On 11/13/2023 06:33, Syed Saba Kareem wrote:
>> ACP7.0 based platform legacy drivers can be built by selecting
>> necessary kernel config option. This patch enables build support
>> of the same.
>>
>> Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
>> ---
>> changes since v1:
>>       - added missing commit message.
>>
>>   sound/soc/amd/acp/Kconfig  | 12 ++++++++++++
>>   sound/soc/amd/acp/Makefile |  2 ++
>>   2 files changed, 14 insertions(+)
>>
>> diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig
>> index 5fb322212938..c8ac0027f741 100644
>> --- a/sound/soc/amd/acp/Kconfig
>> +++ b/sound/soc/amd/acp/Kconfig
>> @@ -73,6 +73,18 @@ config SND_AMD_ASOC_ACP63
>>         Say Y if you want to enable AUDIO on ACP6.3
>>         If unsure select "N".
>>   +config SND_AMD_ASOC_ACP70
>> +    tristate "AMD ACP ASOC Acp7.0 Support"
>> +    depends on X86 && PCI
>> +    depends on ACPI
>> +    select SND_SOC_AMD_ACP_PCM
>> +    select SND_SOC_AMD_ACP_I2S
>> +    select SND_SOC_AMD_ACP_PDM
>
> Do you not need:
>
>     select SND_SOC_AMD_ACP_LEGACY_COMMON
>
> Like how ACP63, Rembrandt, and Renoir all select?
>
Yes, this flag is missing will upstream the fix as an incremental patch.
>> +    help
>> +    This option enables Acp7.0 PDM support on AMD platform.
>> +    Say Y if you want to enable AUDIO on ACP7.0
>> +          If unsure select "N".
>> +
>>   config SND_SOC_AMD_MACH_COMMON
>>       tristate
>>       depends on X86 && PCI && I2C
>> diff --git a/sound/soc/amd/acp/Makefile b/sound/soc/amd/acp/Makefile
>> index dd85700f1c5f..ff5f7893b81e 100644
>> --- a/sound/soc/amd/acp/Makefile
>> +++ b/sound/soc/amd/acp/Makefile
>> @@ -15,6 +15,7 @@ snd-acp-pci-objs     := acp-pci.o
>>   snd-acp-renoir-objs     := acp-renoir.o
>>   snd-acp-rembrandt-objs  := acp-rembrandt.o
>>   snd-acp63-objs := acp63.o
>> +snd-acp70-objs := acp70.o
>>     #machine specific driver
>>   snd-acp-mach-objs     := acp-mach-common.o
>> @@ -30,6 +31,7 @@ obj-$(CONFIG_SND_SOC_AMD_ACP_PCI) += snd-acp-pci.o
>>   obj-$(CONFIG_SND_AMD_ASOC_RENOIR) += snd-acp-renoir.o
>>   obj-$(CONFIG_SND_AMD_ASOC_REMBRANDT) += snd-acp-rembrandt.o
>>   obj-$(CONFIG_SND_AMD_ASOC_ACP63) += snd-acp63.o
>> +obj-$(CONFIG_SND_AMD_ASOC_ACP70) += snd-acp70.o
>>     obj-$(CONFIG_SND_SOC_AMD_MACH_COMMON) += snd-acp-mach.o
>>   obj-$(CONFIG_SND_SOC_AMD_LEGACY_MACH) += snd-acp-legacy-mach.o
>
diff mbox series

Patch

diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig
index 5fb322212938..c8ac0027f741 100644
--- a/sound/soc/amd/acp/Kconfig
+++ b/sound/soc/amd/acp/Kconfig
@@ -73,6 +73,18 @@  config SND_AMD_ASOC_ACP63
 	  Say Y if you want to enable AUDIO on ACP6.3
 	  If unsure select "N".
 
+config SND_AMD_ASOC_ACP70
+	tristate "AMD ACP ASOC Acp7.0 Support"
+	depends on X86 && PCI
+	depends on ACPI
+	select SND_SOC_AMD_ACP_PCM
+	select SND_SOC_AMD_ACP_I2S
+	select SND_SOC_AMD_ACP_PDM
+	help
+	This option enables Acp7.0 PDM support on AMD platform.
+	Say Y if you want to enable AUDIO on ACP7.0
+          If unsure select "N".
+
 config SND_SOC_AMD_MACH_COMMON
 	tristate
 	depends on X86 && PCI && I2C
diff --git a/sound/soc/amd/acp/Makefile b/sound/soc/amd/acp/Makefile
index dd85700f1c5f..ff5f7893b81e 100644
--- a/sound/soc/amd/acp/Makefile
+++ b/sound/soc/amd/acp/Makefile
@@ -15,6 +15,7 @@  snd-acp-pci-objs     := acp-pci.o
 snd-acp-renoir-objs     := acp-renoir.o
 snd-acp-rembrandt-objs  := acp-rembrandt.o
 snd-acp63-objs := acp63.o
+snd-acp70-objs := acp70.o
 
 #machine specific driver
 snd-acp-mach-objs     := acp-mach-common.o
@@ -30,6 +31,7 @@  obj-$(CONFIG_SND_SOC_AMD_ACP_PCI) += snd-acp-pci.o
 obj-$(CONFIG_SND_AMD_ASOC_RENOIR) += snd-acp-renoir.o
 obj-$(CONFIG_SND_AMD_ASOC_REMBRANDT) += snd-acp-rembrandt.o
 obj-$(CONFIG_SND_AMD_ASOC_ACP63) += snd-acp63.o
+obj-$(CONFIG_SND_AMD_ASOC_ACP70) += snd-acp70.o
 
 obj-$(CONFIG_SND_SOC_AMD_MACH_COMMON) += snd-acp-mach.o
 obj-$(CONFIG_SND_SOC_AMD_LEGACY_MACH) += snd-acp-legacy-mach.o