Message ID | 20221115192625.9410-2-alexander.helms.jy@renesas.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2904348wru; Tue, 15 Nov 2022 11:27:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf5v10tYI0pwODJvzfGeSW9TstRakmenCW5wpBUf5uYG6667JonhPqYYwCk03JA9FeHQ5l5D X-Received: by 2002:a17:90b:4004:b0:20b:1f6:3fe0 with SMTP id ie4-20020a17090b400400b0020b01f63fe0mr3721151pjb.125.1668540440156; Tue, 15 Nov 2022 11:27:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668540440; cv=pass; d=google.com; s=arc-20160816; b=h5yJ+12yFkgPDiWC4NVrcWcTHof8nuhBYPK51d31pnl6HyjfM+QFzehVEcWlGcxxED 7MyFtNStzN2Z6Fix0gScq8kJCXiCKtVUxwu6Gdc6Ck0ftX5CMnYpNJDPJ5L+cClHVlHB QS3btEqZRaYJfXlksA1yRE9QXPHl2zsYD+V2YIIskVoaqbP9BwO+EBpZ/HJINr6iCfVo pbwALiFyBqUcxeOcrhuHP15JUOd9YRuXWILCRYGtNt5r+5a3AfG1QkDkrKimX/v9TP+L 8P+g9XuYc9hBTLR7mW4fcJRSIz4VGmR3iTOggDfofrLet1hXguh+cedCYpNf8gBabiLk tL1g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=k7Amuk9wvF3fS/mRP6wyth+AfjBF8++xpUIk9D6cvVM=; b=jTzc3LrcI8CcCLOOr3381d2tB/b7kI5f3E1anb0Z663STdWhjvpJGT54sCU9q+8oUF UGndfh/H2henhCSpsvRDGJlbwZqXYehCHkCXRV/bbBLVieq72zAYVP8SOY/OXB43fZkw xNhi98hYzEeRMrNCOeWjZTY3O/X2h+tWFbfoBvpwR2GBC6zriecNsTNCPzGx1iyce3RB jfmVTbSstAONC/K7QsXg4BHlwY/22yncQ6eIlRDsLTf9li2pDTrMybl12LG9RaMCsfSS UmeeiGnQsrY8kW7jJwiBHVKVGdHCT5jzGr9jFap+PO67EHSgblamCyaKThfdyY1O3h96 cBLQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@renesas.com header.s=selector1 header.b=Lui5LWfR; arc=pass (i=1 spf=pass spfdomain=renesas.com dkim=pass dkdomain=renesas.com dmarc=pass fromdomain=renesas.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f28-20020a631f1c000000b0046afc3948c4si13010039pgf.707.2022.11.15.11.27.06; Tue, 15 Nov 2022 11:27:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@renesas.com header.s=selector1 header.b=Lui5LWfR; arc=pass (i=1 spf=pass spfdomain=renesas.com dkim=pass dkdomain=renesas.com dmarc=pass fromdomain=renesas.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230215AbiKOT0u (ORCPT <rfc822;maxim.cournoyer@gmail.com> + 99 others); Tue, 15 Nov 2022 14:26:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230113AbiKOT0s (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 15 Nov 2022 14:26:48 -0500 Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01on20712.outbound.protection.outlook.com [IPv6:2a01:111:f403:7010::712]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 766D42F387; Tue, 15 Nov 2022 11:26:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Isn/lxD2CiImJDT6VWV500NwqdfvzTkCVnYErxQP8LexC9NwJHX+qxyjmVKGlxT3eI/ZzRG7+ywXlGQvZQgsrvN2rP7YhUDo931lfgMSDsdZ/b7Ug6Bixo/r/4d0ww1KppRejvHw2Kr+rc4xdLqpI+cH8hxQm/uDOL8js+MlaSSinoMtnp+1x2CQ/J3lPI9iL0xwGc49kYayvDogqX42uJIS6CTOHH/hidedS/9WqLct6IGBPLXYndbhFYn1JEnB/0vlRQlk+MKQeIxHcsrkN0q7mjJ/NPVHLCJypZpDVertu5dXFbkIxsGr3PTOInqsVORZnucn6G8t6AOT9urqoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k7Amuk9wvF3fS/mRP6wyth+AfjBF8++xpUIk9D6cvVM=; b=XKLyv6JlVy9EUWuSodsCx9/ns5Zz9+Pu320auPL+lNxWDYL31MBHyfMC6ZpF7VrfXhWp12I2qmRngcQD+l3GvyFq3kOmjiAluP3FBdyJZnT4tsNWtZ0s2ZRa8pMla4DLfpKexOtExBdRNn3w9VIFkWKk7qBQllux3M80E417EQCWdywPzwgSpJJdXOrT1QoTvuu10c/yVJEW5qH/DsO/2Rh0LWk42hjsvxn8NLxdn+ck5aawQ+AmVOku5CIWTuCq/EwnRQmszRrRk9CeVavBAedWNHr4Ivk7Nzy7lup2ue4onP5Tb6G8Gp5PkHevFReNqLz4Atg+2ocPYRnSo0WtEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k7Amuk9wvF3fS/mRP6wyth+AfjBF8++xpUIk9D6cvVM=; b=Lui5LWfRn3h8isS47jzRXi/npHCpcDrdyR7I5zIccc42MQCOM+dWR66J6L6INj/HiHYFKFxbOXg0Tmw34vWzk/A4fVgbrAKKtoAQdHzbJgORL0hocI3nZLO7RX5du9OnfHZefTNXRb9A2ZQogrBoWLi/JKWZrUE96pAeYX0bzWg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from OSAPR01MB3892.jpnprd01.prod.outlook.com (2603:1096:604:5b::23) by TYWPR01MB10539.jpnprd01.prod.outlook.com (2603:1096:400:2fe::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Tue, 15 Nov 2022 19:26:43 +0000 Received: from OSAPR01MB3892.jpnprd01.prod.outlook.com ([fe80::60f7:f062:7c7c:d289]) by OSAPR01MB3892.jpnprd01.prod.outlook.com ([fe80::60f7:f062:7c7c:d289%6]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 19:26:43 +0000 From: Alex Helms <alexander.helms.jy@renesas.com> To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, geert+renesas@glider.be, alexander.helms.jy@renesas.com Subject: [PATCH 1/2] dtbindings: clock: Add bindings for Renesas PhiClock Date: Tue, 15 Nov 2022 12:26:24 -0700 Message-Id: <20221115192625.9410-2-alexander.helms.jy@renesas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221115192625.9410-1-alexander.helms.jy@renesas.com> References: <20221115192625.9410-1-alexander.helms.jy@renesas.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BYAPR11CA0057.namprd11.prod.outlook.com (2603:10b6:a03:80::34) To OSAPR01MB3892.jpnprd01.prod.outlook.com (2603:1096:604:5b::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSAPR01MB3892:EE_|TYWPR01MB10539:EE_ X-MS-Office365-Filtering-Correlation-Id: f7e01ab4-6478-49b4-409e-08dac73f544a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CynpzVHYwaYTcVOB+ApP68Dw5NL7h2nLtechfkBUS4SnhpJkE5boSmDX4w0ltE2uJpgJwq85g5+z83vQInNyI2LLO2FnFUOmSwhABh7avvEhmkgP0EXhySHdpgCiYykJn92LYT7F1yZq6pQKqds9AwzCg/tXSmp7ZDlBJGS7fNSOoIR0jJ92iXBURnUPJKOjEmmk+tCe+UE8iPWclPuU5FWJdWBobFepBQtCRfRCQ3Sy0d16MV9/CO24ibZbrcVyk/H4/pT+H+EC1TtB4BDhpPFec9s+lfxX32bU8rIimeSEySOji5fJnd8EEyr6KydMrdxr4LL3SGed3zQsvvHPrn1u/f5Jg6d2k8rf3vJaRDwbGEDrmr5whYptFn9dfaKydoeo9MsgpfsOMimCsAZBC7Bvl21wdyW2pEGvzrIJC63HL8pvOm37lgBh7pPS9UwoUul3ik8y0fflPO1my4Eb9FK9Z3MwXuIhVqtL3KVznjgTB+Ps9N42YKEUw1P1NOLCZKBqtWs4EzSI8le3jUgjssFgAC6VNmMSDzfhuuiaToFfFAZnhAJ/0mXUP6T4KhGM8uHHMuG+q6gk52wQMib76/h+UuGlZgFOGRJ4ev1etkY4aWQdKb7yH/DDC48WHVhd2v9zER1DAYHgzqiN5A2QAq1BFICYXxhHBihvy8fz0hzp5M4/dzPGgBI9crMCF9eXMtndxi/5d8LQlZD4C0T6SMwao8ZM4WIpYoAK/nj6U67cdqsUin8InzKoCYvtwQiMbKd3+RTPJZvFTfKS/fClBd0kMzd/vPlyuiaSdUw8OWPkOOXK/FyDaSrAj2uGuB/AUK5UIyeU52Jah6nGn5XgFQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSAPR01MB3892.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(136003)(376002)(346002)(451199015)(2906002)(8936002)(8676002)(83380400001)(36756003)(2616005)(66946007)(66556008)(66476007)(41300700001)(86362001)(6506007)(38350700002)(38100700002)(52116002)(186003)(5660300002)(1076003)(4326008)(103116003)(966005)(316002)(26005)(6486002)(107886003)(6512007)(478600001)(6666004);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: iIUDOxf4+uQBVR36RZ/ios7YRzO8m+9ZnIpvWNFHXhz/lgwcpLUlu+R8d8xS3moJl13QchVA8uJdAgOo5TJm0JOeuHGkYOd7V2PY/tN7WKqKXFHD317WNVuEXYejos3j1oqq4axzqUiClAnyiaa2Hd7O03bSczHeOK7SSow/EKYg7ss9+Tn83AkJiR6G3QY/ZvUNLXHzfP7c5fH1lb375kmL9mkISuBT2LYQiGee03uzqyxwYRXSivrC3frSvdsI4srCpARdPN3JjmmHqZ7PcFtO4kxduwJ5jNZ0fskmOpXzMwFV8WL4le17FdjjfvI2GIQlNP5mcNMqkT1GqaVeRVIUFTTSBtQiJ83rB7aNle5dtCTpmtnrkJrHS9IKN88WE4L7/UC+R9FyEa+ImsTDS3kPpdJ9lU0iJAI7wM1I+0IORxH1JqftObeKUKyhcVxqmizUPaO4MrvKTFuh/wUeaT428K5oXLr9os0dGVlSFNHtgsG3QfeJnGdCQYQXl8SAivq68gdgI26J53fC5exjPHHFDp+2b58JuN3zIc/N/1tBp2c+dGiL4w8DKdGEI11Z/9cFHGpiU49cl+Z239qKI1TAr3mnfc4tbQCSTQwRpmU8cleQMWlMw2v8qd/s4wCHiE3Ymrolcz4/vjJ14VELMDqAxLJ9kXq9lJ9hglsfjPeqFckBqCth1pPnh295vhfE7ZBjzlYCyGrR6krycSV5XNnMTAXuxHV3pkUYTGYljxzSXZ2EiGyf7NWEfc5VxQl8s72L4RrYY2DndTHe9QF1uyWHkbT5znTmQvB0Bz4E6m4o1p+De9E0kHQbcutqFoiiDq/URkrKC23FWWZBRj/cR3mrcqkkh0B8lsh+T7xN9Ux2pI+bSovX+Pt6ZYs16EMcu+Rt4jB29i+uxiQHNaYSedZ20BvO2GrUQPO363fFqKGix9UVtm0ykfkGKkocYufY8b1thZ1/7McpfiWg/Kh1nkvoMzPXw/y75oyUi7TOBIJGa/cAgUL7zmMQ9jujMHAF3QvY6q0a37QCXxkiWqnsCa4wk2gK8879w3L0jq7umUe5cdWwxIpKk7LVa5hB0C7i0U63t8VGGpS9WCydJxBuOeaysl8nnXzyu9xOvtDPMpUtWFxJCB5OGaFAlArr06L+BAsdt/IXXU4eQ+l4X+cPCt5NAguwNsGV2zVd1Aj86nWxxFlqlQ26aL+6Y61XfzhooslkP0G97fuHAZ9j0TqZlaO7CwndxJNjlik35WGJpzl7yM+5+rFQxovOAUX3qJZKoIsWUmU0ii2CK/UaIJiXsNgJEbBYGF80oK77q2Y3VX5mASm6WZ7BXJ1zagB9zDcedCSpH3SzvaTfi4oPicixVSnDoJSAFG0P7tfVQpUkM3km2fAPzp4FjlsyfQUnUrAExLSD86eOuFw+d0SauKl2uyl74f1fsFHJGX8l58IhM4Gfpok7b/bND6zjPe/Lhp/iv+2PQWoHVXxXCwRv59hfikIzJokZ2GzpTCKtOQcEUU6UaBVmBqdvHoaa5y/G+oich/gRB9+rvCT4AhUM/x5U9zhc7Xk4uWEcQRlvwf0ngwnpaCeMWPmwtYlshDvoJ/aB3En8z2ZKEtgPVhx3JlmMwaRtMY/YzYJoV6Gi7mKXvHU= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7e01ab4-6478-49b4-409e-08dac73f544a X-MS-Exchange-CrossTenant-AuthSource: OSAPR01MB3892.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 19:26:43.8772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ht9LNrhWLQzp72n/jgeAX27X5HhKPL+USQCPoEpTbaMeaJC0Kazzb/xg9F632fhbHNFMU4O/63devwc9K/EX4p0lNrLabfNEhvoq+OPWYM0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB10539 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749591460742326038?= X-GMAIL-MSGID: =?utf-8?q?1749591460742326038?= |
Series |
Add support for Renesas PhiClock 9FGV1006 clock generator
|
|
Commit Message
Alex Helms
Nov. 15, 2022, 7:26 p.m. UTC
Add dt bindings for the Renesas PhiClock clock generator.
Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com>
---
.../bindings/clock/renesas,phiclock.yaml | 81 +++++++++++++++++++
MAINTAINERS | 5 ++
2 files changed, 86 insertions(+)
create mode 100644 Documentation/devicetree/bindings/clock/renesas,phiclock.yaml
Comments
On 15/11/2022 20:26, Alex Helms wrote: > Add dt bindings for the Renesas PhiClock clock generator. > Subject: drop second, redundant "bindings" > Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com> > --- > .../bindings/clock/renesas,phiclock.yaml | 81 +++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 86 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/renesas,phiclock.yaml > > diff --git a/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml b/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml > new file mode 100644 > index 000000000..2b36534d3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml Filename based on compatible. > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/renesas,phiclock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas PhiClock Clock Generator Device Tree Bindings Drop "Device Tree Bindings" > + > +maintainers: > + - Alex Helms <alexander.helms.jy@renesas.com> > + > +description: | > + The Renesas PhiClock is a programmable I2C clock generator that provides > + 1 reference output and 2 clock outputs. > + > + The driver supports spread spectrum but only if all configurations use the Driver as in Linux driver? Drop entire paragraph. Bindings are about hardware, not driver. > + same spread spectrum parameters. If your configuration uses spread spectrum, > + you must include renesas,ss-amount-percent, renesas,ss-modulation-hz, and > + renesas,ss-direction in the device tree. > + > +properties: compatible goes always first. Start your schema from example-schema.yaml. > + '#clock-cells': > + const: 1 > + > + clock-names: > + items: > + - const: xin-clkin Just "xin" or entirely drop. > + > + clocks: > + const: 1 > + > + compatible: > + enum: > + - renesas,9fgv1006 > + > + reg: > + maxItems: 1 > + > + renesas,ss-amount-percent: > + description: Spread spectrum absolute amount as hundredths of a percent, e.g. 150 is 1.50%. What? If this is percent then it cannot be hundreds of percent. Percent is percent. Use appropriate units. https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml > + minimum: 0 > + maximum: 500 > + > + renesas,ss-modulation-hz: > + description: Spread spectrum modulation rate in Hz > + minimum: 30000 > + maximum: 63000 > + > + renesas,ss-direction: > + $ref: /schemas/types.yaml#/definitions/string > + description: Spread spectrum direction > + enum: [ down, center ] > + > +required: > + - clock-names > + - '#clock-cells' > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + ref25: ref25m { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <25000000>; > + }; Drop, it's obvious, isn't it? > + Best regards, Krzysztof
Hi Krzysztof, On Wed, Nov 16, 2022 at 9:20 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 15/11/2022 20:26, Alex Helms wrote: > > Add dt bindings for the Renesas PhiClock clock generator. > > > > Subject: drop second, redundant "bindings" > > > Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com> > > --- > > .../bindings/clock/renesas,phiclock.yaml | 81 +++++++++++++++++++ > > MAINTAINERS | 5 ++ > > 2 files changed, 86 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/renesas,phiclock.yaml > > > > diff --git a/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml b/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml > > new file mode 100644 > > index 000000000..2b36534d3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml > > Filename based on compatible. Looks like there are more of them, so I guess the family name is fine? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 16/11/2022 09:34, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Wed, Nov 16, 2022 at 9:20 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> On 15/11/2022 20:26, Alex Helms wrote: >>> Add dt bindings for the Renesas PhiClock clock generator. >>> >> >> Subject: drop second, redundant "bindings" >> >>> Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com> >>> --- >>> .../bindings/clock/renesas,phiclock.yaml | 81 +++++++++++++++++++ >>> MAINTAINERS | 5 ++ >>> 2 files changed, 86 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/clock/renesas,phiclock.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml b/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml >>> new file mode 100644 >>> index 000000000..2b36534d3 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml >> >> Filename based on compatible. > > Looks like there are more of them, so I guess the family name is fine? > If you are sure, then yes. Can we add them now? If not, it's also fine. Best regards, Krzysztof
On 11/16/2022 1:20 AM, Krzysztof Kozlowski wrote: > On 15/11/2022 20:26, Alex Helms wrote: >> Add dt bindings for the Renesas PhiClock clock generator. >> > > Subject: drop second, redundant "bindings" > >> Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com> >> --- >> .../bindings/clock/renesas,phiclock.yaml | 81 +++++++++++++++++++ >> MAINTAINERS | 5 ++ >> 2 files changed, 86 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/renesas,phiclock.yaml >> >> diff --git a/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml b/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml >> new file mode 100644 >> index 000000000..2b36534d3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml > > Filename based on compatible. > As Geert mentioned in the other thread, this is a family of products but the others cannot be added now. >> @@ -0,0 +1,81 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fclock%2Frenesas%2Cphiclock.yaml%23&data=05%7C01%7Calexander.helms.jy%40renesas.com%7C9c13a32848f3434e217108dac7ab69f6%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C638041836281252737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=J6kNqua%2FJf0c8HczRM8gU8%2Fm%2BhX6gSF2fqnf2n3wSbI%3D&reserved=0 >> +$schema: https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Calexander.helms.jy%40renesas.com%7C9c13a32848f3434e217108dac7ab69f6%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C638041836281252737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ofZbC2sBnTpJR3KKzPVqhsFy28r4JjbJpaVGSuHKx38%3D&reserved=0 >> + >> +title: Renesas PhiClock Clock Generator Device Tree Bindings > > Drop "Device Tree Bindings" > >> + >> +maintainers: >> + - Alex Helms <alexander.helms.jy@renesas.com> >> + >> +description: | >> + The Renesas PhiClock is a programmable I2C clock generator that provides >> + 1 reference output and 2 clock outputs. >> + >> + The driver supports spread spectrum but only if all configurations use the > > Driver as in Linux driver? Drop entire paragraph. Bindings are about > hardware, not driver. > >> + same spread spectrum parameters. If your configuration uses spread spectrum, >> + you must include renesas,ss-amount-percent, renesas,ss-modulation-hz, and >> + renesas,ss-direction in the device tree. >> + >> +properties: > > compatible goes always first. Start your schema from example-schema.yaml. > >> + '#clock-cells': >> + const: 1 >> + >> + clock-names: >> + items: >> + - const: xin-clkin > > Just "xin" or entirely drop. The pin name on the datasheet is "xin-clkin" and as the name implies it can be a crystal or clock input. If the name were different it could be confusing. > >> + >> + clocks: >> + const: 1 >> + >> + compatible: >> + enum: >> + - renesas,9fgv1006 >> + >> + reg: >> + maxItems: 1 >> + >> + renesas,ss-amount-percent: >> + description: Spread spectrum absolute amount as hundredths of a percent, e.g. 150 is 1.50%. > > What? If this is percent then it cannot be hundreds of percent. Percent > is percent. Use appropriate units. > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdevicetree-org%2Fdt-schema%2Fblob%2Fmain%2Fdtschema%2Fschemas%2Fproperty-units.yaml&data=05%7C01%7Calexander.helms.jy%40renesas.com%7C9c13a32848f3434e217108dac7ab69f6%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C638041836281252737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6MULpJhPyyjWSo1SvPCrz6KidE1VEtiiNYk1O5wS1vI%3D&reserved=0 > Values like 0.5% or 2.5% must be representable which is why this property is an integer of hundredths of percent. How else would you represent a non-integer percent? >> + minimum: 0 >> + maximum: 500 >> + >> + renesas,ss-modulation-hz: >> + description: Spread spectrum modulation rate in Hz >> + minimum: 30000 >> + maximum: 63000 >> + >> + renesas,ss-direction: >> + $ref: /schemas/types.yaml#/definitions/string >> + description: Spread spectrum direction >> + enum: [ down, center ] >> + >> +required: >> + - clock-names >> + - '#clock-cells' >> + - compatible >> + - reg >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + ref25: ref25m { >> + compatible = "fixed-clock"; >> + #clock-cells = <0>; >> + clock-frequency = <25000000>; >> + }; > > Drop, it's obvious, isn't it? > I disagree, this may be obvious to someone familiar with how clocks in the device tree works but not long ago it was entirely new to me and examples like these in the dt schemas were very helpful in getting the device up and running. There are several other bindings that define external crystals and reference clocks in this way. >> + > > Best regards, > Krzysztof >
On 16/11/2022 21:11, Alex Helms wrote: >>> + clocks: >>> + const: 1 >>> + >>> + compatible: >>> + enum: >>> + - renesas,9fgv1006 >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + renesas,ss-amount-percent: >>> + description: Spread spectrum absolute amount as hundredths of a percent, e.g. 150 is 1.50%. >> >> What? If this is percent then it cannot be hundreds of percent. Percent >> is percent. Use appropriate units. >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdevicetree-org%2Fdt-schema%2Fblob%2Fmain%2Fdtschema%2Fschemas%2Fproperty-units.yaml&data=05%7C01%7Calexander.helms.jy%40renesas.com%7C9c13a32848f3434e217108dac7ab69f6%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C638041836281252737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6MULpJhPyyjWSo1SvPCrz6KidE1VEtiiNYk1O5wS1vI%3D&reserved=0 >> > > Values like 0.5% or 2.5% must be representable which is why this > property is an integer of hundredths of percent. How else would you > represent a non-integer percent? With an appropriate unit. > >>> + minimum: 0 >>> + maximum: 500 >>> + >>> + renesas,ss-modulation-hz: >>> + description: Spread spectrum modulation rate in Hz >>> + minimum: 30000 >>> + maximum: 63000 >>> + >>> + renesas,ss-direction: >>> + $ref: /schemas/types.yaml#/definitions/string >>> + description: Spread spectrum direction >>> + enum: [ down, center ] >>> + >>> +required: >>> + - clock-names >>> + - '#clock-cells' >>> + - compatible >>> + - reg >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + ref25: ref25m { >>> + compatible = "fixed-clock"; >>> + #clock-cells = <0>; >>> + clock-frequency = <25000000>; >>> + }; >> >> Drop, it's obvious, isn't it? >> > > I disagree, this may be obvious to someone familiar with how clocks in > the device tree works but not long ago it was entirely new to me and > examples like these in the dt schemas were very helpful in getting the > device up and running. There are several other bindings that define > external crystals and reference clocks in this way. It is obvious because it is the same for every device being a consumer of external clock. There is no point to duplicate non-device related examples in every device binding. Best regards, Krzysztof
On Thu, Nov 17, 2022 at 8:39 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 16/11/2022 21:11, Alex Helms wrote: > >>> + clocks: > >>> + const: 1 > >>> + > >>> + compatible: > >>> + enum: > >>> + - renesas,9fgv1006 > >>> + > >>> + reg: > >>> + maxItems: 1 > >>> + > >>> + renesas,ss-amount-percent: > >>> + description: Spread spectrum absolute amount as hundredths of a percent, e.g. 150 is 1.50%. > >> > >> What? If this is percent then it cannot be hundreds of percent. Percent > >> is percent. Use appropriate units. > >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdevicetree-org%2Fdt-schema%2Fblob%2Fmain%2Fdtschema%2Fschemas%2Fproperty-units.yaml&data=05%7C01%7Calexander.helms.jy%40renesas.com%7C9c13a32848f3434e217108dac7ab69f6%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C638041836281252737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6MULpJhPyyjWSo1SvPCrz6KidE1VEtiiNYk1O5wS1vI%3D&reserved=0 > >> > > > > Values like 0.5% or 2.5% must be representable which is why this > > property is an integer of hundredths of percent. How else would you > > represent a non-integer percent? > > With an appropriate unit. Krzysztof really means the property should be named e.g. "renesas,ss-amount-centipercent" instead. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 17/11/2022 09:11, Geert Uytterhoeven wrote: >>>>> + >>>>> + renesas,ss-amount-percent: >>>>> + description: Spread spectrum absolute amount as hundredths of a percent, e.g. 150 is 1.50%. >>>> >>>> What? If this is percent then it cannot be hundreds of percent. Percent >>>> is percent. Use appropriate units. >>>> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdevicetree-org%2Fdt-schema%2Fblob%2Fmain%2Fdtschema%2Fschemas%2Fproperty-units.yaml&data=05%7C01%7Calexander.helms.jy%40renesas.com%7C9c13a32848f3434e217108dac7ab69f6%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C638041836281252737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6MULpJhPyyjWSo1SvPCrz6KidE1VEtiiNYk1O5wS1vI%3D&reserved=0 >>>> >>> >>> Values like 0.5% or 2.5% must be representable which is why this >>> property is an integer of hundredths of percent. How else would you >>> represent a non-integer percent? >> >> With an appropriate unit. > > Krzysztof really means the property should be named e.g. > "renesas,ss-amount-centipercent" instead. > I provided an URL to document with units, so I was hoping Alex will take a bit of effort to open it. Hundredths of percent sounds like basis point... If it is not basis point, maybe it could be made such? Best regards, Krzysztof
Hi Krzysztof, On Thu, Nov 17, 2022 at 11:41 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 17/11/2022 09:11, Geert Uytterhoeven wrote: > >>>>> + renesas,ss-amount-percent: > >>>>> + description: Spread spectrum absolute amount as hundredths of a percent, e.g. 150 is 1.50%. > >>>> > >>>> What? If this is percent then it cannot be hundreds of percent. Percent > >>>> is percent. Use appropriate units. > >>>> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdevicetree-org%2Fdt-schema%2Fblob%2Fmain%2Fdtschema%2Fschemas%2Fproperty-units.yaml&data=05%7C01%7Calexander.helms.jy%40renesas.com%7C9c13a32848f3434e217108dac7ab69f6%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C638041836281252737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6MULpJhPyyjWSo1SvPCrz6KidE1VEtiiNYk1O5wS1vI%3D&reserved=0 > >>>> > >>> > >>> Values like 0.5% or 2.5% must be representable which is why this > >>> property is an integer of hundredths of percent. How else would you > >>> represent a non-integer percent? > >> > >> With an appropriate unit. > > > > Krzysztof really means the property should be named e.g. > > "renesas,ss-amount-centipercent" instead. > > I provided an URL to document with units, so I was hoping Alex will take > a bit of effort to open it. Hundredths of percent sounds like basis > point... If it is not basis point, maybe it could be made such? Thank you, I didn't know about basis points. TIL ;-) (and I didn't dare to click on the safelink-converted quoted link) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml b/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml new file mode 100644 index 000000000..2b36534d3 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/renesas,phiclock.yaml @@ -0,0 +1,81 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/renesas,phiclock.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas PhiClock Clock Generator Device Tree Bindings + +maintainers: + - Alex Helms <alexander.helms.jy@renesas.com> + +description: | + The Renesas PhiClock is a programmable I2C clock generator that provides + 1 reference output and 2 clock outputs. + + The driver supports spread spectrum but only if all configurations use the + same spread spectrum parameters. If your configuration uses spread spectrum, + you must include renesas,ss-amount-percent, renesas,ss-modulation-hz, and + renesas,ss-direction in the device tree. + +properties: + '#clock-cells': + const: 1 + + clock-names: + items: + - const: xin-clkin + + clocks: + const: 1 + + compatible: + enum: + - renesas,9fgv1006 + + reg: + maxItems: 1 + + renesas,ss-amount-percent: + description: Spread spectrum absolute amount as hundredths of a percent, e.g. 150 is 1.50%. + minimum: 0 + maximum: 500 + + renesas,ss-modulation-hz: + description: Spread spectrum modulation rate in Hz + minimum: 30000 + maximum: 63000 + + renesas,ss-direction: + $ref: /schemas/types.yaml#/definitions/string + description: Spread spectrum direction + enum: [ down, center ] + +required: + - clock-names + - '#clock-cells' + - compatible + - reg + +additionalProperties: false + +examples: + - | + ref25: ref25m { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <25000000>; + }; + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + phiclock: clock-controller@68 { + compatible = "renesas,9fgv1006"; + reg = <0x68>; + #clock-cells = <1>; + clocks = <&ref25>; + clock-names = "xin-clkin"; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 256f03904..7eabe930b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17641,6 +17641,11 @@ S: Maintained F: Documentation/devicetree/bindings/clock/renesas,versaclock7.yaml F: drivers/clk/clk-versaclock7.c +RENESAS PHICLOCK CLOCK DRIVER +M: Alex Helms <alexander.helms.jy@renesas.com> +S: Maintained +F: Documentation/devicetree/bindings/clock/renesas,phiclock.yaml + RESET CONTROLLER FRAMEWORK M: Philipp Zabel <p.zabel@pengutronix.de> S: Maintained