| Message ID | 20221113191301.5526-2-Sergey.Semin@baikalelectronics.ru |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1801032wru;
Sun, 13 Nov 2022 11:15:53 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf4AiB6zG202jCFVN9lQTU2qDIH+q+H0oUTGViVHQwkKk+MeEQxzBh6eSn6bhjsrv0uxWNn9
X-Received: by 2002:a17:906:8541:b0:7ae:c1af:89af with SMTP id
h1-20020a170906854100b007aec1af89afmr8204865ejy.550.1668366953430;
Sun, 13 Nov 2022 11:15:53 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1668366953; cv=none;
d=google.com; s=arc-20160816;
b=0PTs+4g28M+DI/XG6Rj/Qkezrfe52lWHAIQ84SRon0itYU8GEfdhDcNy/VppzxlBtd
sp3sGiQr0W89TEE5T9IV/7Dv797+0a0h6FPkwsPtEfl5NEyoim2AHft36d/Lpk+XDJPc
NtXaXgZn88xeSbs6U94JiV6921YNJWVjvlFKwlh4n2QGx5gI00vYt4nthiFzE5YtK3yC
o2opOTCpGDott/c4s6EoefpB2srwfFKQeenb5auScNZFlSrxel/RYPbNy6kSa/5cgfsp
aNcvyrm5A6WvoxM4k5sS7IB8KtzK2XeTeAupC4Ep8bUQ+aidtLZrguidqBcpDEbSG05Z
igYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=HAbPpyQXjz8ylsqMTZ03ZjBo19Ye/nkDntALZaYQcTI=;
b=aJPo/xo9jpawdc5GS+3F5PUeS7MhAEhgDOO3wcbkz1O/QlKjXfXOfsSVz3gyw2IVYx
wOlfPAgBxT/gBXw0pooqVrTADCX2g1alj7Bine2crkCX+E5Ry+Mww3p3GiEV0876+q/A
PSeUMQTXHUPh21hwLpATmHfG9B/RgWXq653nRBQY1kGU84JlQhxw6N6nL2LEu/V0EWnD
rPJyYl3faHrUzCl0tWYSYg7UlKB6lvs8en9hXvf8o7u7To+J5JSXePlArRHAbLb79Op1
ss/m4+OBFrDX5a8n0VBKuH8md0Ml2t/Nm6sZgY7Hy4Al1DvWd0ppcHrCycF5hnNPUlZ0
M5gg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@baikalelectronics.ru header.s=post
header.b="MdsG/jrP";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE)
header.from=baikalelectronics.ru
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
x24-20020a1709064a9800b007808f3f4cbcsi5686604eju.239.2022.11.13.11.15.28;
Sun, 13 Nov 2022 11:15:53 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@baikalelectronics.ru header.s=post
header.b="MdsG/jrP";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE)
header.from=baikalelectronics.ru
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S235599AbiKMTPF (ORCPT <rfc822;winker.wchi@gmail.com>
+ 99 others); Sun, 13 Nov 2022 14:15:05 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46250 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S235317AbiKMTOw (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sun, 13 Nov 2022 14:14:52 -0500
Received: from post.baikalelectronics.com (post.baikalelectronics.com
[213.79.110.86])
by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1639EDEC2;
Sun, 13 Nov 2022 11:14:46 -0800 (PST)
Received: from post.baikalelectronics.com (localhost.localdomain [127.0.0.1])
by post.baikalelectronics.com (Proxmox) with ESMTP id DC4D2E0EAA;
Sun, 13 Nov 2022 22:14:44 +0300 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
baikalelectronics.ru; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:from:from:in-reply-to:message-id
:mime-version:references:reply-to:subject:subject:to:to; s=post;
bh=HAbPpyQXjz8ylsqMTZ03ZjBo19Ye/nkDntALZaYQcTI=; b=MdsG/jrPr/Nh
jgBXP9IN3550UJm78IBv4xU/Ne4mbJuQqwFTQufpJdA21N13fSKLcdjf1N5p50l9
cXZtuIAoKo++6UpdJ9RAgkysnOj1bhTMmdmNmFCoQ8VBf8OS+O4o5VhDzv26ZOMU
cKsEuLvwG/fYvcglxlFeDNktNdcLPPA=
Received: from mail.baikal.int (mail.baikal.int [192.168.51.25])
by post.baikalelectronics.com (Proxmox) with ESMTP id C8416E0E6A;
Sun, 13 Nov 2022 22:14:44 +0300 (MSK)
Received: from localhost (192.168.168.10) by mail (192.168.51.25) with
Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 13 Nov 2022 22:14:44 +0300
From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Rob Herring <robh+dt@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Cai Huoqing <cai.huoqing@linux.dev>,
Robin Murphy <robin.murphy@arm.com>,
Jingoo Han <jingoohan1@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Richard Zhu <hongxing.zhu@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
CC: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>, =?utf-8?q?Krzys?=
=?utf-8?q?ztof_Wilczy=C5=84ski?= <kw@linux.com>, Frank Li <Frank.Li@nxp.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
caihuoqing <caihuoqing@baidu.com>, Vinod Koul <vkoul@kernel.org>,
<linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx
and imx8mq
Date: Sun, 13 Nov 2022 22:12:42 +0300
Message-ID: <20221113191301.5526-2-Sergey.Semin@baikalelectronics.ru>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221113191301.5526-1-Sergey.Semin@baikalelectronics.ru>
References: <20221113191301.5526-1-Sergey.Semin@baikalelectronics.ru>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [192.168.168.10]
X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25)
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1749409546207831029?=
X-GMAIL-MSGID: =?utf-8?q?1749409546207831029?=
|
| Series |
PCI: dwc: Add generic resources and Baikal-T1 support
|
|
Commit Message
Serge Semin
Nov. 13, 2022, 7:12 p.m. UTC
Originally as it was defined the legacy bindings the pcie_inbound_axi and
pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and
fsl,imx8mq-pcie devices respectively. But the bindings conversion has been
incorrectly so now the fourth clock name is defined as "pcie_inbound_axi
for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong.
Let's fix that by conditionally apply the clock-names constraints based on
the compatible string content.
Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema")
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Changelog v5:
- This is a new patch added on the v5 release of the patchset.
Changelog v7:
- Move the allOf clause to the bottom of the bindings. (@Krzysztof)
- Get back the names to the clock-names property and make sure the
platform-specific name constraint is applied in the allOf clause.
(@Rob)
---
.../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++--
1 file changed, 42 insertions(+), 4 deletions(-)
Comments
On Sun, 13 Nov 2022 22:12:42 +0300, Serge Semin wrote: > Originally as it was defined the legacy bindings the pcie_inbound_axi and > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > Let's fix that by conditionally apply the clock-names constraints based on > the compatible string content. > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > Changelog v5: > - This is a new patch added on the v5 release of the patchset. > > Changelog v7: > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > - Get back the names to the clock-names property and make sure the > platform-specific name constraint is applied in the allOf clause. > (@Rob) > --- > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > 1 file changed, 42 insertions(+), 4 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ pcie@1ffc000: Unevaluated properties are not allowed ('disable-gpio' was unexpected) arch/arm/boot/dts/imx6dl-emcon-avari.dtb arch/arm/boot/dts/imx6q-emcon-avari.dtb pcie@33800000: clock-names:1: 'pcie_bus' was expected arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-evk.dtb arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33800000: clock-names:2: 'pcie_phy' was expected arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-evk.dtb arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb pcie@33800000: clock-names:3: 'pcie_aux' was expected arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33800000: clock-names:3: 'pcie_bus' is not one of ['pcie_inbound_axi', 'pcie_aux'] arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33800000: power-domains: [[102, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb pcie@33800000: power-domains: [[102]] is too short arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb pcie@33800000: power-domains: [[103]] is too short arch/arm/boot/dts/imx7d-colibri-emmc-iris.dtb arch/arm/boot/dts/imx7d-colibri-iris.dtb pcie@33800000: power-domains: [[104]] is too short arch/arm/boot/dts/imx7d-colibri-aster.dtb arch/arm/boot/dts/imx7d-colibri-emmc-aster.dtb arch/arm/boot/dts/imx7d-colibri-emmc-iris-v2.dtb arch/arm/boot/dts/imx7d-colibri-iris-v2.dtb pcie@33800000: power-domains: [[106]] is too short arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb pcie@33800000: power-domains: [[107]] is too short arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dtb arch/arm/boot/dts/imx7d-colibri-eval-v3.dtb pcie@33800000: power-domains: [[108]] is too short arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb pcie@33800000: power-domains: [[125]] is too short arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb pcie@33800000: power-domains: [[126]] is too short arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb pcie@33800000: power-domains: [[49, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb pcie@33800000: power-domains: [[55]] is too short arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb pcie@33800000: power-domains: [[59]] is too short arch/arm/boot/dts/imx7d-cl-som-imx7.dtb pcie@33800000: power-domains: [[60, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb pcie@33800000: power-domains: [[61]] is too short arch/arm/boot/dts/imx7d-sbc-imx7.dtb pcie@33800000: power-domains: [[63]] is too short arch/arm/boot/dts/imx7d-zii-rmu2.dtb pcie@33800000: power-domains: [[64, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-evk.dtb pcie@33800000: power-domains: [[64]] is too short arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm/boot/dts/imx7d-remarkable2.dtb pcie@33800000: power-domains: [[67]] is too short arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb pcie@33800000: power-domains: [[68]] is too short arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm/boot/dts/imx7d-meerkat96.dtb pcie@33800000: power-domains: [[70, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb pcie@33800000: power-domains: [[70]] is too short arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb pcie@33800000: power-domains: [[72]] is too short arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb pcie@33800000: power-domains: [[73]] is too short arch/arm/boot/dts/imx7d-flex-concentrator.dtb arch/arm/boot/dts/imx7d-flex-concentrator-mfg.dtb arch/arm/boot/dts/imx7d-smegw01.dtb pcie@33800000: power-domains: [[75]] is too short arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb pcie@33800000: power-domains: [[76, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb pcie@33800000: power-domains: [[76]] is too short arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb pcie@33800000: power-domains: [[77]] is too short arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb pcie@33800000: power-domains: [[78]] is too short arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb pcie@33800000: power-domains: [[79]] is too short arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb pcie@33800000: power-domains: [[80]] is too short arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb pcie@33800000: power-domains: [[81]] is too short arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-evk.dtb pcie@33800000: power-domains: [[82]] is too short arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb pcie@33800000: power-domains: [[83, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb pcie@33800000: power-domains: [[84]] is too short arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb pcie@33800000: power-domains: [[86, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb pcie@33800000: power-domains: [[86]] is too short arch/arm/boot/dts/imx7d-nitrogen7.dtb arch/arm/boot/dts/imx7d-pico-nymph.dtb pcie@33800000: power-domains: [[87]] is too short arch/arm/boot/dts/imx7d-sdb-reva.dtb pcie@33800000: power-domains: [[88]] is too short arch/arm/boot/dts/imx7d-pico-dwarf.dtb arch/arm/boot/dts/imx7d-pico-hobbit.dtb arch/arm/boot/dts/imx7d-sdb.dtb arch/arm/boot/dts/imx7d-sdb-sht11.dtb pcie@33800000: power-domains: [[89]] is too short arch/arm/boot/dts/imx7d-pico-pi.dtb arch/arm/boot/dts/imx7d-zii-rpu2.dtb pcie@33800000: power-domains: [[92]] is too short arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb pcie@33800000: power-domains: [[96]] is too short arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm/boot/dts/imx7d-mba7.dtb pcie@33800000: power-domains: [[97, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb pcie@33800000: power-domains: [[97]] is too short arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb pcie@33800000: power-domains: [[98]] is too short arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33800000: reset-names:0: 'pciephy' was expected arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb arch/arm64/boot/dts/freescale/imx8mp-evk.dtb arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb pcie@33800000: reset-names:1: 'apps' was expected arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb arch/arm64/boot/dts/freescale/imx8mp-evk.dtb arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb pcie@33800000: reset-names: ['apps', 'turnoff'] is too short arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb arch/arm64/boot/dts/freescale/imx8mp-evk.dtb arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb pcie@33800000: resets: [[101, 26], [101, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb pcie@33800000: resets: [[25, 28], [25, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb pcie@33800000: resets: [[26, 28], [26, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb pcie@33800000: resets: [[27, 28], [27, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb pcie@33800000: resets: [[28, 28], [28, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb pcie@33800000: resets: [[29, 28], [29, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb pcie@33800000: resets: [[31, 28], [31, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb pcie@33800000: resets: [[34, 28], [34, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb pcie@33800000: resets: [[40, 28], [40, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb pcie@33800000: resets: [[48, 26], [48, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb pcie@33800000: resets: [[59, 26], [59, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb pcie@33800000: resets: [[63, 26], [63, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-evk.dtb pcie@33800000: resets: [[69, 26], [69, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb pcie@33800000: resets: [[75, 26], [75, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb pcie@33800000: resets: [[82, 26], [82, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb pcie@33800000: resets: [[85, 26], [85, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb pcie@33800000: resets: [[96, 26], [96, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb pcie@33800000: Unevaluated properties are not allowed ('clock-names', 'epdev_on-supply', 'hard-wired', 'power-domains' were unexpected) arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb pcie@33800000: Unevaluated properties are not allowed ('clock-names', 'power-domains' were unexpected) arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33800000: Unevaluated properties are not allowed ('power-domains', 'reset-names', 'resets' were unexpected) arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb arch/arm64/boot/dts/freescale/imx8mp-evk.dtb arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb pcie@33800000: Unevaluated properties are not allowed ('power-domains' was unexpected) arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb arch/arm/boot/dts/imx7d-cl-som-imx7.dtb arch/arm/boot/dts/imx7d-colibri-aster.dtb arch/arm/boot/dts/imx7d-colibri-emmc-aster.dtb arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dtb arch/arm/boot/dts/imx7d-colibri-emmc-iris.dtb arch/arm/boot/dts/imx7d-colibri-emmc-iris-v2.dtb arch/arm/boot/dts/imx7d-colibri-eval-v3.dtb arch/arm/boot/dts/imx7d-colibri-iris.dtb arch/arm/boot/dts/imx7d-colibri-iris-v2.dtb arch/arm/boot/dts/imx7d-flex-concentrator.dtb arch/arm/boot/dts/imx7d-flex-concentrator-mfg.dtb arch/arm/boot/dts/imx7d-mba7.dtb arch/arm/boot/dts/imx7d-meerkat96.dtb arch/arm/boot/dts/imx7d-nitrogen7.dtb arch/arm/boot/dts/imx7d-pico-dwarf.dtb arch/arm/boot/dts/imx7d-pico-hobbit.dtb arch/arm/boot/dts/imx7d-pico-nymph.dtb arch/arm/boot/dts/imx7d-pico-pi.dtb arch/arm/boot/dts/imx7d-remarkable2.dtb arch/arm/boot/dts/imx7d-sbc-imx7.dtb arch/arm/boot/dts/imx7d-sdb.dtb arch/arm/boot/dts/imx7d-sdb-reva.dtb arch/arm/boot/dts/imx7d-sdb-sht11.dtb arch/arm/boot/dts/imx7d-smegw01.dtb arch/arm/boot/dts/imx7d-zii-rmu2.dtb arch/arm/boot/dts/imx7d-zii-rpu2.dtb pcie@33c00000: 'bus-range' is a required property arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33c00000: clock-names:1: 'pcie_bus' was expected arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33c00000: clock-names:3: 'pcie_aux' was expected arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33c00000: clock-names:3: 'pcie_bus' is not one of ['pcie_inbound_axi', 'pcie_aux'] arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33c00000: power-domains: [[102]] is too short arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb pcie@33c00000: power-domains: [[125]] is too short arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb pcie@33c00000: power-domains: [[126]] is too short arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb pcie@33c00000: power-domains: [[70]] is too short arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb pcie@33c00000: power-domains: [[78]] is too short arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb pcie@33c00000: power-domains: [[79]] is too short arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb pcie@33c00000: power-domains: [[80]] is too short arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb pcie@33c00000: power-domains: [[81]] is too short arch/arm64/boot/dts/freescale/imx8mq-evk.dtb pcie@33c00000: power-domains: [[82]] is too short arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb pcie@33c00000: power-domains: [[92]] is too short arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb pcie@33c00000: power-domains: [[97]] is too short arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb pcie@33c00000: power-domains: [[98]] is too short arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33c00000: Unevaluated properties are not allowed ('clock-names', 'epdev_on-supply', 'hard-wired', 'power-domains' were unexpected) arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb pcie@33c00000: Unevaluated properties are not allowed ('clock-names', 'power-domains' were unexpected) arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33c00000: Unevaluated properties are not allowed ('power-domains' was unexpected) arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb
On Sun, Nov 13, 2022 at 06:06:28PM -0600, Rob Herring wrote: > > On Sun, 13 Nov 2022 22:12:42 +0300, Serge Semin wrote: > > Originally as it was defined the legacy bindings the pcie_inbound_axi and > > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > > Let's fix that by conditionally apply the clock-names constraints based on > > the compatible string content. > > > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > > --- > > > > Changelog v5: > > - This is a new patch added on the v5 release of the patchset. > > > > Changelog v7: > > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > > - Get back the names to the clock-names property and make sure the > > platform-specific name constraint is applied in the allOf clause. > > (@Rob) > > --- > > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > > 1 file changed, 42 insertions(+), 4 deletions(-) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. Yeah, these are the old warnings. No semantic change causing them provided in this patch. -Sergey > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > pcie@1ffc000: Unevaluated properties are not allowed ('disable-gpio' was unexpected) > arch/arm/boot/dts/imx6dl-emcon-avari.dtb > arch/arm/boot/dts/imx6q-emcon-avari.dtb > > pcie@33800000: clock-names:1: 'pcie_bus' was expected > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33800000: clock-names:2: 'pcie_phy' was expected > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > > pcie@33800000: clock-names:3: 'pcie_aux' was expected > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33800000: clock-names:3: 'pcie_bus' is not one of ['pcie_inbound_axi', 'pcie_aux'] > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33800000: power-domains: [[102, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb > > pcie@33800000: power-domains: [[102]] is too short > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > > pcie@33800000: power-domains: [[103]] is too short > arch/arm/boot/dts/imx7d-colibri-emmc-iris.dtb > arch/arm/boot/dts/imx7d-colibri-iris.dtb > > pcie@33800000: power-domains: [[104]] is too short > arch/arm/boot/dts/imx7d-colibri-aster.dtb > arch/arm/boot/dts/imx7d-colibri-emmc-aster.dtb > arch/arm/boot/dts/imx7d-colibri-emmc-iris-v2.dtb > arch/arm/boot/dts/imx7d-colibri-iris-v2.dtb > > pcie@33800000: power-domains: [[106]] is too short > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > > pcie@33800000: power-domains: [[107]] is too short > arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dtb > arch/arm/boot/dts/imx7d-colibri-eval-v3.dtb > > pcie@33800000: power-domains: [[108]] is too short > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > > pcie@33800000: power-domains: [[125]] is too short > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb > > pcie@33800000: power-domains: [[126]] is too short > arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb > > pcie@33800000: power-domains: [[49, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb > > pcie@33800000: power-domains: [[55]] is too short > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb > > pcie@33800000: power-domains: [[59]] is too short > arch/arm/boot/dts/imx7d-cl-som-imx7.dtb > > pcie@33800000: power-domains: [[60, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb > > pcie@33800000: power-domains: [[61]] is too short > arch/arm/boot/dts/imx7d-sbc-imx7.dtb > > pcie@33800000: power-domains: [[63]] is too short > arch/arm/boot/dts/imx7d-zii-rmu2.dtb > > pcie@33800000: power-domains: [[64, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > > pcie@33800000: power-domains: [[64]] is too short > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm/boot/dts/imx7d-remarkable2.dtb > > pcie@33800000: power-domains: [[67]] is too short > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > > pcie@33800000: power-domains: [[68]] is too short > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm/boot/dts/imx7d-meerkat96.dtb > > pcie@33800000: power-domains: [[70, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > > pcie@33800000: power-domains: [[70]] is too short > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb > arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb > > pcie@33800000: power-domains: [[72]] is too short > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > > pcie@33800000: power-domains: [[73]] is too short > arch/arm/boot/dts/imx7d-flex-concentrator.dtb > arch/arm/boot/dts/imx7d-flex-concentrator-mfg.dtb > arch/arm/boot/dts/imx7d-smegw01.dtb > > pcie@33800000: power-domains: [[75]] is too short > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb > > pcie@33800000: power-domains: [[76, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb > > pcie@33800000: power-domains: [[76]] is too short > arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb > arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > > pcie@33800000: power-domains: [[77]] is too short > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > > pcie@33800000: power-domains: [[78]] is too short > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb > > pcie@33800000: power-domains: [[79]] is too short > arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb > > pcie@33800000: power-domains: [[80]] is too short > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > > pcie@33800000: power-domains: [[81]] is too short > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > > pcie@33800000: power-domains: [[82]] is too short > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb > > pcie@33800000: power-domains: [[83, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb > > pcie@33800000: power-domains: [[84]] is too short > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > > pcie@33800000: power-domains: [[86, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb > > pcie@33800000: power-domains: [[86]] is too short > arch/arm/boot/dts/imx7d-nitrogen7.dtb > arch/arm/boot/dts/imx7d-pico-nymph.dtb > > pcie@33800000: power-domains: [[87]] is too short > arch/arm/boot/dts/imx7d-sdb-reva.dtb > > pcie@33800000: power-domains: [[88]] is too short > arch/arm/boot/dts/imx7d-pico-dwarf.dtb > arch/arm/boot/dts/imx7d-pico-hobbit.dtb > arch/arm/boot/dts/imx7d-sdb.dtb > arch/arm/boot/dts/imx7d-sdb-sht11.dtb > > pcie@33800000: power-domains: [[89]] is too short > arch/arm/boot/dts/imx7d-pico-pi.dtb > arch/arm/boot/dts/imx7d-zii-rpu2.dtb > > pcie@33800000: power-domains: [[92]] is too short > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > > pcie@33800000: power-domains: [[96]] is too short > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm/boot/dts/imx7d-mba7.dtb > > pcie@33800000: power-domains: [[97, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb > > pcie@33800000: power-domains: [[97]] is too short > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb > > pcie@33800000: power-domains: [[98]] is too short > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33800000: reset-names:0: 'pciephy' was expected > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb > arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb > > pcie@33800000: reset-names:1: 'apps' was expected > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb > arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb > > pcie@33800000: reset-names: ['apps', 'turnoff'] is too short > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb > arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb > > pcie@33800000: resets: [[101, 26], [101, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb > > pcie@33800000: resets: [[25, 28], [25, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb > > pcie@33800000: resets: [[26, 28], [26, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > > pcie@33800000: resets: [[27, 28], [27, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > > pcie@33800000: resets: [[28, 28], [28, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > > pcie@33800000: resets: [[29, 28], [29, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb > > pcie@33800000: resets: [[31, 28], [31, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > > pcie@33800000: resets: [[34, 28], [34, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > > pcie@33800000: resets: [[40, 28], [40, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > > pcie@33800000: resets: [[48, 26], [48, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb > > pcie@33800000: resets: [[59, 26], [59, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb > > pcie@33800000: resets: [[63, 26], [63, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > > pcie@33800000: resets: [[69, 26], [69, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > > pcie@33800000: resets: [[75, 26], [75, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb > > pcie@33800000: resets: [[82, 26], [82, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb > > pcie@33800000: resets: [[85, 26], [85, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb > > pcie@33800000: resets: [[96, 26], [96, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb > > pcie@33800000: Unevaluated properties are not allowed ('clock-names', 'epdev_on-supply', 'hard-wired', 'power-domains' were unexpected) > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > > pcie@33800000: Unevaluated properties are not allowed ('clock-names', 'power-domains' were unexpected) > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33800000: Unevaluated properties are not allowed ('power-domains', 'reset-names', 'resets' were unexpected) > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb > arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb > > pcie@33800000: Unevaluated properties are not allowed ('power-domains' was unexpected) > arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb > arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb > arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb > arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb > arch/arm/boot/dts/imx7d-cl-som-imx7.dtb > arch/arm/boot/dts/imx7d-colibri-aster.dtb > arch/arm/boot/dts/imx7d-colibri-emmc-aster.dtb > arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dtb > arch/arm/boot/dts/imx7d-colibri-emmc-iris.dtb > arch/arm/boot/dts/imx7d-colibri-emmc-iris-v2.dtb > arch/arm/boot/dts/imx7d-colibri-eval-v3.dtb > arch/arm/boot/dts/imx7d-colibri-iris.dtb > arch/arm/boot/dts/imx7d-colibri-iris-v2.dtb > arch/arm/boot/dts/imx7d-flex-concentrator.dtb > arch/arm/boot/dts/imx7d-flex-concentrator-mfg.dtb > arch/arm/boot/dts/imx7d-mba7.dtb > arch/arm/boot/dts/imx7d-meerkat96.dtb > arch/arm/boot/dts/imx7d-nitrogen7.dtb > arch/arm/boot/dts/imx7d-pico-dwarf.dtb > arch/arm/boot/dts/imx7d-pico-hobbit.dtb > arch/arm/boot/dts/imx7d-pico-nymph.dtb > arch/arm/boot/dts/imx7d-pico-pi.dtb > arch/arm/boot/dts/imx7d-remarkable2.dtb > arch/arm/boot/dts/imx7d-sbc-imx7.dtb > arch/arm/boot/dts/imx7d-sdb.dtb > arch/arm/boot/dts/imx7d-sdb-reva.dtb > arch/arm/boot/dts/imx7d-sdb-sht11.dtb > arch/arm/boot/dts/imx7d-smegw01.dtb > arch/arm/boot/dts/imx7d-zii-rmu2.dtb > arch/arm/boot/dts/imx7d-zii-rpu2.dtb > > pcie@33c00000: 'bus-range' is a required property > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33c00000: clock-names:1: 'pcie_bus' was expected > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33c00000: clock-names:3: 'pcie_aux' was expected > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33c00000: clock-names:3: 'pcie_bus' is not one of ['pcie_inbound_axi', 'pcie_aux'] > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33c00000: power-domains: [[102]] is too short > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > > pcie@33c00000: power-domains: [[125]] is too short > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb > > pcie@33c00000: power-domains: [[126]] is too short > arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb > > pcie@33c00000: power-domains: [[70]] is too short > arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb > arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb > > pcie@33c00000: power-domains: [[78]] is too short > arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb > > pcie@33c00000: power-domains: [[79]] is too short > arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb > > pcie@33c00000: power-domains: [[80]] is too short > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > > pcie@33c00000: power-domains: [[81]] is too short > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > > pcie@33c00000: power-domains: [[82]] is too short > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb > > pcie@33c00000: power-domains: [[92]] is too short > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > > pcie@33c00000: power-domains: [[97]] is too short > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb > > pcie@33c00000: power-domains: [[98]] is too short > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33c00000: Unevaluated properties are not allowed ('clock-names', 'epdev_on-supply', 'hard-wired', 'power-domains' were unexpected) > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > > pcie@33c00000: Unevaluated properties are not allowed ('clock-names', 'power-domains' were unexpected) > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33c00000: Unevaluated properties are not allowed ('power-domains' was unexpected) > arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb > arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb > arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb > arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb > arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb >
On Sun, Nov 13, 2022 at 10:12:42PM +0300, Serge Semin wrote: > Originally as it was defined the legacy bindings the pcie_inbound_axi and > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > Let's fix that by conditionally apply the clock-names constraints based on > the compatible string content. > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > Changelog v5: > - This is a new patch added on the v5 release of the patchset. > > Changelog v7: > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > - Get back the names to the clock-names property and make sure the > platform-specific name constraint is applied in the allOf clause. > (@Rob) > --- > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > 1 file changed, 42 insertions(+), 4 deletions(-) We have 2 patches doing the same thing: https://lore.kernel.org/all/20221109002449.35936-1-marex@denx.de/ Please hash out which one you all want. Both seem to have clock warnings still... Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, Nov 16, 2022 at 02:38:12PM -0600, Rob Herring wrote: > On Sun, Nov 13, 2022 at 10:12:42PM +0300, Serge Semin wrote: > > Originally as it was defined the legacy bindings the pcie_inbound_axi and > > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > > Let's fix that by conditionally apply the clock-names constraints based on > > the compatible string content. > > > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > > --- > > > > Changelog v5: > > - This is a new patch added on the v5 release of the patchset. > > > > Changelog v7: > > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > > - Get back the names to the clock-names property and make sure the > > platform-specific name constraint is applied in the allOf clause. > > (@Rob) > > --- > > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > > 1 file changed, 42 insertions(+), 4 deletions(-) > > We have 2 patches doing the same thing: > > https://lore.kernel.org/all/20221109002449.35936-1-marex@denx.de/ It seems to me that that patch does two things at a time: 1. Fixes invalid fourth clock-names entry. 2. Fixes the fsl,imx8mm-pcie device having the "pcie_aux" clock name required instead of "pcie_phy". My patch does only the first part. What about moving my patch to that series and converting the Marek' patch to being applicable on top of it and fixing the imx8mm part only? That seems reasonable. -Sergey > > Please hash out which one you all want. Both seem to have clock > warnings still... > > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, Nov 17, 2022 at 10:43:22AM +0300, Serge Semin wrote: > On Wed, Nov 16, 2022 at 02:38:12PM -0600, Rob Herring wrote: > > On Sun, Nov 13, 2022 at 10:12:42PM +0300, Serge Semin wrote: > > > Originally as it was defined the legacy bindings the pcie_inbound_axi and > > > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > > > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > > > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > > > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > > > Let's fix that by conditionally apply the clock-names constraints based on > > > the compatible string content. > > > > > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > > Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > > > > --- > > > > > > Changelog v5: > > > - This is a new patch added on the v5 release of the patchset. > > > > > > Changelog v7: > > > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > > > - Get back the names to the clock-names property and make sure the > > > platform-specific name constraint is applied in the allOf clause. > > > (@Rob) > > > --- > > > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > > > 1 file changed, 42 insertions(+), 4 deletions(-) > > > > We have 2 patches doing the same thing: > > > > https://lore.kernel.org/all/20221109002449.35936-1-marex@denx.de/ > > It seems to me that that patch does two things at a time: > 1. Fixes invalid fourth clock-names entry. > 2. Fixes the fsl,imx8mm-pcie device having the "pcie_aux" clock name > required instead of "pcie_phy". > > My patch does only the first part. What about moving my patch to that > series and converting the Marek' patch to being applicable on top of > it and fixing the imx8mm part only? That seems reasonable. BTW, if this patch is moved from here the series will fail the dt_binding_check procedure. -Sergey > > -Sergey > > > > > Please hash out which one you all want. Both seem to have clock > > warnings still... > > > > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index 376e739bcad4..49b4f7a32e71 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml @@ -14,9 +14,6 @@ description: |+ This PCIe host controller is based on the Synopsys DesignWare PCIe IP and thus inherits all the common properties defined in snps,dw-pcie.yaml. -allOf: - - $ref: /schemas/pci/snps,dw-pcie.yaml# - properties: compatible: enum: @@ -61,7 +58,7 @@ properties: - const: pcie - const: pcie_bus - const: pcie_phy - - const: pcie_inbound_axi for imx6sx-pcie, pcie_aux for imx8mq-pcie + - enum: [ pcie_inbound_axi, pcie_aux ] num-lanes: const: 1 @@ -175,6 +172,47 @@ required: - clocks - clock-names +allOf: + - $ref: /schemas/pci/snps,dw-pcie.yaml# + - if: + properties: + compatible: + contains: + const: fsl,imx6sx-pcie + then: + properties: + clock-names: + items: + - {} + - {} + - {} + - const: pcie_inbound_axi + - if: + properties: + compatible: + contains: + const: fsl,imx8mq-pcie + then: + properties: + clock-names: + items: + - {} + - {} + - {} + - const: pcie_aux + - if: + properties: + compatible: + not: + contains: + enum: + - fsl,imx6sx-pcie + - fsl,imx8mq-pcie + then: + properties: + clock-names: + maxItems: 3 + unevaluatedProperties: false examples: